X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-distributed-datastore%2Fsrc%2Ftest%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fdatastore%2FSimpleShardDataTreeCohortTest.java;h=99b02f1cddc3fbd2add99bad5b229aae372652ce;hb=4e5083390e8f3076b0c6cd9fc43f656c4a109c1d;hp=7a4cb9b5efecc3233826c92f6ac7331bce478e4a;hpb=466078ab1dc8a8cc2981b161051f6edecd6af85a;p=controller.git diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/SimpleShardDataTreeCohortTest.java b/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/SimpleShardDataTreeCohortTest.java index 7a4cb9b5ef..99b02f1cdd 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/SimpleShardDataTreeCohortTest.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/SimpleShardDataTreeCohortTest.java @@ -23,20 +23,23 @@ import java.util.concurrent.CompletableFuture; import java.util.concurrent.Future; import org.junit.Before; import org.junit.Test; +import org.junit.runner.RunWith; import org.mockito.Mock; -import org.mockito.MockitoAnnotations; +import org.mockito.junit.MockitoJUnitRunner; +import org.opendaylight.yangtools.yang.common.Empty; import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier; -import org.opendaylight.yangtools.yang.data.api.schema.tree.ConflictingModificationAppliedException; -import org.opendaylight.yangtools.yang.data.api.schema.tree.DataTreeCandidate; -import org.opendaylight.yangtools.yang.data.api.schema.tree.DataTreeCandidateTip; -import org.opendaylight.yangtools.yang.data.api.schema.tree.DataTreeModification; -import org.opendaylight.yangtools.yang.data.api.schema.tree.DataValidationFailedException; +import org.opendaylight.yangtools.yang.data.tree.api.ConflictingModificationAppliedException; +import org.opendaylight.yangtools.yang.data.tree.api.DataTreeCandidate; +import org.opendaylight.yangtools.yang.data.tree.api.DataTreeCandidateTip; +import org.opendaylight.yangtools.yang.data.tree.api.DataTreeModification; +import org.opendaylight.yangtools.yang.data.tree.api.DataValidationFailedException; /** * Unit tests for SimpleShardDataTreeCohort. * * @author Thomas Pantelis */ +@RunWith(MockitoJUnitRunner.StrictStubs.class) public class SimpleShardDataTreeCohortTest extends AbstractTest { @Mock private ShardDataTree mockShardDataTree; @@ -54,8 +57,6 @@ public class SimpleShardDataTreeCohortTest extends AbstractTest { @Before public void setup() { - MockitoAnnotations.initMocks(this); - doReturn(Optional.empty()).when(mockUserCohorts).commit(); doReturn(Optional.empty()).when(mockUserCohorts).abort(); @@ -75,10 +76,10 @@ public class SimpleShardDataTreeCohortTest extends AbstractTest { }).when(mockShardDataTree).startCanCommit(cohort); @SuppressWarnings("unchecked") - final FutureCallback callback = mock(FutureCallback.class); + final FutureCallback callback = mock(FutureCallback.class); cohort.canCommit(callback); - verify(callback).onSuccess(null); + verify(callback).onSuccess(Empty.value()); verifyNoMoreInteractions(callback); } @@ -89,7 +90,7 @@ public class SimpleShardDataTreeCohortTest extends AbstractTest { }).when(mockShardDataTree).startCanCommit(cohort); @SuppressWarnings("unchecked") - final FutureCallback callback = mock(FutureCallback.class); + final FutureCallback callback = mock(FutureCallback.class); cohort.canCommit(callback); verify(callback).onFailure(cause); @@ -98,12 +99,12 @@ public class SimpleShardDataTreeCohortTest extends AbstractTest { @Test public void testCanCommitWithConflictingModEx() { - testValidatationPropagates(new ConflictingModificationAppliedException(YangInstanceIdentifier.EMPTY, "mock")); + testValidatationPropagates(new ConflictingModificationAppliedException(YangInstanceIdentifier.empty(), "mock")); } @Test public void testCanCommitWithDataValidationEx() { - testValidatationPropagates(new DataValidationFailedException(YangInstanceIdentifier.EMPTY, "mock")); + testValidatationPropagates(new DataValidationFailedException(YangInstanceIdentifier.empty(), "mock")); } @Test @@ -209,11 +210,11 @@ public class SimpleShardDataTreeCohortTest extends AbstractTest { } private static Future abort(final ShardDataTreeCohort cohort) { - final CompletableFuture f = new CompletableFuture<>(); - cohort.abort(new FutureCallback() { + final CompletableFuture f = new CompletableFuture<>(); + cohort.abort(new FutureCallback<>() { @Override - public void onSuccess(final Void result) { - f.complete(null); + public void onSuccess(final Empty result) { + f.complete(result); } @Override