X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-distributed-datastore%2Fsrc%2Ftest%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fdatastore%2Fentityownership%2FDistributedEntityOwnershipServiceTest.java;h=83056bae3a02a520766cfc804b2cc28a44b94660;hb=12fcdfe39aa26dcba7fd3bb4d4c68e3d02e65c51;hp=e9d837c17ff1e41263e1b839d881cc30dcb554a8;hpb=15c366198fa48eefd94f4d1a72faa9833e988250;p=controller.git diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/entityownership/DistributedEntityOwnershipServiceTest.java b/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/entityownership/DistributedEntityOwnershipServiceTest.java index e9d837c17f..83056bae3a 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/entityownership/DistributedEntityOwnershipServiceTest.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/entityownership/DistributedEntityOwnershipServiceTest.java @@ -27,22 +27,23 @@ import static org.opendaylight.controller.cluster.datastore.entityownership.Enti import static org.opendaylight.controller.cluster.datastore.entityownership.EntityOwnersModel.entityOwnersWithEntityTypeEntry; import static org.opendaylight.controller.cluster.datastore.entityownership.EntityOwnersModel.entityPath; import static org.opendaylight.controller.cluster.datastore.entityownership.EntityOwnersModel.entityTypeEntryWithEntityEntry; + import akka.actor.ActorRef; -import akka.actor.PoisonPill; import com.google.common.base.Optional; import com.google.common.collect.Sets; import java.util.Collection; -import java.util.concurrent.CountDownLatch; import java.util.concurrent.TimeUnit; -import java.util.concurrent.atomic.AtomicReference; import org.junit.After; import org.junit.Before; import org.junit.Test; import org.mockito.ArgumentCaptor; import org.mockito.Mockito; +import org.opendaylight.controller.cluster.access.concepts.MemberName; +import org.opendaylight.controller.cluster.datastore.AbstractDataStore; import org.opendaylight.controller.cluster.datastore.DatastoreContext; import org.opendaylight.controller.cluster.datastore.DatastoreContextFactory; import org.opendaylight.controller.cluster.datastore.DistributedDataStore; +import org.opendaylight.controller.cluster.datastore.Shard; import org.opendaylight.controller.cluster.datastore.ShardDataTree; import org.opendaylight.controller.cluster.datastore.config.Configuration; import org.opendaylight.controller.cluster.datastore.config.ConfigurationImpl; @@ -52,18 +53,16 @@ import org.opendaylight.controller.cluster.datastore.entityownership.messages.Re import org.opendaylight.controller.cluster.datastore.entityownership.messages.UnregisterCandidateLocal; import org.opendaylight.controller.cluster.datastore.entityownership.messages.UnregisterListenerLocal; import org.opendaylight.controller.cluster.datastore.entityownership.selectionstrategy.EntityOwnerSelectionStrategyConfig; -import org.opendaylight.controller.cluster.datastore.messages.GetShardDataTree; import org.opendaylight.controller.cluster.datastore.utils.MockClusterWrapper; import org.opendaylight.controller.md.cluster.datastore.model.SchemaContextHelper; -import org.opendaylight.controller.md.sal.common.api.clustering.CandidateAlreadyRegisteredException; -import org.opendaylight.controller.md.sal.common.api.clustering.Entity; -import org.opendaylight.controller.md.sal.common.api.clustering.EntityOwnershipCandidateRegistration; -import org.opendaylight.controller.md.sal.common.api.clustering.EntityOwnershipListener; -import org.opendaylight.controller.md.sal.common.api.clustering.EntityOwnershipListenerRegistration; -import org.opendaylight.controller.md.sal.common.api.clustering.EntityOwnershipState; +import org.opendaylight.mdsal.eos.common.api.CandidateAlreadyRegisteredException; +import org.opendaylight.mdsal.eos.common.api.EntityOwnershipState; +import org.opendaylight.mdsal.eos.dom.api.DOMEntity; +import org.opendaylight.mdsal.eos.dom.api.DOMEntityOwnershipCandidateRegistration; +import org.opendaylight.mdsal.eos.dom.api.DOMEntityOwnershipListener; +import org.opendaylight.mdsal.eos.dom.api.DOMEntityOwnershipListenerRegistration; import org.opendaylight.yangtools.yang.common.QName; import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier; -import org.opendaylight.yangtools.yang.data.api.schema.tree.DataTree; import org.opendaylight.yangtools.yang.data.api.schema.tree.TreeType; import org.opendaylight.yangtools.yang.data.impl.schema.ImmutableNodes; import scala.concurrent.Await; @@ -75,24 +74,24 @@ import scala.concurrent.duration.Duration; * * @author Thomas Pantelis */ -public class DistributedEntityOwnershipServiceTest extends AbstractEntityOwnershipTest { +public class DistributedEntityOwnershipServiceTest extends AbstractClusterRefEntityOwnershipTest { static final String ENTITY_TYPE = "test"; static final String ENTITY_TYPE2 = "test2"; static final QName QNAME = QName.create("test", "2015-08-11", "foo"); static int ID_COUNTER = 1; private final String dataStoreName = "config" + ID_COUNTER++; - private DistributedDataStore dataStore; + private AbstractDataStore dataStore; @Before public void setUp() { - DatastoreContext datastoreContext = DatastoreContext.newBuilder().dataStoreName(dataStoreName). - shardInitializationTimeout(10, TimeUnit.SECONDS).build(); + DatastoreContext datastoreContext = DatastoreContext.newBuilder().dataStoreName(dataStoreName) + .shardInitializationTimeout(10, TimeUnit.SECONDS).build(); Configuration configuration = new ConfigurationImpl(new EmptyModuleShardConfigProvider()) { @Override - public Collection getUniqueMemberNamesForAllShards() { - return Sets.newHashSet("member-1"); + public Collection getUniqueMemberNamesForAllShards() { + return Sets.newHashSet(MemberName.forName("member-1")); } }; @@ -100,14 +99,15 @@ public class DistributedEntityOwnershipServiceTest extends AbstractEntityOwnersh Mockito.doReturn(datastoreContext).when(mockContextFactory).getBaseDatastoreContext(); Mockito.doReturn(datastoreContext).when(mockContextFactory).getShardDatastoreContext(Mockito.anyString()); - dataStore = new DistributedDataStore(getSystem(), new MockClusterWrapper(), configuration, mockContextFactory, null); + dataStore = new DistributedDataStore(getSystem(), new MockClusterWrapper(), configuration, + mockContextFactory, null); dataStore.onGlobalContextUpdated(SchemaContextHelper.entityOwners()); } @After public void tearDown() { - dataStore.getActorContext().getShardManager().tell(PoisonPill.getInstance(), ActorRef.noSender()); + dataStore.close(); } private static T verifyMessage(final DistributedEntityOwnershipService mock, final Class type) { @@ -135,20 +135,20 @@ public class DistributedEntityOwnershipServiceTest extends AbstractEntityOwnersh dataStore.getActorContext(), EntityOwnerSelectionStrategyConfig.newBuilder().build())); YangInstanceIdentifier entityId = YangInstanceIdentifier.of(QNAME); - Entity entity = new Entity(ENTITY_TYPE, entityId); + DOMEntity entity = new DOMEntity(ENTITY_TYPE, entityId); - EntityOwnershipCandidateRegistration reg = service.registerCandidate(entity); + DOMEntityOwnershipCandidateRegistration reg = service.registerCandidate(entity); verifyRegisterCandidateLocal(service, entity); verifyEntityOwnershipCandidateRegistration(entity, reg); verifyEntityCandidate(service.getLocalEntityOwnershipShard(), ENTITY_TYPE, entityId, - dataStore.getActorContext().getCurrentMemberName()); + dataStore.getActorContext().getCurrentMemberName().getName()); // Register the same entity - should throw exception try { service.registerCandidate(entity); fail("Expected CandidateAlreadyRegisteredException"); - } catch(CandidateAlreadyRegisteredException e) { + } catch (CandidateAlreadyRegisteredException e) { // expected assertEquals("getEntity", entity, e.getEntity()); } @@ -156,12 +156,12 @@ public class DistributedEntityOwnershipServiceTest extends AbstractEntityOwnersh // Register a different entity - should succeed reset(service); - Entity entity2 = new Entity(ENTITY_TYPE2, entityId); - EntityOwnershipCandidateRegistration reg2 = service.registerCandidate(entity2); - verifyRegisterCandidateLocal(service, entity2); + DOMEntity entity2 = new DOMEntity(ENTITY_TYPE2, entityId); + DOMEntityOwnershipCandidateRegistration reg2 = service.registerCandidate(entity2); + verifyEntityOwnershipCandidateRegistration(entity2, reg2); verifyEntityCandidate(service.getLocalEntityOwnershipShard(), ENTITY_TYPE2, entityId, - dataStore.getActorContext().getCurrentMemberName()); + dataStore.getActorContext().getCurrentMemberName().getName()); service.close(); } @@ -171,8 +171,9 @@ public class DistributedEntityOwnershipServiceTest extends AbstractEntityOwnersh DistributedEntityOwnershipService service = spy(DistributedEntityOwnershipService.start( dataStore.getActorContext(), EntityOwnerSelectionStrategyConfig.newBuilder().build())); - Entity entity = new Entity(ENTITY_TYPE, YangInstanceIdentifier.of(QNAME)); - EntityOwnershipCandidateRegistration reg = service.registerCandidate(entity); + DOMEntity entity = new DOMEntity(ENTITY_TYPE, YangInstanceIdentifier.of(QNAME)); + + DOMEntityOwnershipCandidateRegistration reg = service.registerCandidate(entity); verifyEntityOwnershipCandidateRegistration(entity, reg); verifyRegisterCandidateLocal(service, entity); @@ -196,10 +197,10 @@ public class DistributedEntityOwnershipServiceTest extends AbstractEntityOwnersh dataStore.getActorContext(), EntityOwnerSelectionStrategyConfig.newBuilder().build())); YangInstanceIdentifier entityId = YangInstanceIdentifier.of(QNAME); - Entity entity = new Entity(ENTITY_TYPE, entityId); - EntityOwnershipListener listener = mock(EntityOwnershipListener.class); + DOMEntity entity = new DOMEntity(ENTITY_TYPE, entityId); + DOMEntityOwnershipListener listener = mock(DOMEntityOwnershipListener.class); - EntityOwnershipListenerRegistration reg = service.registerListener(entity.getType(), listener); + DOMEntityOwnershipListenerRegistration reg = service.registerListener(entity.getType(), listener); assertNotNull("EntityOwnershipListenerRegistration null", reg); assertEquals("getEntityType", entity.getType(), reg.getEntityType()); @@ -223,35 +224,40 @@ public class DistributedEntityOwnershipServiceTest extends AbstractEntityOwnersh DistributedEntityOwnershipService service = spy(DistributedEntityOwnershipService.start( dataStore.getActorContext(), EntityOwnerSelectionStrategyConfig.newBuilder().build())); - ShardDataTree shardDataTree = new ShardDataTree(SchemaContextHelper.entityOwners(), TreeType.OPERATIONAL); + final Shard mockShard = Mockito.mock(Shard.class); + ShardDataTree shardDataTree = new ShardDataTree(mockShard, SchemaContextHelper.entityOwners(), + TreeType.OPERATIONAL); when(service.getLocalEntityOwnershipShardDataTree()).thenReturn(shardDataTree.getDataTree()); - Entity entity1 = new Entity(ENTITY_TYPE, "one"); - writeNode(ENTITY_OWNERS_PATH, entityOwnersWithCandidate(ENTITY_TYPE, entity1.getId(), "member-1"), shardDataTree); + DOMEntity entity1 = new DOMEntity(ENTITY_TYPE, "one"); + writeNode(ENTITY_OWNERS_PATH, entityOwnersWithCandidate(ENTITY_TYPE, entity1.getIdentifier(), "member-1"), + shardDataTree); writeNode(ENTITY_OWNERS_PATH, entityOwnersWithEntityTypeEntry(entityTypeEntryWithEntityEntry(entity1.getType(), - entityEntryWithOwner(entity1.getId(), "member-1"))), shardDataTree); - verifyGetOwnershipState(service, entity1, true, true); + entityEntryWithOwner(entity1.getIdentifier(), "member-1"))), shardDataTree); + verifyGetOwnershipState(service, entity1, EntityOwnershipState.IS_OWNER); - writeNode(ENTITY_OWNERS_PATH, entityOwnersWithCandidate(ENTITY_TYPE, entity1.getId(), "member-2"), shardDataTree); - writeNode(entityPath(entity1.getType(), entity1.getId()), entityEntryWithOwner(entity1.getId(), "member-2"), - shardDataTree); - verifyGetOwnershipState(service, entity1, false, true); + writeNode(ENTITY_OWNERS_PATH, entityOwnersWithCandidate(ENTITY_TYPE, + entity1.getIdentifier(), "member-2"), shardDataTree); + writeNode(entityPath(entity1.getType(), entity1.getIdentifier()), + entityEntryWithOwner(entity1.getIdentifier(), "member-2"), shardDataTree); + verifyGetOwnershipState(service, entity1, EntityOwnershipState.OWNED_BY_OTHER); - writeNode(entityPath(entity1.getType(), entity1.getId()), entityEntryWithOwner(entity1.getId(), ""), - shardDataTree); - verifyGetOwnershipState(service, entity1, false, false); + writeNode(entityPath(entity1.getType(), entity1.getIdentifier()), entityEntryWithOwner(entity1.getIdentifier(), + ""), shardDataTree); + verifyGetOwnershipState(service, entity1, EntityOwnershipState.NO_OWNER); - Entity entity2 = new Entity(ENTITY_TYPE, "two"); + DOMEntity entity2 = new DOMEntity(ENTITY_TYPE, "two"); Optional state = service.getOwnershipState(entity2); assertEquals("getOwnershipState present", false, state.isPresent()); - writeNode(ENTITY_OWNERS_PATH, entityOwnersWithCandidate(ENTITY_TYPE, entity2.getId(), "member-1"), shardDataTree); - writeNode(entityPath(entity2.getType(), entity2.getId()), ImmutableNodes.mapEntry(ENTITY_QNAME, - ENTITY_ID_QNAME, entity2.getId()), shardDataTree); - verifyGetOwnershipState(service, entity2, false, false); + writeNode(ENTITY_OWNERS_PATH, entityOwnersWithCandidate(ENTITY_TYPE, entity2.getIdentifier(), "member-1"), + shardDataTree); + writeNode(entityPath(entity2.getType(), entity2.getIdentifier()), ImmutableNodes.mapEntry(ENTITY_QNAME, + ENTITY_ID_QNAME, entity2.getIdentifier()), shardDataTree); + verifyGetOwnershipState(service, entity2, EntityOwnershipState.NO_OWNER); - deleteNode(candidatePath(entityPath(entity2.getType(), entity2.getId()), "member-1"), shardDataTree); + deleteNode(candidatePath(entityPath(entity2.getType(), entity2.getIdentifier()), "member-1"), shardDataTree); Optional state2 = service.getOwnershipState(entity2); assertEquals("getOwnershipState present", false, state2.isPresent()); service.close(); @@ -262,7 +268,7 @@ public class DistributedEntityOwnershipServiceTest extends AbstractEntityOwnersh DistributedEntityOwnershipService service = DistributedEntityOwnershipService.start(dataStore.getActorContext(), EntityOwnerSelectionStrategyConfig.newBuilder().build()); - final Entity test = new Entity("test-type", "test"); + final DOMEntity test = new DOMEntity("test-type", "test"); assertFalse(service.isCandidateRegistered(test)); @@ -273,67 +279,34 @@ public class DistributedEntityOwnershipServiceTest extends AbstractEntityOwnersh service.close(); } - private static void verifyGetOwnershipState(final DistributedEntityOwnershipService service, final Entity entity, - final boolean isOwner, final boolean hasOwner) { + private static void verifyGetOwnershipState(final DistributedEntityOwnershipService service, final DOMEntity entity, + final EntityOwnershipState expState) { Optional state = service.getOwnershipState(entity); assertEquals("getOwnershipState present", true, state.isPresent()); - assertEquals("isOwner", isOwner, state.get().isOwner()); - assertEquals("hasOwner", hasOwner, state.get().hasOwner()); + assertEquals("EntityOwnershipState", expState, state.get()); } + @SuppressWarnings("checkstyle:IllegalCatch") private void verifyEntityCandidate(final ActorRef entityOwnershipShard, final String entityType, final YangInstanceIdentifier entityId, final String candidateName) { - verifyEntityCandidate(entityType, entityId, candidateName, - path -> { - try { - return dataStore.newReadOnlyTransaction().read(path).get(5, TimeUnit.SECONDS).get(); - } catch (Exception e) { - return null; - } - }); + verifyEntityCandidate(entityType, entityId, candidateName, path -> { + try { + return dataStore.newReadOnlyTransaction().read(path).get(5, TimeUnit.SECONDS).get(); + } catch (Exception e) { + return null; + } + }); } - private static void verifyRegisterCandidateLocal(final DistributedEntityOwnershipService service, final Entity entity) { + private static void verifyRegisterCandidateLocal(final DistributedEntityOwnershipService service, + final DOMEntity entity) { RegisterCandidateLocal regCandidate = verifyMessage(service, RegisterCandidateLocal.class); assertEquals("getEntity", entity, regCandidate.getEntity()); } - private static void verifyEntityOwnershipCandidateRegistration(final Entity entity, final EntityOwnershipCandidateRegistration reg) { + private static void verifyEntityOwnershipCandidateRegistration(final DOMEntity entity, + final DOMEntityOwnershipCandidateRegistration reg) { assertNotNull("EntityOwnershipCandidateRegistration null", reg); assertEquals("getInstance", entity, reg.getInstance()); } - - static class TestEntityOwnershipShard extends EntityOwnershipShard { - private final AtomicReference messageReceived; - private final AtomicReference receivedMessage; - private final AtomicReference> messageClass; - private final AtomicReference dataTree; - - protected TestEntityOwnershipShard(final EntityOwnershipShard.Builder builder, - final AtomicReference> messageClass, final AtomicReference messageReceived, - final AtomicReference receivedMessage, final AtomicReference dataTree) { - super(builder); - this.messageClass = messageClass; - this.messageReceived = messageReceived; - this.receivedMessage = receivedMessage; - this.dataTree = dataTree; - } - - @Override - public void handleCommand(final Object message) { - try { - if(dataTree.get() != null && message instanceof GetShardDataTree) { - sender().tell(dataTree.get(), self()); - } else { - super.handleCommand(message); - } - } finally { - Class expMsgClass = messageClass.get(); - if(expMsgClass != null && expMsgClass.equals(message.getClass())) { - receivedMessage.set(message); - messageReceived.get().countDown(); - } - } - } - } }