X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-distributed-datastore%2Fsrc%2Ftest%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fdatastore%2Fentityownership%2FDistributedEntityOwnershipServiceTest.java;h=b130134b3c2ad2d6089f3895ff8b75a7ed0cfd64;hb=44d274e8a4282ef859a35369c563e4963cf2185a;hp=aac4b23d3aa645c7db10de16fc994edfcb381761;hpb=5a0edd493bafc365647bc6311b4b7da86a78645d;p=controller.git diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/entityownership/DistributedEntityOwnershipServiceTest.java b/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/entityownership/DistributedEntityOwnershipServiceTest.java index aac4b23d3a..b130134b3c 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/entityownership/DistributedEntityOwnershipServiceTest.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/entityownership/DistributedEntityOwnershipServiceTest.java @@ -29,9 +29,9 @@ import static org.opendaylight.controller.cluster.datastore.entityownership.Enti import static org.opendaylight.controller.cluster.datastore.entityownership.EntityOwnersModel.entityTypeEntryWithEntityEntry; import akka.actor.ActorRef; -import com.google.common.base.Optional; import com.google.common.collect.Sets; import java.util.Collection; +import java.util.Optional; import java.util.concurrent.TimeUnit; import org.junit.After; import org.junit.Before; @@ -67,14 +67,14 @@ import org.opendaylight.yangtools.yang.data.api.schema.tree.TreeType; import org.opendaylight.yangtools.yang.data.impl.schema.ImmutableNodes; import scala.concurrent.Await; import scala.concurrent.Future; -import scala.concurrent.duration.Duration; +import scala.concurrent.duration.FiniteDuration; /** * Unit tests for DistributedEntityOwnershipService. * * @author Thomas Pantelis */ -public class DistributedEntityOwnershipServiceTest extends AbstractEntityOwnershipTest { +public class DistributedEntityOwnershipServiceTest extends AbstractClusterRefEntityOwnershipTest { static final String ENTITY_TYPE = "test"; static final String ENTITY_TYPE2 = "test2"; static final QName QNAME = QName.create("test", "2015-08-11", "foo"); @@ -118,12 +118,12 @@ public class DistributedEntityOwnershipServiceTest extends AbstractEntityOwnersh @Test public void testEntityOwnershipShardCreated() throws Exception { - DistributedEntityOwnershipService service = DistributedEntityOwnershipService.start(dataStore.getActorContext(), + DistributedEntityOwnershipService service = DistributedEntityOwnershipService.start(dataStore.getActorUtils(), EntityOwnerSelectionStrategyConfig.newBuilder().build()); - Future future = dataStore.getActorContext().findLocalShardAsync( + Future future = dataStore.getActorUtils().findLocalShardAsync( DistributedEntityOwnershipService.ENTITY_OWNERSHIP_SHARD_NAME); - ActorRef shardActor = Await.result(future, Duration.create(10, TimeUnit.SECONDS)); + ActorRef shardActor = Await.result(future, FiniteDuration.create(10, TimeUnit.SECONDS)); assertNotNull(DistributedEntityOwnershipService.ENTITY_OWNERSHIP_SHARD_NAME + " not found", shardActor); service.close(); @@ -132,7 +132,7 @@ public class DistributedEntityOwnershipServiceTest extends AbstractEntityOwnersh @Test public void testRegisterCandidate() throws Exception { DistributedEntityOwnershipService service = spy(DistributedEntityOwnershipService.start( - dataStore.getActorContext(), EntityOwnerSelectionStrategyConfig.newBuilder().build())); + dataStore.getActorUtils(), EntityOwnerSelectionStrategyConfig.newBuilder().build())); YangInstanceIdentifier entityId = YangInstanceIdentifier.of(QNAME); DOMEntity entity = new DOMEntity(ENTITY_TYPE, entityId); @@ -141,7 +141,7 @@ public class DistributedEntityOwnershipServiceTest extends AbstractEntityOwnersh verifyRegisterCandidateLocal(service, entity); verifyEntityOwnershipCandidateRegistration(entity, reg); verifyEntityCandidate(service.getLocalEntityOwnershipShard(), ENTITY_TYPE, entityId, - dataStore.getActorContext().getCurrentMemberName().getName()); + dataStore.getActorUtils().getCurrentMemberName().getName()); // Register the same entity - should throw exception @@ -161,7 +161,7 @@ public class DistributedEntityOwnershipServiceTest extends AbstractEntityOwnersh verifyEntityOwnershipCandidateRegistration(entity2, reg2); verifyEntityCandidate(service.getLocalEntityOwnershipShard(), ENTITY_TYPE2, entityId, - dataStore.getActorContext().getCurrentMemberName().getName()); + dataStore.getActorUtils().getCurrentMemberName().getName()); service.close(); } @@ -169,7 +169,7 @@ public class DistributedEntityOwnershipServiceTest extends AbstractEntityOwnersh @Test public void testCloseCandidateRegistration() throws Exception { DistributedEntityOwnershipService service = spy(DistributedEntityOwnershipService.start( - dataStore.getActorContext(), EntityOwnerSelectionStrategyConfig.newBuilder().build())); + dataStore.getActorUtils(), EntityOwnerSelectionStrategyConfig.newBuilder().build())); DOMEntity entity = new DOMEntity(ENTITY_TYPE, YangInstanceIdentifier.of(QNAME)); @@ -194,7 +194,7 @@ public class DistributedEntityOwnershipServiceTest extends AbstractEntityOwnersh @Test public void testListenerRegistration() { DistributedEntityOwnershipService service = spy(DistributedEntityOwnershipService.start( - dataStore.getActorContext(), EntityOwnerSelectionStrategyConfig.newBuilder().build())); + dataStore.getActorUtils(), EntityOwnerSelectionStrategyConfig.newBuilder().build())); YangInstanceIdentifier entityId = YangInstanceIdentifier.of(QNAME); DOMEntity entity = new DOMEntity(ENTITY_TYPE, entityId); @@ -222,7 +222,7 @@ public class DistributedEntityOwnershipServiceTest extends AbstractEntityOwnersh @Test public void testGetOwnershipState() throws Exception { DistributedEntityOwnershipService service = spy(DistributedEntityOwnershipService.start( - dataStore.getActorContext(), EntityOwnerSelectionStrategyConfig.newBuilder().build())); + dataStore.getActorUtils(), EntityOwnerSelectionStrategyConfig.newBuilder().build())); final Shard mockShard = Mockito.mock(Shard.class); ShardDataTree shardDataTree = new ShardDataTree(mockShard, SchemaContextHelper.entityOwners(), @@ -249,7 +249,7 @@ public class DistributedEntityOwnershipServiceTest extends AbstractEntityOwnersh DOMEntity entity2 = new DOMEntity(ENTITY_TYPE, "two"); Optional state = service.getOwnershipState(entity2); - assertEquals("getOwnershipState present", false, state.isPresent()); + assertFalse("getOwnershipState present", state.isPresent()); writeNode(ENTITY_OWNERS_PATH, entityOwnersWithCandidate(ENTITY_TYPE, entity2.getIdentifier(), "member-1"), shardDataTree); @@ -259,13 +259,13 @@ public class DistributedEntityOwnershipServiceTest extends AbstractEntityOwnersh deleteNode(candidatePath(entityPath(entity2.getType(), entity2.getIdentifier()), "member-1"), shardDataTree); Optional state2 = service.getOwnershipState(entity2); - assertEquals("getOwnershipState present", false, state2.isPresent()); + assertFalse("getOwnershipState present", state2.isPresent()); service.close(); } @Test public void testIsCandidateRegistered() throws CandidateAlreadyRegisteredException { - DistributedEntityOwnershipService service = DistributedEntityOwnershipService.start(dataStore.getActorContext(), + DistributedEntityOwnershipService service = DistributedEntityOwnershipService.start(dataStore.getActorUtils(), EntityOwnerSelectionStrategyConfig.newBuilder().build()); final DOMEntity test = new DOMEntity("test-type", "test"); @@ -282,7 +282,7 @@ public class DistributedEntityOwnershipServiceTest extends AbstractEntityOwnersh private static void verifyGetOwnershipState(final DistributedEntityOwnershipService service, final DOMEntity entity, final EntityOwnershipState expState) { Optional state = service.getOwnershipState(entity); - assertEquals("getOwnershipState present", true, state.isPresent()); + assertTrue("getOwnershipState present", state.isPresent()); assertEquals("EntityOwnershipState", expState, state.get()); }