X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-distributed-datastore%2Fsrc%2Ftest%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fdatastore%2Fmessages%2FWriteDataTest.java;h=8148c9ca9528fc709ad1ecaf3febbda265bc033d;hb=3927509ec3ecfa32a51b725d2b7155d425f5b877;hp=6a5d65f8daab3e3952393e8bbdb764560c355886;hpb=c2f8c5b00708ab1d9e003ede0c960133989d5e0c;p=controller.git diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/messages/WriteDataTest.java b/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/messages/WriteDataTest.java index 6a5d65f8da..8148c9ca95 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/messages/WriteDataTest.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/messages/WriteDataTest.java @@ -7,27 +7,76 @@ */ package org.opendaylight.controller.cluster.datastore.messages; -import org.junit.Assert; +import static org.junit.Assert.assertEquals; +import java.io.Serializable; +import org.apache.commons.lang.SerializationUtils; import org.junit.Test; +import org.opendaylight.controller.cluster.datastore.DataStoreVersions; import org.opendaylight.controller.md.cluster.datastore.model.TestModel; +import org.opendaylight.controller.protobuff.messages.common.NormalizedNodeMessages.InstanceIdentifier; +import org.opendaylight.controller.protobuff.messages.common.NormalizedNodeMessages.Node; +import org.opendaylight.controller.protobuff.messages.transaction.ShardTransactionMessages; +import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier; +import org.opendaylight.yangtools.yang.data.api.schema.NormalizedNode; import org.opendaylight.yangtools.yang.data.impl.schema.ImmutableNodes; -import org.opendaylight.yangtools.yang.model.api.SchemaContext; +import org.opendaylight.yangtools.yang.data.impl.schema.builder.impl.ImmutableContainerNodeBuilder; /** * Unit tests for WriteData. * * @author Thomas Pantelis */ +@Deprecated public class WriteDataTest { @Test public void testSerialization() { - SchemaContext schemaContext = TestModel.createTestContext(); - WriteData expected = new WriteData(TestModel.TEST_PATH, ImmutableNodes - .containerNode(TestModel.TEST_QNAME), schemaContext); + YangInstanceIdentifier path = TestModel.TEST_PATH; + NormalizedNode data = ImmutableContainerNodeBuilder.create().withNodeIdentifier( + new YangInstanceIdentifier.NodeIdentifier(TestModel.TEST_QNAME)). + withChild(ImmutableNodes.leafNode(TestModel.DESC_QNAME, "foo")).build(); - WriteData actual = WriteData.fromSerializable(expected.toSerializable(), schemaContext); - Assert.assertEquals("getPath", expected.getPath(), actual.getPath()); - Assert.assertEquals("getData", expected.getData(), actual.getData()); + WriteData expected = new WriteData(path, data, DataStoreVersions.CURRENT_VERSION); + + Object serialized = expected.toSerializable(); + assertEquals("Serialized type", WriteData.class, serialized.getClass()); + assertEquals("Version", DataStoreVersions.CURRENT_VERSION, ((WriteData)serialized).getVersion()); + + Object clone = SerializationUtils.clone((Serializable) serialized); + WriteData actual = WriteData.fromSerializable(clone); + assertEquals("Version", DataStoreVersions.CURRENT_VERSION, actual.getVersion()); + assertEquals("getPath", expected.getPath(), actual.getPath()); + assertEquals("getData", expected.getData(), actual.getData()); + } + + @Test + public void testIsSerializedType() { + assertEquals("isSerializedType", true, WriteData.isSerializedType( + ShardTransactionMessages.WriteData.newBuilder() + .setInstanceIdentifierPathArguments(InstanceIdentifier.getDefaultInstance()) + .setNormalizedNode(Node.getDefaultInstance()).build())); + assertEquals("isSerializedType", true, WriteData.isSerializedType(new WriteData())); + assertEquals("isSerializedType", false, WriteData.isSerializedType(new Object())); + } + + /** + * Tests backwards compatible serialization/deserialization of a WriteData message with the + * base and R1 Helium versions, which used the protobuff WriteData message. + */ + @Test + public void testSerializationWithHeliumR1Version() throws Exception { + YangInstanceIdentifier path = TestModel.TEST_PATH; + NormalizedNode data = ImmutableContainerNodeBuilder.create().withNodeIdentifier( + new YangInstanceIdentifier.NodeIdentifier(TestModel.TEST_QNAME)). + withChild(ImmutableNodes.leafNode(TestModel.DESC_QNAME, "foo")).build(); + + WriteData expected = new WriteData(path, data, DataStoreVersions.HELIUM_1_VERSION); + + Object serialized = expected.toSerializable(); + assertEquals("Serialized type", ShardTransactionMessages.WriteData.class, serialized.getClass()); + + WriteData actual = WriteData.fromSerializable(SerializationUtils.clone((Serializable) serialized)); + assertEquals("getPath", expected.getPath(), actual.getPath()); + assertEquals("getData", expected.getData(), actual.getData()); } }