X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-dom-broker%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fmd%2Fsal%2Fdom%2Fbroker%2Fimpl%2Fcompat%2FBackwardsCompatibleTransaction.java;h=27e322f23baf265a046d04317f2bfbf78ab2f74c;hb=0e7b83c0739ac579ca6dbf6a3f7992f70eb3000f;hp=b3fb7b6da8be09d67c0b7244f50f99c093a8173b;hpb=aa7b316a424f60fb1b5179e44924e9457147093a;p=controller.git diff --git a/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/md/sal/dom/broker/impl/compat/BackwardsCompatibleTransaction.java b/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/md/sal/dom/broker/impl/compat/BackwardsCompatibleTransaction.java index b3fb7b6da8..27e322f23b 100644 --- a/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/md/sal/dom/broker/impl/compat/BackwardsCompatibleTransaction.java +++ b/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/md/sal/dom/broker/impl/compat/BackwardsCompatibleTransaction.java @@ -43,7 +43,7 @@ import com.google.common.base.Preconditions; import com.google.common.util.concurrent.ListenableFuture; public abstract class BackwardsCompatibleTransaction implements - DataModificationTransaction, Delegator { +DataModificationTransaction, Delegator { private static final Logger LOG = LoggerFactory.getLogger(BackwardsCompatibleTransaction.class); @@ -228,23 +228,23 @@ public abstract class BackwardsCompatibleTransaction currentArguments = new ArrayList<>(); - DataNormalizationOperation currentOp = getNormalizer().getRootOperation(); - Iterator iterator = normalizedPath.getPath().iterator(); - while(iterator.hasNext()) { - PathArgument currentArg = iterator.next(); - try { - currentOp = currentOp.getChild(currentArg); - } catch (DataNormalizationException e) { - throw new IllegalArgumentException(String.format("Invalid child encountered in path %s", normalizedPath), e); + List currentArguments = new ArrayList<>(); + DataNormalizationOperation currentOp = getNormalizer().getRootOperation(); + Iterator iterator = normalizedPath.getPathArguments().iterator(); + while(iterator.hasNext()) { + PathArgument currentArg = iterator.next(); + try { + currentOp = currentOp.getChild(currentArg); + } catch (DataNormalizationException e) { + throw new IllegalArgumentException(String.format("Invalid child encountered in path %s", normalizedPath), e); + } + currentArguments.add(currentArg); + InstanceIdentifier currentPath = InstanceIdentifier.create(currentArguments); + boolean isPresent = getDelegate().read(store, currentPath).get().isPresent(); + if(isPresent == false && iterator.hasNext()) { + getDelegate().merge(store, currentPath, currentOp.createDefault(currentArg)); + } } - currentArguments.add(currentArg); - InstanceIdentifier currentPath = new InstanceIdentifier(currentArguments); - boolean isPresent = getDelegate().read(store, currentPath).get().isPresent(); - if(isPresent == false && iterator.hasNext()) { - getDelegate().merge(store, currentPath, currentOp.createDefault(currentArg)); - } - } } catch (InterruptedException | ExecutionException e) { LOG.error("Exception durring read.",e); }