X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-dom-broker%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fmd%2Fsal%2Fdom%2Fbroker%2Fimpl%2Fmount%2FDOMMountPointServiceImpl.java;h=5fce0f1b371d3f637cf91b5ab648669bc69d3ddb;hb=42d81f7049dd51da1909b0cf503364c931a77dda;hp=41650666cd80c022931a7877b2d9fd9bbbd6a708;hpb=6d73d16b194435ea1ea783a37d1b51fc1f558a1f;p=controller.git diff --git a/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/md/sal/dom/broker/impl/mount/DOMMountPointServiceImpl.java b/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/md/sal/dom/broker/impl/mount/DOMMountPointServiceImpl.java index 41650666cd..5fce0f1b37 100644 --- a/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/md/sal/dom/broker/impl/mount/DOMMountPointServiceImpl.java +++ b/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/md/sal/dom/broker/impl/mount/DOMMountPointServiceImpl.java @@ -3,81 +3,141 @@ * * This program and the accompanying materials are made available under the * terms of the Eclipse Public License v1.0 which accompanies this distribution, - * and is available at http://www.eclipse.org/legal/epl-v10.html. + * and is available at http://www.eclipse.org/legal/epl-v10.html */ package org.opendaylight.controller.md.sal.dom.broker.impl.mount; +import com.google.common.annotations.VisibleForTesting; import com.google.common.base.Optional; import com.google.common.base.Preconditions; import com.google.common.collect.ClassToInstanceMap; import com.google.common.collect.MutableClassToInstanceMap; -import java.util.HashMap; -import java.util.Map; import org.opendaylight.controller.md.sal.dom.api.DOMMountPoint; import org.opendaylight.controller.md.sal.dom.api.DOMMountPointService; import org.opendaylight.controller.md.sal.dom.api.DOMService; import org.opendaylight.controller.md.sal.dom.broker.spi.mount.SimpleDOMMountPoint; import org.opendaylight.controller.sal.core.api.mount.MountProvisionListener; +import org.opendaylight.mdsal.dom.api.DOMMountPointListener; +import org.opendaylight.yangtools.concepts.AbstractListenerRegistration; import org.opendaylight.yangtools.concepts.ListenerRegistration; import org.opendaylight.yangtools.concepts.ObjectRegistration; -import org.opendaylight.yangtools.concepts.util.ListenerRegistry; import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier; import org.opendaylight.yangtools.yang.model.api.SchemaContext; public class DOMMountPointServiceImpl implements DOMMountPointService { - private final Map mountPoints = new HashMap<>(); + private final org.opendaylight.mdsal.dom.api.DOMMountPointService delegate; - private final ListenerRegistry listeners = ListenerRegistry.create(); + @VisibleForTesting + public DOMMountPointServiceImpl() { + this(new org.opendaylight.mdsal.dom.broker.DOMMountPointServiceImpl()); + } - @Override - public Optional getMountPoint(final YangInstanceIdentifier path) { - return Optional.fromNullable(mountPoints.get(path)); + public DOMMountPointServiceImpl(final org.opendaylight.mdsal.dom.api.DOMMountPointService delegate) { + this.delegate = delegate; } @Override - public DOMMountPointBuilder createMountPoint(final YangInstanceIdentifier path) { - Preconditions.checkState(!mountPoints.containsKey(path), "Mount point already exists"); - return new DOMMountPointBuilderImpl(path); + public Optional getMountPoint(final YangInstanceIdentifier path) { + final Optional delegateMountPoint = delegate.getMountPoint(path); + return delegateMountPoint.isPresent() ? Optional.of(convert(delegateMountPoint.get())) : Optional.absent(); } - public void notifyMountCreated(final YangInstanceIdentifier identifier) { - for (final ListenerRegistration listener : listeners - .getListeners()) { - listener.getInstance().onMountPointCreated(identifier); - } + private static DOMMountPoint convert(final org.opendaylight.mdsal.dom.api.DOMMountPoint from) { + return new DOMMountPoint() { + @Override + public YangInstanceIdentifier getIdentifier() { + return from.getIdentifier(); + } + + @Override + public Optional getService(final Class cls) { + return from.getService(cls); + } + + @Override + public SchemaContext getSchemaContext() { + return from.getSchemaContext(); + } + + @Override + public int hashCode() { + return from.getIdentifier().hashCode(); + } + + @Override + public boolean equals(final Object obj) { + if (this == obj) { + return true; + } + + if (!(obj instanceof DOMMountPoint)) { + return false; + } + + DOMMountPoint other = (DOMMountPoint) obj; + return from.getIdentifier().equals(other.getIdentifier()); + } + }; } - public void notifyMountRemoved(final YangInstanceIdentifier identifier) { - for (final ListenerRegistration listener : listeners - .getListeners()) { - listener.getInstance().onMountPointRemoved(identifier); - } + @Override + public DOMMountPointBuilder createMountPoint(final YangInstanceIdentifier path) { + return new DOMMountPointBuilderImpl(path); } @Override public ListenerRegistration registerProvisionListener( final MountProvisionListener listener) { - return listeners.register(listener); + final ListenerRegistration delegateReg = delegate.registerProvisionListener(listener); + return new AbstractListenerRegistration(listener) { + @Override + protected void removeRegistration() { + delegateReg.close(); + } + }; + } + + @Override + public ListenerRegistration registerProvisionListener(final DOMMountPointListener listener) { + return delegate.registerProvisionListener(listener); } + /** + * Deprecated. + + * @deprecated this method should never have been exposed publicly - registration should be done via the + * public {@link #createMountPoint} interface. As such, this method expects the {@code mountPoint} param + * to be of type {@link SimpleDOMMountPoint}. + */ + @SuppressWarnings("unchecked") + @Deprecated public ObjectRegistration registerMountPoint(final DOMMountPoint mountPoint) { - synchronized (mountPoints) { - Preconditions.checkState(!mountPoints.containsKey(mountPoint.getIdentifier()), "Mount point already exists"); - mountPoints.put(mountPoint.getIdentifier(), mountPoint); - } - notifyMountCreated(mountPoint.getIdentifier()); + Preconditions.checkArgument(mountPoint instanceof SimpleDOMMountPoint, "Expected SimpleDOMMountPoint"); - return new MountRegistration(mountPoint); - } + final org.opendaylight.mdsal.dom.api.DOMMountPointService.DOMMountPointBuilder delegateBuilder = + delegate.createMountPoint(mountPoint.getIdentifier()); - public void unregisterMountPoint(final YangInstanceIdentifier mountPointId) { - synchronized (mountPoints) { - Preconditions.checkState(mountPoints.containsKey(mountPointId), "Mount point does not exist"); - mountPoints.remove(mountPointId); + if (mountPoint.getSchemaContext() != null) { + delegateBuilder.addInitialSchemaContext(mountPoint.getSchemaContext()); } - notifyMountRemoved(mountPointId); + + ((SimpleDOMMountPoint)mountPoint).getAllServices().forEach( + entry -> delegateBuilder.addService((Class)entry.getKey(), entry.getValue())); + + final ObjectRegistration delegateReg = delegateBuilder.register(); + return new ObjectRegistration() { + @Override + public void close() { + delegateReg.close(); + } + + @Override + public DOMMountPoint getInstance() { + return mountPoint; + } + }; } public class DOMMountPointBuilderImpl implements DOMMountPointBuilder { @@ -106,26 +166,8 @@ public class DOMMountPointServiceImpl implements DOMMountPointService { @Override public ObjectRegistration register() { Preconditions.checkState(mountPoint == null, "Mount point is already built."); - mountPoint = SimpleDOMMountPoint.create(path, services,schemaContext); + mountPoint = SimpleDOMMountPoint.create(path, services, schemaContext); return registerMountPoint(mountPoint); } } - - private final class MountRegistration implements ObjectRegistration { - private final DOMMountPoint mountPoint; - - public MountRegistration(final DOMMountPoint mountPoint) { - this.mountPoint = mountPoint; - } - - @Override - public DOMMountPoint getInstance() { - return mountPoint; - } - - @Override - public void close() throws Exception { - unregisterMountPoint(mountPoint.getIdentifier()); - } - } }