X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-remoterpc-connector%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fremote%2Frpc%2Fmessages%2FActionResponse.java;h=d6a23583aa10b1e4ffe2608260d3f059171468d5;hb=HEAD;hp=145f86fba444a65a4a66029e958a93061357a544;hpb=abaef4a5ae37f27542155457fe7306a4662b1eeb;p=controller.git diff --git a/opendaylight/md-sal/sal-remoterpc-connector/src/main/java/org/opendaylight/controller/remote/rpc/messages/ActionResponse.java b/opendaylight/md-sal/sal-remoterpc-connector/src/main/java/org/opendaylight/controller/remote/rpc/messages/ActionResponse.java index 145f86fba4..09d68d63e3 100644 --- a/opendaylight/md-sal/sal-remoterpc-connector/src/main/java/org/opendaylight/controller/remote/rpc/messages/ActionResponse.java +++ b/opendaylight/md-sal/sal-remoterpc-connector/src/main/java/org/opendaylight/controller/remote/rpc/messages/ActionResponse.java @@ -16,21 +16,21 @@ import java.io.IOException; import java.io.ObjectInput; import java.io.ObjectOutput; import java.util.Collection; -import java.util.Optional; import org.eclipse.jdt.annotation.NonNull; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.cluster.datastore.node.utils.stream.SerializationUtils; import org.opendaylight.yangtools.yang.common.RpcError; import org.opendaylight.yangtools.yang.data.api.schema.ContainerNode; -import org.opendaylight.yangtools.yang.data.api.schema.NormalizedNode; @SuppressFBWarnings({"SE_TRANSIENT_FIELD_NOT_RESTORED", "DMI_NONSERIALIZABLE_OBJECT_WRITTEN"}) public class ActionResponse extends AbstractResponse { + @java.io.Serial private static final long serialVersionUID = 1L; private final transient @NonNull ImmutableList<@NonNull RpcError> errors; - public ActionResponse(final @NonNull Optional output, @NonNull final Collection errors) { - super(output.orElse(null)); + public ActionResponse(final @Nullable ContainerNode output, @NonNull final Collection errors) { + super(output); this.errors = ImmutableList.copyOf(errors); } @@ -67,9 +67,9 @@ public class ActionResponse extends AbstractResponse { @Override public void readExternal(final ObjectInput in) throws IOException, ClassNotFoundException { @SuppressWarnings("unchecked") - final ImmutableList errors = (ImmutableList) in.readObject(); - final Optional output = SerializationUtils.readNormalizedNode(in); - actionResponse = new ActionResponse(output.map(ContainerNode.class::cast), errors); + final var errors = (ImmutableList) in.readObject(); + final var output = SerializationUtils.readNormalizedNode(in); + actionResponse = new ActionResponse(output.map(ContainerNode.class::cast).orElse(null), errors); } private Object readResolve() {