X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-remoterpc-connector%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fremote%2Frpc%2Fmessages%2FRpcResponse.java;h=bb308203ddd789fcf783c7ab6e8e0abadd2ca63a;hb=HEAD;hp=97a515514001f5f8e1aa079886d2c955b5adbb10;hpb=abaef4a5ae37f27542155457fe7306a4662b1eeb;p=controller.git diff --git a/opendaylight/md-sal/sal-remoterpc-connector/src/main/java/org/opendaylight/controller/remote/rpc/messages/RpcResponse.java b/opendaylight/md-sal/sal-remoterpc-connector/src/main/java/org/opendaylight/controller/remote/rpc/messages/RpcResponse.java index 97a5155140..bb308203dd 100644 --- a/opendaylight/md-sal/sal-remoterpc-connector/src/main/java/org/opendaylight/controller/remote/rpc/messages/RpcResponse.java +++ b/opendaylight/md-sal/sal-remoterpc-connector/src/main/java/org/opendaylight/controller/remote/rpc/messages/RpcResponse.java @@ -9,16 +9,19 @@ package org.opendaylight.controller.remote.rpc.messages; import java.io.Externalizable; import java.io.IOException; +import java.io.InvalidObjectException; import java.io.ObjectInput; import java.io.ObjectOutput; +import java.util.Optional; import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.cluster.datastore.node.utils.stream.SerializationUtils; +import org.opendaylight.yangtools.yang.data.api.schema.ContainerNode; import org.opendaylight.yangtools.yang.data.api.schema.NormalizedNode; -public class RpcResponse extends AbstractResponse { +public class RpcResponse extends AbstractResponse { private static final long serialVersionUID = -4211279498688989245L; - public RpcResponse(final @Nullable NormalizedNode output) { + public RpcResponse(final @Nullable ContainerNode output) { super(output); } @@ -27,6 +30,18 @@ public class RpcResponse extends AbstractResponse { return new Proxy(this); } + static @Nullable ContainerNode unmaskContainer(final Optional optNode) + throws InvalidObjectException { + if (optNode.isEmpty()) { + return null; + } + final var node = optNode.orElseThrow(); + if (node instanceof ContainerNode container) { + return container; + } + throw new InvalidObjectException("Unexpected data " + node.contract().getSimpleName()); + } + private static class Proxy implements Externalizable { private static final long serialVersionUID = 1L; @@ -49,7 +64,7 @@ public class RpcResponse extends AbstractResponse { @Override public void readExternal(final ObjectInput in) throws IOException { - rpcResponse = new RpcResponse(SerializationUtils.readNormalizedNode(in).orElse(null)); + rpcResponse = new RpcResponse(unmaskContainer(SerializationUtils.readNormalizedNode(in))); } private Object readResolve() {