X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-remoterpc-connector%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fremote%2Frpc%2Fmessages%2FRpcResponse.java;h=bb308203ddd789fcf783c7ab6e8e0abadd2ca63a;hb=HEAD;hp=a2f4f1f99421103f1ab28954348740a7a6af9277;hpb=ba6824307ad4b3c272abefe9682d623adc3b42d2;p=controller.git diff --git a/opendaylight/md-sal/sal-remoterpc-connector/src/main/java/org/opendaylight/controller/remote/rpc/messages/RpcResponse.java b/opendaylight/md-sal/sal-remoterpc-connector/src/main/java/org/opendaylight/controller/remote/rpc/messages/RpcResponse.java index a2f4f1f994..bb308203dd 100644 --- a/opendaylight/md-sal/sal-remoterpc-connector/src/main/java/org/opendaylight/controller/remote/rpc/messages/RpcResponse.java +++ b/opendaylight/md-sal/sal-remoterpc-connector/src/main/java/org/opendaylight/controller/remote/rpc/messages/RpcResponse.java @@ -9,13 +9,16 @@ package org.opendaylight.controller.remote.rpc.messages; import java.io.Externalizable; import java.io.IOException; +import java.io.InvalidObjectException; import java.io.ObjectInput; import java.io.ObjectOutput; +import java.util.Optional; import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.cluster.datastore.node.utils.stream.SerializationUtils; import org.opendaylight.yangtools.yang.data.api.schema.ContainerNode; +import org.opendaylight.yangtools.yang.data.api.schema.NormalizedNode; -public class RpcResponse extends AbstractResponse { +public class RpcResponse extends AbstractResponse { private static final long serialVersionUID = -4211279498688989245L; public RpcResponse(final @Nullable ContainerNode output) { @@ -27,6 +30,18 @@ public class RpcResponse extends AbstractResponse { return new Proxy(this); } + static @Nullable ContainerNode unmaskContainer(final Optional optNode) + throws InvalidObjectException { + if (optNode.isEmpty()) { + return null; + } + final var node = optNode.orElseThrow(); + if (node instanceof ContainerNode container) { + return container; + } + throw new InvalidObjectException("Unexpected data " + node.contract().getSimpleName()); + } + private static class Proxy implements Externalizable { private static final long serialVersionUID = 1L; @@ -49,7 +64,7 @@ public class RpcResponse extends AbstractResponse { @Override public void readExternal(final ObjectInput in) throws IOException { - rpcResponse = new RpcResponse((ContainerNode) SerializationUtils.readNormalizedNode(in).orElse(null)); + rpcResponse = new RpcResponse(unmaskContainer(SerializationUtils.readNormalizedNode(in))); } private Object readResolve() {