X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-remoterpc-connector%2Fsrc%2Ftest%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fremote%2Frpc%2Fregistry%2Fgossip%2FGossiperTest.java;h=9fccb069437a2a33b171cbd3f309b186b42f4f08;hb=e9fce74e37472296faa2faf1acbd110b74196032;hp=642534028bcfc551176c3c6fd0c540d9aa485ce6;hpb=9ddc65e1ddae50f691566cd9382707679436c055;p=controller.git diff --git a/opendaylight/md-sal/sal-remoterpc-connector/src/test/java/org/opendaylight/controller/remote/rpc/registry/gossip/GossiperTest.java b/opendaylight/md-sal/sal-remoterpc-connector/src/test/java/org/opendaylight/controller/remote/rpc/registry/gossip/GossiperTest.java index 642534028b..9fccb06943 100644 --- a/opendaylight/md-sal/sal-remoterpc-connector/src/test/java/org/opendaylight/controller/remote/rpc/registry/gossip/GossiperTest.java +++ b/opendaylight/md-sal/sal-remoterpc-connector/src/test/java/org/opendaylight/controller/remote/rpc/registry/gossip/GossiperTest.java @@ -16,15 +16,13 @@ import static org.mockito.Mockito.spy; import static org.mockito.Mockito.times; import static org.mockito.Mockito.verify; +import akka.actor.ActorSelection; import akka.actor.ActorSystem; import akka.actor.Address; import akka.actor.Props; import akka.testkit.JavaTestKit; import akka.testkit.TestActorRef; import com.typesafe.config.ConfigFactory; -import java.util.ArrayList; -import java.util.Collections; -import java.util.List; import java.util.Map; import org.junit.After; import org.junit.AfterClass; @@ -70,23 +68,18 @@ public class GossiperTest { @Test public void testReceiveGossipTick_WhenNoRemoteMemberShouldIgnore() { - - mockGossiper.setClusterMembers(Collections.
emptyList()); - doNothing().when(mockGossiper).getLocalStatusAndSendTo(any(Address.class)); + mockGossiper.setClusterMembers(); + doNothing().when(mockGossiper).getLocalStatusAndSendTo(any(ActorSelection.class)); mockGossiper.receiveGossipTick(); - verify(mockGossiper, times(0)).getLocalStatusAndSendTo(any(Address.class)); + verify(mockGossiper, times(0)).getLocalStatusAndSendTo(any(ActorSelection.class)); } @Test public void testReceiveGossipTick_WhenRemoteMemberExistsShouldSendStatus() { - List
members = new ArrayList<>(); - Address remote = new Address("tcp", "member"); - members.add(remote); - - mockGossiper.setClusterMembers(members); - doNothing().when(mockGossiper).getLocalStatusAndSendTo(any(Address.class)); + mockGossiper.setClusterMembers(new Address("tcp", "member")); + doNothing().when(mockGossiper).getLocalStatusAndSendTo(any(ActorSelection.class)); mockGossiper.receiveGossipTick(); - verify(mockGossiper, times(1)).getLocalStatusAndSendTo(any(Address.class)); + verify(mockGossiper, times(1)).getLocalStatusAndSendTo(any(ActorSelection.class)); } @SuppressWarnings("unchecked") @@ -97,10 +90,7 @@ public class GossiperTest { GossipStatus remoteStatus = new GossipStatus(nonMember, mock(Map.class)); //add a member - List
members = new ArrayList<>(); - members.add(new Address("tcp", "member")); - - mockGossiper.setClusterMembers(members); + mockGossiper.setClusterMembers(new Address("tcp", "member")); mockGossiper.receiveGossipStatus(remoteStatus); verify(mockGossiper, times(0)).getSender(); } @@ -122,8 +112,7 @@ public class GossiperTest { * @return instance of Gossiper class */ private static Gossiper createGossiper() { - final Props props = Props.create(Gossiper.class, false, - new RemoteRpcProviderConfig(system.settings().config())); + final Props props = Gossiper.testProps(new RemoteRpcProviderConfig(system.settings().config())); final TestActorRef testRef = TestActorRef.create(system, props, "testGossiper"); return testRef.underlyingActor();