X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-rest-connector%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fsal%2Frest%2Fimpl%2FXmlToCompositeNodeProvider.java;fp=opendaylight%2Fmd-sal%2Fsal-rest-connector%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fsal%2Frest%2Fimpl%2FXmlToCompositeNodeProvider.java;h=07b30327f07d7c8d8723e79268d213702bc189b4;hb=6cfe2845817ee6c0036de61ba9e4e51e55954eb4;hp=09733f5e907faa533167be5211b39cf2839b6345;hpb=db4f7442fdf4df1fade6c65c5da5a8ff7dba2079;p=controller.git diff --git a/opendaylight/md-sal/sal-rest-connector/src/main/java/org/opendaylight/controller/sal/rest/impl/XmlToCompositeNodeProvider.java b/opendaylight/md-sal/sal-rest-connector/src/main/java/org/opendaylight/controller/sal/rest/impl/XmlToCompositeNodeProvider.java index 09733f5e90..07b30327f0 100644 --- a/opendaylight/md-sal/sal-rest-connector/src/main/java/org/opendaylight/controller/sal/rest/impl/XmlToCompositeNodeProvider.java +++ b/opendaylight/md-sal/sal-rest-connector/src/main/java/org/opendaylight/controller/sal/rest/impl/XmlToCompositeNodeProvider.java @@ -18,19 +18,12 @@ import javax.xml.stream.XMLStreamException; import org.opendaylight.controller.sal.rest.api.RestconfService; import org.opendaylight.yangtools.yang.data.api.CompositeNode; -import org.opendaylight.yangtools.yang.data.api.Node; -import org.opendaylight.yangtools.yang.data.api.SimpleNode; -import org.opendaylight.yangtools.yang.data.impl.XmlTreeBuilder; -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; @Provider @Consumes({API+RestconfService.XML}) public enum XmlToCompositeNodeProvider implements MessageBodyReader { INSTANCE; - private final static Logger logger = LoggerFactory.getLogger(XmlToCompositeNodeProvider.class); - @Override public boolean isReadable(Class type, Type genericType, Annotation[] annotations, MediaType mediaType) { return true; @@ -40,16 +33,10 @@ public enum XmlToCompositeNodeProvider implements MessageBodyReader type, Type genericType, Annotation[] annotations, MediaType mediaType, MultivaluedMap httpHeaders, InputStream entityStream) throws IOException, WebApplicationException { + XmlReader xmlReader = new XmlReader(); try { - Node node = XmlTreeBuilder.buildDataTree(entityStream); - if (node instanceof SimpleNode) { - logger.info("Node is SimpleNode"); - throw new WebApplicationException(Response.status(Response.Status.BAD_REQUEST) - .entity("XML should start with XML element that contains 1..N XML child elements.").build()); - } - return (CompositeNode) node; - } catch (XMLStreamException e) { - logger.info("Error during translation of InputStream to Node\n" + e.getMessage()); + return xmlReader.read(entityStream); + } catch (XMLStreamException | UnsupportedFormatException e) { throw new WebApplicationException(Response.status(Response.Status.BAD_REQUEST) .entity(e.getMessage()).build()); }