X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-rest-connector%2Fsrc%2Ftest%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fsal%2Frestconf%2Fimpl%2Ftest%2FRestGetOperationTest.java;h=893622f60a18ae8a0b8e5e394f9631d0f418374c;hb=1ee71ae58a03de1c1f8fd8c789e7921508ba9f59;hp=d997a8afb19d60854f58bb2802ee4f5ad850da61;hpb=e4b42231fac4bf9749d91f65a526cced1be7d6a3;p=controller.git diff --git a/opendaylight/md-sal/sal-rest-connector/src/test/java/org/opendaylight/controller/sal/restconf/impl/test/RestGetOperationTest.java b/opendaylight/md-sal/sal-rest-connector/src/test/java/org/opendaylight/controller/sal/restconf/impl/test/RestGetOperationTest.java index d997a8afb1..893622f60a 100644 --- a/opendaylight/md-sal/sal-rest-connector/src/test/java/org/opendaylight/controller/sal/restconf/impl/test/RestGetOperationTest.java +++ b/opendaylight/md-sal/sal-rest-connector/src/test/java/org/opendaylight/controller/sal/restconf/impl/test/RestGetOperationTest.java @@ -1,20 +1,31 @@ +/* + * Copyright (c) 2014 Cisco Systems, Inc. and others. All rights reserved. + * + * This program and the accompanying materials are made available under the + * terms of the Eclipse Public License v1.0 which accompanies this distribution, + * and is available at http://www.eclipse.org/legal/epl-v10.html + */ package org.opendaylight.controller.sal.restconf.impl.test; +import static junit.framework.Assert.assertNotNull; import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertTrue; import static org.mockito.Matchers.any; +import static org.mockito.Matchers.eq; import static org.mockito.Mockito.mock; import static org.mockito.Mockito.when; -import static org.opendaylight.controller.sal.restconf.impl.test.RestOperationUtils.JSON; -import static org.opendaylight.controller.sal.restconf.impl.test.RestOperationUtils.XML; -import static org.opendaylight.controller.sal.restconf.impl.test.RestOperationUtils.createUri; import java.io.FileNotFoundException; import java.io.UnsupportedEncodingException; import java.net.URI; import java.net.URISyntaxException; +import java.text.ParseException; +import java.text.SimpleDateFormat; import java.util.ArrayList; +import java.util.Date; import java.util.List; -import java.util.logging.Level; +import java.util.regex.Matcher; +import java.util.regex.Pattern; import javax.ws.rs.core.Application; import javax.ws.rs.core.MediaType; @@ -22,15 +33,12 @@ import javax.ws.rs.core.Response; import org.glassfish.jersey.server.ResourceConfig; import org.glassfish.jersey.test.JerseyTest; -import org.glassfish.jersey.test.TestProperties; -import org.junit.Before; import org.junit.BeforeClass; import org.junit.Test; +import org.opendaylight.controller.sal.core.api.mount.MountInstance; import org.opendaylight.controller.sal.core.api.mount.MountService; -import org.opendaylight.controller.sal.rest.api.Draft01; -import org.opendaylight.controller.sal.rest.api.Draft02; -import org.opendaylight.controller.sal.rest.api.RestconfService; import org.opendaylight.controller.sal.rest.impl.JsonToCompositeNodeProvider; +import org.opendaylight.controller.sal.rest.impl.RestconfDocumentedExceptionMapper; import org.opendaylight.controller.sal.rest.impl.StructuredDataToJsonProvider; import org.opendaylight.controller.sal.rest.impl.StructuredDataToXmlProvider; import org.opendaylight.controller.sal.rest.impl.XmlToCompositeNodeProvider; @@ -39,8 +47,10 @@ import org.opendaylight.controller.sal.restconf.impl.CompositeNodeWrapper; import org.opendaylight.controller.sal.restconf.impl.ControllerContext; import org.opendaylight.controller.sal.restconf.impl.RestconfImpl; import org.opendaylight.controller.sal.restconf.impl.SimpleNodeWrapper; +import org.opendaylight.yangtools.yang.common.QName; import org.opendaylight.yangtools.yang.data.api.CompositeNode; import org.opendaylight.yangtools.yang.data.api.InstanceIdentifier; +import org.opendaylight.yangtools.yang.data.api.InstanceIdentifier.PathArgument; import org.opendaylight.yangtools.yang.data.api.Node; import org.opendaylight.yangtools.yang.model.api.SchemaContext; @@ -50,6 +60,10 @@ public class RestGetOperationTest extends JerseyTest { private static RestconfImpl restconfImpl; private static SchemaContext schemaContextYangsIetf; private static SchemaContext schemaContextTestModule; + private static CompositeNode answerFromGet; + + private static SchemaContext schemaContextModules; + private static SchemaContext schemaContextBehindMountPoint; @BeforeClass public static void init() throws FileNotFoundException { @@ -61,213 +75,484 @@ public class RestGetOperationTest extends JerseyTest { restconfImpl = RestconfImpl.getInstance(); restconfImpl.setBroker(brokerFacade); restconfImpl.setControllerContext(controllerContext); - } + answerFromGet = prepareCompositeNodeWithIetfInterfacesInterfacesData(); - @Before - public void logs() { - /* enable/disable Jersey logs to console */ - /* - * List loggedRecords = getLoggedRecords(); for (LogRecord l - * : loggedRecords) { System.out.println(l.getMessage()); } - */ + schemaContextModules = TestUtils.loadSchemaContext("/modules"); + schemaContextBehindMountPoint = TestUtils.loadSchemaContext("/modules/modules-behind-mount-point"); } @Override protected Application configure() { /* enable/disable Jersey logs to console */ - /* - * enable(TestProperties.LOG_TRAFFIC); - */ - enable(TestProperties.DUMP_ENTITY); - enable(TestProperties.RECORD_LOG_LEVEL); - set(TestProperties.RECORD_LOG_LEVEL, Level.ALL.intValue()); - + // enable(TestProperties.LOG_TRAFFIC); + // enable(TestProperties.DUMP_ENTITY); + // enable(TestProperties.RECORD_LOG_LEVEL); + // set(TestProperties.RECORD_LOG_LEVEL, Level.ALL.intValue()); ResourceConfig resourceConfig = new ResourceConfig(); resourceConfig = resourceConfig.registerInstances(restconfImpl, StructuredDataToXmlProvider.INSTANCE, StructuredDataToJsonProvider.INSTANCE, XmlToCompositeNodeProvider.INSTANCE, JsonToCompositeNodeProvider.INSTANCE); + resourceConfig.registerClasses( RestconfDocumentedExceptionMapper.class ); return resourceConfig; } /** - * Tests {@link RestconfImpl#readData() readAllData()} method of - * RestconfImpl with url {@code "/datastore/ identifier}"}. Status codes 200 - * is tested. + * Tests of status codes for "/operational/{identifier}". */ @Test - public void getDatastoreDataViaUrlTest200() throws FileNotFoundException, UnsupportedEncodingException { + public void getOperationalStatusCodes() throws UnsupportedEncodingException { mockReadOperationalDataMethod(); - getDataWithUrl("/datastore/", Draft01.MediaTypes.DATA + JSON, 200); - getDataWithUrl("/datastore/", Draft01.MediaTypes.DATA + XML, 200); - getDataWithUrl("/datastore/", MediaType.APPLICATION_JSON, 200); - getDataWithUrl("/datastore/", MediaType.APPLICATION_XML, 200); - getDataWithUrl("/datastore/", MediaType.TEXT_XML, 200); + String uri = "/operational/ietf-interfaces:interfaces/interface/eth0"; + assertEquals(200, get(uri, MediaType.APPLICATION_XML)); + + uri = "/operational/wrong-module:interfaces/interface/eth0"; + assertEquals(400, get(uri, MediaType.APPLICATION_XML)); } /** - * Tests {@link RestconfImpl#readData() readAllData()} method of - * RestconfImpl with url {@code "/datastore/ identifier}"}. Status codes 400 - * is tested. + * Tests of status codes for "/config/{identifier}". */ @Test - public void getDatastoreDataViaUrlTest400() throws FileNotFoundException, UnsupportedEncodingException { - mockReadOperationalDataMethod(); - getDataWithUrl("/datastore/", Draft01.MediaTypes.DATA + JSON, 400); - getDataWithUrl("/datastore/", Draft01.MediaTypes.DATA + XML, 400); - getDataWithUrl("/datastore/", MediaType.APPLICATION_JSON, 400); - getDataWithUrl("/datastore/", MediaType.APPLICATION_XML, 400); - getDataWithUrl("/datastore/", MediaType.TEXT_XML, 400); + public void getConfigStatusCodes() throws UnsupportedEncodingException { + mockReadConfigurationDataMethod(); + String uri = "/config/ietf-interfaces:interfaces/interface/eth0"; + assertEquals(200, get(uri, MediaType.APPLICATION_XML)); + + uri = "/config/wrong-module:interfaces/interface/eth0"; + assertEquals(400, get(uri, MediaType.APPLICATION_XML)); } /** - * Tests {@link RestconfImpl#readOperationalData(String) - * readOperationalData(String)} method of RestconfImpl with url - * {@code "/operational/...identifier..."}. Status codes 200 is tested. + * MountPoint test. URI represents mount point. */ @Test - public void getOperationalDataViaUrl200() throws UnsupportedEncodingException { - mockReadOperationalDataMethod(); - getDataWithUrl("/operational/", Draft02.MediaTypes.DATA + JSON, 200); - getDataWithUrl("/operational/", Draft02.MediaTypes.DATA + XML, 200); - getDataWithUrl("/operational/", MediaType.APPLICATION_JSON, 200); - getDataWithUrl("/operational/", MediaType.APPLICATION_XML, 200); - getDataWithUrl("/operational/", MediaType.TEXT_XML, 200); + public void getDataWithUrlMountPoint() throws UnsupportedEncodingException, URISyntaxException { + when( + brokerFacade.readConfigurationDataBehindMountPoint(any(MountInstance.class), + any(InstanceIdentifier.class))).thenReturn(prepareCnDataForMountPointTest()); + MountInstance mountInstance = mock(MountInstance.class); + when(mountInstance.getSchemaContext()).thenReturn(schemaContextTestModule); + MountService mockMountService = mock(MountService.class); + when(mockMountService.getMountPoint(any(InstanceIdentifier.class))).thenReturn(mountInstance); + + ControllerContext.getInstance().setMountService(mockMountService); + + String uri = "/config/ietf-interfaces:interfaces/interface/0/yang-ext:mount/test-module:cont/cont1"; + assertEquals(200, get(uri, MediaType.APPLICATION_XML)); + + uri = "/config/ietf-interfaces:interfaces/yang-ext:mount/test-module:cont/cont1"; + assertEquals(200, get(uri, MediaType.APPLICATION_XML)); } /** - * Tests {@link RestconfImpl#readOperationalData(String) - * readOperationalData(String)} method of RestconfImpl with url - * {@code "/operational/...identifier..."}. Status codes 400 is tested. + * MountPoint test. URI represents mount point. + * + * Slashes in URI behind mount point. lst1 element with key + * GigabitEthernet0%2F0%2F0%2F0 (GigabitEthernet0/0/0/0) is requested via + * GET HTTP operation. It is tested whether %2F character is replaced with + * simple / in InstanceIdentifier parameter in method + * {@link BrokerFacade#readConfigurationDataBehindMountPoint(MountInstance, InstanceIdentifier)} + * which is called in method {@link RestconfImpl#readConfigurationData} + * + * + * @throws ParseException */ @Test - public void getOperationalDataViaUrl400() throws UnsupportedEncodingException { - mockReadOperationalDataMethod(); - getDataWithUrl("/operational/", Draft02.MediaTypes.DATA + JSON, 400); - getDataWithUrl("/operational/", Draft02.MediaTypes.DATA + XML, 400); - getDataWithUrl("/operational/", MediaType.APPLICATION_JSON, 400); - getDataWithUrl("/operational/", MediaType.APPLICATION_XML, 400); - getDataWithUrl("/operational/", MediaType.TEXT_XML, 400); + public void getDataWithSlashesBehindMountPoint() throws UnsupportedEncodingException, URISyntaxException, + ParseException { + InstanceIdentifier awaitedInstanceIdentifier = prepareInstanceIdentifierForList(); + when( + brokerFacade.readConfigurationDataBehindMountPoint(any(MountInstance.class), + eq(awaitedInstanceIdentifier))).thenReturn(prepareCnDataForMountPointTest()); + MountInstance mountInstance = mock(MountInstance.class); + when(mountInstance.getSchemaContext()).thenReturn(schemaContextTestModule); + MountService mockMountService = mock(MountService.class); + when(mockMountService.getMountPoint(any(InstanceIdentifier.class))).thenReturn(mountInstance); + + ControllerContext.getInstance().setMountService(mockMountService); + + String uri = "/config/ietf-interfaces:interfaces/interface/0/yang-ext:mount/test-module:cont/lst1/GigabitEthernet0%2F0%2F0%2F0"; + assertEquals(200, get(uri, MediaType.APPLICATION_XML)); + } + + private InstanceIdentifier prepareInstanceIdentifierForList() throws URISyntaxException, ParseException { + List parameters = new ArrayList<>(); + + Date revision = new SimpleDateFormat("yyyy-MM-dd").parse("2014-01-09"); + URI uri = new URI("test:module"); + QName qNameCont = QName.create(uri, revision, "cont"); + QName qNameList = QName.create(uri, revision, "lst1"); + QName qNameKeyList = QName.create(uri, revision, "lf11"); + + parameters.add(new InstanceIdentifier.NodeIdentifier(qNameCont)); + parameters.add(new InstanceIdentifier.NodeIdentifierWithPredicates(qNameList, qNameKeyList, + "GigabitEthernet0/0/0/0")); + return new InstanceIdentifier(parameters); } - /** - * Tests {@link RestconfImpl#readOperationalData - * #readConfigurationData(String) readConfigurationData(String)} method of - * RestconfImpl with url {@code "/config/...identifier..."}. Status codes - * 200 is tested. - */ @Test - public void getConfigDataViaUrl200() throws UnsupportedEncodingException { - mockReadConfigurationDataMethod(); - getDataWithUrl("/config/", Draft02.MediaTypes.DATA + JSON, 200); - getDataWithUrl("/config/", Draft02.MediaTypes.DATA + XML, 200); - getDataWithUrl("/config/", MediaType.APPLICATION_JSON, 200); - getDataWithUrl("/config/", MediaType.APPLICATION_XML, 200); - getDataWithUrl("/config/", MediaType.TEXT_XML, 200); + public void getDataMountPointIntoHighestElement() throws UnsupportedEncodingException, URISyntaxException { + when( + brokerFacade.readConfigurationDataBehindMountPoint(any(MountInstance.class), + any(InstanceIdentifier.class))).thenReturn(prepareCnDataForMountPointTest()); + MountInstance mountInstance = mock(MountInstance.class); + when(mountInstance.getSchemaContext()).thenReturn(schemaContextTestModule); + MountService mockMountService = mock(MountService.class); + when(mockMountService.getMountPoint(any(InstanceIdentifier.class))).thenReturn(mountInstance); + + ControllerContext.getInstance().setMountService(mockMountService); + + String uri = "/config/ietf-interfaces:interfaces/interface/0/yang-ext:mount/"; + assertEquals(200, get(uri, MediaType.APPLICATION_XML)); } - /** - * Tests {@link RestconfImpl#readOperationalData - * #readConfigurationData(String) readConfigurationData(String)} method of - * RestconfImpl with url {@code "/config/...identifier..."}. Status codes - * 400 is tested. - */ + // /modules @Test - public void getConfigDataViaUrl400() throws UnsupportedEncodingException { - mockReadConfigurationDataMethod(); - getDataWithUrl("/config/", Draft02.MediaTypes.DATA + JSON, 400); - getDataWithUrl("/config/", Draft02.MediaTypes.DATA + XML, 400); - getDataWithUrl("/config/", MediaType.APPLICATION_JSON, 400); - getDataWithUrl("/config/", MediaType.APPLICATION_XML, 400); - getDataWithUrl("/config/", MediaType.TEXT_XML, 400); + public void getModulesTest() throws UnsupportedEncodingException, FileNotFoundException { + ControllerContext.getInstance().setGlobalSchema(schemaContextModules); + + String uri = "/modules"; + + Response response = target(uri).request("application/yang.api+json").get(); + validateModulesResponseJson(response); + + response = target(uri).request("application/yang.api+xml").get(); + validateModulesResponseXml(response); } - /** - * Tests {@link RestconfImpl#readAllData() readAllData()} method of - * RestconfImpl with url {@code "/datastore"}. Currently the method isn't - * supported so it returns 500 - */ + // /streams/ @Test - public void getDatastoreDataAllTest500() throws UnsupportedEncodingException { - getDatastoreAllDataTest(Draft01.MediaTypes.DATASTORE + XML); - getDatastoreAllDataTest(Draft01.MediaTypes.DATASTORE + JSON); + public void getStreamsTest() throws UnsupportedEncodingException, FileNotFoundException { + ControllerContext.getInstance().setGlobalSchema(schemaContextModules); + + String uri = "/streams"; + + Response response = target(uri).request("application/yang.api+json").get(); + String responseBody = response.readEntity(String.class); + assertNotNull(responseBody); + assertTrue(responseBody.contains("streams")); + + response = target(uri).request("application/yang.api+xml").get(); + responseBody = response.readEntity(String.class); + assertNotNull(responseBody); + assertTrue(responseBody.contains(""); + + regex.append(".*<"); + regex.append(".*" + rpcName); + regex.append(".*" + namespace); + regex.append(".*/"); + regex.append(".*>"); + + regex.append(".*"); + + regex.append(".*"); + regex.append("$"); + Pattern ptrn = Pattern.compile(regex.toString(), Pattern.DOTALL); + return ptrn.matcher(searchIn); + } + + // /restconf/modules/pathToMountPoint/yang-ext:mount + @Test + public void getModulesBehindMountPoint() throws FileNotFoundException, UnsupportedEncodingException { + ControllerContext controllerContext = ControllerContext.getInstance(); + controllerContext.setGlobalSchema(schemaContextModules); + + MountInstance mountInstance = mock(MountInstance.class); + when(mountInstance.getSchemaContext()).thenReturn(schemaContextBehindMountPoint); + MountService mockMountService = mock(MountService.class); + when(mockMountService.getMountPoint(any(InstanceIdentifier.class))).thenReturn(mountInstance); + + controllerContext.setMountService(mockMountService); + + String uri = "/modules/ietf-interfaces:interfaces/interface/0/yang-ext:mount/"; + + Response response = target(uri).request("application/yang.api+json").get(); + assertEquals(200, response.getStatus()); + String responseBody = response.readEntity(String.class); + + assertTrue( + "module1-behind-mount-point in json wasn't found", + prepareJsonRegex("module1-behind-mount-point", "2014-02-03", "module:1:behind:mount:point", + responseBody).find()); + assertTrue( + "module2-behind-mount-point in json wasn't found", + prepareJsonRegex("module2-behind-mount-point", "2014-02-04", "module:2:behind:mount:point", + responseBody).find()); + + response = target(uri).request("application/yang.api+xml").get(); + assertEquals(200, response.getStatus()); + responseBody = response.readEntity(String.class); + assertTrue( + "module1-behind-mount-point in json wasn't found", + prepareXmlRegex("module1-behind-mount-point", "2014-02-03", "module:1:behind:mount:point", responseBody) + .find()); + assertTrue( + "module2-behind-mount-point in json wasn't found", + prepareXmlRegex("module2-behind-mount-point", "2014-02-04", "module:2:behind:mount:point", responseBody) + .find()); + + } + + // /restconf/modules/module/pathToMountPoint/yang-ext:mount/moduleName/revision + @Test + public void getModuleBehindMountPoint() throws FileNotFoundException, UnsupportedEncodingException { + ControllerContext controllerContext = ControllerContext.getInstance(); + controllerContext.setGlobalSchema(schemaContextModules); + + MountInstance mountInstance = mock(MountInstance.class); + when(mountInstance.getSchemaContext()).thenReturn(schemaContextBehindMountPoint); + MountService mockMountService = mock(MountService.class); + when(mockMountService.getMountPoint(any(InstanceIdentifier.class))).thenReturn(mountInstance); + + controllerContext.setMountService(mockMountService); + + String uri = "/modules/module/ietf-interfaces:interfaces/interface/0/yang-ext:mount/module1-behind-mount-point/2014-02-03"; + + Response response = target(uri).request("application/yang.api+json").get(); + assertEquals(200, response.getStatus()); + String responseBody = response.readEntity(String.class); + + assertTrue( + "module1-behind-mount-point in json wasn't found", + prepareJsonRegex("module1-behind-mount-point", "2014-02-03", "module:1:behind:mount:point", + responseBody).find()); + String[] split = responseBody.split("\"module\""); + assertEquals("\"module\" element is returned more then once", 2, split.length); + + response = target(uri).request("application/yang.api+xml").get(); + assertEquals(200, response.getStatus()); + responseBody = response.readEntity(String.class); + assertTrue( + "module1-behind-mount-point in json wasn't found", + prepareXmlRegex("module1-behind-mount-point", "2014-02-03", "module:1:behind:mount:point", responseBody) + .find()); + split = responseBody.split(""); - assertEquals("Status is incorrect for media type " + mediaType + ".", 500, response.getStatus()); + regex.append(".*"); + regex.append(".*" + module); + regex.append(".*<\\/name>"); + + regex.append(".*"); + regex.append(".*" + revision); + regex.append(".*<\\/revision>"); + + regex.append(".*"); + regex.append(".*" + namespace); + regex.append(".*<\\/namespace>"); + + regex.append(".*<\\/module.*>"); + + regex.append(".*"); + regex.append("$"); + + Pattern ptrn = Pattern.compile(regex.toString(), Pattern.DOTALL); + return ptrn.matcher(searchIn); } - private void getDatastoreAllDataTest(String mediaType) throws UnsupportedEncodingException { - String uri = createUri("/datastore", ""); - Response response = target(uri).request(mediaType).get(); + private void prepareMockForModulesTest(ControllerContext mockedControllerContext) throws FileNotFoundException { + SchemaContext schemaContext = TestUtils.loadSchemaContext("/modules"); + mockedControllerContext.setGlobalSchema(schemaContext); + // when(mockedControllerContext.getGlobalSchema()).thenReturn(schemaContext); + } - assertEquals(500, response.getStatus()); + private int get(String uri, String mediaType) { + return target(uri).request(mediaType).get().getStatus(); } private CompositeNode prepareCnDataForMountPointTest() throws URISyntaxException { @@ -277,7 +562,15 @@ public class RestGetOperationTest extends JerseyTest { return cont1.unwrap(); } - private CompositeNode prepareCompositeNodeWithIetfInterfacesInterfacesData() { + private void mockReadOperationalDataMethod() { + when(brokerFacade.readOperationalData(any(InstanceIdentifier.class))).thenReturn(answerFromGet); + } + + private void mockReadConfigurationDataMethod() { + when(brokerFacade.readConfigurationData(any(InstanceIdentifier.class))).thenReturn(answerFromGet); + } + + private static CompositeNode prepareCompositeNodeWithIetfInterfacesInterfacesData() { CompositeNode intface; try { intface = new CompositeNodeWrapper(new URI("interface"), "interface"); @@ -295,13 +588,4 @@ public class RestGetOperationTest extends JerseyTest { return null; } - private void mockReadOperationalDataMethod() { - CompositeNode loadedCompositeNode = prepareCompositeNodeWithIetfInterfacesInterfacesData(); - when(brokerFacade.readOperationalData(any(InstanceIdentifier.class))).thenReturn(loadedCompositeNode); - } - - private void mockReadConfigurationDataMethod() { - CompositeNode loadedCompositeNode = prepareCompositeNodeWithIetfInterfacesInterfacesData(); - when(brokerFacade.readConfigurationData(any(InstanceIdentifier.class))).thenReturn(loadedCompositeNode); - } }