X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fstatistics-manager%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fmd%2Fstatistics%2Fmanager%2FStatisticsProvider.java;h=892d304daa8d6cd20c7010082f2698cb8de90266;hb=19ab68258206beb0ced04f77480f419002342bc1;hp=8ffa5d673269f06954c70cffd483d5fa893e540d;hpb=def3f90c150a98aa910ce5ba3e4692c461dd3250;p=controller.git diff --git a/opendaylight/md-sal/statistics-manager/src/main/java/org/opendaylight/controller/md/statistics/manager/StatisticsProvider.java b/opendaylight/md-sal/statistics-manager/src/main/java/org/opendaylight/controller/md/statistics/manager/StatisticsProvider.java index 8ffa5d6732..892d304daa 100644 --- a/opendaylight/md-sal/statistics-manager/src/main/java/org/opendaylight/controller/md/statistics/manager/StatisticsProvider.java +++ b/opendaylight/md-sal/statistics-manager/src/main/java/org/opendaylight/controller/md/statistics/manager/StatisticsProvider.java @@ -9,10 +9,8 @@ package org.opendaylight.controller.md.statistics.manager; import java.util.Collection; import java.util.Timer; -import java.util.TimerTask; import java.util.concurrent.ConcurrentHashMap; import java.util.concurrent.ConcurrentMap; -import java.util.concurrent.TimeUnit; import org.opendaylight.controller.sal.binding.api.NotificationProviderService; import org.opendaylight.controller.sal.binding.api.RpcConsumerRegistry; @@ -51,8 +49,6 @@ import com.google.common.base.Preconditions; * */ public class StatisticsProvider implements AutoCloseable { - public static final long STATS_COLLECTION_MILLIS = TimeUnit.SECONDS.toMillis(15); - private static final Logger spLogger = LoggerFactory.getLogger(StatisticsProvider.class); private final ConcurrentMap handlers = new ConcurrentHashMap<>(); @@ -101,27 +97,6 @@ public class StatisticsProvider implements AutoCloseable { this.flowCapableTrackerRegistration = dps.registerDataChangeListener(fcnId, new FlowCapableTracker(this, fcnId)); - timer.schedule(new TimerTask() { - @Override - public void run() { - try { - // Send stats requests - for (NodeStatisticsHandler h : handlers.values()) { - h.requestPeriodicStatistics(); - } - - // Perform cleanup - for(NodeStatisticsHandler nodeStatisticsAger : handlers.values()){ - nodeStatisticsAger.cleanStaleStatistics(); - } - - } catch (RuntimeException e) { - spLogger.warn("Failed to request statistics", e); - } - } - }, 0, STATS_COLLECTION_MILLIS); - - spLogger.debug("Statistics timer task with timer interval : {}ms", STATS_COLLECTION_MILLIS); spLogger.info("Statistics Provider started."); } @@ -173,7 +148,7 @@ public class StatisticsProvider implements AutoCloseable { final NodeStatisticsHandler old = handlers.putIfAbsent(key.getId(), h); if (old == null) { spLogger.debug("Started node handler for {}", key.getId()); - h.start(); + h.start(timer); } else { spLogger.debug("Prevented race on handler for {}", key.getId()); }