X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fnetconf%2Fconfig-netconf-connector%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fnetconf%2Fconfignetconfconnector%2Fmapping%2Fattributes%2Ffromxml%2FObjectNameAttributeReadingStrategy.java;h=59dc11f0b81fc78b2ee6405a5d323541cc04e1d3;hb=371bb07d5c970798f247170130c93147890708e8;hp=bdb9391e2b5a26ac7191eac76448c422a2f0ad11;hpb=d77ff43c050b0d97188b97f8e169626a9f253b71;p=controller.git diff --git a/opendaylight/netconf/config-netconf-connector/src/main/java/org/opendaylight/controller/netconf/confignetconfconnector/mapping/attributes/fromxml/ObjectNameAttributeReadingStrategy.java b/opendaylight/netconf/config-netconf-connector/src/main/java/org/opendaylight/controller/netconf/confignetconfconnector/mapping/attributes/fromxml/ObjectNameAttributeReadingStrategy.java index bdb9391e2b..59dc11f0b8 100644 --- a/opendaylight/netconf/config-netconf-connector/src/main/java/org/opendaylight/controller/netconf/confignetconfconnector/mapping/attributes/fromxml/ObjectNameAttributeReadingStrategy.java +++ b/opendaylight/netconf/config-netconf-connector/src/main/java/org/opendaylight/controller/netconf/confignetconfconnector/mapping/attributes/fromxml/ObjectNameAttributeReadingStrategy.java @@ -15,9 +15,12 @@ import org.opendaylight.controller.netconf.util.xml.XmlElement; import org.opendaylight.controller.netconf.util.xml.XmlNetconfConstants; import java.util.List; +import java.util.Map; public class ObjectNameAttributeReadingStrategy extends AbstractAttributeReadingStrategy { + private static final Object PREFIX_SEPARATOR = ":"; + public ObjectNameAttributeReadingStrategy(DependencyAttribute attributeIfc) { super(attributeIfc); } @@ -35,11 +38,28 @@ public class ObjectNameAttributeReadingStrategy extends AbstractAttributeReading private ObjectNameAttributeMappingStrategy.MappedDependency resolve(XmlElement firstChild) { XmlElement typeElement = firstChild.getOnlyChildElementWithSameNamespace(XmlNetconfConstants.TYPE_KEY); - String serviceName = typeElement.getTextContent(); + Map.Entry prefixNamespace = typeElement.findNamespaceOfTextContent(); + + String serviceName = checkPrefixAndExtractServiceName(typeElement, prefixNamespace); + XmlElement nameElement = firstChild.getOnlyChildElementWithSameNamespace(XmlNetconfConstants.NAME_KEY); String dependencyName = nameElement.getTextContent(); - return new ObjectNameAttributeMappingStrategy.MappedDependency(serviceName, dependencyName); + return new ObjectNameAttributeMappingStrategy.MappedDependency(prefixNamespace.getValue(), serviceName, + dependencyName); + } + + public static String checkPrefixAndExtractServiceName(XmlElement typeElement, Map.Entry prefixNamespace) { + String serviceName = typeElement.getTextContent(); + + Preconditions.checkState(prefixNamespace.equals("") == false, "Service %s value not prefixed with namespace", + XmlNetconfConstants.TYPE_KEY); + String prefix = prefixNamespace.getKey() + PREFIX_SEPARATOR; + Preconditions.checkState(serviceName.startsWith(prefix), + "Service %s not correctly prefixed, expected %s, but was %s", XmlNetconfConstants.TYPE_KEY, prefix, + serviceName); + serviceName = serviceName.substring(prefix.length()); + return serviceName; } }