X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fnetconf%2Fconfig-netconf-connector%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fnetconf%2Fconfignetconfconnector%2Foperations%2Feditconfig%2FMissingInstanceHandlingStrategy.java;h=1eb4c834dc5207407473778184608237ad1db753;hb=992a433ff8fd0ce7335bf5ea9e59a75602a95a19;hp=c431766c4c5a61ebbf53928a529b63ea933d4f2b;hpb=6dae254dbc2940d1f0f372d65d69b0e0dda415fe;p=controller.git diff --git a/opendaylight/netconf/config-netconf-connector/src/main/java/org/opendaylight/controller/netconf/confignetconfconnector/operations/editconfig/MissingInstanceHandlingStrategy.java b/opendaylight/netconf/config-netconf-connector/src/main/java/org/opendaylight/controller/netconf/confignetconfconnector/operations/editconfig/MissingInstanceHandlingStrategy.java index c431766c4c..1eb4c834dc 100644 --- a/opendaylight/netconf/config-netconf-connector/src/main/java/org/opendaylight/controller/netconf/confignetconfconnector/operations/editconfig/MissingInstanceHandlingStrategy.java +++ b/opendaylight/netconf/config-netconf-connector/src/main/java/org/opendaylight/controller/netconf/confignetconfconnector/operations/editconfig/MissingInstanceHandlingStrategy.java @@ -8,6 +8,9 @@ package org.opendaylight.controller.netconf.confignetconfconnector.operations.editconfig; +import java.util.Map; +import javax.management.InstanceAlreadyExistsException; +import javax.management.ObjectName; import org.opendaylight.controller.config.util.ConfigTransactionClient; import org.opendaylight.controller.netconf.api.NetconfDocumentedException; import org.opendaylight.controller.netconf.confignetconfconnector.exception.NetconfConfigHandlingException; @@ -16,21 +19,16 @@ import org.opendaylight.controller.netconf.confignetconfconnector.mapping.config import org.slf4j.Logger; import org.slf4j.LoggerFactory; -import javax.management.InstanceAlreadyExistsException; -import javax.management.ObjectName; -import java.util.Map; - public class MissingInstanceHandlingStrategy extends AbstractEditConfigStrategy { - private static final Logger logger = LoggerFactory.getLogger(MissingInstanceHandlingStrategy.class); + private static final Logger LOG = LoggerFactory.getLogger(MissingInstanceHandlingStrategy.class); @Override void handleMissingInstance(Map configuration, ConfigTransactionClient ta, String module, String instance, ServiceRegistryWrapper services) throws NetconfConfigHandlingException { - ObjectName on = null; try { - on = ta.createModule(module, instance); - logger.trace("New instance for {} {} created under name {}", module, instance, on); + ObjectName on = ta.createModule(module, instance); + LOG.trace("New instance for {} {} created under name {}", module, instance, on); } catch (InstanceAlreadyExistsException e1) { throw new NetconfConfigHandlingException(String.format("Unable to create instance for %s : %s.", module, instance), NetconfDocumentedException.ErrorType.application, @@ -42,6 +40,5 @@ public class MissingInstanceHandlingStrategy extends AbstractEditConfigStrategy @Override void executeStrategy(Map configuration, ConfigTransactionClient ta, ObjectName objectName, ServiceRegistryWrapper services) { - return; } }