X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fnetconf%2Fnetconf-it%2Fsrc%2Ftest%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fnetconf%2Fit%2Fpax%2FIdentityRefNetconfTest.java;h=981f1148e48520f300e6af00810054380285f31c;hb=fee7a0ff61c980453e0302e750b464988f58a5ce;hp=18275ad78b0c53081fee38fdbfbffb7f34aa6867;hpb=1745f92957146128e8a4a111adb7ed830f737e0a;p=controller.git diff --git a/opendaylight/netconf/netconf-it/src/test/java/org/opendaylight/controller/netconf/it/pax/IdentityRefNetconfTest.java b/opendaylight/netconf/netconf-it/src/test/java/org/opendaylight/controller/netconf/it/pax/IdentityRefNetconfTest.java index 18275ad78b..981f1148e4 100644 --- a/opendaylight/netconf/netconf-it/src/test/java/org/opendaylight/controller/netconf/it/pax/IdentityRefNetconfTest.java +++ b/opendaylight/netconf/netconf-it/src/test/java/org/opendaylight/controller/netconf/it/pax/IdentityRefNetconfTest.java @@ -1,10 +1,10 @@ /* - * Copyright (c) 2013 Cisco Systems, Inc. and others. All rights reserved. - * - * This program and the accompanying materials are made available under the - * terms of the Eclipse Public License v1.0 which accompanies this distribution, - * and is available at http://www.eclipse.org/legal/epl-v10.html - */ +* Copyright (c) 2013 Cisco Systems, Inc. and others. All rights reserved. +* +* This program and the accompanying materials are made available under the +* terms of the Eclipse Public License v1.0 which accompanies this distribution, +* and is available at http://www.eclipse.org/legal/epl-v10.html +*/ package org.opendaylight.controller.netconf.it.pax; import static org.junit.Assert.fail; @@ -20,23 +20,30 @@ import static org.ops4j.pax.exam.CoreOptions.streamBundle; import static org.ops4j.pax.exam.CoreOptions.systemPackages; import static org.ops4j.pax.exam.CoreOptions.systemProperty; -import javax.inject.Inject; +import io.netty.util.HashedWheelTimer; +import io.netty.util.Timer; +import java.io.IOException; +import java.net.InetSocketAddress; +import java.util.concurrent.ExecutionException; +import java.util.concurrent.TimeoutException; + import javax.xml.parsers.ParserConfigurationException; -import com.google.common.base.Preconditions; -import com.google.common.base.Throwables; -import io.netty.channel.nio.NioEventLoopGroup; import org.junit.Assert; import org.junit.Ignore; import org.junit.Test; import org.junit.matchers.JUnitMatchers; import org.junit.runner.RunWith; import org.opendaylight.controller.netconf.api.NetconfMessage; -import org.opendaylight.controller.netconf.client.NetconfClientDispatcher; +import org.opendaylight.controller.netconf.client.NetconfClientDispatcherImpl; +import org.opendaylight.controller.netconf.client.SimpleNetconfClientSessionListener; +import org.opendaylight.controller.netconf.client.conf.NetconfClientConfiguration; +import org.opendaylight.controller.netconf.client.conf.NetconfClientConfigurationBuilder; import org.opendaylight.controller.netconf.client.test.TestingNetconfClient; import org.opendaylight.controller.netconf.util.test.XmlFileLoader; import org.opendaylight.controller.netconf.util.xml.XmlUtil; import org.opendaylight.controller.sal.binding.api.BindingAwareBroker; +import org.opendaylight.protocol.framework.NeverReconnectStrategy; import org.ops4j.pax.exam.Configuration; import org.ops4j.pax.exam.Option; import org.ops4j.pax.exam.junit.PaxExam; @@ -46,10 +53,11 @@ import org.ops4j.pax.tinybundles.core.TinyBundles; import org.osgi.framework.Constants; import org.xml.sax.SAXException; -import java.io.IOException; -import java.net.InetSocketAddress; -import java.util.concurrent.ExecutionException; -import java.util.concurrent.TimeoutException; +import com.google.common.base.Preconditions; +import com.google.common.base.Throwables; + +import io.netty.channel.nio.NioEventLoopGroup; +import io.netty.util.concurrent.GlobalEventExecutor; @Ignore @RunWith(PaxExam.class) @@ -58,7 +66,11 @@ public class IdentityRefNetconfTest { public static final int CLIENT_CONNECTION_TIMEOUT_MILLIS = 15000; // Wait for controller to start - @Inject + + // FIXME move this (pax) test to different module + // pax jars contain guava classes that clash with real guava dependencies in non-pax tests + // + //@Inject @Filter(timeout = 60 * 1000) BindingAwareBroker broker; @@ -99,7 +111,11 @@ public class IdentityRefNetconfTest { mavenBundle("org.slf4j", "slf4j-api").versionAsInProject(), mavenBundle("org.slf4j", "log4j-over-slf4j").versionAsInProject(), mavenBundle("ch.qos.logback", "logback-core").versionAsInProject(), - mavenBundle("ch.qos.logback", "logback-classic").versionAsInProject()); + mavenBundle("ch.qos.logback", "logback-classic").versionAsInProject(), + mavenBundle("org.openexi", "nagasena").versionAsInProject(), + mavenBundle("org.openexi", "nagasena-rta").versionAsInProject()); + + } private Option testingModules() { @@ -113,26 +129,29 @@ public class IdentityRefNetconfTest { public void testIdRef() throws Exception { Preconditions.checkNotNull(broker, "Controller not initialized"); - NioEventLoopGroup nettyThreadgroup = new NioEventLoopGroup(); - NetconfClientDispatcher clientDispatcher = new NetconfClientDispatcher(nettyThreadgroup, nettyThreadgroup, - CLIENT_CONNECTION_TIMEOUT_MILLIS); NetconfMessage edit = xmlFileToNetconfMessage("netconfMessages/editConfig_identities.xml"); NetconfMessage commit = xmlFileToNetconfMessage("netconfMessages/commit.xml"); NetconfMessage getConfig = xmlFileToNetconfMessage("netconfMessages/getConfig.xml"); - try (TestingNetconfClient netconfClient = new TestingNetconfClient("client", tcpAddress, CLIENT_CONNECTION_TIMEOUT_MILLIS, clientDispatcher)) { + NioEventLoopGroup nettyThreadgroup = new NioEventLoopGroup(); + Timer timer = new HashedWheelTimer(); + NetconfClientDispatcherImpl clientDispatcher = new NetconfClientDispatcherImpl(nettyThreadgroup, nettyThreadgroup, timer); + try (TestingNetconfClient netconfClient = new TestingNetconfClient("client", clientDispatcher, getClientConfiguration(tcpAddress))) { sendMessage(edit, netconfClient); sendMessage(commit, netconfClient); sendMessage(getConfig, netconfClient, "id-test", - "prefix:test-identity1", - "prefix:test-identity2", - "prefix:test-identity2", - "prefix:test-identity1"); + "prefix:test-identity1", + "prefix:test-identity2", + "prefix:test-identity2", + "prefix:test-identity1"); clientDispatcher.close(); } catch (Exception e) { fail(Throwables.getStackTraceAsString(e)); + } finally { + nettyThreadgroup.shutdownGracefully().get(); + timer.stop(); } } @@ -152,4 +171,14 @@ public class IdentityRefNetconfTest { ParserConfigurationException { return XmlFileLoader.xmlFileToNetconfMessage(fileName); } + + public NetconfClientConfiguration getClientConfiguration(final InetSocketAddress tcpAddress) { + final NetconfClientConfigurationBuilder b = NetconfClientConfigurationBuilder.create(); + b.withAddress(tcpAddress); + b.withSessionListener(new SimpleNetconfClientSessionListener()); + b.withReconnectStrategy(new NeverReconnectStrategy(GlobalEventExecutor.INSTANCE, + CLIENT_CONNECTION_TIMEOUT_MILLIS)); + b.withConnectionTimeoutMillis(CLIENT_CONNECTION_TIMEOUT_MILLIS); + return b.build(); + } }