X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fnetconf%2Fnetconf-ssh%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fnetconf%2Fssh%2Fosgi%2FNetconfSSHActivator.java;h=d74308cfadbae8e658e58f9b189d93baaea83c2e;hb=d8cb12ba12932c5b418a4fcaf814b42b439c486c;hp=112bf67f69b48d869fede643308dca962c317819;hpb=e27d63bdcfbfb0c1078a9c3e5aabf59ae7e2315f;p=controller.git diff --git a/opendaylight/netconf/netconf-ssh/src/main/java/org/opendaylight/controller/netconf/ssh/osgi/NetconfSSHActivator.java b/opendaylight/netconf/netconf-ssh/src/main/java/org/opendaylight/controller/netconf/ssh/osgi/NetconfSSHActivator.java index 112bf67f69..d74308cfad 100644 --- a/opendaylight/netconf/netconf-ssh/src/main/java/org/opendaylight/controller/netconf/ssh/osgi/NetconfSSHActivator.java +++ b/opendaylight/netconf/netconf-ssh/src/main/java/org/opendaylight/controller/netconf/ssh/osgi/NetconfSSHActivator.java @@ -7,7 +7,13 @@ */ package org.opendaylight.controller.netconf.ssh.osgi; -import com.google.common.base.Optional; +import static com.google.common.base.Preconditions.checkNotNull; + +import java.io.File; +import java.io.FileInputStream; +import java.io.IOException; +import java.net.InetSocketAddress; +import org.apache.commons.io.FilenameUtils; import org.apache.commons.io.IOUtils; import org.opendaylight.controller.netconf.ssh.NetconfSSHServer; import org.opendaylight.controller.netconf.ssh.authentication.AuthProvider; @@ -22,15 +28,10 @@ import org.osgi.util.tracker.ServiceTrackerCustomizer; import org.slf4j.Logger; import org.slf4j.LoggerFactory; -import java.io.File; -import java.io.FileInputStream; -import java.io.IOException; -import java.net.InetSocketAddress; - /** * Activator for netconf SSH bundle which creates SSH bridge between netconf client and netconf server. Activator * starts SSH Server in its own thread. This thread is closed when activator calls stop() method. Server opens socket - * and listen for client connections. Each client connection creation is handled in separate + * and listens for client connections. Each client connection creation is handled in separate * {@link org.opendaylight.controller.netconf.ssh.threads.SocketThread} thread. * This thread creates two additional threads {@link org.opendaylight.controller.netconf.ssh.threads.IOThread} * forwarding data from/to client.IOThread closes servers session and server connection when it gets -1 on input stream. @@ -41,29 +42,28 @@ public class NetconfSSHActivator implements BundleActivator{ private NetconfSSHServer server; private static final Logger logger = LoggerFactory.getLogger(NetconfSSHActivator.class); - private static final String EXCEPTION_MESSAGE = "Netconf ssh bridge is not available."; private IUserManager iUserManager; private BundleContext context = null; - ServiceTrackerCustomizer customizer = new ServiceTrackerCustomizer(){ + private ServiceTrackerCustomizer customizer = new ServiceTrackerCustomizer(){ @Override - public IUserManager addingService(ServiceReference reference) { + public IUserManager addingService(final ServiceReference reference) { logger.trace("Service {} added, let there be SSH bridge.", reference); iUserManager = context.getService(reference); try { onUserManagerFound(iUserManager); - } catch (Exception e) { + } catch (final Exception e) { logger.trace("Can't start SSH server due to {}",e); } return iUserManager; } @Override - public void modifiedService(ServiceReference reference, IUserManager service) { + public void modifiedService(final ServiceReference reference, final IUserManager service) { logger.trace("Replacing modified service {} in netconf SSH.", reference); server.addUserManagerService(service); } @Override - public void removedService(ServiceReference reference, IUserManager service) { + public void removedService(final ServiceReference reference, final IUserManager service) { logger.trace("Removing service {} from netconf SSH. " + "SSH won't authenticate users until IUserManager service will be started.", reference); removeUserManagerService(); @@ -72,58 +72,61 @@ public class NetconfSSHActivator implements BundleActivator{ @Override - public void start(BundleContext context) throws Exception { + public void start(final BundleContext context) { this.context = context; listenForManagerService(); } @Override - public void stop(BundleContext context) throws Exception { + public void stop(BundleContext context) throws IOException { if (server != null){ server.stop(); logger.trace("Netconf SSH bridge is down ..."); } } - private void startSSHServer() throws Exception { + private void startSSHServer() throws IOException { + checkNotNull(this.iUserManager, "No user manager service available."); logger.trace("Starting netconf SSH bridge."); - Optional sshSocketAddressOptional = NetconfConfigUtil.extractSSHNetconfAddress(context, EXCEPTION_MESSAGE); - InetSocketAddress tcpSocketAddress = NetconfConfigUtil.extractTCPNetconfAddress(context, - EXCEPTION_MESSAGE, true); + final InetSocketAddress sshSocketAddress = NetconfConfigUtil.extractSSHNetconfAddress(context, + NetconfConfigUtil.DEFAULT_NETCONF_SSH_ADDRESS); + final InetSocketAddress tcpSocketAddress = NetconfConfigUtil.extractTCPNetconfClientAddress(context, + NetconfConfigUtil.DEFAULT_NETCONF_TCP_ADDRESS); - if (sshSocketAddressOptional.isPresent()){ - String path = NetconfConfigUtil.getPrivateKeyPath(context); - path = path.replace("\\", "/"); // FIXME: shouldn't this convert lines to system dependent path separator? - if (path.equals("")){ - throw new Exception("Missing netconf.ssh.pk.path key in configuration file."); - } + String path = FilenameUtils.separatorsToSystem(NetconfConfigUtil.getPrivateKeyPath(context)); - File privateKeyFile = new File(path); - String privateKeyPEMString; - if (privateKeyFile.exists() == false) { - // generate & save to file + if (path.isEmpty()) { + throw new IllegalStateException("Missing netconf.ssh.pk.path key in configuration file."); + } + + final File privateKeyFile = new File(path); + final String privateKeyPEMString; + if (privateKeyFile.exists() == false) { + // generate & save to file + try { privateKeyPEMString = PEMGenerator.generateTo(privateKeyFile); - } else { - // read from file - try (FileInputStream fis = new FileInputStream(path)) { - privateKeyPEMString = IOUtils.toString(fis); - } catch (IOException e) { - logger.error("Error reading RSA key from file '{}'", path); - throw new IllegalStateException("Error reading RSA key from file " + path); - } + } catch (Exception e) { + logger.error("Exception occurred while generating PEM string {}", e); + throw new IllegalStateException("Error generating RSA key from file " + path); } - AuthProvider authProvider = new AuthProvider(iUserManager, privateKeyPEMString); - this.server = NetconfSSHServer.start(sshSocketAddressOptional.get().getPort(),tcpSocketAddress,authProvider); - - Thread serverThread = new Thread(server,"netconf SSH server thread"); - serverThread.setDaemon(true); - serverThread.start(); - logger.trace("Netconf SSH bridge up and running."); } else { - logger.trace("No valid connection configuration for SSH bridge found."); - throw new Exception("No valid connection configuration for SSH bridge found."); + // read from file + try (FileInputStream fis = new FileInputStream(path)) { + privateKeyPEMString = IOUtils.toString(fis); + } catch (final IOException e) { + logger.error("Error reading RSA key from file '{}'", path); + throw new IOException("Error reading RSA key from file " + path, e); + } } + final AuthProvider authProvider = new AuthProvider(iUserManager, privateKeyPEMString); + this.server = NetconfSSHServer.start(sshSocketAddress.getPort(), tcpSocketAddress, authProvider); + + final Thread serverThread = new Thread(server, "netconf SSH server thread"); + serverThread.setDaemon(true); + serverThread.start(); + logger.trace("Netconf SSH bridge up and running."); } - private void onUserManagerFound(IUserManager userManager) throws Exception{ + + private void onUserManagerFound(final IUserManager userManager) throws Exception{ if (server!=null && server.isUp()){ server.addUserManagerService(userManager); } else { @@ -134,7 +137,7 @@ public class NetconfSSHActivator implements BundleActivator{ this.server.removeUserManagerService(); } private void listenForManagerService(){ - ServiceTracker listenerTracker = new ServiceTracker<>(context, IUserManager.class,customizer); + final ServiceTracker listenerTracker = new ServiceTracker<>(context, IUserManager.class,customizer); listenerTracker.open(); } }