X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fnetconf%2Fnetconf-util%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fnetconf%2Futil%2Fosgi%2FNetconfConfigUtil.java;fp=opendaylight%2Fnetconf%2Fnetconf-util%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fnetconf%2Futil%2Fosgi%2FNetconfConfigUtil.java;h=76068399c17f470b249c0ba35027f89d723b5d81;hb=bd2fdc53c6e7d21febc673b1d7062ca82849eb74;hp=54041e6602c52adc996b3d06c29f6461b5e7e4b1;hpb=9d2212483a4fca225d5ad58e7f924f58b638ddb6;p=controller.git diff --git a/opendaylight/netconf/netconf-util/src/main/java/org/opendaylight/controller/netconf/util/osgi/NetconfConfigUtil.java b/opendaylight/netconf/netconf-util/src/main/java/org/opendaylight/controller/netconf/util/osgi/NetconfConfigUtil.java index 54041e6602..76068399c1 100644 --- a/opendaylight/netconf/netconf-util/src/main/java/org/opendaylight/controller/netconf/util/osgi/NetconfConfigUtil.java +++ b/opendaylight/netconf/netconf-util/src/main/java/org/opendaylight/controller/netconf/util/osgi/NetconfConfigUtil.java @@ -8,21 +8,19 @@ package org.opendaylight.controller.netconf.util.osgi; -import static com.google.common.base.Preconditions.checkNotNull; -import static com.google.common.base.Preconditions.checkState; +import com.google.common.base.Optional; +import org.opendaylight.protocol.util.SSLUtil; +import org.osgi.framework.BundleContext; +import javax.net.ssl.KeyManagerFactory; +import javax.net.ssl.SSLContext; import java.io.File; import java.io.FileInputStream; import java.io.InputStream; import java.net.InetSocketAddress; -import javax.net.ssl.KeyManagerFactory; -import javax.net.ssl.SSLContext; - -import org.opendaylight.controller.config.stat.ConfigProvider; -import org.opendaylight.protocol.util.SSLUtil; - -import com.google.common.base.Optional; +import static com.google.common.base.Preconditions.checkNotNull; +import static com.google.common.base.Preconditions.checkState; public class NetconfConfigUtil { private static final String PREFIX_PROP = "netconf."; @@ -37,19 +35,19 @@ public class NetconfConfigUtil { private static final String NETCONF_TLS_KEYSTORE_PROP = PREFIX_PROP + InfixProp.tls + ".keystore"; private static final String NETCONF_TLS_KEYSTORE_PASSWORD_PROP = NETCONF_TLS_KEYSTORE_PROP + ".password"; - public static Optional extractTCPNetconfAddress(ConfigProvider configProvider) { - return extractSomeNetconfAddress(configProvider, InfixProp.tcp); + public static Optional extractTCPNetconfAddress(BundleContext context) { + return extractSomeNetconfAddress(context, InfixProp.tcp); } - public static Optional extractTLSConfiguration(ConfigProvider configProvider) { - Optional address = extractSomeNetconfAddress(configProvider, InfixProp.tls); + public static Optional extractTLSConfiguration(BundleContext context) { + Optional address = extractSomeNetconfAddress(context, InfixProp.tls); if (address.isPresent()) { - String keystoreFileName = configProvider.getProperty(NETCONF_TLS_KEYSTORE_PROP); + String keystoreFileName = context.getProperty(NETCONF_TLS_KEYSTORE_PROP); File keystoreFile = new File(keystoreFileName); checkState(keystoreFile.exists() && keystoreFile.isFile() && keystoreFile.canRead(), "Keystore file %s does not exist or is not readable file", keystoreFileName); keystoreFile = keystoreFile.getAbsoluteFile(); - String keystorePassword = configProvider.getProperty(NETCONF_TLS_KEYSTORE_PASSWORD_PROP); + String keystorePassword = context.getProperty(NETCONF_TLS_KEYSTORE_PASSWORD_PROP); checkNotNull(keystoreFileName, "Property %s must be defined for tls netconf server", NETCONF_TLS_KEYSTORE_PROP); keystorePassword = keystorePassword != null ? keystorePassword : ""; @@ -98,7 +96,7 @@ public class NetconfConfigUtil { } /** - * @param configProvider + * @param context * from which properties are being read. * @param infixProp * either tcp or tls @@ -107,14 +105,14 @@ public class NetconfConfigUtil { * @throws IllegalStateException * if address or port are invalid */ - private static Optional extractSomeNetconfAddress(ConfigProvider configProvider, + private static Optional extractSomeNetconfAddress(BundleContext context, InfixProp infixProp) { - String address = configProvider.getProperty(PREFIX_PROP + infixProp + ADDRESS_SUFFIX_PROP); + String address = context.getProperty(PREFIX_PROP + infixProp + ADDRESS_SUFFIX_PROP); if (address == null) { return Optional.absent(); } String portKey = PREFIX_PROP + infixProp + PORT_SUFFIX_PROP; - String portString = configProvider.getProperty(portKey); + String portString = context.getProperty(portKey); checkNotNull(portString, "Netconf port must be specified in properties file with " + portKey); try { int port = Integer.valueOf(portString);