X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fprotocol_plugins%2Fopenflow%2Fsrc%2Ftest%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fprotocol_plugin%2Fopenflow%2Finternal%2FFlowProgrammerServiceTest.java;h=96f0d80022a5be59ea716d46b2cf8c5e26d20f1b;hb=3a117f105f127bb255dd44f3cdde28e45d4d389a;hp=a751948de7d5a73d22696f66a0bcefb15ca82b53;hpb=62e7364552cc671134c06821e6f9dbe3579ea0dc;p=controller.git diff --git a/opendaylight/protocol_plugins/openflow/src/test/java/org/opendaylight/controller/protocol_plugin/openflow/internal/FlowProgrammerServiceTest.java b/opendaylight/protocol_plugins/openflow/src/test/java/org/opendaylight/controller/protocol_plugin/openflow/internal/FlowProgrammerServiceTest.java index a751948de7..96f0d80022 100644 --- a/opendaylight/protocol_plugins/openflow/src/test/java/org/opendaylight/controller/protocol_plugin/openflow/internal/FlowProgrammerServiceTest.java +++ b/opendaylight/protocol_plugins/openflow/src/test/java/org/opendaylight/controller/protocol_plugin/openflow/internal/FlowProgrammerServiceTest.java @@ -18,9 +18,6 @@ import java.util.List; import org.junit.Assert; import org.junit.Test; import org.opendaylight.controller.protocol_plugin.openflow.vendorextension.v6extension.V6Match; -import org.openflow.protocol.OFMatch; -import org.openflow.protocol.action.OFAction; - import org.opendaylight.controller.sal.action.Action; import org.opendaylight.controller.sal.action.Flood; import org.opendaylight.controller.sal.action.FloodAll; @@ -46,6 +43,9 @@ import org.opendaylight.controller.sal.utils.EtherTypes; import org.opendaylight.controller.sal.utils.IPProtocols; import org.opendaylight.controller.sal.utils.NodeConnectorCreator; import org.opendaylight.controller.sal.utils.NodeCreator; +import org.openflow.protocol.OFMatch; +import org.openflow.protocol.action.OFAction; +import org.openflow.util.U32; public class FlowProgrammerServiceTest { @@ -298,6 +298,16 @@ public class FlowProgrammerServiceTest { */ FlowConverter salToOF = new FlowConverter(aFlow); V6Match v6Match = (V6Match) salToOF.getOFMatch(); + // need this hardcoding here to make the test pass. + // this should not be a problem in actual code. + // in the test the sal match is converted to a V6 match. + // we lose the wildcard info as the V6 match is used for nicira extensions + // and nicira deals with wildcards in a different way. + // converting the V6 match back to sal match is not going to preserve the wildcard info. + // and we need the wildcard info for reading the vlan pcp now. + // when creating a V6Match using the readFrom method + // we do convert the nicira extensions format correctly to populate the wildcard info. + v6Match.setWildcards(U32.t(Long.valueOf(~OFMatch.OFPFW_DL_VLAN_PCP))); List ofActions = salToOF.getOFActions(); /*