X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fsal%2Fapi%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fsal%2Fpacket%2Faddress%2FEthernetAddress.java;h=bd1949f380545a85c3bbf27bb874ae0c761f62da;hb=fba140bf09ffbf8694aa41f544caaa331c2ec29a;hp=57dea9c3d9b2f8a103322a0766d436921d7089aa;hpb=42210c03b0a4c54706320ba9f55794c0abd4d201;p=controller.git diff --git a/opendaylight/sal/api/src/main/java/org/opendaylight/controller/sal/packet/address/EthernetAddress.java b/opendaylight/sal/api/src/main/java/org/opendaylight/controller/sal/packet/address/EthernetAddress.java index 57dea9c3d9..bd1949f380 100644 --- a/opendaylight/sal/api/src/main/java/org/opendaylight/controller/sal/packet/address/EthernetAddress.java +++ b/opendaylight/sal/api/src/main/java/org/opendaylight/controller/sal/packet/address/EthernetAddress.java @@ -9,14 +9,14 @@ package org.opendaylight.controller.sal.packet.address; +import java.util.Arrays; + import javax.xml.bind.annotation.XmlAccessType; import javax.xml.bind.annotation.XmlAccessorType; import javax.xml.bind.annotation.XmlElement; import javax.xml.bind.annotation.XmlRootElement; +import javax.xml.bind.annotation.XmlTransient; -import org.apache.commons.lang3.builder.ReflectionToStringBuilder; -import org.apache.commons.lang3.builder.EqualsBuilder; -import org.apache.commons.lang3.builder.HashCodeBuilder; import org.opendaylight.controller.sal.core.ConstructionException; import org.opendaylight.controller.sal.utils.HexEncode; @@ -24,6 +24,7 @@ import org.opendaylight.controller.sal.utils.HexEncode; @XmlAccessorType(XmlAccessType.NONE) public class EthernetAddress extends DataLinkAddress { private static final long serialVersionUID = 1L; + @XmlTransient private byte[] macAddress; public static final EthernetAddress BROADCASTMAC = createWellKnownAddress(new byte[] { @@ -44,8 +45,8 @@ public class EthernetAddress extends DataLinkAddress { } /* Private constructor to satisfy JAXB */ + @SuppressWarnings("unused") private EthernetAddress() { - } /** @@ -93,22 +94,34 @@ public class EthernetAddress extends DataLinkAddress { @Override public int hashCode() { - return HashCodeBuilder.reflectionHashCode(this); + final int prime = 31; + int result = super.hashCode(); + result = prime * result + Arrays.hashCode(macAddress); + return result; } @Override public boolean equals(Object obj) { - return EqualsBuilder.reflectionEquals(this, obj); + if (this == obj) + return true; + if (!super.equals(obj)) + return false; + if (getClass() != obj.getClass()) + return false; + EthernetAddress other = (EthernetAddress) obj; + if (!Arrays.equals(macAddress, other.macAddress)) + return false; + return true; } @Override public String toString() { - return "EthernetAddress[" + ReflectionToStringBuilder.toString(this) + return "EthernetAddress [macAddress=" + HexEncode.bytesToHexStringFormat(macAddress) + "]"; } @XmlElement(name = "macAddress") public String getMacAddress() { - return HexEncode.bytesToHexString(macAddress); + return HexEncode.bytesToHexStringFormat(macAddress); } }