X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fsal%2Fapi%2Fsrc%2Ftest%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fsal%2Fpacket%2FICMPTest.java;h=287b73ae3c22fda416fe21a8f003bc9d6e451312;hb=34bc6ec632529a0dfe419aa7404bb42a456fbc96;hp=445f7211c0f8c3fc50a7f5bb4856ed0e05993565;hpb=42210c03b0a4c54706320ba9f55794c0abd4d201;p=controller.git

diff --git a/opendaylight/sal/api/src/test/java/org/opendaylight/controller/sal/packet/ICMPTest.java b/opendaylight/sal/api/src/test/java/org/opendaylight/controller/sal/packet/ICMPTest.java
index 445f7211c0..287b73ae3c 100644
--- a/opendaylight/sal/api/src/test/java/org/opendaylight/controller/sal/packet/ICMPTest.java
+++ b/opendaylight/sal/api/src/test/java/org/opendaylight/controller/sal/packet/ICMPTest.java
@@ -1,6 +1,6 @@
 
 /*
- * Copyright (c) 2013 Cisco Systems, Inc. and others.  All rights reserved.
+ * Copyright (c) 2013-2014 Cisco Systems, Inc. and others.  All rights reserved.
  *
  * This program and the accompanying materials are made available under the
  * terms of the Eclipse Public License v1.0 which accompanies this distribution,
@@ -9,21 +9,21 @@
 
 package org.opendaylight.controller.sal.packet;
 
+import java.util.Arrays;
+
 import junit.framework.Assert;
 
 import org.junit.Test;
-import org.opendaylight.controller.sal.packet.ICMP;
 
 public class ICMPTest {
 
     @Test
     public void testSetTypeCode() {
         ICMP icmp = new ICMP();
-        short icmpTypeCode = 2;
-        icmp.setTypeCode(icmpTypeCode);
-        byte[] typeCode = icmp.hdrFieldsMap.get("TypeCode");
-        Assert.assertTrue(typeCode[0] == 0);
-        Assert.assertTrue(typeCode[1] == 2);
+        byte icmpType = 2;
+        icmp.setType(icmpType);
+        byte[] typeCode = icmp.hdrFieldsMap.get("Type");
+        Assert.assertTrue(typeCode[0] == 2);
 
     }
 
@@ -32,7 +32,7 @@ public class ICMPTest {
         ICMP icmp = new ICMP();
         short icmpChecksum = 200;
         icmp.setChecksum(icmpChecksum);
-        byte[] checksum = icmp.hdrFieldsMap.get("HeaderChecksum");
+        byte[] checksum = icmp.hdrFieldsMap.get("Checksum");
         Assert.assertTrue(checksum[0] == 0);
         Assert.assertTrue(checksum[1] == -56);
 
@@ -59,4 +59,75 @@ public class ICMPTest {
         Assert.assertTrue(sequenceNumber[1] == -120);
 
     }
+
+    @Test
+    public void testSerialization() throws PacketException {
+        byte icmpRawPayload[] = { (byte) 0x38, (byte) 0x26, (byte) 0x9e,
+                (byte) 0x51, (byte) 0x00, (byte) 0x00, (byte) 0x00,
+                (byte) 0x00, (byte) 0x2e, (byte) 0x6a, (byte) 0x08,
+                (byte) 0x00, (byte) 0x00, (byte) 0x00, (byte) 0x00,
+                (byte) 0x00, (byte) 0x10, (byte) 0x11, (byte) 0x12,
+                (byte) 0x13, (byte) 0x14, (byte) 0x15, (byte) 0x16,
+                (byte) 0x17, (byte) 0x18, (byte) 0x19, (byte) 0x1a,
+                (byte) 0x1b, (byte) 0x1c, (byte) 0x1d, (byte) 0x1e,
+                (byte) 0x1f, (byte) 0x20, (byte) 0x21, (byte) 0x22,
+                (byte) 0x23, (byte) 0x24, (byte) 0x25, (byte) 0x26,
+                (byte) 0x27, (byte) 0x28, (byte) 0x29, (byte) 0x2a,
+                (byte) 0x2b, (byte) 0x2c, (byte) 0x2d, (byte) 0x2e,
+                (byte) 0x2f, (byte) 0x30, (byte) 0x31, (byte) 0x32,
+                (byte) 0x33, (byte) 0x34, (byte) 0x35, (byte) 0x36, (byte) 0x37 };
+        serializeTest(icmpRawPayload, (short)0xe553);
+
+        serializeTest(null, (short)0xb108);
+        serializeTest(new byte[0], (short)0xb108);
+
+        byte[] odd = {
+            (byte)0xba, (byte)0xd4, (byte)0xc7, (byte)0x53,
+            (byte)0xf8, (byte)0x59, (byte)0x68, (byte)0x77,
+            (byte)0xfd, (byte)0x27, (byte)0xe0, (byte)0x5b,
+            (byte)0xd0, (byte)0x2e, (byte)0x28, (byte)0x41,
+            (byte)0xa3, (byte)0x48, (byte)0x5d, (byte)0x2e,
+            (byte)0x7d, (byte)0x5b, (byte)0xd3, (byte)0x60,
+            (byte)0xb3, (byte)0x88, (byte)0x8d, (byte)0x0f,
+            (byte)0x1d, (byte)0x87, (byte)0x51, (byte)0x0f,
+            (byte)0x6a, (byte)0xff, (byte)0xf7, (byte)0xd4,
+            (byte)0x40, (byte)0x35, (byte)0x4e, (byte)0x01,
+            (byte)0x36,
+        };
+        serializeTest(odd, (short)0xd0ad);
+
+        // Large payload that causes 16-bit checksum overflow more than
+        // 255 times.
+        byte[] largeEven = new byte[1024];
+        Arrays.fill(largeEven, (byte)0xff);
+        serializeTest(largeEven, (short)0xb108);
+
+        byte[] largeOdd = new byte[1021];
+        Arrays.fill(largeOdd, (byte)0xff);
+        serializeTest(largeOdd, (short)0xb207);
+    }
+
+    private void serializeTest(byte[] payload, short checksum)
+        throws PacketException {
+        ICMP icmp = new ICMP();
+        icmp.setType((byte)8).setCode((byte)0).
+            setIdentifier((short)0x46f5).setSequenceNumber((short)2);
+        int payloadSize = 0;
+        if (payload != null) {
+            icmp.setRawPayload(payload);
+            payloadSize = payload.length;
+        }
+
+        // Serialize
+        byte[] data = icmp.serialize();
+        Assert.assertEquals(payloadSize + 8, data.length);
+
+        // Deserialize
+        ICMP icmpDes = new ICMP();
+        icmpDes.deserialize(data, 0, data.length);
+
+        Assert.assertFalse(icmpDes.isCorrupted());
+        Assert.assertEquals(checksum, icmpDes.getChecksum());
+        Assert.assertEquals(icmp, icmpDes);
+    }
 }