X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fswitchmanager%2Fimplementation%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fswitchmanager%2Finternal%2FSwitchManager.java;h=60330c1ad46b4709c56267578b411ccba2d4aefa;hb=5d4843d94709e192311888113dad767d4d947582;hp=835f40e6c6663e1f2a04f9c99922def15defabec;hpb=65662c5141097ed382ad2037ad4a78a9965aad22;p=controller.git diff --git a/opendaylight/switchmanager/implementation/src/main/java/org/opendaylight/controller/switchmanager/internal/SwitchManager.java b/opendaylight/switchmanager/implementation/src/main/java/org/opendaylight/controller/switchmanager/internal/SwitchManager.java index 835f40e6c6..60330c1ad4 100644 --- a/opendaylight/switchmanager/implementation/src/main/java/org/opendaylight/controller/switchmanager/internal/SwitchManager.java +++ b/opendaylight/switchmanager/implementation/src/main/java/org/opendaylight/controller/switchmanager/internal/SwitchManager.java @@ -712,7 +712,8 @@ public class SwitchManager implements ISwitchManager, IConfigurationContainerAwa switchConfig = new SwitchConfig(nodeId, updateProperties); } else { // check if description is configured or was published by any other node - for (Node n : nodeProps.keySet()) { + for (Map.Entry> entry : nodeProps.entrySet()) { + Node n = entry.getKey(); Description desc = (Description) getNodeProp(n, Description.propertyName); NodeDescription nDesc = (this.statisticsManager == null) ? null : this.statisticsManager .getNodeDescription(n); @@ -762,7 +763,8 @@ public class SwitchManager implements ISwitchManager, IConfigurationContainerAwa return new Status(StatusCode.SUCCESS); } Map propMap = new HashMap(propMapCurr); - for (String prop : prevNodeProperties.keySet()) { + for (Map.Entry entry : prevNodeProperties.entrySet()) { + String prop = entry.getKey(); if (!updateProperties.containsKey(prop)) { if (prop.equals(Description.propertyName)) { if (!advertisedDesc.isEmpty()) { @@ -770,6 +772,10 @@ public class SwitchManager implements ISwitchManager, IConfigurationContainerAwa propMap.put(Description.propertyName, desc); } continue; + } else if (prop.equals(ForwardingMode.name)) { + Property defaultMode = new ForwardingMode(ForwardingMode.REACTIVE_FORWARDING); + propMap.put(ForwardingMode.name, defaultMode); + continue; } propMap.remove(prop); } @@ -795,7 +801,8 @@ public class SwitchManager implements ISwitchManager, IConfigurationContainerAwa Map propMapCurr = nodeProps.get(node); if ((propMapCurr != null) && (nodeProperties != null) && (!nodeProperties.isEmpty())) { Map propMap = new HashMap(propMapCurr); - for (String prop : nodeProperties.keySet()) { + for (Map.Entry entry : nodeProperties.entrySet()) { + String prop = entry.getKey(); if (prop.equals(Description.propertyName)) { Map> nodeProp = this.inventoryService.getNodeProps(); if (nodeProp.get(node) != null) { @@ -908,8 +915,8 @@ public class SwitchManager implements ISwitchManager, IConfigurationContainerAwa } } - // copy node properties from config boolean proactiveForwarding = false; + // copy node properties from config if (nodeConfigList != null) { String nodeId = node.toString(); SwitchConfig conf = nodeConfigList.get(nodeId); @@ -923,6 +930,10 @@ public class SwitchManager implements ISwitchManager, IConfigurationContainerAwa } } + if (!propMap.containsKey(ForwardingMode.name)) { + Property defaultMode = new ForwardingMode(ForwardingMode.REACTIVE_FORWARDING); + propMap.put(ForwardingMode.name, defaultMode); + } boolean result = false; if (propMapCurr == null) { if (nodeProps.putIfAbsent(node, propMap) == null) { @@ -955,6 +966,17 @@ public class SwitchManager implements ISwitchManager, IConfigurationContainerAwa return; } nodeProps.remove(node); + nodeConnectorNames.remove(node); + Set removeNodeConnectorSet = new HashSet(); + for (Map.Entry> entry : nodeConnectorProps.entrySet()) { + NodeConnector nodeConnector = entry.getKey(); + if (nodeConnector.getNode().equals(node)) { + removeNodeConnectorSet.add(nodeConnector); + } + } + for (NodeConnector nc : removeNodeConnectorSet) { + nodeConnectorProps.remove(nc); + } // check if span ports need to be cleaned up removeSpanPorts(node); @@ -1028,6 +1050,7 @@ public class SwitchManager implements ISwitchManager, IConfigurationContainerAwa public void updateNodeConnector(NodeConnector nodeConnector, UpdateType type, Set props) { Map propMap = new HashMap(); + boolean update = true; log.debug("updateNodeConnector: {} type {} props {} for container {}", new Object[] { nodeConnector, type, props, containerName }); @@ -1038,7 +1061,6 @@ public class SwitchManager implements ISwitchManager, IConfigurationContainerAwa switch (type) { case ADDED: - case CHANGED: if (props != null) { for (Property prop : props) { addNodeConnectorProp(nodeConnector, prop); @@ -1050,17 +1072,33 @@ public class SwitchManager implements ISwitchManager, IConfigurationContainerAwa addSpanPort(nodeConnector); break; + case CHANGED: + if (!nodeConnectorProps.containsKey(nodeConnector) || (props == null)) { + update = false; + } else { + for (Property prop : props) { + addNodeConnectorProp(nodeConnector, prop); + propMap.put(prop.getName(), prop); + } + } + break; case REMOVED: + if (!nodeConnectorProps.containsKey(nodeConnector)) { + update = false; + } removeNodeConnectorAllProps(nodeConnector); // clean up span config removeSpanPort(nodeConnector); break; default: + update = false; break; } - notifyNodeConnector(nodeConnector, type, propMap); + if (update) { + notifyNodeConnector(nodeConnector, type, propMap); + } } @Override @@ -1161,7 +1199,8 @@ public class SwitchManager implements ISwitchManager, IConfigurationContainerAwa } Set nodeConnectorSet = new HashSet(); - for (NodeConnector nodeConnector : nodeConnectorProps.keySet()) { + for (Map.Entry> entry : nodeConnectorProps.entrySet()) { + NodeConnector nodeConnector = entry.getKey(); if (!nodeConnector.getNode().equals(node)) { continue; } @@ -1180,7 +1219,8 @@ public class SwitchManager implements ISwitchManager, IConfigurationContainerAwa } Set nodeConnectorSet = new HashSet(); - for (NodeConnector nodeConnector : nodeConnectorProps.keySet()) { + for (Map.Entry> entry : nodeConnectorProps.entrySet()) { + NodeConnector nodeConnector = entry.getKey(); if (!nodeConnector.getNode().equals(node)) { continue; } @@ -1197,7 +1237,8 @@ public class SwitchManager implements ISwitchManager, IConfigurationContainerAwa } Set nodeConnectorSet = new HashSet(); - for (NodeConnector nodeConnector : nodeConnectorProps.keySet()) { + for (Map.Entry> entry : nodeConnectorProps.entrySet()) { + NodeConnector nodeConnector = entry.getKey(); if (!nodeConnector.getNode().equals(node) || isSpecial(nodeConnector)) { continue; @@ -1336,9 +1377,10 @@ public class SwitchManager implements ISwitchManager, IConfigurationContainerAwa Map mapCurr = nodeConnectorNames.get(node); Map map = new HashMap(); if (mapCurr != null) { - for (String s : mapCurr.keySet()) { + for (Map.Entry entry : mapCurr.entrySet()) { + String s = entry.getKey(); try { - map.put(s, new NodeConnector(mapCurr.get(s))); + map.put(s, new NodeConnector(entry.getValue())); } catch (ConstructionException e) { e.printStackTrace(); } @@ -1397,9 +1439,10 @@ public class SwitchManager implements ISwitchManager, IConfigurationContainerAwa Map mapCurr = nodeConnectorNames.get(node); if (mapCurr != null) { Map map = new HashMap(); - for (String s : mapCurr.keySet()) { + for (Map.Entry entry : mapCurr.entrySet()) { + String s = entry.getKey(); try { - map.put(s, new NodeConnector(mapCurr.get(s))); + map.put(s, new NodeConnector(entry.getValue())); } catch (ConstructionException e) { e.printStackTrace(); } @@ -1433,9 +1476,10 @@ public class SwitchManager implements ISwitchManager, IConfigurationContainerAwa Map mapCurr = nodeConnectorNames.get(node); if (mapCurr != null) { Map map = new HashMap(); - for (String s : mapCurr.keySet()) { + for (Map.Entry entry : mapCurr.entrySet()) { + String s = entry.getKey(); try { - map.put(s, new NodeConnector(mapCurr.get(s))); + map.put(s, new NodeConnector(entry.getValue())); } catch (ConstructionException e) { e.printStackTrace(); } @@ -1682,7 +1726,8 @@ public class SwitchManager implements ISwitchManager, IConfigurationContainerAwa service.notifyNode(node, type, propMap); } - for (NodeConnector nodeConnector : nodeConnectorProps.keySet()) { + for (Map.Entry> entry : nodeConnectorProps.entrySet()) { + NodeConnector nodeConnector = entry.getKey(); propMap = nodeConnectorProps.get(nodeConnector); service.notifyNodeConnector(nodeConnector, type, propMap); } @@ -1721,8 +1766,6 @@ public class SwitchManager implements ISwitchManager, IConfigurationContainerAwa public String getHelp() { StringBuffer help = new StringBuffer(); help.append("---Switch Manager---\n"); - help.append("\t pns - Print connected nodes\n"); - help.append("\t pncs - Print node connectors for a given node\n"); help.append("\t pencs - Print enabled node connectors for a given node\n"); help.append("\t pdm - Print switch ports in device map\n"); help.append("\t snt - Set node tier number\n"); @@ -1731,37 +1774,6 @@ public class SwitchManager implements ISwitchManager, IConfigurationContainerAwa return help.toString(); } - public void _pns(CommandInterpreter ci) { - ci.println(" Node Type MAC Name Tier"); - if (nodeProps == null) { - return; - } - Set nodeSet = nodeProps.keySet(); - if (nodeSet == null) { - return; - } - List nodeArray = new ArrayList(); - for (Node node : nodeSet) { - nodeArray.add(node.toString()); - } - Collections.sort(nodeArray); - for (String str: nodeArray) { - Node node = Node.fromString(str); - Description desc = ((Description) getNodeProp(node, - Description.propertyName)); - Tier tier = ((Tier) getNodeProp(node, Tier.TierPropName)); - String nodeName = (desc == null) ? "" : desc.getValue(); - MacAddress mac = (MacAddress) getNodeProp(node, - MacAddress.name); - String macAddr = (mac == null) ? "" : HexEncode - .bytesToHexStringFormat(mac.getMacAddress()); - int tierNum = (tier == null) ? 0 : tier.getValue(); - ci.println(node + " " + node.getType() + " " + macAddr - + " " + nodeName + " " + tierNum); - } - ci.println("Total number of Nodes: " + nodeSet.size()); - } - public void _pencs(CommandInterpreter ci) { String st = ci.nextArgument(); if (st == null) { @@ -1788,43 +1800,6 @@ public class SwitchManager implements ISwitchManager, IConfigurationContainerAwa ci.println("Total number of NodeConnectors: " + nodeConnectorSet.size()); } - public void _pncs(CommandInterpreter ci) { - String st = ci.nextArgument(); - if (st == null) { - ci.println("Please enter node id"); - return; - } - - Node node = Node.fromString(st); - if (node == null) { - ci.println("Please enter node id"); - return; - } - - ci.println(" NodeConnector BandWidth(Gbps) Admin State"); - Set nodeConnectorSet = getNodeConnectors(node); - if (nodeConnectorSet == null) { - return; - } - for (NodeConnector nodeConnector : nodeConnectorSet) { - if (nodeConnector == null) { - continue; - } - Map propMap = getNodeConnectorProps(nodeConnector); - Bandwidth bw = (Bandwidth) propMap.get(Bandwidth.BandwidthPropName); - Config config = (Config) propMap.get(Config.ConfigPropName); - State state = (State) propMap.get(State.StatePropName); - String out = nodeConnector + " "; - out += (bw != null) ? bw.getValue() / Math.pow(10, 9) : " "; - out += " "; - out += (config != null) ? config.getValue() : " "; - out += " "; - out += (state != null) ? state.getValue() : " "; - ci.println(out); - } - ci.println("Total number of NodeConnectors: " + nodeConnectorSet.size()); - } - public void _pdm(CommandInterpreter ci) { String st = ci.nextArgument(); if (st == null) {