X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=openflow-protocol-impl%2Fsrc%2Ftest%2Fjava%2Forg%2Fopendaylight%2Fopenflowjava%2Fprotocol%2Fimpl%2Fcore%2FOFFrameDecoderTest.java;h=41d692c820820f0c49c22c6ece46d558174c8d8b;hb=07de1ed897da9d7dc70c6d550f38c59339ed751e;hp=723ce1c92efccaca14e9f55c71bce13a5f7eae82;hpb=0b5e88c7d107c9d925fa2fb342efc5e0ce0f250e;p=openflowjava.git

diff --git a/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/core/OFFrameDecoderTest.java b/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/core/OFFrameDecoderTest.java
index 723ce1c9..41d692c8 100644
--- a/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/core/OFFrameDecoderTest.java
+++ b/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/core/OFFrameDecoderTest.java
@@ -1,102 +1,167 @@
-/* Copyright (C)2013 Pantheon Technologies, s.r.o. All rights reserved. */
-package org.opendaylight.openflowjava.protocol.impl.core;
-
-import io.netty.buffer.ByteBuf;
-import io.netty.channel.ChannelHandlerContext;
-
-import java.util.ArrayList;
-import java.util.List;
-
-import org.junit.Assert;
-import org.junit.Before;
-import org.junit.Test;
-import org.junit.runner.RunWith;
-import org.mockito.Mock;
-import org.mockito.runners.MockitoJUnitRunner;
-import org.opendaylight.openflowjava.protocol.impl.util.ByteBufUtils;
-
-/**
- * Testing class of {@link OFFrameDecoder}
- * 
- * @author michal.polkorab
- */
-@RunWith(MockitoJUnitRunner.class)
-public class OFFrameDecoderTest {
-
-    @Mock
-    ChannelHandlerContext channelHandlerContext;
-
-    private OFFrameDecoder decoder;
-    private List<Object> list = new ArrayList<>();
-
-    /**
-     * Sets up tests
-     */
-    @Before
-    public void setUp() {
-        list.clear();
-        decoder = new OFFrameDecoder();
-    }
-
-    /**
-     * Test of decoding
-     * {@link OFFrameDecoder#decode(io.netty.channel.ChannelHandlerContext, io.netty.buffer.ByteBuf, java.util.List)}
-     * 
-     * @throws Exception
-     */
-    @Test
-    public void testDecode8BMessage() throws Exception {
-        decoder.decode(channelHandlerContext,
-                ByteBufUtils.hexStringToByteBuf("04 00 00 08 00 00 00 01"),
-                list);
-
-        Assert.assertEquals(8, ((ByteBuf) list.get(0)).readableBytes());
-    }
-
-    /**
-     * Test of decoding
-     * {@link OFFrameDecoder#decode(io.netty.channel.ChannelHandlerContext, io.netty.buffer.ByteBuf, java.util.List)}
-     * 
-     * @throws Exception
-     */
-    @Test
-    public void testDecode16BMessage() throws Exception {
-        decoder.decode(channelHandlerContext,
-                ByteBufUtils.hexStringToByteBuf("04 00 00 10 00 00 00 00 00 00 00 00 00 00 00 42"),
-                list);
-
-        Assert.assertEquals(16, ((ByteBuf) list.get(0)).readableBytes());
-    }
-
-    /**
-     * Test of decoding
-     * {@link OFFrameDecoder#decode(io.netty.channel.ChannelHandlerContext, io.netty.buffer.ByteBuf, java.util.List)}
-     * 
-     * @throws Exception
-     */
-    @Test
-    public void testDecodeIncompleteMessage() throws Exception {
-        decoder.decode(channelHandlerContext,
-                ByteBufUtils.hexStringToByteBuf("04 00 00 08 00"),
-                list);
-
-        Assert.assertEquals("List is not empty", 0, list.size());
-    }
-
-    /**
-     * Test of decoding
-     * {@link OFFrameDecoder#decode(io.netty.channel.ChannelHandlerContext, io.netty.buffer.ByteBuf, java.util.List)}
-     * 
-     * @throws Exception
-     */
-    @Test
-    public void testDecodeCompleteAndPartialMessage() throws Exception {
-        decoder.decode(channelHandlerContext,
-                ByteBufUtils.hexStringToByteBuf("04 00 00 08 00 00 00 01 04 00 00 08 00"),
-                list);
-
-        Assert.assertEquals(8, ((ByteBuf) list.get(0)).readableBytes());
-        Assert.assertEquals(1, list.size());
-    }
-    
-}
\ No newline at end of file
+/*
+ * Copyright (c) 2013 Pantheon Technologies s.r.o. and others. All rights reserved.
+ *
+ * This program and the accompanying materials are made available under the
+ * terms of the Eclipse Public License v1.0 which accompanies this distribution,
+ * and is available at http://www.eclipse.org/legal/epl-v10.html
+ */
+
+package org.opendaylight.openflowjava.protocol.impl.core;
+
+import static org.junit.Assert.assertEquals;
+import io.netty.buffer.ByteBuf;
+import io.netty.channel.ChannelHandlerContext;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import org.junit.Assert;
+import org.junit.Before;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.mockito.Mock;
+import org.mockito.MockitoAnnotations;
+import org.mockito.runners.MockitoJUnitRunner;
+import org.opendaylight.openflowjava.protocol.impl.core.connection.ConnectionFacade;
+import org.opendaylight.openflowjava.util.ByteBufUtils;
+
+/**
+ * Testing class of {@link OFFrameDecoder}
+ *
+ * @author michal.polkorab
+ */
+@RunWith(MockitoJUnitRunner.class)
+public class OFFrameDecoderTest {
+
+    @Mock
+    ChannelHandlerContext channelHandlerContext;
+
+    @Mock
+    ConnectionFacade connectionFacade;
+    private OFFrameDecoder decoder;
+    private List<Object> list = new ArrayList<>();
+
+    /**
+     * Sets up tests
+     */
+    @Before
+    public void setUp() {
+        MockitoAnnotations.initMocks(this);
+        decoder = new OFFrameDecoder(connectionFacade, false);
+        list.clear();
+
+    }
+
+    /**
+     * Test of decoding
+     * {@link OFFrameDecoder#decode(io.netty.channel.ChannelHandlerContext, io.netty.buffer.ByteBuf, java.util.List)}
+     */
+    @Test
+    public void testDecode8BMessage() {
+        try {
+            decoder.decode(channelHandlerContext,
+                    ByteBufUtils.hexStringToByteBuf("04 00 00 08 00 00 00 01"),
+                    list);
+        } catch (Exception e) {
+            Assert.fail();
+        }
+
+        assertEquals(8, ((ByteBuf) list.get(0)).readableBytes());
+    }
+
+    /**
+     * Test of decoding
+     * {@link OFFrameDecoder#decode(io.netty.channel.ChannelHandlerContext, io.netty.buffer.ByteBuf, java.util.List)}
+     */
+    @Test
+    public void testDecode16BMessage() {
+        ByteBuf byteBuffer = ByteBufUtils
+                .hexStringToByteBuf("04 00 00 10 00 00 00 00 00 00 00 00 00 00 00 42");
+        try {
+            decoder.decode(channelHandlerContext, byteBuffer, list);
+        } catch (Exception e) {
+            Assert.fail();
+        }
+
+        assertEquals(16, ((ByteBuf) list.get(0)).readableBytes());
+        assertEquals(0, byteBuffer.readableBytes());
+    }
+
+    /**
+     * Test of decoding
+     * {@link OFFrameDecoder#decode(io.netty.channel.ChannelHandlerContext, io.netty.buffer.ByteBuf, java.util.List)}
+     */
+    @Test
+    public void testDecode5BIncompleteMessage() {
+        ByteBuf byteBuffer = ByteBufUtils.hexStringToByteBuf("04 00 00 08 00");
+        try {
+            decoder.decode(channelHandlerContext, byteBuffer, list);
+        } catch (Exception e) {
+            Assert.fail();
+        }
+
+        Assert.assertEquals("List is not empty", 0, list.size());
+        assertEquals(5, byteBuffer.readableBytes());
+    }
+
+    /**
+     * Test of decoding
+     * {@link OFFrameDecoder#decode(io.netty.channel.ChannelHandlerContext, io.netty.buffer.ByteBuf, java.util.List)}
+     */
+    @Test
+    public void testDecode16BIncompleteMessage() {
+        ByteBuf byteBuffer = ByteBufUtils
+                .hexStringToByteBuf("04 00 00 11 00 00 00 00 00 00 00 00 00 00 00 42");
+        try {
+            decoder.decode(channelHandlerContext, byteBuffer, list);
+        } catch (Exception e) {
+            Assert.fail();
+        }
+
+        Assert.assertEquals("List is not empty", 0, list.size());
+        assertEquals(16, byteBuffer.readableBytes());
+    }
+
+    /**
+     * Test of decoding
+     * {@link OFFrameDecoder#decode(io.netty.channel.ChannelHandlerContext, io.netty.buffer.ByteBuf, java.util.List)}
+     */
+    @Test
+    public void testDecodeCompleteAndPartialMessage() {
+        ByteBuf byteBuffer = ByteBufUtils
+                .hexStringToByteBuf("04 00 00 08 00 00 00 01 04 00 00 08 00");
+        try {
+            decoder.decode(channelHandlerContext, byteBuffer, list);
+        } catch (Exception e) {
+            Assert.fail();
+        }
+
+        Assert.assertEquals(8, ((ByteBuf) list.get(0)).readableBytes());
+        Assert.assertEquals(1, list.size());
+        assertEquals(5, byteBuffer.readableBytes());
+
+    }
+
+    @Test
+    public void testExceptionCaught() throws Exception {
+        decoder.exceptionCaught(channelHandlerContext, new Throwable());
+    }
+
+    /**
+     * Test of decoding
+     * {@link OFFrameDecoder#decode(io.netty.channel.ChannelHandlerContext, io.netty.buffer.ByteBuf, java.util.List)}
+     */
+    @Test
+    public void testDecode8BMessageWithTls() {
+        decoder = new OFFrameDecoder(connectionFacade, true);
+        try {
+            decoder.decode(channelHandlerContext,
+                    ByteBufUtils.hexStringToByteBuf("04 00 00 08 00 00 00 01"),
+                    list);
+        } catch (Exception e) {
+            Assert.fail();
+        }
+
+        assertEquals(8, ((ByteBuf) list.get(0)).readableBytes());
+    }
+}