X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=openflow-protocol-impl%2Fsrc%2Ftest%2Fjava%2Forg%2Fopendaylight%2Fopenflowjava%2Fprotocol%2Fimpl%2Fdeserialization%2Ffactories%2FQueueGetConfigReplyMessageFactoryTest.java;h=4c447fc3441430860b3effe02ffb696d08b5255f;hb=0d9c30aa4c3e66f92eca0a867d3cf678b07770ca;hp=01a7d025ac30b49f69af9ae657cae7a119b93fea;hpb=2c0d6baf3a4ca0c6de5992d68e5f2eb200a918ed;p=openflowjava.git diff --git a/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/deserialization/factories/QueueGetConfigReplyMessageFactoryTest.java b/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/deserialization/factories/QueueGetConfigReplyMessageFactoryTest.java index 01a7d025..4c447fc3 100644 --- a/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/deserialization/factories/QueueGetConfigReplyMessageFactoryTest.java +++ b/openflow-protocol-impl/src/test/java/org/opendaylight/openflowjava/protocol/impl/deserialization/factories/QueueGetConfigReplyMessageFactoryTest.java @@ -1,12 +1,11 @@ /* Copyright (C)2013 Pantheon Technologies, s.r.o. All rights reserved. */ package org.opendaylight.openflowjava.protocol.impl.deserialization.factories; +import io.netty.buffer.ByteBuf; + import java.util.ArrayList; -import java.util.Comparator; import java.util.List; -import io.netty.buffer.ByteBuf; - import org.junit.Assert; import org.junit.Test; import org.opendaylight.openflowjava.protocol.impl.util.BufferHelper; @@ -19,14 +18,15 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.protocol.rev130731 import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.protocol.rev130731.queue.get.config.reply.Queues; import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.protocol.rev130731.queue.get.config.reply.QueuesBuilder; -import com.google.common.collect.ComparisonChain; - /** * @author timotej.kubas * @author michal.polkorab */ public class QueueGetConfigReplyMessageFactoryTest { + /** + * Testing {@link QueueGetConfigReplyMessageFactory} for correct translation into POJO + */ @Test public void test(){ ByteBuf bb = BufferHelper.buildBuffer("00 01 02 03 00 00 00 00 00 00 00 01 00 00 00 01 00 00 00 00 00 00 00 00 00 02 00 00 00 00 00 00"); @@ -36,8 +36,8 @@ public class QueueGetConfigReplyMessageFactoryTest { Assert.assertEquals("Wrong queues", builtByFactory.getQueues(), createQueuesList()); } - public List createQueuesList(){ - List queuesList = new ArrayList(); + private static List createQueuesList(){ + List queuesList = new ArrayList<>(); QueuesBuilder qb = new QueuesBuilder(); qb.setQueueId(new QueueId(1L)); qb.setPort(new PortNumber(1L)); @@ -47,8 +47,8 @@ public class QueueGetConfigReplyMessageFactoryTest { return queuesList; } - public List createPropertiesList(){ - List propertiesList = new ArrayList(); + private static List createPropertiesList(){ + List propertiesList = new ArrayList<>(); PropertiesBuilder pb = new PropertiesBuilder(); pb.setProperty(QueueProperty.values()[2]); propertiesList.add(pb.build());