X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=openflowplugin-impl%2Fsrc%2Ftest%2Fjava%2Forg%2Fopendaylight%2Fopenflowplugin%2Fimpl%2Fconnection%2Flistener%2FSystemNotificationsListenerImplTest.java;h=2abf175a02beb836ef7c27001739294d09b07012;hb=b4f4b4b702e2ccd8a7c62fd2a5c184c5b1cbe665;hp=997dd3a2b326f2529c450afc6bc2311b8b3accb6;hpb=6916d4f22823d56b391d0d45cb8544260def3431;p=openflowplugin.git diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/connection/listener/SystemNotificationsListenerImplTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/connection/listener/SystemNotificationsListenerImplTest.java index 997dd3a2b3..2abf175a02 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/connection/listener/SystemNotificationsListenerImplTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/connection/listener/SystemNotificationsListenerImplTest.java @@ -8,21 +8,21 @@ package org.opendaylight.openflowplugin.impl.connection.listener; +import static org.mockito.ArgumentMatchers.any; + import com.google.common.util.concurrent.Futures; +import com.google.common.util.concurrent.ListenableFuture; import com.google.common.util.concurrent.SettableFuture; import java.net.InetSocketAddress; -import java.util.concurrent.Future; import java.util.concurrent.SynchronousQueue; import java.util.concurrent.TimeUnit; - import org.junit.After; import org.junit.Before; import org.junit.Test; import org.junit.runner.RunWith; -import org.mockito.Matchers; import org.mockito.Mock; import org.mockito.Mockito; -import org.mockito.runners.MockitoJUnitRunner; +import org.mockito.junit.MockitoJUnitRunner; import org.opendaylight.openflowjava.protocol.api.connection.ConnectionAdapter; import org.opendaylight.openflowplugin.api.openflow.connection.ConnectionContext; import org.opendaylight.openflowplugin.impl.connection.ConnectionContextImpl; @@ -40,13 +40,13 @@ import org.opendaylight.yangtools.yang.common.RpcResult; import org.opendaylight.yangtools.yang.common.RpcResultBuilder; /** - * Testing basic bahavior of {@link SystemNotificationsListenerImpl} + * Testing basic bahavior of {@link SystemNotificationsListenerImpl}. */ @RunWith(MockitoJUnitRunner.class) public class SystemNotificationsListenerImplTest { private static final int SAFE_TIMEOUT = 1000; - private final static int ECHO_REPLY_TIMEOUT = 2000; + private static final int ECHO_REPLY_TIMEOUT = 2000; @Mock private ConnectionAdapter connectionAdapter; @@ -57,17 +57,17 @@ public class SystemNotificationsListenerImplTest { private ConnectionContextImpl connectionContextGolem; private SystemNotificationsListenerImpl systemNotificationsListener; - private static final NodeId nodeId = + private static final NodeId NODE_ID = new NodeId("OFP:TEST"); - private final ThreadPoolLoggingExecutor threadPool = - new ThreadPoolLoggingExecutor(0, Integer.MAX_VALUE, 60L, TimeUnit.SECONDS, new SynchronousQueue<>(), "opfpool"); + private final ThreadPoolLoggingExecutor threadPool = new ThreadPoolLoggingExecutor( + 0, Integer.MAX_VALUE, 60L, TimeUnit.SECONDS, new SynchronousQueue<>(), "opfpool"); @Before public void setUp() { connectionContextGolem = new ConnectionContextImpl(connectionAdapter); connectionContextGolem.changeStateToWorking(); - connectionContextGolem.setNodeId(nodeId); + connectionContextGolem.setNodeId(NODE_ID); connectionContext = Mockito.spy(connectionContextGolem); Mockito.when(connectionAdapter.getRemoteAddress()).thenReturn( @@ -89,14 +89,10 @@ public class SystemNotificationsListenerImplTest { } /** - * successful scenario - connection is on and closes without errors - * - * @throws Exception + * Successful scenario - connection is on and closes without errors. */ @Test public void testOnDisconnectEvent1() throws Exception { - Mockito.when(connectionAdapter.isAlive()).thenReturn(true); - Mockito.when(connectionAdapter.disconnect()).thenReturn(Futures.immediateFuture(Boolean.TRUE)); DisconnectEvent disconnectNotification = new DisconnectEventBuilder().setInfo("testing disconnect").build(); systemNotificationsListener.onDisconnectEvent(disconnectNotification); @@ -108,14 +104,10 @@ public class SystemNotificationsListenerImplTest { } /** - * broken scenario - connection is on but fails to close - * - * @throws Exception + * Broken scenario - connection is on but fails to close. */ @Test public void testOnDisconnectEvent2() throws Exception { - Mockito.when(connectionAdapter.isAlive()).thenReturn(true); - Mockito.when(connectionAdapter.disconnect()).thenReturn(Futures.immediateFuture(Boolean.FALSE)); DisconnectEvent disconnectNotification = new DisconnectEventBuilder().setInfo("testing disconnect").build(); systemNotificationsListener.onDisconnectEvent(disconnectNotification); @@ -127,17 +119,12 @@ public class SystemNotificationsListenerImplTest { } /** - * successful scenario - connection is already down - * - * @throws Exception + * Successful scenario - connection is already down. */ @Test public void testOnDisconnectEvent3() throws Exception { connectionContextGolem.changeStateToTimeouting(); - Mockito.when(connectionAdapter.isAlive()).thenReturn(true); - Mockito.when(connectionAdapter.disconnect()).thenReturn(Futures.immediateFailedFuture(new Exception("unit exception"))); - DisconnectEvent disconnectNotification = new DisconnectEventBuilder().setInfo("testing disconnect").build(); systemNotificationsListener.onDisconnectEvent(disconnectNotification); @@ -148,14 +135,11 @@ public class SystemNotificationsListenerImplTest { } /** - * broken scenario - connection is on but throws error on close - * - * @throws Exception + * Broken scenario - connection is on but throws error on close. */ @Test public void testOnDisconnectEvent4() throws Exception { Mockito.when(connectionContext.getConnectionState()).thenReturn(ConnectionContext.CONNECTION_STATE.RIP); - Mockito.when(connectionAdapter.isAlive()).thenReturn(false); DisconnectEvent disconnectNotification = new DisconnectEventBuilder().setInfo("testing disconnect").build(); systemNotificationsListener.onDisconnectEvent(disconnectNotification); @@ -167,15 +151,14 @@ public class SystemNotificationsListenerImplTest { } /** - * first encounter of idle event, echo received successfully - * - * @throws Exception + * First encounter of idle event, echo received successfully. */ @Test public void testOnSwitchIdleEvent1() throws Exception { - final Future> echoReply = Futures.immediateFuture(RpcResultBuilder.success(new EchoOutputBuilder().setXid(0L).build()).build()); + final ListenableFuture> echoReply = + Futures.immediateFuture(RpcResultBuilder.success(new EchoOutputBuilder().setXid(0L).build()).build()); - Mockito.when(connectionAdapter.echo(Matchers.any(EchoInput.class))).thenReturn(echoReply); + Mockito.when(connectionAdapter.echo(any(EchoInput.class))).thenReturn(echoReply); SwitchIdleEvent notification = new SwitchIdleEventBuilder().setInfo("wake up, device sleeps").build(); systemNotificationsListener.onSwitchIdleEvent(notification); @@ -184,23 +167,22 @@ public class SystemNotificationsListenerImplTest { Thread.sleep(SAFE_TIMEOUT); verifyCommonInvocations(); - Mockito.verify(connectionAdapter, Mockito.timeout(SAFE_TIMEOUT)).echo(Matchers.any(EchoInput.class)); + Mockito.verify(connectionAdapter, Mockito.timeout(SAFE_TIMEOUT)).echo(any(EchoInput.class)); Mockito.verify(connectionAdapter, Mockito.never()).disconnect(); Mockito.verify(connectionContext).changeStateToTimeouting(); Mockito.verify(connectionContext).changeStateToWorking(); } /** - * first encounter of idle event, echo not receive - * - * @throws Exception + * First encounter of idle event, echo not receive. */ @Test public void testOnSwitchIdleEvent2() throws Exception { final SettableFuture> echoReply = SettableFuture.create(); - Mockito.when(connectionAdapter.echo(Matchers.any(EchoInput.class))).thenReturn(echoReply); + Mockito.when(connectionAdapter.echo(any(EchoInput.class))).thenReturn(echoReply); Mockito.when(connectionAdapter.isAlive()).thenReturn(true); - Mockito.when(connectionAdapter.disconnect()).thenReturn(Futures.immediateFailedFuture(new Exception("unit exception"))); + Mockito.when(connectionAdapter.disconnect()) + .thenReturn(Futures.immediateFailedFuture(new Exception("unit exception"))); SwitchIdleEvent notification = new SwitchIdleEventBuilder().setInfo("wake up, device sleeps").build(); systemNotificationsListener.onSwitchIdleEvent(notification); @@ -208,7 +190,7 @@ public class SystemNotificationsListenerImplTest { Thread.sleep(SystemNotificationsListenerImpl.MAX_ECHO_REPLY_TIMEOUT + SAFE_TIMEOUT); verifyCommonInvocations(); - Mockito.verify(connectionAdapter, Mockito.timeout(SAFE_TIMEOUT)).echo(Matchers.any(EchoInput.class)); + Mockito.verify(connectionAdapter, Mockito.timeout(SAFE_TIMEOUT)).echo(any(EchoInput.class)); Mockito.verify(connectionAdapter).disconnect(); Mockito.verify(connectionContext).changeStateToTimeouting(); Mockito.verify(connectionContext).closeConnection(true); @@ -225,4 +207,4 @@ public class SystemNotificationsListenerImplTest { Mockito.verify(connectionContext, Mockito.timeout(SAFE_TIMEOUT).atLeastOnce()).getConnectionState(); Mockito.verify(connectionContext, Mockito.timeout(SAFE_TIMEOUT).atLeastOnce()).getFeatures(); } -} \ No newline at end of file +}