X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=openflowplugin-impl%2Fsrc%2Ftest%2Fjava%2Forg%2Fopendaylight%2Fopenflowplugin%2Fimpl%2Fstatistics%2Fservices%2Fdirect%2Fsinglelayer%2FGroupDirectStatisticsServiceTest.java;h=98cdbc55ab372545ba72ab0f238e263717d8f5ce;hb=21c984447de25eb251e2ed51b64f9ef486e8c3a4;hp=f2247cc0557759770015eb38ffc7f91f70682c3d;hpb=ab48afdf8678dd131c771921dfa9d89554b9c50a;p=openflowplugin.git diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/direct/singlelayer/GroupDirectStatisticsServiceTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/direct/singlelayer/GroupDirectStatisticsServiceTest.java index f2247cc055..98cdbc55ab 100644 --- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/direct/singlelayer/GroupDirectStatisticsServiceTest.java +++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/services/direct/singlelayer/GroupDirectStatisticsServiceTest.java @@ -5,41 +5,36 @@ * terms of the Eclipse Public License v1.0 which accompanies this distribution, * and is available at http://www.eclipse.org/legal/epl-v10.html */ - package org.opendaylight.openflowplugin.impl.statistics.services.direct.singlelayer; import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertTrue; -import static org.mockito.Matchers.any; -import static org.mockito.Matchers.eq; -import static org.mockito.Mockito.mock; +import static org.mockito.ArgumentMatchers.any; +import static org.mockito.ArgumentMatchers.eq; import static org.mockito.Mockito.verify; -import static org.mockito.Mockito.when; -import java.util.Arrays; -import java.util.Collections; import java.util.List; -import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; +import org.opendaylight.mdsal.common.api.LogicalDatastoreType; import org.opendaylight.openflowplugin.api.openflow.device.Xid; import org.opendaylight.openflowplugin.impl.statistics.services.direct.AbstractDirectStatisticsServiceTest; -import org.opendaylight.yang.gen.v1.urn.opendaylight.direct.statistics.rev160511.GetGroupStatisticsInput; -import org.opendaylight.yang.gen.v1.urn.opendaylight.direct.statistics.rev160511.GetGroupStatisticsOutput; +import org.opendaylight.yang.gen.v1.urn.opendaylight.direct.statistics.rev160511.GetGroupStatisticsInputBuilder; +import org.opendaylight.yang.gen.v1.urn.opendaylight.direct.statistics.rev160511.GetGroupStatisticsOutputBuilder; import org.opendaylight.yang.gen.v1.urn.opendaylight.group.statistics.rev131111.multipart.reply.multipart.reply.body.MultipartReplyGroupStatsBuilder; import org.opendaylight.yang.gen.v1.urn.opendaylight.group.statistics.rev131111.multipart.request.multipart.request.body.MultipartRequestGroupStats; import org.opendaylight.yang.gen.v1.urn.opendaylight.group.types.rev131018.GroupId; -import org.opendaylight.yang.gen.v1.urn.opendaylight.group.types.rev131018.group.statistics.reply.GroupStats; import org.opendaylight.yang.gen.v1.urn.opendaylight.group.types.rev131018.group.statistics.reply.GroupStatsBuilder; -import org.opendaylight.yang.gen.v1.urn.opendaylight.multipart.types.rev170112.MultipartReply; import org.opendaylight.yang.gen.v1.urn.opendaylight.multipart.types.rev170112.MultipartReplyBuilder; import org.opendaylight.yang.gen.v1.urn.opendaylight.multipart.types.rev170112.MultipartRequest; import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.common.types.rev130731.MultipartType; +import org.opendaylight.yangtools.yang.binding.util.BindingMap; +import org.opendaylight.yangtools.yang.common.Uint32; public class GroupDirectStatisticsServiceTest extends AbstractDirectStatisticsServiceTest { - static final Long GROUP_NO = 1L; + static final Uint32 GROUP_NO = Uint32.ONE; private GroupDirectStatisticsService service; @Override - public void setUp() throws Exception { + public void setUp() { service = new GroupDirectStatisticsService(requestContextStack, deviceContext, convertorManager, @@ -47,56 +42,40 @@ public class GroupDirectStatisticsServiceTest extends AbstractDirectStatisticsSe } @Override - public void testBuildRequestBody() throws Exception { - final GetGroupStatisticsInput input = mock(GetGroupStatisticsInput.class); - - when(input.getNode()).thenReturn(createNodeRef(NODE_ID)); - when(input.getGroupId()).thenReturn(new GroupId(GROUP_NO)); - + public void testBuildRequestBody() { final MultipartRequestGroupStats body = (MultipartRequestGroupStats) ((MultipartRequest) service - .buildRequest(new Xid(42L), input)) + .buildRequest(new Xid(Uint32.valueOf(42L)), new GetGroupStatisticsInputBuilder() + .setGroupId(new GroupId(GROUP_NO)) + .setNode(createNodeRef(NODE_ID)) + .build())) .getMultipartRequestBody(); assertEquals(GROUP_NO, body.getGroupId().getValue()); } @Override - public void testBuildReply() throws Exception { - final GroupStats groupStat = new GroupStatsBuilder() - .setGroupId(new GroupId(GROUP_NO)) - .build(); - - final MultipartReply reply = new MultipartReplyBuilder() - .setMultipartReplyBody(new MultipartReplyGroupStatsBuilder() - .setGroupStats(Collections.singletonList(groupStat)) - .build()) - .build(); - - final List input = Collections.singletonList(reply); - - final GetGroupStatisticsOutput output = service.buildReply(input, true); - assertTrue(output.getGroupStats().size() > 0); - - final org.opendaylight.yang.gen.v1.urn - .opendaylight.group.types.rev131018.group.statistics.reply.GroupStats stats = output.getGroupStats().get(0); + public void testBuildReply() { + final var output = service.buildReply(List.of(new MultipartReplyBuilder() + .setMultipartReplyBody(new MultipartReplyGroupStatsBuilder() + .setGroupStats(BindingMap.of(new GroupStatsBuilder() + .setGroupId(new GroupId(GROUP_NO)) + .build())) + .build()) + .build()), true); + assertTrue(output.nonnullGroupStats().size() > 0); + + final var stats = output.nonnullGroupStats().values().iterator().next(); assertEquals(stats.getGroupId().getValue(), GROUP_NO); } @Override - public void testStoreStatistics() throws Exception { - final org.opendaylight.yang.gen.v1.urn - .opendaylight.group.types.rev131018.group.statistics.reply.GroupStats stat = - mock(org.opendaylight.yang.gen.v1.urn - .opendaylight.group.types.rev131018.group.statistics.reply.GroupStats.class); - when(stat.getGroupId()).thenReturn(new GroupId(GROUP_NO)); - - final List stats = Collections.singletonList(stat); - final GetGroupStatisticsOutput output = mock(GetGroupStatisticsOutput.class); - when(output.getGroupStats()).thenReturn(stats); - - multipartWriterProvider.lookup(MultipartType.OFPMPGROUP).get().write(output, true); + public void testStoreStatistics() { + multipartWriterProvider.lookup(MultipartType.OFPMPGROUP).orElseThrow() + .write(new GetGroupStatisticsOutputBuilder() + .setGroupStats(BindingMap.of(new org.opendaylight.yang.gen.v1.urn.opendaylight.group.types.rev131018 + .group.statistics.reply.GroupStatsBuilder().setGroupId(new GroupId(GROUP_NO)).build())) + .build(), true); verify(deviceContext).writeToTransactionWithParentsSlow(eq(LogicalDatastoreType.OPERATIONAL), any(), any()); } }