X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=openstack%2Fnet-virt-providers%2Fsrc%2Ftest%2Fjava%2Forg%2Fopendaylight%2Fovsdb%2Fopenstack%2Fnetvirt%2Fproviders%2Fopenflow13%2Fservices%2FL3FowardingServiceTest.java;h=66a0681936f6e9f9a3705b39a2eab67a607840f2;hb=54305a94221ce4a05f8286e45fa48c6f42b6a483;hp=019802a2e60916c918dc1020139a5e2f58785794;hpb=d32dc7c317adaf7f7d6dac5a930afd28a4ea7d6b;p=netvirt.git diff --git a/openstack/net-virt-providers/src/test/java/org/opendaylight/ovsdb/openstack/netvirt/providers/openflow13/services/L3FowardingServiceTest.java b/openstack/net-virt-providers/src/test/java/org/opendaylight/ovsdb/openstack/netvirt/providers/openflow13/services/L3FowardingServiceTest.java index 019802a2e6..66a0681936 100644 --- a/openstack/net-virt-providers/src/test/java/org/opendaylight/ovsdb/openstack/netvirt/providers/openflow13/services/L3FowardingServiceTest.java +++ b/openstack/net-virt-providers/src/test/java/org/opendaylight/ovsdb/openstack/netvirt/providers/openflow13/services/L3FowardingServiceTest.java @@ -19,14 +19,12 @@ import static org.mockito.Mockito.when; import java.net.InetAddress; import org.junit.Before; -import org.junit.Ignore; import org.junit.Test; import org.junit.runner.RunWith; import org.mockito.InjectMocks; import org.mockito.Mock; import org.mockito.runners.MockitoJUnitRunner; import org.opendaylight.controller.md.sal.binding.api.DataBroker; -import org.opendaylight.controller.md.sal.binding.api.ReadWriteTransaction; import org.opendaylight.controller.md.sal.binding.api.WriteTransaction; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; import org.opendaylight.controller.md.sal.common.api.data.TransactionCommitFailedException; @@ -43,16 +41,15 @@ import com.google.common.util.concurrent.CheckedFuture; /** * Unit test fort {@link L3ForwardingService} */ -@Ignore // TODO SB_MIGRATION @RunWith(MockitoJUnitRunner.class) +@SuppressWarnings("unchecked") public class L3FowardingServiceTest { @InjectMocks private L3ForwardingService l3ForwardingService = new L3ForwardingService(); - //@Mock private MdsalConsumer mdsalConsumer; + @Mock private DataBroker dataBroker; @Mock private PipelineOrchestrator orchestrator; - @Mock private ReadWriteTransaction readWriteTransaction; @Mock private WriteTransaction writeTransaction; @Mock private CheckedFuture commitFuture; @@ -62,15 +59,10 @@ public class L3FowardingServiceTest { @Before public void setUp() throws Exception { - when(readWriteTransaction.submit()).thenReturn(commitFuture); when(writeTransaction.submit()).thenReturn(commitFuture); - DataBroker dataBroker = mock(DataBroker.class); - when(dataBroker.newReadWriteTransaction()).thenReturn(readWriteTransaction); when(dataBroker.newWriteOnlyTransaction()).thenReturn(writeTransaction); - //when(mdsalConsumer.getDataBroker()).thenReturn(dataBroker); - when(orchestrator.getNextServiceInPipeline(any(Service.class))).thenReturn(Service.ARP_RESPONDER); } @@ -86,9 +78,9 @@ public class L3FowardingServiceTest { new Status(StatusCode.SUCCESS), l3ForwardingService.programForwardingTableEntry(Long.valueOf(123), SEGMENTATION_ID, address, MAC_ADDRESS, Action.ADD)); - verify(readWriteTransaction, times(2)).put(any(LogicalDatastoreType.class), + verify(writeTransaction, times(2)).put(any(LogicalDatastoreType.class), any(InstanceIdentifier.class), any(Node.class), anyBoolean()); - verify(readWriteTransaction, times(1)).submit(); + verify(writeTransaction, times(1)).submit(); verify(commitFuture, times(1)).get(); assertEquals("Error, did not return the expected StatusCode", @@ -96,7 +88,7 @@ public class L3FowardingServiceTest { l3ForwardingService.programForwardingTableEntry(Long.valueOf(123), SEGMENTATION_ID, address, MAC_ADDRESS, Action.DELETE)); verify(writeTransaction, times(1)).delete(any(LogicalDatastoreType.class), any(InstanceIdentifier.class)); - verify(readWriteTransaction, times(1)).submit(); + verify(writeTransaction, times(2)).submit(); verify(commitFuture, times(2)).get(); // 1 + 1 above }