X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=spec%2Fspec_helper.rb;h=5d60a6500c40fefbe989f979d602fd8f7585e0d2;hb=7a664a0e4fa8bd3f16d7fce7844b67d0e43f51de;hp=af6e87478cac45ffd3397629b53bae1f1ae24246;hpb=ffbc569203f71198722aac86fd6740c464a5e766;p=integration%2Fpackaging%2Fpuppet-opendaylight.git diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index af6e874..5d60a65 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -3,35 +3,8 @@ require 'rspec-puppet-facts' include RspecPuppetFacts # Customize filters to ignore 3rd-party code -# If the coverage report shows not-our-code results, add it here +# If the rspec coverage report shows not-our-code results, add it here custom_filters = [ - 'Anchor[java::end]', - 'Stage[setup]', - 'Anchor[java::begin:]', - 'Archive::Download[opendaylight.tar.gz]', - 'Archive::Download[opendaylight-systemd.tar.gz]', - 'Archive::Extract[opendaylight]', - 'Archive::Extract[opendaylight-systemd]', - 'Class[Java::Config]', - 'Class[Java::Params]', - 'Class[Stdlib::Stages]', - 'Class[Stdlib]', - 'Exec[Configure ODL OVSDB Clustering]', - 'Exec[download archive opendaylight.tar.gz and check sum]', - 'Exec[download archive opendaylight-systemd.tar.gz and check sum]', - 'Exec[opendaylight unpack]', - 'Exec[opendaylight-systemd unpack]', - 'Exec[rm-on-error-opendaylight.tar.gz]', - 'Exec[rm-on-error-opendaylight-systemd.tar.gz]', - 'Exec[reload_systemd_units]', - 'Exec[update-java-alternatives]', - 'Package[curl]', - 'Stage[deploy]', - 'Stage[deploy_app]', - 'Stage[deploy_infra]', - 'Stage[runtime]', - 'Stage[setup_app]', - 'Stage[setup_infra]', ] RSpec::Puppet::Coverage.filters.push(*custom_filters) @@ -40,7 +13,9 @@ RSpec::Puppet::Coverage.filters.push(*custom_filters) # # Tests that are common to all possible configurations -def generic_tests() +def generic_tests(options = {}) + java_opts = options.fetch(:java_opts, '-Djava.net.preferIPv4Stack=true') + # Confirm that module compiles it { should compile } it { should compile.with_all_deps } @@ -50,6 +25,7 @@ def generic_tests() it { should contain_class('opendaylight::params') } it { should contain_class('opendaylight::install') } it { should contain_class('opendaylight::config') } + it { should contain_class('opendaylight::post_config') } it { should contain_class('opendaylight::service') } # Confirm relationships between classes @@ -58,6 +34,8 @@ def generic_tests() it { should contain_class('opendaylight::config').that_notifies('Class[opendaylight::service]') } it { should contain_class('opendaylight::service').that_subscribes_to('Class[opendaylight::config]') } it { should contain_class('opendaylight::service').that_comes_before('Class[opendaylight]') } + it { should contain_class('opendaylight::post_config').that_requires('Class[opendaylight::service]') } + it { should contain_class('opendaylight::post_config').that_comes_before('Class[opendaylight]') } it { should contain_class('opendaylight').that_requires('Class[opendaylight::service]') } # Confirm presence of generic resources @@ -83,6 +61,57 @@ def generic_tests() 'group' => 'odl', ) } + + it { + should contain_file_line('Karaf Java Options').with( + 'ensure' => 'present', + 'path' => '/opt/opendaylight/bin/karaf', + 'line' => "JAVA_OPTS=#{java_opts}", + 'match' => '^JAVA_OPTS=.*$', + 'after' => '^PROGNAME=.*$' + ) + } + +end + +# Shared tests that specialize in testing log file size and rollover +def log_settings(options = {}) + # Extraxt params. The dafault value should be same as in opendaylight::params + log_max_size = options.fetch(:log_max_size, '10GB') + log_max_rollover = options.fetch(:log_max_rollover, 2) + log_mechanism = options.fetch(:log_mechanism, 'file') + + if log_mechanism == 'console' + it { + should contain_file_line('consoleappender').with( + 'path' => '/opt/opendaylight/etc/org.ops4j.pax.logging.cfg', + 'line' => 'karaf.log.console=INFO', + 'after' => 'log4j2.rootLogger.appenderRef.Console.filter.threshold.type = ThresholdFilter', + 'match' => '^karaf.log.console.*$' + ) + } + else + it { + should contain_file_line('logmaxsize').with( + 'path' => '/opt/opendaylight/etc/org.ops4j.pax.logging.cfg', + 'line' => "log4j2.appender.rolling.policies.size.size = #{log_max_size}", + 'match' => '^log4j2.appender.rolling.policies.size.size.*$', + ) + } + it { + should contain_file_line('rolloverstrategy').with( + 'path' => '/opt/opendaylight/etc/org.ops4j.pax.logging.cfg', + 'line' => 'log4j2.appender.rolling.strategy.type = DefaultRolloverStrategy' + ) + } + it { + should contain_file_line('logmaxrollover').with( + 'path' => '/opt/opendaylight/etc/org.ops4j.pax.logging.cfg', + 'line' => "log4j2.appender.rolling.strategy.max = #{log_max_rollover}", + 'match' => '^log4j2.appender.rolling.strategy.max.*$', + ) + } + end end # Shared tests that specialize in testing Karaf feature installs @@ -90,7 +119,7 @@ def karaf_feature_tests(options = {}) # Extract params # NB: This default list should be the same as the one in opendaylight::params # TODO: Remove this possible source of bugs^^ - default_features = options.fetch(:default_features, ['config', 'standard', 'region', 'package', 'kar', 'ssh', 'management']) + default_features = options.fetch(:default_features, ['standard', 'wrap', 'ssh']) extra_features = options.fetch(:extra_features, []) # The order of this list concat matters @@ -122,18 +151,37 @@ def odl_rest_port_tests(options = {}) # Extract params # NB: This default value should be the same as one in opendaylight::params # TODO: Remove this possible source of bugs^^ - odl_rest_port = options.fetch(:odl_rest_port, 8080) - + odl_rest_port = options.fetch(:odl_rest_port, 8181) + odl_bind_ip = options.fetch(:odl_bind_ip, '0.0.0.0') # Confirm properties of ODL REST port config file # NB: These hashes don't work with Ruby 1.8.7, but we # don't support 1.8.7 so that's okay. See issue #36. it { - should contain_file('jetty.xml').with( - 'ensure' => 'file', - 'path' => '/opt/opendaylight/etc/jetty.xml', - 'owner' => 'odl', - 'group' => 'odl', - 'content' => /Property name="jetty.port" default="#{odl_rest_port}"/ + should contain_augeas('ODL REST Port') + } + + if not odl_bind_ip.eql? '0.0.0.0' + it { + should contain_augeas('ODL REST IP') + should contain_file_line('set pax bind IP').with( + 'ensure' => 'present', + 'path' => '/opt/opendaylight/etc/org.ops4j.pax.web.cfg', + 'line' => "org.ops4j.pax.web.listening.addresses = #{odl_bind_ip}", + 'require' => 'File[org.ops4j.pax.web.cfg]' + ) + } + else + it { + should_not contain_augeas('ODL REST IP') + } + end + + it { + should contain_file_line('set pax bind port').with( + 'ensure' => 'present', + 'path' => '/opt/opendaylight/etc/org.ops4j.pax.web.cfg', + 'line' => "org.osgi.service.http.port = #{odl_rest_port}", + 'require' => 'File[org.ops4j.pax.web.cfg]' ) } end @@ -147,16 +195,27 @@ def log_level_tests(options = {}) if log_levels.empty? # Should contain log level config file it { - should_not contain_file_line('logger-org.opendaylight.ovsdb') + should_not contain_file_line('logger-org.opendaylight.ovsdb-level') + } + it { + should_not contain_file_line('logger-org.opendaylight.ovsdb-name') } else # Verify each custom log level config entry log_levels.each_pair do |logger, level| + underscored_version = "#{logger}".gsub('.', '_') it { - should contain_file_line("logger-#{logger}").with( + should contain_file_line("logger-#{logger}-level").with( + 'ensure' => 'present', + 'path' => '/opt/opendaylight/etc/org.ops4j.pax.logging.cfg', + 'line' => "log4j2.logger.#{underscored_version}.level = #{level}", + 'match' => "log4j2.logger.#{underscored_version}.level = .*$" + ) + should contain_file_line("logger-#{logger}-name").with( 'ensure' => 'present', 'path' => '/opt/opendaylight/etc/org.ops4j.pax.logging.cfg', - 'line' => "log4j.logger.#{logger}=#{level}", + 'line' => "log4j2.logger.#{underscored_version}.name = #{logger}", + 'match' => "log4j2.logger.#{underscored_version}.name = .*$" ) } end @@ -166,8 +225,9 @@ end def enable_ha_tests(options = {}) # Extract params enable_ha = options.fetch(:enable_ha, false) + odl_bind_ip = options.fetch(:odl_bind_ip, '0.0.0.0') ha_node_ips = options.fetch(:ha_node_ips, []) - ha_node_index = options.fetch(:ha_node_index, 0) + ha_db_modules = options.fetch(:ha_db_modules, { 'default' => false }) # HA_NODE_IPS size ha_node_count = ha_node_ips.size @@ -175,32 +235,77 @@ def enable_ha_tests(options = {}) # Check for HA_NODE_COUNT < 2 fail("Number of HA nodes less than 2: #{ha_node_count} and HA Enabled") end + + if enable_ha + ha_node_index = ha_node_ips.index(odl_bind_ip) + it { + should contain_file('akka.conf').with( + 'path' => '/opt/opendaylight/configuration/initial/akka.conf', + 'ensure' => 'file', + 'owner' => 'odl', + 'group' => 'odl', + 'content' => /roles\s*=\s*\["member-#{ha_node_index}"\]/ + ) + } + + ha_db_modules.each do |mod, urn| + it { should contain_file('module-shards.conf').with( + 'path' => '/opt/opendaylight/configuration/initial/module-shards.conf', + 'ensure' => 'file', + 'owner' => 'odl', + 'group' => 'odl', + 'content' => /name = "#{mod}"/ + )} + if mod == 'default' + it { should contain_file('modules.conf').with( + 'path' => '/opt/opendaylight/configuration/initial/modules.conf', + 'ensure' => 'file', + 'owner' => 'odl', + 'group' => 'odl' + )} + else + it { should contain_file('modules.conf').with( + 'path' => '/opt/opendaylight/configuration/initial/modules.conf', + 'ensure' => 'file', + 'owner' => 'odl', + 'group' => 'odl', + 'content' => /name = "#{mod}"/, + )} + end + end + else + it { + should_not contain_file('akka.conf') + should_not contain_file('module-shards.conf') + should_not contain_file('modules.conf') + } + end end def rpm_install_tests(options = {}) # Extract params - rpm_repo = options.fetch(:rpm_repo, 'opendaylight-6-testing') - java_opts = options.fetch(:java_opts, '-Djava.net.preferIPv4Stack=true') + rpm_repo = options.fetch(:rpm_repo, 'https://nexus.opendaylight.org/content/repositories/opendaylight-oxygen-epel-7-$basearch-devel') + # Default to CentOS 7 Yum repo URL # Confirm presence of RPM-related resources - it { should contain_yumrepo(rpm_repo) } + it { should contain_yumrepo('opendaylight') } it { should contain_package('opendaylight') } # Confirm relationships between RPM-related resources - it { should contain_package('opendaylight').that_requires("Yumrepo[#{rpm_repo}]") } - it { should contain_yumrepo(rpm_repo).that_comes_before('Package[opendaylight]') } + it { should contain_package('opendaylight').that_requires('Yumrepo[opendaylight]') } + it { should contain_yumrepo('opendaylight').that_comes_before('Package[opendaylight]') } # Confirm properties of RPM-related resources # NB: These hashes don't work with Ruby 1.8.7, but we # don't support 1.8.7 so that's okay. See issue #36. it { - should contain_yumrepo(rpm_repo).with( + should contain_yumrepo('opendaylight').with( 'enabled' => '1', 'gpgcheck' => '0', 'descr' => 'OpenDaylight SDN Controller', - 'baseurl' => "http://cbs.centos.org/repos/nfv7-#{rpm_repo}/$basearch/os/", + 'baseurl' => "#{rpm_repo}", ) } it { @@ -208,20 +313,11 @@ def rpm_install_tests(options = {}) 'ensure' => 'present', ) } - - it { - should contain_file_line('java_options_systemd').with( - 'ensure' => 'present', - 'path' => '/usr/lib/systemd/system/opendaylight.service', - 'line' => "Environment=_JAVA_OPTIONS=\'#{java_opts}\'", - 'after' => 'ExecStart=/opt/opendaylight/bin/start', - ) - } end def deb_install_tests(options = {}) # Extract params - deb_repo = options.fetch(:deb_repo, 'ppa:odl-team/carbon') + deb_repo = options.fetch(:deb_repo, 'ppa:odl-team/nitrogen') # Confirm the presence of Deb-related resources it { should contain_apt__ppa(deb_repo) } @@ -243,7 +339,7 @@ end def unsupported_os_tests(options = {}) # Extract params expected_msg = options.fetch(:expected_msg) - rpm_repo = options.fetch(:rpm_repo, 'opendaylight-6-testing') + rpm_repo = options.fetch(:rpm_repo, 'https://nexus.opendaylight.org/content/repositories/opendaylight-oxygen-epel-7-$basearch-devel') # Confirm that classes fail on unsupported OSs it { expect { should contain_class('opendaylight') }.to raise_error(Puppet::Error, /#{expected_msg}/) } @@ -252,46 +348,54 @@ def unsupported_os_tests(options = {}) it { expect { should contain_class('opendaylight::service') }.to raise_error(Puppet::Error, /#{expected_msg}/) } # Confirm that other resources fail on unsupported OSs - it { expect { should contain_yumrepo(rpm_repo) }.to raise_error(Puppet::Error, /#{expected_msg}/) } + it { expect { should contain_yumrepo('opendaylight') }.to raise_error(Puppet::Error, /#{expected_msg}/) } it { expect { should contain_package('opendaylight') }.to raise_error(Puppet::Error, /#{expected_msg}/) } it { expect { should contain_service('opendaylight') }.to raise_error(Puppet::Error, /#{expected_msg}/) } it { expect { should contain_file('org.apache.karaf.features.cfg') }.to raise_error(Puppet::Error, /#{expected_msg}/) } end -# Shared tests that specialize in testing security group mode -def enable_sg_tests(sg_mode='stateful', os_release) - # Extract params - # NB: This default value should be the same as one in opendaylight::params - # TODO: Remove this possible source of bugs^^ - +# Shared tests that specialize in testing SNAT mechanism +def snat_mechanism_tests(snat_mechanism='controller') it { should contain_file('/opt/opendaylight/etc/opendaylight') } it { should contain_file('/opt/opendaylight/etc/opendaylight/datastore')} it { should contain_file('/opt/opendaylight/etc/opendaylight/datastore/initial')} it { should contain_file('/opt/opendaylight/etc/opendaylight/datastore/initial/config')} - if os_release != '7.3' and sg_mode == 'stateful' - # Confirm sg_mode becomes learn - it { - should contain_file('netvirt-aclservice-config.xml').with( - 'ensure' => 'file', - 'path' => '/opt/opendaylight/etc/opendaylight/datastore/initial/config/netvirt-aclservice-config.xml', - 'owner' => 'odl', - 'group' => 'odl', - 'content' => /learn/ + # Confirm snat_mechanism + it { + should contain_file('netvirt-natservice-config.xml').with( + 'ensure' => 'file', + 'path' => '/opt/opendaylight/etc/opendaylight/datastore/initial/config/netvirt-natservice-config.xml', + 'owner' => 'odl', + 'group' => 'odl', + 'content' => /#{snat_mechanism}<\/nat-mode>/ ) } - else - # Confirm other sg_mode is passed correctly - it { - should contain_file('netvirt-aclservice-config.xml').with( - 'ensure' => 'file', - 'path' => '/opt/opendaylight/etc/opendaylight/datastore/initial/config/netvirt-aclservice-config.xml', - 'owner' => 'odl', - 'group' => 'odl', - 'content' => /#{sg_mode}/ +end + +# Shared tests that specialize in testing SFC Config +def sfc_tests() + it { should contain_file('/opt/opendaylight/etc/opendaylight') } + it { should contain_file('/opt/opendaylight/etc/opendaylight/datastore')} + it { should contain_file('/opt/opendaylight/etc/opendaylight/datastore/initial')} + it { should contain_file('/opt/opendaylight/etc/opendaylight/datastore/initial/config')} + + it { + should contain_file('netvirt-elanmanager-config.xml').with( + 'ensure' => 'file', + 'path' => '/opt/opendaylight/etc/opendaylight/datastore/initial/config/netvirt-elanmanager-config.xml', + 'owner' => 'odl', + 'group' => 'odl', + 'source' => 'puppet:///modules/opendaylight/netvirt-elanmanager-config.xml' + ) + should contain_file('genius-itm-config.xml').with( + 'ensure' => 'file', + 'path' => '/opt/opendaylight/etc/opendaylight/datastore/initial/config/genius-itm-config.xml', + 'owner' => 'odl', + 'group' => 'odl', + 'source' => 'puppet:///modules/opendaylight/genius-itm-config.xml' ) } - end end # Shared tests that specialize in testing VPP routing node config @@ -335,3 +439,127 @@ def username_password_tests(username, password) ) } end + +# ODL websocket address tests +def odl_websocket_address_tests(options = {}) + # Extract params + # NB: This default value should be the same as one in opendaylight::params + # TODO: Remove this possible source of bugs^^ + odl_bind_ip = options.fetch(:odl_bind_ip, '0.0.0.0') + # Confirm properties of ODL REST port config file + # NB: These hashes don't work with Ruby 1.8.7, but we + # don't support 1.8.7 so that's okay. See issue #36. + + if not odl_bind_ip.eql? '0.0.0.0' + it { + should contain_file('/opt/opendaylight/etc/org.opendaylight.restconf.cfg').with( + 'ensure' => 'file', + 'path' => '/opt/opendaylight/etc/org.opendaylight.restconf.cfg', + 'owner' => 'odl', + 'group' => 'odl', + ) + } + it { + should contain_file_line('websocket-address').with( + 'path' => '/opt/opendaylight/etc/org.opendaylight.restconf.cfg', + 'line' => "websocket-address=#{odl_bind_ip}", + 'match' => '^websocket-address=.*$', + ) + } + else + it { + should_not contain_file_line('websocket-address') + } + end +end + +def odl_tls_tests(options = {}) + enable_tls = options.fetch(:enable_tls, false) + tls_keystore_password = options.fetch(:tls_keystore_password, nil) + tls_trusted_certs = options.fetch(:tls_trusted_certs, []) + tls_keystore_password = options.fetch(:tls_keystore_password, nil) + tls_key_file = options.fetch(:tls_key_file, nil) + tls_cert_file = options.fetch(:tls_cert_file, nil) + tls_ca_cert_file = options.fetch(:tls_ca_cert_file, nil) + odl_rest_port = options.fetch(:odl_rest_port, 8181) + + if enable_tls + if tls_keystore_password.nil? + it { expect { should contain_class('opendaylight::config') }.to raise_error(Puppet::PreformattedError) } + return + end + + if tls_key_file or tls_cert_file + if tls_key_file and tls_cert_file + it { + should contain_odl_keystore('controller') + } + else + it { expect { should contain_class('opendaylight::config') }.to raise_error(Puppet::PreformattedError) } + end + end + it { + should contain_augeas('Remove HTTP ODL REST Port') + should contain_augeas('ODL SSL REST Port') + should contain_file_line('set pax TLS port').with( + 'path' => '/opt/opendaylight/etc/org.ops4j.pax.web.cfg', + 'line' => "org.osgi.service.http.port.secure = #{odl_rest_port}", + 'match' => '^#?org.osgi.service.http.port.secure.*$', + ) + should contain_file_line('set pax TLS keystore location').with( + 'path' => '/opt/opendaylight/etc/org.ops4j.pax.web.cfg', + 'line' => 'org.ops4j.pax.web.ssl.keystore = configuration/ssl/ctl.jks', + 'match' => '^#?org.ops4j.pax.web.ssl.keystore.*$', + ) + should contain_file_line('set pax TLS keystore integrity password').with( + 'path' => '/opt/opendaylight/etc/org.ops4j.pax.web.cfg', + 'line' => "org.ops4j.pax.web.ssl.password = #{tls_keystore_password}", + 'match' => '^#?org.ops4j.pax.web.ssl.password.*$', + ) + should contain_file_line('set pax TLS keystore password').with( + 'path' => '/opt/opendaylight/etc/org.ops4j.pax.web.cfg', + 'line' => "org.ops4j.pax.web.ssl.keypassword = #{tls_keystore_password}", + 'match' => '^#?org.ops4j.pax.web.ssl.keypassword.*$', + ) + should contain_file('aaa-cert-config.xml').with( + 'ensure' => 'file', + 'path' => '/opt/opendaylight/etc/opendaylight/datastore/initial/config/aaa-cert-config.xml', + 'owner' => 'odl', + 'group' => 'odl', + ) + should contain_file('org.opendaylight.ovsdb.library.cfg').with( + 'ensure' => 'file', + 'path' => '/opt/opendaylight/etc/org.opendaylight.ovsdb.library.cfg', + 'owner' => 'odl', + 'group' => 'odl', + 'source' => 'puppet:///modules/opendaylight/org.opendaylight.ovsdb.library.cfg' + ) + should contain_file('/opt/opendaylight/configuration/ssl').with( + 'ensure' => 'directory', + 'path' => '/opt/opendaylight/configuration/ssl', + 'owner' => 'odl', + 'group' => 'odl', + 'mode' => '0755' + ) + should contain_file_line('enable pax TLS').with( + 'ensure' => 'present', + 'path' => '/opt/opendaylight/etc/org.ops4j.pax.web.cfg', + 'line' => 'org.osgi.service.http.secure.enabled = true', + 'match' => '^#?org.osgi.service.http.secure.enabled.*$', + ) + should contain_file('org.ops4j.pax.web.cfg').with( + 'ensure' => 'file', + 'path' => '/opt/opendaylight/etc/org.ops4j.pax.web.cfg', + 'owner' => 'odl', + 'group' => 'odl', + ) + should contain_file('default-openflow-connection-config.xml').with( + 'ensure' => 'file', + 'path' => '/opt/opendaylight/etc/opendaylight/datastore/initial/config/default-openflow-connection-config.xml', + 'owner' => 'odl', + 'group' => 'odl', + 'content' => /TLS<\/transport-protocol>/ + ) + } + end +end