X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=spec%2Fspec_helper_acceptance.rb;h=389fabc6843b731c0b983b18eb0996ea1a860a95;hb=b0306984f8aa2580d05b414e6c0881cc136afc8d;hp=030db2e0fbe3cb44b3e286a779c7698188bf99de;hpb=7b8186b2eb9a31943b46955989eca5b42c50fbf8;p=integration%2Fpackaging%2Fpuppet-opendaylight.git

diff --git a/spec/spec_helper_acceptance.rb b/spec/spec_helper_acceptance.rb
index 030db2e..389fabc 100644
--- a/spec/spec_helper_acceptance.rb
+++ b/spec/spec_helper_acceptance.rb
@@ -1,15 +1,16 @@
 require 'beaker-rspec/spec_helper'
 require 'beaker-rspec/helpers/serverspec'
+require 'beaker-puppet'
+
+include Beaker::DSL::InstallUtils::FOSSUtils
+include Beaker::DSL::InstallUtils::ModuleUtils
+include Beaker::DSL::Helpers::PuppetHelpers
 
 # Install Puppet on all Beaker hosts
 unless ENV['BEAKER_provision'] == 'no'
   hosts.each do |host|
     # Install Puppet
-    if host.is_pe?
-      install_pe
-    else
-      install_puppet
-    end
+    install_puppet_agent_on(host, {:puppet_collection => "pc1"})
   end
 end
 
@@ -27,12 +28,9 @@ RSpec.configure do |c|
     puppet_module_install(:source => proj_root, :module_name => 'opendaylight')
     hosts.each do |host|
       # Install stdlib, a dependency of the odl mod
-      # TODO: Why is 1 an acceptable exit code?
-      on host, puppet('module', 'install', 'puppetlabs-stdlib'), { :acceptable_exit_codes => [0,1] }
-      # Install archive, a dependency of the odl mod use for tarball-type installs
-      on host, puppet('module', 'install', 'camptocamp-archive'), { :acceptable_exit_codes => [0] }
-      # Install Java Puppet mod, a dependency of the tarball install method
-      on host, puppet('module', 'install', 'puppetlabs-java'), { :acceptable_exit_codes => [0] }
+      on host, puppet('module', 'install', 'puppetlabs-stdlib'), { :acceptable_exit_codes => [0] }
+      # Install apt, a dependency of the deb install method
+      on host, puppet('module', 'install', 'puppetlabs-apt'), { :acceptable_exit_codes => [0] }
     end
   end
 end
@@ -47,43 +45,82 @@ end
 #   http://serverspec.org/resource_types.html
 
 def install_odl(options = {})
+  # Install params are passed via environment var, set in Rakefile
+  # Changing the installed version of ODL via `puppet apply` is not supported
+  # by puppet-odl, so it's not possible to vary these params in the same
+  # Beaker test run. Do a different run passing different env vars.
+  rpm_repo = ENV['RPM_REPO']
+  deb_repo = ENV['DEB_REPO']
+
   # NB: These param defaults should match the ones used by the opendaylight
   #   class, which are defined in opendaylight::params
   # TODO: Remove this possible source of bugs^^
   # Extract params if given, defaulting to odl class defaults if not
-  # Default install method is passed via environment var, set in Rakefile
-  install_method = options.fetch(:install_method, ENV['INSTALL_METHOD'])
-  extra_features = options.fetch(:extra_features, [])
-  default_features = options.fetch(:default_features,
-    ['config', 'standard', 'region', 'package', 'kar', 'ssh', 'management'])
-  odl_rest_port = options.fetch(:odl_rest_port, 8080)
+  extra_features = options.fetch(:extra_features, ['odl-restconf'])
+  default_features = options.fetch(:default_features, ['standard', 'wrap', 'ssh'])
+  odl_rest_port = options.fetch(:odl_rest_port, 8181)
+  odl_bind_ip = options.fetch(:odl_bind_ip, '0.0.0.0')
+  log_levels = options.fetch(:log_levels, {})
+  enable_ha = options.fetch(:enable_ha, false)
+  ha_node_ips = options.fetch(:ha_node_ips, [])
+  ha_node_index = options.fetch(:ha_node_index, 0)
+  ha_db_modules = options.fetch(:ha_db_modules, { 'default' => false })
+  username = options.fetch(:username, 'admin')
+  password = options.fetch(:password, 'admin')
+  log_max_size = options.fetch(:log_max_size, '10GB')
+  log_max_rollover = options.fetch(:log_max_rollover, 2)
+  log_rollover_fileindex = options.fetch(:log_rollover_fileindex, 'min')
+  snat_mechanism = options.fetch(:snat_mechanism, 'controller')
+  enable_tls = options.fetch(:enable_tls, false)
+  tls_keystore_password = options.fetch(:tls_keystore_password, 'dummypass')
+  log_mechanism = options.fetch(:log_mechanism, 'file')
+  inherit_dscp_marking = options.fetch(:inherit_dscp_marking, false)
+  stats_polling_enabled = options.fetch(:stats_polling_enabled, false)
 
   # Build script for consumption by Puppet apply
   it 'should work idempotently with no errors' do
     pp = <<-EOS
     class { 'opendaylight':
-      install_method => #{install_method},
+      rpm_repo => '#{rpm_repo}',
+      deb_repo => '#{deb_repo}',
       default_features => #{default_features},
       extra_features => #{extra_features},
-      odl_rest_port=> #{odl_rest_port},
+      odl_rest_port => #{odl_rest_port},
+      odl_bind_ip => '#{odl_bind_ip}',
+      enable_ha => #{enable_ha},
+      ha_node_ips => #{ha_node_ips},
+      ha_node_index => #{ha_node_index},
+      ha_db_modules => #{ha_db_modules},
+      log_levels => #{log_levels},
+      username => #{username},
+      password => #{password},
+      log_max_size => '#{log_max_size}',
+      log_max_rollover => #{log_max_rollover},
+      log_rollover_fileindex => #{log_rollover_fileindex},
+      snat_mechanism => #{snat_mechanism},
+      enable_tls => #{enable_tls},
+      tls_keystore_password => #{tls_keystore_password},
+      log_mechanism => #{log_mechanism},
+      inherit_dscp_marking => #{inherit_dscp_marking},
+      stats_polling_enabled => #{stats_polling_enabled},
     }
     EOS
 
     # Apply our Puppet manifest on the Beaker host
     apply_manifest(pp, :catch_failures => true)
 
-    # The tarball extract isn't idempotent, can't do this check
-    # See: https://github.com/dfarrell07/puppet-opendaylight/issues/45#issuecomment-78135725
-    if install_method != 'tarball'
-      # Run it twice to test for idempotency
-      apply_manifest(pp, :catch_changes  => true)
+    # Not checking for idempotence because of false failures
+    # related to package manager cache updates outputting to
+    # stdout and different IDs for the puppet manifest apply.
+    # I think this is a limitation in how Beaker can check
+    # for changes, not a problem with the Puppet module.
     end
-  end
 end
 
 # Shared function that handles generic validations
 # These should be common for all odl class param combos
-def generic_validations()
+def generic_validations(options = {})
+  java_opts = options.fetch(:java_opts, [])
   # Verify ODL's directory
   describe file('/opt/opendaylight/') do
     it { should be_directory }
@@ -95,10 +132,10 @@ def generic_validations()
   describe service('opendaylight') do
     it { should be_enabled }
     it { should be_enabled.with_level(3) }
-    it { should be_running }
+    it { should be_running.under('systemd') }
   end
 
-  # Creation handled by RPM, or Puppet during tarball installs
+  # Creation handled by RPM or Deb
   describe user('odl') do
     it { should exist }
     it { should belong_to_group 'odl' }
@@ -111,7 +148,7 @@ def generic_validations()
     it { should have_home_directory '/opt/opendaylight' }
   end
 
-  # Creation handled by RPM, or Puppet during tarball installs
+  # Creation handled by RPM or Deb
   describe group('odl') do
     it { should exist }
   end
@@ -127,9 +164,44 @@ def generic_validations()
     it { should be_running }
   end
 
-  # Validations specific to the host OS
-  if ['centos-7', 'fedora-20', 'fedora-21'].include? ENV['RS_SET']
-    # Validations for Red Hat family OSs
+  # Should contain Karaf features config file
+  describe file('/opt/opendaylight/etc/org.apache.karaf.features.cfg') do
+    it { should be_file }
+    it { should be_owned_by 'odl' }
+    it { should be_grouped_into 'odl' }
+  end
+
+  odl_bind_ip = options.fetch(:odl_bind_ip, '127.0.0.1')
+  if odl_bind_ip == '127.0.0.1'
+    java_options = ['-Djava.net.preferIPv4Stack=true'] + java_opts
+  else
+    java_options = ['-Djava.net.preferIPv6Addresses=true'] + java_opts
+  end
+
+  # Should contain karaf file with Java options set
+  describe file('/opt/opendaylight/bin/karaf') do
+    it { should be_file }
+    it { should be_owned_by 'odl' }
+    it { should be_grouped_into 'odl' }
+    its(:content) { should match /^EXTRA_JAVA_OPTS=#{java_options.join(" ")}/ }
+  end
+
+  # Should contain ODL NB port config file
+  describe file('/opt/opendaylight/etc/jetty.xml') do
+    it { should be_file }
+    it { should be_owned_by 'odl' }
+    it { should be_grouped_into 'odl' }
+  end
+
+  # Should contain log level config file
+  describe file('/opt/opendaylight/etc/org.ops4j.pax.logging.cfg') do
+    it { should be_file }
+    it { should be_owned_by 'odl' }
+    it { should be_grouped_into 'odl' }
+  end
+
+  if ['centos-7', 'centos-7-docker'].include? ENV['RS_SET']
+    # Validations for modern Red Hat family OSs
 
     # Verify ODL systemd .service file
     describe file('/usr/lib/systemd/system/opendaylight.service') do
@@ -139,38 +211,68 @@ def generic_validations()
       it { should be_mode '644' }
     end
 
-    # Java 7 should be installed
-    describe package('java-1.7.0-openjdk') do
+    # Java 8 should be installed
+    describe package('java-1.8.0-openjdk') do
       it { should be_installed }
     end
-  elsif ENV['RS_SET'] == 'ubuntu-1404'
-    # Ubuntu-specific validations
 
-    # Verify ODL Upstart config file
-    describe file('/etc/init/opendaylight.conf') do
+  # Ubuntu 16.04 specific validation
+  elsif ['ubuntu-16', 'ubuntu-16-docker'].include? ENV['RS_SET']
+
+    # Verify ODL systemd .service file
+    describe file('/lib/systemd/system/opendaylight.service') do
       it { should be_file }
       it { should be_owned_by 'root' }
       it { should be_grouped_into 'root' }
       it { should be_mode '644' }
     end
 
-    # Java 7 should be installed
-    describe package('openjdk-7-jdk') do
+    # Java 8 should be installed
+    describe package('openjdk-8-jre-headless') do
       it { should be_installed }
     end
+
   else
     fail("Unexpected RS_SET (host OS): #{ENV['RS_SET']}")
   end
 end
 
+# Shared function for validations related to log file settings
+def log_settings_validations(options = {})
+  # Should contain log level config file with correct file size and rollover values
+  log_max_size = options.fetch(:log_max_size, '10GB')
+  log_max_rollover = options.fetch(:log_max_rollover, 2)
+  log_rollover_fileindex = options.fetch(:log_rollover_fileindex, 'min')
+  log_mechanism = options.fetch(:log_mechanism, 'file')
+
+  if log_mechanism == 'console'
+    describe file('/opt/opendaylight/etc/org.ops4j.pax.logging.cfg') do
+      it { should be_file }
+      it { should be_owned_by 'odl' }
+      it { should be_grouped_into 'odl' }
+      its(:content) { should match /^karaf.log.console=INFO/ }
+      its(:content) { should match /^log4j2.appender.console.direct = true/ }
+    end
+  else
+    describe file('/opt/opendaylight/etc/org.ops4j.pax.logging.cfg') do
+      it { should be_file }
+      it { should be_owned_by 'odl' }
+      it { should be_grouped_into 'odl' }
+      its(:content) { should match /^log4j2.appender.rolling.policies.size.size = #{log_max_size}/ }
+      its(:content) { should match /^log4j2.appender.rolling.strategy.type = DefaultRolloverStrategy/ }
+      its(:content) { should match /^log4j2.appender.rolling.strategy.max = #{log_max_rollover}/ }
+      its(:content) { should match /^log4j2.appender.rolling.strategy.fileIndex = #{log_rollover_fileindex}/ }
+    end
+  end
+end
+
 # Shared function for validations related to the Karaf config file
 def karaf_config_validations(options = {})
   # NB: These param defaults should match the ones used by the opendaylight
   #   class, which are defined in opendaylight::params
   # TODO: Remove this possible source of bugs^^
   extra_features = options.fetch(:extra_features, [])
-  default_features = options.fetch(:default_features, ['config', 'standard', 'region',
-                                  'package', 'kar', 'ssh', 'management'])
+  default_features = options.fetch(:default_features, ['standard', 'wrap', 'ssh'])
 
   # Create one list of all of the features
   features = default_features + extra_features
@@ -188,19 +290,158 @@ def port_config_validations(options = {})
   # NB: This param default should match the one used by the opendaylight
   #   class, which is defined in opendaylight::params
   # TODO: Remove this possible source of bugs^^
-  odl_rest_port = options.fetch(:odl_rest_port, 8080)
+  odl_rest_port = options.fetch(:odl_rest_port, 8181)
+
+  describe file('/opt/opendaylight/etc/jetty.xml') do
+    it { should be_file }
+    it { should be_owned_by 'odl' }
+    it { should be_grouped_into 'odl' }
+    its(:content) { should match /Property name="jetty.port" default="#{odl_rest_port}"/ }
+  end
 
-  describe file('/opt/opendaylight/configuration/tomcat-server.xml') do
+  describe file('/opt/opendaylight/etc/org.ops4j.pax.web.cfg') do
     it { should be_file }
     it { should be_owned_by 'odl' }
     it { should be_grouped_into 'odl' }
-    its(:content) { should match /Connector port="#{odl_rest_port}"/ }
+    its(:content) { should match /org.osgi.service.http.port = #{odl_rest_port}/ }
   end
 end
 
+# Shared function for validations related to the ODL bind IP
+def odl_bind_ip_validation(options = {})
+  # NB: This param default should match the one used by the opendaylight
+  #   class, which is defined in opendaylight::params
+  # TODO: Remove this possible source of bugs^^
+  odl_bind_ip = options.fetch(:odl_bind_ip, '0.0.0.0')
+
+  if odl_bind_ip != '0.0.0.0'
+    describe file('/opt/opendaylight/etc/org.apache.karaf.shell.cfg') do
+      it { should be_file }
+      it { should be_owned_by 'odl' }
+      it { should be_grouped_into 'odl' }
+      its(:content) { should match /sshHost = #{odl_bind_ip}/ }
+    end
+
+    describe file('/opt/opendaylight/etc/org.opendaylight.ovsdb.library.cfg') do
+      it { should be_file }
+      it { should be_owned_by 'odl' }
+      it { should be_grouped_into 'odl' }
+      its(:content) { should match /ovsdb-listener-ip = #{odl_bind_ip}/ }
+    end
+
+    describe file('/opt/opendaylight/etc/opendaylight/datastore/initial/config/default-openflow-connection-config.xml') do
+      it { should be_file }
+      it { should be_owned_by 'odl' }
+      it { should be_grouped_into 'odl' }
+      its(:content) { should match /<address>#{odl_bind_ip}<\/address>/ }
+    end
+
+    describe command("loop_count=0; until [[ \$loop_count -ge 30 ]]; do netstat -punta | grep 8101 | grep #{odl_bind_ip} && break; loop_count=\$[\$loop_count+1]; sleep 1; done; echo \"Waited \$loop_count seconds to detect ODL karaf bound to IP\"") do
+      its(:exit_status) { should eq 0 }
+    end
+
+    describe command("loop_count=0; until [[ \$loop_count -ge 60 ]]; do netstat -punta | grep 6653 | grep #{odl_bind_ip} && break; loop_count=\$[\$loop_count+1]; sleep 1; done; echo \"Waited \$loop_count seconds to detect ODL karaf bound to IP\"") do
+      its(:exit_status) { should eq 0 }
+    end
+
+    describe command("loop_count=0; until [[ \$loop_count -ge 60 ]]; do netstat -punta | grep 6640 | grep #{odl_bind_ip} && break; loop_count=\$[\$loop_count+1]; sleep 1; done; echo \"Waited \$loop_count seconds to detect ODL karaf bound to IP\"") do
+      its(:exit_status) { should eq 0 }
+    end
+  end
+end
+
+# Shared function for validations related to custom logging verbosity
+def log_level_validations(options = {})
+  # NB: This param default should match the one used by the opendaylight
+  #   class, which is defined in opendaylight::params
+  # TODO: Remove this possible source of bugs^^
+  log_levels = options.fetch(:log_levels, {})
+
+  if log_levels.empty?
+    # Should contain log level config file
+    describe file('/opt/opendaylight/etc/org.ops4j.pax.logging.cfg') do
+      it { should be_file }
+      it { should be_owned_by 'odl' }
+      it { should be_grouped_into 'odl' }
+    end
+  else
+    # Should contain log level config file
+    describe file('/opt/opendaylight/etc/org.ops4j.pax.logging.cfg') do
+      it { should be_file }
+      it { should be_owned_by 'odl' }
+      it { should be_grouped_into 'odl' }
+    end
+    # Verify each custom log level config entry
+    log_levels.each_pair do |logger, level|
+      underscored_version = "#{logger}".gsub('.', '_')
+      describe file('/opt/opendaylight/etc/org.ops4j.pax.logging.cfg') do
+        it { should be_file }
+        it { should be_owned_by 'odl' }
+        it { should be_grouped_into 'odl' }
+        its(:content) { should match /^log4j2.logger.#{underscored_version}.level = #{level}/ }
+        its(:content) { should match /^log4j2.logger.#{underscored_version}.name = #{logger}/ }
+      end
+    end
+  end
+end
+
+# Shared function for validations related to ODL OVSDB HA config
+def enable_ha_validations(options = {})
+  # NB: This param default should match the one used by the opendaylight
+  #   class, which is defined in opendaylight::params
+  # TODO: Remove this possible source of bugs^^
+  enable_ha = options.fetch(:enable_ha, false)
+  ha_node_ips = options.fetch(:ha_node_ips, [])
+  odl_bind_ip = options.fetch(:odl_bind_ip, '0.0.0.0')
+  ha_db_modules = options.fetch(:ha_db_modules, { 'default' => false })
+  # HA_NODE_IPS size
+  ha_node_count = ha_node_ips.size
+
+  if (enable_ha) && (ha_node_count < 2)
+    # Check for HA_NODE_COUNT < 2
+    fail("Number of HA nodes less than 2: #{ha_node_count} and HA Enabled")
+  end
+
+  if enable_ha
+    ha_node_index = ha_node_ips.index(odl_bind_ip)
+    describe file('/opt/opendaylight/configuration/initial/akka.conf') do
+      it { should be_file }
+      it { should be_owned_by 'odl' }
+      it { should be_grouped_into 'odl' }
+      its(:content) { should match /roles\s*=\s*\["member-#{ha_node_index}"\]/ }
+    end
+
+    ha_db_modules.each do |mod, urn|
+      describe file('/opt/opendaylight/configuration/initial/module-shards.conf') do
+        it { should be_file }
+        it { should be_owned_by 'odl' }
+        it { should be_grouped_into 'odl' }
+        its(:content) { should match /name = "#{mod}"/ }
+      end
+
+      if mod == 'default'
+        describe file('/opt/opendaylight/configuration/initial/modules.conf') do
+          it { should be_file }
+          it { should be_owned_by 'odl' }
+          it { should be_grouped_into 'odl' }
+        end
+      else
+        describe file('/opt/opendaylight/configuration/initial/modules.conf') do
+          it { should be_file }
+          it { should be_owned_by 'odl' }
+          it { should be_grouped_into 'odl' }
+          its(:content) { should match /name = "#{mod}"/ }
+          its(:content) { should match /namespace = "#{urn}"/ }
+        end
+      end
+    end
+  end
+end
 
 # Shared function that handles validations specific to RPM-type installs
 def rpm_validations()
+  rpm_repo = ENV['RPM_REPO']
+
   describe yumrepo('opendaylight') do
     it { should exist }
     it { should be_enabled }
@@ -211,14 +452,179 @@ def rpm_validations()
   end
 end
 
-# Shared function that handles validations specific to tarball-type installs
-def tarball_validations()
-  describe yumrepo('opendaylight') do
-    it { should_not exist }
-    it { should_not be_enabled }
+# Shared function that handles validations specific to Deb-type installs
+def deb_validations()
+  deb_repo = ENV['DEB_REPO']
+  # Check ppa
+  # Docs: http://serverspec.org/resource_types.html#ppa
+  describe ppa(deb_repo) do
+    it { should exist }
+    it { should be_enabled }
   end
 
   describe package('opendaylight') do
-    it { should_not be_installed }
+    it { should be_installed }
+  end
+end
+
+# Shared function for validations related to username/password
+def username_password_validations(options = {})
+  # NB: This param default should match the one used by the opendaylight
+  #   class, which is defined in opendaylight::params
+  # TODO: Remove this possible source of bugs^^
+  odl_username = options.fetch(:username, 'admin')
+  odl_password = options.fetch(:password, 'admin')
+  odl_check_url = 'http://127.0.0.1:8181/restconf'
+
+  describe file('/opt/opendaylight/data/idmlight.db.mv.db') do
+    it { should be_file }
+  end
+
+  describe command("loop_count=0; until [[ \$loop_count -ge 300 ]]; do curl -o /dev/null --fail --silent --head -u #{odl_username}:#{odl_password} #{odl_check_url} && break; loop_count=\$[\$loop_count+1]; sleep 1; done; echo \"Waited \$loop_count seconds for ODL to become active\"") do
+    its(:exit_status) { should eq 0 }
+  end
+
+  describe command("curl -o /dev/null --fail --silent --head -u #{odl_username}:#{odl_password} #{odl_check_url}") do
+    its(:exit_status) { should eq 0 }
+  end
+end
+
+# Shared function for validations related to the SNAT config file
+def snat_mechanism_validations(options = {})
+  # NB: This param default should match the one used by the opendaylight
+  #   class, which is defined in opendaylight::params
+  # TODO: Remove this possible source of bugs^^
+  snat_mechanism = options.fetch(:snat_mechanism, 'controller')
+
+  describe file('/opt/opendaylight/etc/opendaylight/datastore/initial/config/netvirt-natservice-config.xml') do
+    it { should be_file }
+    it { should be_owned_by 'odl' }
+    it { should be_grouped_into 'odl' }
+    its(:content) { should match /<nat-mode>#{snat_mechanism}<\/nat-mode>/ }
+  end
+end
+
+# Shared function for validations related to SFC
+def sfc_validations(options = {})
+  # NB: This param default should match the one used by the opendaylight
+  #   class, which is defined in opendaylight::params
+  # TODO: Remove this possible source of bugs^^
+
+  extra_features = options.fetch(:extra_features, [])
+  if extra_features.include? 'odl-netvirt-sfc'
+    sfc_enabled = true
+  else
+    sfc_enabled = false
+  end
+
+  describe file('/opt/opendaylight/etc/opendaylight/datastore/initial/config/genius-itm-config.xml') do
+    it { should be_file }
+    it { should be_owned_by 'odl' }
+    it { should be_grouped_into 'odl' }
+    its(:content) { should match /<gpe-extension-enabled>#{sfc_enabled}<\/gpe-extension-enabled>/ }
+  end
+end
+
+# Shared function for validations related to tos value for DSCP marking
+def dscp_validations(options = {})
+  # NB: This param default should match the one used by the opendaylight
+  #   class, which is defined in opendaylight::params
+  # TODO: Remove this possible source of bugs^^
+
+  inherit_dscp_marking = options.fetch(:inherit_dscp_marking, false)
+
+  if inherit_dscp_marking
+    describe file('/opt/opendaylight/etc/opendaylight/datastore/initial/config/genius-itm-config.xml') do
+      it { should be_file }
+      it { should be_owned_by 'odl' }
+      it { should be_grouped_into 'odl' }
+      its(:content) { should match /<default-tunnel-tos>inherit<\/default-tunnel-tos>/ }
+    end
+  end
+end
+
+def websocket_address_validations(options = {})
+  # NB: This param default should match the one used by the opendaylight
+  #   class, which is defined in opendaylight::params
+  # TODO: Remove this possible source of bugs^^
+  odl_bind_ip = options.fetch(:odl_bind_ip, '0.0.0.0')
+
+  if not odl_bind_ip.eql? '0.0.0.0'
+    describe file('/opt/opendaylight/etc/org.opendaylight.restconf.cfg') do
+      it { should be_file }
+      it { should be_owned_by 'odl' }
+      it { should be_grouped_into 'odl' }
+      its(:content) { should match /^websocket-address=#{odl_bind_ip}/ }
+    end
+  else
+    describe file('/opt/opendaylight/etc/org.opendaylight.restconf.cfg') do
+      it { should be_file }
+    end
+  end
+end
+
+def tls_validations(options = {})
+  # NB: This param default should match the one used by the opendaylight
+  #   class, which is defined in opendaylight::params
+  # TODO: Remove this possible source of bugs^^
+  tls_keystore_password = options.fetch(:tls_keystore_password)
+  odl_rest_port = options.fetch(:odl_rest_port, 8181)
+
+  describe file('/opt/opendaylight/etc/org.ops4j.pax.web.cfg') do
+    it { should be_file }
+    it { should be_owned_by 'odl' }
+    it { should be_grouped_into 'odl' }
+    its(:content) { should match /org.osgi.service.http.port.secure = #{odl_rest_port}/ }
+    its(:content) { should match /org.ops4j.pax.web.ssl.keystore = configuration\/ssl\/ctl.jks/ }
+    its(:content) { should match /org.ops4j.pax.web.ssl.password = #{tls_keystore_password}/ }
+    its(:content) { should match /org.ops4j.pax.web.ssl.keypassword = #{tls_keystore_password}/ }
+    its(:content) { should match /org.osgi.service.http.secure.enabled = true/ }
+    its(:content) { should match /org.osgi.service.http.enabled = false/ }
+  end
+
+  describe file('/opt/opendaylight/etc/org.opendaylight.ovsdb.library.cfg') do
+    it { should be_file }
+    it { should be_owned_by 'odl' }
+    it { should be_grouped_into 'odl' }
+    its(:content) { should match /use-ssl = true/ }
+  end
+
+  describe file('/opt/opendaylight/etc/opendaylight/datastore/initial/config/default-openflow-connection-config.xml') do
+    it { should be_file }
+    it { should be_owned_by 'odl' }
+    it { should be_grouped_into 'odl' }
+    its(:content) { should match /<keystore-password>#{tls_keystore_password}<\/keystore-password>/ }
+    its(:content) { should match /<truststore-password>#{tls_keystore_password}<\/truststore-password>/ }
+    its(:content) { should match /<transport-protocol>TLS<\/transport-protocol>/ }
+  end
+
+  describe file('/opt/opendaylight/etc/opendaylight/datastore/initial/config/aaa-cert-config.xml') do
+    it { should be_file }
+    it { should be_owned_by 'odl' }
+    it { should be_grouped_into 'odl' }
+    its(:content) { should match /<store-password>#{tls_keystore_password}<\/store-password>/ }
+    its(:content) { should match /<use-mdsal>false<\/use-mdsal>/ }
+  end
+
+  describe file('/opt/opendaylight/etc/jetty.xml') do
+    it { should be_file }
+    it { should be_owned_by 'odl' }
+    it { should be_grouped_into 'odl' }
+    its(:content) { should match /<Property name="jetty.secure.port" default="#{odl_rest_port}" \/>/ }
+  end
+end
+
+# Shared function for validations related to OVS statistics polling
+def stats_polling_validations(options = {})
+  # NB: This param default should match the one used by the opendaylight
+  #   class, which is defined in opendaylight::params
+  # TODO: Remove this possible source of bugs^^
+
+  stats_polling_enabled = options.fetch(:stats_polling_enabled, false)
+  describe file('/opt/opendaylight/etc/org.opendaylight.openflowplugin.cfg') do
+    it { should be_file }
+    it { should be_owned_by 'odl' }
+    it { should be_grouped_into 'odl' }
+    its(:content) { should match /is-statistics-polling-on=#{stats_polling_enabled}/ }
   end
 end