X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=tapi%2Fsrc%2Ftest%2Fjava%2Forg%2Fopendaylight%2Ftransportpce%2Ftapi%2Ftopology%2FConvertORTopoToTapiTopoTest.java;h=b017dd0c62f44ecb1cc8ec0c6a4f25eb29051b82;hb=0830b49ed1456d51538f90b1237e16b4bb8ca741;hp=6f1789305ffc7bad6af39272cd5b53ee2bca831e;hpb=db48b1e815c4f74a008f98f015fffe1bf0a052ca;p=transportpce.git diff --git a/tapi/src/test/java/org/opendaylight/transportpce/tapi/topology/ConvertORTopoToTapiTopoTest.java b/tapi/src/test/java/org/opendaylight/transportpce/tapi/topology/ConvertORTopoToTapiTopoTest.java index 6f1789305..b017dd0c6 100644 --- a/tapi/src/test/java/org/opendaylight/transportpce/tapi/topology/ConvertORTopoToTapiTopoTest.java +++ b/tapi/src/test/java/org/opendaylight/transportpce/tapi/topology/ConvertORTopoToTapiTopoTest.java @@ -12,9 +12,9 @@ import static org.hamcrest.CoreMatchers.either; import static org.hamcrest.CoreMatchers.hasItem; import static org.hamcrest.CoreMatchers.hasItems; import static org.hamcrest.MatcherAssert.assertThat; -import static org.junit.Assert.assertEquals; -import static org.junit.Assert.assertNull; -import static org.junit.Assert.fail; +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertNull; +import static org.junit.jupiter.api.Assertions.fail; import com.google.common.util.concurrent.FluentFuture; import java.nio.charset.Charset; @@ -28,26 +28,26 @@ import java.util.UUID; import java.util.concurrent.ExecutionException; import java.util.stream.Collectors; import org.eclipse.jdt.annotation.Nullable; -import org.junit.BeforeClass; -import org.junit.Test; +import org.junit.jupiter.api.BeforeAll; +import org.junit.jupiter.api.Test; import org.opendaylight.mdsal.binding.api.DataBroker; import org.opendaylight.mdsal.common.api.LogicalDatastoreType; import org.opendaylight.transportpce.common.InstanceIdentifiers; import org.opendaylight.transportpce.common.network.NetworkTransactionImpl; import org.opendaylight.transportpce.common.network.NetworkTransactionService; -import org.opendaylight.transportpce.common.network.RequestProcessor; import org.opendaylight.transportpce.tapi.TapiStringConstants; import org.opendaylight.transportpce.tapi.utils.TapiLink; +import org.opendaylight.transportpce.tapi.utils.TapiLinkImpl; import org.opendaylight.transportpce.tapi.utils.TapiTopologyDataUtils; import org.opendaylight.transportpce.test.AbstractTest; import org.opendaylight.transportpce.test.utils.TopologyDataUtils; -import org.opendaylight.yang.gen.v1.http.org.openroadm.common.network.rev200529.Link1; -import org.opendaylight.yang.gen.v1.http.org.openroadm.common.network.rev200529.Link1Builder; -import org.opendaylight.yang.gen.v1.http.org.openroadm.common.network.rev200529.TerminationPoint1; -import org.opendaylight.yang.gen.v1.http.org.openroadm.common.network.rev200529.TerminationPoint1Builder; +import org.opendaylight.yang.gen.v1.http.org.openroadm.common.network.rev230526.Link1; +import org.opendaylight.yang.gen.v1.http.org.openroadm.common.network.rev230526.Link1Builder; +import org.opendaylight.yang.gen.v1.http.org.openroadm.common.network.rev230526.TerminationPoint1; +import org.opendaylight.yang.gen.v1.http.org.openroadm.common.network.rev230526.TerminationPoint1Builder; import org.opendaylight.yang.gen.v1.http.org.openroadm.common.state.types.rev191129.State; import org.opendaylight.yang.gen.v1.http.org.openroadm.equipment.states.types.rev191129.AdminStates; -import org.opendaylight.yang.gen.v1.http.org.openroadm.network.types.rev200529.OpenroadmTpType; +import org.opendaylight.yang.gen.v1.http.org.openroadm.network.types.rev230526.OpenroadmTpType; import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.network.rev180226.NetworkId; import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.network.rev180226.Networks; import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.network.rev180226.NodeId; @@ -63,41 +63,43 @@ import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.network.top import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.network.topology.rev180226.networks.network.node.TerminationPoint; import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.network.topology.rev180226.networks.network.node.TerminationPointBuilder; import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.network.topology.rev180226.networks.network.node.TerminationPointKey; -import org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.common.rev181210.AdministrativeState; -import org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.common.rev181210.CapacityUnit; -import org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.common.rev181210.ForwardingDirection; -import org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.common.rev181210.LayerProtocolName; -import org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.common.rev181210.LifecycleState; -import org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.common.rev181210.OperationalState; -import org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.common.rev181210.PortDirection; -import org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.common.rev181210.PortRole; -import org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.common.rev181210.TerminationDirection; -import org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.common.rev181210.TerminationState; -import org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.common.rev181210.Uuid; -import org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.common.rev181210.global._class.Name; -import org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.common.rev181210.global._class.NameKey; -import org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.dsr.rev181210.DIGITALSIGNALTYPE100GigE; -import org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.dsr.rev181210.DIGITALSIGNALTYPE10GigELAN; -import org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.odu.rev181210.ODUTYPEODU2; -import org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.odu.rev181210.ODUTYPEODU2E; -import org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.odu.rev181210.ODUTYPEODU4; -import org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.photonic.media.rev181210.PHOTONICLAYERQUALIFIEROMS; -import org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.photonic.media.rev181210.PHOTONICLAYERQUALIFIEROTSi; -import org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.topology.rev181210.ForwardingRule; -import org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.topology.rev181210.RuleType; -import org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.topology.rev181210.node.NodeRuleGroup; -import org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.topology.rev181210.node.OwnedNodeEdgePoint; -import org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.topology.rev181210.node.OwnedNodeEdgePointKey; -import org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.topology.rev181210.node.edge.point.MappedServiceInterfacePointKey; -import org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.topology.rev181210.node.rule.group.NodeEdgePoint; -import org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.topology.rev181210.node.rule.group.Rule; -import org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.topology.rev181210.topology.Link; +import org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.common.rev221121.AdministrativeState; +import org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.common.rev221121.CAPACITYUNITGBPS; +import org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.common.rev221121.Direction; +import org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.common.rev221121.ForwardingDirection; +import org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.common.rev221121.LAYERPROTOCOLQUALIFIER; +import org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.common.rev221121.LayerProtocolName; +import org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.common.rev221121.LifecycleState; +import org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.common.rev221121.OperationalState; +import org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.common.rev221121.PortRole; +import org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.common.rev221121.Uuid; +import org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.common.rev221121.global._class.Name; +import org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.common.rev221121.global._class.NameKey; +import org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.digital.otn.rev221121.ODUTYPEODU2; +import org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.digital.otn.rev221121.ODUTYPEODU2E; +import org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.digital.otn.rev221121.ODUTYPEODU4; +import org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.dsr.rev221121.DIGITALSIGNALTYPE100GigE; +import org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.dsr.rev221121.DIGITALSIGNALTYPE10GigELAN; +import org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.photonic.media.rev221121.PHOTONICLAYERQUALIFIEROMS; +import org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.photonic.media.rev221121.PHOTONICLAYERQUALIFIEROTS; +import org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.photonic.media.rev221121.PHOTONICLAYERQUALIFIEROTSi; +import org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.topology.rev221121.FORWARDINGRULEMAYFORWARDACROSSGROUP; +import org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.topology.rev221121.RuleType; +import org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.topology.rev221121.node.NodeRuleGroup; +import org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.topology.rev221121.node.OwnedNodeEdgePoint; +import org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.topology.rev221121.node.OwnedNodeEdgePointKey; +import org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.topology.rev221121.node.edge.point.MappedServiceInterfacePointKey; +import org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.topology.rev221121.node.edge.point.SupportedCepLayerProtocolQualifierInstances; +import org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.topology.rev221121.node.rule.group.NodeEdgePoint; +import org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.topology.rev221121.node.rule.group.Rule; +import org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.topology.rev221121.topology.Link; import org.opendaylight.yangtools.yang.binding.InstanceIdentifier; -import org.opendaylight.yangtools.yang.binding.KeyedInstanceIdentifier; +import org.opendaylight.yangtools.yang.common.Decimal64; import org.opendaylight.yangtools.yang.common.Uint64; import org.slf4j.Logger; import org.slf4j.LoggerFactory; + public class ConvertORTopoToTapiTopoTest extends AbstractTest { private static final Logger LOG = LoggerFactory.getLogger(ConvertORTopoToTapiTopoTest.class); @@ -112,64 +114,73 @@ public class ConvertORTopoToTapiTopoTest extends AbstractTest { private static TapiLink tapiLink; private static DataBroker dataBroker = getDataBroker(); - @BeforeClass - public static void setUp() throws InterruptedException, ExecutionException { - TopologyDataUtils.writeTopologyFromFileToDatastore(getDataStoreContextUtil(), - TapiTopologyDataUtils.OPENROADM_TOPOLOGY_FILE, InstanceIdentifiers.OVERLAY_NETWORK_II); - TopologyDataUtils.writeTopologyFromFileToDatastore(getDataStoreContextUtil(), - TapiTopologyDataUtils.OTN_TOPOLOGY_FILE, InstanceIdentifiers.OTN_NETWORK_II); - TopologyDataUtils.writePortmappingFromFileToDatastore(getDataStoreContextUtil(), + @BeforeAll + static void setUp() throws InterruptedException, ExecutionException { + TopologyDataUtils.writeTopologyFromFileToDatastore( + getDataStoreContextUtil(), + TapiTopologyDataUtils.OPENROADM_TOPOLOGY_FILE, + InstanceIdentifiers.OVERLAY_NETWORK_II); + TopologyDataUtils.writeTopologyFromFileToDatastore( + getDataStoreContextUtil(), + TapiTopologyDataUtils.OTN_TOPOLOGY_FILE, + InstanceIdentifiers.OTN_NETWORK_II); + TopologyDataUtils.writePortmappingFromFileToDatastore( + getDataStoreContextUtil(), TapiTopologyDataUtils.PORTMAPPING_FILE); - - KeyedInstanceIdentifier muxAIID = InstanceIdentifier.create(Networks.class) - .child(org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.network.rev180226.networks.Network - .class, new NetworkKey(new NetworkId("otn-topology"))) - .child(Node.class, new NodeKey(new NodeId("SPDR-SA1-XPDR1"))); FluentFuture> muxAFuture = dataBroker.newReadOnlyTransaction() - .read(LogicalDatastoreType.CONFIGURATION, muxAIID); - KeyedInstanceIdentifier muxCIID = InstanceIdentifier.create(Networks.class) - .child(org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.network.rev180226.networks.Network - .class, new NetworkKey(new NetworkId("otn-topology"))) - .child(Node.class, new NodeKey(new NodeId("SPDR-SC1-XPDR1"))); - FluentFuture> muxCFuture = dataBroker.newReadOnlyTransaction() - .read(LogicalDatastoreType.CONFIGURATION, muxCIID); - KeyedInstanceIdentifier switchIID = InstanceIdentifier.create(Networks.class) - .child(org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.network.rev180226.networks.Network - .class, new NetworkKey(new NetworkId("otn-topology"))) - .child(Node.class, new NodeKey(new NodeId("SPDR-SA1-XPDR2"))); - FluentFuture> switchFuture = dataBroker.newReadOnlyTransaction() - .read(LogicalDatastoreType.CONFIGURATION, switchIID); - - otnMuxA = muxAFuture.get().get(); - otnMuxC = muxCFuture.get().get(); - otnSwitch = switchFuture.get().get(); - - KeyedInstanceIdentifier tpdrIID = InstanceIdentifier.create(Networks.class) - .child(org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.network.rev180226.networks.Network - .class, new NetworkKey(new NetworkId("otn-topology"))) - .child(Node.class, new NodeKey(new NodeId("XPDR-A1-XPDR1"))); - FluentFuture> tpdrFuture = dataBroker.newReadOnlyTransaction() - .read(LogicalDatastoreType.CONFIGURATION, tpdrIID); - tpdr100G = tpdrFuture.get().get(); - - InstanceIdentifier linksIID = InstanceIdentifier.create(Networks.class) - .child(org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.network.rev180226.networks.Network - .class, new NetworkKey(new NetworkId("otn-topology"))) - .augmentation(Network1.class); + .read(LogicalDatastoreType.CONFIGURATION, + //muxAIID + InstanceIdentifier.create(Networks.class) + .child(org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.network.rev180226 + .networks.Network.class, + new NetworkKey(new NetworkId("otn-topology"))) + .child(Node.class, new NodeKey(new NodeId("SPDR-SA1-XPDR1")))); + FluentFuture> muxCFuture = + dataBroker.newReadOnlyTransaction().read(LogicalDatastoreType.CONFIGURATION, + //muxCIID + InstanceIdentifier.create(Networks.class) + .child(org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.network.rev180226 + .networks.Network.class, + new NetworkKey(new NetworkId("otn-topology"))) + .child(Node.class, new NodeKey(new NodeId("SPDR-SC1-XPDR1")))); + FluentFuture> switchFuture = + dataBroker.newReadOnlyTransaction().read(LogicalDatastoreType.CONFIGURATION, + //switchIID + InstanceIdentifier.create(Networks.class) + .child(org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.network.rev180226 + .networks.Network.class, + new NetworkKey(new NetworkId("otn-topology"))) + .child(Node.class, new NodeKey(new NodeId("SPDR-SA1-XPDR2")))); + otnMuxA = muxAFuture.get().orElseThrow(); + otnMuxC = muxCFuture.get().orElseThrow(); + otnSwitch = switchFuture.get().orElseThrow(); + FluentFuture> tpdrFuture = + dataBroker.newReadOnlyTransaction().read(LogicalDatastoreType.CONFIGURATION, + //tpdrIID + InstanceIdentifier.create(Networks.class) + .child(org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.network.rev180226 + .networks.Network.class, + new NetworkKey(new NetworkId("otn-topology"))) + .child(Node.class, new NodeKey(new NodeId("XPDR-A1-XPDR1")))); + tpdr100G = tpdrFuture.get().orElseThrow(); FluentFuture> linksFuture = dataBroker.newReadOnlyTransaction() - .read(LogicalDatastoreType.CONFIGURATION, linksIID); - otnLinks = linksFuture.get().get().getLink(); - - topologyUuid = new Uuid(UUID.nameUUIDFromBytes(TapiStringConstants.T0_MULTILAYER.getBytes( - Charset.forName("UTF-8"))).toString()); - networkTransactionService = new NetworkTransactionImpl( - new RequestProcessor(getDataStoreContextUtil().getDataBroker())); - tapiLink = new TapiLink(networkTransactionService); + .read(LogicalDatastoreType.CONFIGURATION, + //linksIID + InstanceIdentifier.create(Networks.class) + .child(org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.network.rev180226 + .networks.Network.class, + new NetworkKey(new NetworkId("otn-topology"))) + .augmentation(Network1.class)); + otnLinks = linksFuture.get().orElseThrow().getLink(); + topologyUuid = new Uuid(UUID.nameUUIDFromBytes(TapiStringConstants.T0_MULTILAYER + .getBytes(Charset.forName("UTF-8"))).toString()); + networkTransactionService = new NetworkTransactionImpl(getDataBroker()); + tapiLink = new TapiLinkImpl(networkTransactionService); LOG.info("TEST SETUP READY"); } @Test - public void convertNodeWhenNoStates() { + void convertNodeWhenNoStates() { Node tpdr = changeTerminationPointState(tpdr100G, "XPDR1-NETWORK1", null, null); List networkPortList = new ArrayList<>(); for (TerminationPoint tp : tpdr100G.augmentation(Node1.class).getTerminationPoint().values()) { @@ -177,160 +188,97 @@ public class ConvertORTopoToTapiTopoTest extends AbstractTest { networkPortList.add(tp.getTpId().getValue()); } } - ConvertORTopoToTapiTopo tapiFactory = new ConvertORTopoToTapiTopo(topologyUuid, tapiLink); + ConvertORToTapiTopology tapiFactory = new ConvertORToTapiTopology(topologyUuid); tapiFactory.convertNode(tpdr, networkPortList); - Uuid dsrNodeUuid = new Uuid(UUID.nameUUIDFromBytes("XPDR-A1-XPDR1+DSR".getBytes(Charset.forName("UTF-8"))) - .toString()); - org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.topology.rev181210.topology.Node dsrNode = tapiFactory - .getTapiNodes().get(new - org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.topology.rev181210.topology.NodeKey(dsrNodeUuid)); + Uuid dsrNodeUuid = new Uuid( + UUID.nameUUIDFromBytes("XPDR-A1-XPDR1+XPONDER".getBytes(Charset.forName("UTF-8"))).toString()); + var dsrNode = tapiFactory.getTapiNodes() + .get(new org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.topology.rev221121 + .topology.NodeKey(dsrNodeUuid)); Uuid networkNepUuid = new Uuid( UUID.nameUUIDFromBytes(("XPDR-A1-XPDR1+iODU+XPDR1-NETWORK1").getBytes(Charset.forName("UTF-8"))) .toString()); OwnedNodeEdgePoint nepN = dsrNode.nonnullOwnedNodeEdgePoint().get(new OwnedNodeEdgePointKey(networkNepUuid)); - assertNull("Administrative State should not be present", nepN.getAdministrativeState()); - assertNull("Operational State should not be present", nepN.getOperationalState()); - - Uuid otsiNodeUuid = new Uuid(UUID.nameUUIDFromBytes("XPDR-A1-XPDR1+OTSi".getBytes(Charset.forName("UTF-8"))) - .toString()); - org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.topology.rev181210.topology.Node otsiNode = tapiFactory - .getTapiNodes().get(new - org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.topology.rev181210.topology.NodeKey(otsiNodeUuid)); - Uuid enepUuid = new Uuid( - UUID.nameUUIDFromBytes(("XPDR-A1-XPDR1+eOTSi+XPDR1-NETWORK1").getBytes(Charset.forName("UTF-8"))) - .toString()); - Uuid inepUuid = new Uuid( - UUID.nameUUIDFromBytes(("XPDR-A1-XPDR1+iOTSi+XPDR1-NETWORK1").getBytes(Charset.forName("UTF-8"))) - .toString()); - OwnedNodeEdgePoint enep = otsiNode.nonnullOwnedNodeEdgePoint().get(new OwnedNodeEdgePointKey(enepUuid)); - assertNull("Administrative State should not be present", enep.getAdministrativeState()); - assertNull("Operational State should not be present", enep.getOperationalState()); + assertNull(nepN.getAdministrativeState(), "Administrative State should not be present"); + assertNull(nepN.getOperationalState(), "Operational State should not be present"); - OwnedNodeEdgePoint inep = otsiNode.nonnullOwnedNodeEdgePoint().get(new OwnedNodeEdgePointKey(inepUuid)); - assertNull("Administrative State should not be present", inep.getAdministrativeState()); - assertNull("Operational State should not be present", inep.getOperationalState()); } @Test - public void convertNodeWhenBadStates1() { - Node tpdr = changeTerminationPointState(tpdr100G, "XPDR1-NETWORK1", AdminStates.OutOfService, - State.OutOfService); + void convertNodeWhenBadStates1() { + Node tpdr = + changeTerminationPointState(tpdr100G, "XPDR1-NETWORK1", AdminStates.OutOfService, State.OutOfService); List networkPortList = new ArrayList<>(); for (TerminationPoint tp : tpdr100G.augmentation(Node1.class).getTerminationPoint().values()) { if (tp.augmentation(TerminationPoint1.class).getTpType().equals(OpenroadmTpType.XPONDERNETWORK)) { networkPortList.add(tp.getTpId().getValue()); } } - ConvertORTopoToTapiTopo tapiFactory = new ConvertORTopoToTapiTopo(topologyUuid, tapiLink); + ConvertORToTapiTopology tapiFactory = new ConvertORToTapiTopology(topologyUuid); tapiFactory.convertNode(tpdr, networkPortList); - Uuid dsrNodeUuid = new Uuid(UUID.nameUUIDFromBytes("XPDR-A1-XPDR1+DSR".getBytes(Charset.forName("UTF-8"))) - .toString()); - org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.topology.rev181210.topology.Node dsrNode = tapiFactory - .getTapiNodes().get(new - org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.topology.rev181210.topology.NodeKey(dsrNodeUuid)); + Uuid dsrNodeUuid = new Uuid( + UUID.nameUUIDFromBytes("XPDR-A1-XPDR1+XPONDER".getBytes(Charset.forName("UTF-8"))).toString()); + var dsrNode = tapiFactory.getTapiNodes() + .get(new org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.topology.rev221121 + .topology.NodeKey(dsrNodeUuid)); Uuid networkNepUuid = new Uuid( UUID.nameUUIDFromBytes(("XPDR-A1-XPDR1+iODU+XPDR1-NETWORK1").getBytes(Charset.forName("UTF-8"))) .toString()); OwnedNodeEdgePoint nepN = dsrNode.nonnullOwnedNodeEdgePoint().get(new OwnedNodeEdgePointKey(networkNepUuid)); - assertEquals("Administrative State should be Locked", - AdministrativeState.LOCKED, nepN.getAdministrativeState()); - assertEquals("Operational State should be Disabled", - OperationalState.DISABLED, nepN.getOperationalState()); - - Uuid otsiNodeUuid = new Uuid(UUID.nameUUIDFromBytes("XPDR-A1-XPDR1+OTSi".getBytes(Charset.forName("UTF-8"))) - .toString()); - org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.topology.rev181210.topology.Node otsiNode = tapiFactory - .getTapiNodes().get(new - org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.topology.rev181210.topology.NodeKey(otsiNodeUuid)); - Uuid enepUuid = new Uuid( - UUID.nameUUIDFromBytes(("XPDR-A1-XPDR1+eOTSi+XPDR1-NETWORK1").getBytes(Charset.forName("UTF-8"))) - .toString()); - Uuid inepUuid = new Uuid( - UUID.nameUUIDFromBytes(("XPDR-A1-XPDR1+iOTSi+XPDR1-NETWORK1").getBytes(Charset.forName("UTF-8"))) - .toString()); - OwnedNodeEdgePoint enep = otsiNode.nonnullOwnedNodeEdgePoint().get(new OwnedNodeEdgePointKey(enepUuid)); - assertEquals("Administrative State should be Locked", - AdministrativeState.LOCKED, enep.getAdministrativeState()); - assertEquals("Operational State should be Disabled", - OperationalState.DISABLED, enep.getOperationalState()); - - OwnedNodeEdgePoint inep = otsiNode.nonnullOwnedNodeEdgePoint().get(new OwnedNodeEdgePointKey(inepUuid)); - assertEquals("Administrative State should be Locked", - AdministrativeState.LOCKED, inep.getAdministrativeState()); - assertEquals("Operational State should be Disabled", - OperationalState.DISABLED, inep.getOperationalState()); + assertEquals(AdministrativeState.LOCKED, nepN.getAdministrativeState(), + "Administrative State should be Locked"); + assertEquals(OperationalState.DISABLED, nepN.getOperationalState(), "Operational State should be Disabled"); } @Test - public void convertNodeWhenBadStates2() { - Node tpdr = changeTerminationPointState(tpdr100G, "XPDR1-NETWORK1", AdminStates.Maintenance, - State.Degraded); + void convertNodeWhenBadStates2() { + Node tpdr = changeTerminationPointState(tpdr100G, "XPDR1-NETWORK1", AdminStates.Maintenance, State.Degraded); List networkPortList = new ArrayList<>(); for (TerminationPoint tp : tpdr100G.augmentation(Node1.class).getTerminationPoint().values()) { if (tp.augmentation(TerminationPoint1.class).getTpType().equals(OpenroadmTpType.XPONDERNETWORK)) { networkPortList.add(tp.getTpId().getValue()); } } - ConvertORTopoToTapiTopo tapiFactory = new ConvertORTopoToTapiTopo(topologyUuid, tapiLink); + ConvertORToTapiTopology tapiFactory = new ConvertORToTapiTopology(topologyUuid); tapiFactory.convertNode(tpdr, networkPortList); - Uuid dsrNodeUuid = new Uuid(UUID.nameUUIDFromBytes("XPDR-A1-XPDR1+DSR".getBytes(Charset.forName("UTF-8"))) - .toString()); - org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.topology.rev181210.topology.Node dsrNode = tapiFactory - .getTapiNodes().get(new - org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.topology.rev181210.topology.NodeKey(dsrNodeUuid)); + Uuid dsrNodeUuid = new Uuid( + UUID.nameUUIDFromBytes("XPDR-A1-XPDR1+XPONDER".getBytes(Charset.forName("UTF-8"))).toString()); + var dsrNode = tapiFactory.getTapiNodes() + .get(new org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.topology.rev221121 + .topology.NodeKey(dsrNodeUuid)); Uuid networkNepUuid = new Uuid( UUID.nameUUIDFromBytes(("XPDR-A1-XPDR1+iODU+XPDR1-NETWORK1").getBytes(Charset.forName("UTF-8"))) .toString()); OwnedNodeEdgePoint nepN = dsrNode.nonnullOwnedNodeEdgePoint().get(new OwnedNodeEdgePointKey(networkNepUuid)); - assertEquals("Administrative State should be Locked", - AdministrativeState.LOCKED, nepN.getAdministrativeState()); - assertEquals("Operational State should be Disabled", - OperationalState.DISABLED, nepN.getOperationalState()); - - Uuid otsiNodeUuid = new Uuid(UUID.nameUUIDFromBytes("XPDR-A1-XPDR1+OTSi".getBytes(Charset.forName("UTF-8"))) - .toString()); - org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.topology.rev181210.topology.Node otsiNode = tapiFactory - .getTapiNodes().get(new - org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.topology.rev181210.topology.NodeKey(otsiNodeUuid)); - Uuid enepUuid = new Uuid( - UUID.nameUUIDFromBytes(("XPDR-A1-XPDR1+eOTSi+XPDR1-NETWORK1").getBytes(Charset.forName("UTF-8"))) - .toString()); - Uuid inepUuid = new Uuid( - UUID.nameUUIDFromBytes(("XPDR-A1-XPDR1+iOTSi+XPDR1-NETWORK1").getBytes(Charset.forName("UTF-8"))) - .toString()); - OwnedNodeEdgePoint enep = otsiNode.nonnullOwnedNodeEdgePoint().get(new OwnedNodeEdgePointKey(enepUuid)); - assertEquals("Administrative State should be Locked", - AdministrativeState.LOCKED, enep.getAdministrativeState()); - assertEquals("Operational State should be Disabled", - OperationalState.DISABLED, enep.getOperationalState()); - - OwnedNodeEdgePoint inep = otsiNode.nonnullOwnedNodeEdgePoint().get(new OwnedNodeEdgePointKey(inepUuid)); - assertEquals("Administrative State should be Locked", - AdministrativeState.LOCKED, inep.getAdministrativeState()); - assertEquals("Operational State should be Disabled", - OperationalState.DISABLED, inep.getOperationalState()); + assertEquals(AdministrativeState.LOCKED, nepN.getAdministrativeState(), + "Administrative State should be Locked"); + assertEquals(OperationalState.DISABLED, nepN.getOperationalState(), "Operational State should be Disabled"); } @Test - public void convertOtnLinkWhenNoState() { - HashMap otnLinksAlt = new HashMap<>(otnLinks); - org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.network.topology.rev180226.networks.network.Link - link = changeOtnLinkState(otnLinks.get(new LinkKey( + void convertOtnLinkWhenNoState() { + HashMap otnLinksAlt = new HashMap<>(otnLinks); + org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.network.topology.rev180226 + .networks.network.Link link = + changeOtnLinkState(otnLinks.get(new LinkKey( new LinkId("ODTU4-SPDR-SA1-XPDR1-XPDR1-NETWORK1toSPDR-SC1-XPDR1-XPDR1-NETWORK1"))), null, null); otnLinksAlt.replace(link.key(), link); - ConvertORTopoToTapiTopo tapiFactory = new ConvertORTopoToTapiTopo(topologyUuid, tapiLink); List networkPortListA = new ArrayList<>(); for (TerminationPoint tp : otnMuxA.augmentation(Node1.class).getTerminationPoint().values()) { if (tp.augmentation(TerminationPoint1.class).getTpType().equals(OpenroadmTpType.XPONDERNETWORK)) { networkPortListA.add(tp.getTpId().getValue()); } } + ConvertORToTapiTopology tapiFactory = new ConvertORToTapiTopology(topologyUuid); + ConvertORTopoToTapiTopo tapiAbsFactory = new ConvertORTopoToTapiTopo(topologyUuid, tapiLink); tapiFactory.convertNode(otnMuxA, networkPortListA); + tapiAbsFactory.setTapiNodes(tapiFactory.getTapiNodes()); List networkPortListC = new ArrayList<>(); for (TerminationPoint tp : otnMuxC.augmentation(Node1.class).getTerminationPoint().values()) { if (tp.augmentation(TerminationPoint1.class).getTpType().equals(OpenroadmTpType.XPONDERNETWORK)) { @@ -338,36 +286,41 @@ public class ConvertORTopoToTapiTopoTest extends AbstractTest { } } tapiFactory.convertNode(otnMuxC, networkPortListC); - tapiFactory.convertLinks(otnLinksAlt); + tapiAbsFactory.setTapiNodes(tapiFactory.getTapiNodes()); + tapiAbsFactory.convertLinks(otnLinksAlt); - List tapiLinks = tapiFactory.getTapiLinks().values().stream() + List tapiLinks = tapiAbsFactory.getTapiLinks().values().stream() .sorted((l1, l2) -> l1.getUuid().getValue().compareTo(l2.getUuid().getValue())) .collect(Collectors.toList()); - assertNull("Administrative State should not be present", tapiLinks.get(3).getAdministrativeState()); - assertEquals("Administrative state should be UNLOCKED", - AdministrativeState.UNLOCKED, tapiLinks.get(0).getAdministrativeState()); - assertNull("Operational State should not be present", tapiLinks.get(3).getOperationalState()); - assertEquals("Operational state should be ENABLED", - OperationalState.ENABLED, tapiLinks.get(0).getOperationalState()); + assertNull(tapiLinks.get(1).getAdministrativeState(), "Administrative State should not be present"); + assertEquals(AdministrativeState.UNLOCKED, tapiLinks.get(0).getAdministrativeState(), + "Administrative state should be UNLOCKED"); + assertNull(tapiLinks.get(1).getOperationalState(), "Operational State should not be present"); + assertEquals(OperationalState.ENABLED, tapiLinks.get(0).getOperationalState(), + "Operational state should be ENABLED"); } @Test - public void convertOtnLinkWhenNoStateOnOppositeLink() { - HashMap otnLinksAlt = new HashMap<>(otnLinks); - org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.network.topology.rev180226.networks.network.Link - link = changeOtnLinkState(otnLinks.get(new LinkKey( + void convertOtnLinkWhenNoStateOnOppositeLink() { + HashMap otnLinksAlt = new HashMap<>(otnLinks); + org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.network.topology.rev180226 + .networks.network.Link link = + changeOtnLinkState(otnLinks.get(new LinkKey( new LinkId("ODTU4-SPDR-SC1-XPDR1-XPDR1-NETWORK1toSPDR-SA1-XPDR1-XPDR1-NETWORK1"))), null, null); otnLinksAlt.replace(link.key(), link); - ConvertORTopoToTapiTopo tapiFactory = new ConvertORTopoToTapiTopo(topologyUuid, tapiLink); List networkPortListA = new ArrayList<>(); for (TerminationPoint tp : otnMuxA.augmentation(Node1.class).getTerminationPoint().values()) { if (tp.augmentation(TerminationPoint1.class).getTpType().equals(OpenroadmTpType.XPONDERNETWORK)) { networkPortListA.add(tp.getTpId().getValue()); } } + ConvertORToTapiTopology tapiFactory = new ConvertORToTapiTopology(topologyUuid); + ConvertORTopoToTapiTopo tapiAbsFactory = new ConvertORTopoToTapiTopo(topologyUuid, tapiLink); tapiFactory.convertNode(otnMuxA, networkPortListA); + tapiAbsFactory.setTapiNodes(tapiFactory.getTapiNodes()); List networkPortListC = new ArrayList<>(); for (TerminationPoint tp : otnMuxC.augmentation(Node1.class).getTerminationPoint().values()) { if (tp.augmentation(TerminationPoint1.class).getTpType().equals(OpenroadmTpType.XPONDERNETWORK)) { @@ -375,37 +328,41 @@ public class ConvertORTopoToTapiTopoTest extends AbstractTest { } } tapiFactory.convertNode(otnMuxC, networkPortListC); - tapiFactory.convertLinks(otnLinksAlt); + tapiAbsFactory.setTapiNodes(tapiFactory.getTapiNodes()); + tapiAbsFactory.convertLinks(otnLinksAlt); - List tapiLinks = tapiFactory.getTapiLinks().values().stream() + List tapiLinks = tapiAbsFactory.getTapiLinks().values().stream() .sorted((l1, l2) -> l1.getUuid().getValue().compareTo(l2.getUuid().getValue())) .collect(Collectors.toList()); - assertNull("Administrative State should not be present", tapiLinks.get(3).getAdministrativeState()); - assertEquals("Administrative state should be UNLOCKED", - AdministrativeState.UNLOCKED, tapiLinks.get(0).getAdministrativeState()); - assertNull("Operational State should not be present", tapiLinks.get(3).getOperationalState()); - assertEquals("Operational state should be ENABLED", - OperationalState.ENABLED, tapiLinks.get(0).getOperationalState()); + assertNull(tapiLinks.get(1).getAdministrativeState(), "Administrative State should not be present"); + assertEquals(AdministrativeState.UNLOCKED, tapiLinks.get(0).getAdministrativeState(), + "Administrative state should be UNLOCKED"); + assertNull(tapiLinks.get(1).getOperationalState(), "Operational State should not be present"); + assertEquals(OperationalState.ENABLED, tapiLinks.get(0).getOperationalState(), + "Operational state should be ENABLED"); } @Test - public void convertOtnLinkWhenBadState1() { - HashMap otnLinksAlt = new HashMap<>(otnLinks); - org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.network.topology.rev180226.networks.network.Link - link = changeOtnLinkState(otnLinks.get(new LinkKey( + void convertOtnLinkWhenBadState1() { + HashMap otnLinksAlt = new HashMap<>(otnLinks); + org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.network.topology.rev180226 + .networks.network.Link link = + changeOtnLinkState(otnLinks.get(new LinkKey( new LinkId("ODTU4-SPDR-SA1-XPDR1-XPDR1-NETWORK1toSPDR-SC1-XPDR1-XPDR1-NETWORK1"))), AdminStates.OutOfService, State.OutOfService); otnLinksAlt.replace(link.key(), link); - - ConvertORTopoToTapiTopo tapiFactory = new ConvertORTopoToTapiTopo(topologyUuid, tapiLink); List networkPortListA = new ArrayList<>(); for (TerminationPoint tp : otnMuxA.augmentation(Node1.class).getTerminationPoint().values()) { if (tp.augmentation(TerminationPoint1.class).getTpType().equals(OpenroadmTpType.XPONDERNETWORK)) { networkPortListA.add(tp.getTpId().getValue()); } } + ConvertORToTapiTopology tapiFactory = new ConvertORToTapiTopology(topologyUuid); + ConvertORTopoToTapiTopo tapiAbsFactory = new ConvertORTopoToTapiTopo(topologyUuid, tapiLink); tapiFactory.convertNode(otnMuxA, networkPortListA); + tapiAbsFactory.setTapiNodes(tapiFactory.getTapiNodes()); List networkPortListC = new ArrayList<>(); for (TerminationPoint tp : otnMuxC.augmentation(Node1.class).getTerminationPoint().values()) { if (tp.augmentation(TerminationPoint1.class).getTpType().equals(OpenroadmTpType.XPONDERNETWORK)) { @@ -413,39 +370,43 @@ public class ConvertORTopoToTapiTopoTest extends AbstractTest { } } tapiFactory.convertNode(otnMuxC, networkPortListC); - tapiFactory.convertLinks(otnLinksAlt); - - List tapiLinks = tapiFactory.getTapiLinks().values().stream() + tapiAbsFactory.setTapiNodes(tapiFactory.getTapiNodes()); + tapiAbsFactory.convertLinks(otnLinksAlt); + List tapiLinks = tapiAbsFactory.getTapiLinks().values().stream() .sorted((l1, l2) -> l1.getUuid().getValue().compareTo(l2.getUuid().getValue())) .collect(Collectors.toList()); - assertEquals("Administrative state should be LOCKED", - AdministrativeState.LOCKED, tapiLinks.get(3).getAdministrativeState()); - assertEquals("Administrative state should be UNLOCKED", - AdministrativeState.UNLOCKED, tapiLinks.get(0).getAdministrativeState()); - assertEquals("Operational state should be DISABLED", - OperationalState.DISABLED, tapiLinks.get(3).getOperationalState()); - assertEquals("Operational state should be ENABLED", - OperationalState.ENABLED, tapiLinks.get(0).getOperationalState()); + LOG.info("TapiLinks are as follow : {}", tapiLinks); + assertEquals(AdministrativeState.LOCKED, tapiLinks.get(1).getAdministrativeState(), + "Administrative state should be LOCKED"); + assertEquals(AdministrativeState.UNLOCKED, tapiLinks.get(0).getAdministrativeState(), + "Administrative state should be UNLOCKED"); + assertEquals(OperationalState.DISABLED, tapiLinks.get(1).getOperationalState(), + "Operational state should be DISABLED"); + assertEquals(OperationalState.ENABLED, tapiLinks.get(0).getOperationalState(), + "Operational state should be ENABLED"); } @Test - public void convertOtnLinkWhenBadState2() { - HashMap otnLinksAlt = new HashMap<>(otnLinks); - org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.network.topology.rev180226.networks.network.Link - link = changeOtnLinkState(otnLinks.get(new LinkKey( + void convertOtnLinkWhenBadState2() { + HashMap otnLinksAlt = new HashMap<>(otnLinks); + org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.network.topology.rev180226 + .networks.network.Link link = + changeOtnLinkState(otnLinks.get(new LinkKey( new LinkId("ODTU4-SPDR-SA1-XPDR1-XPDR1-NETWORK1toSPDR-SC1-XPDR1-XPDR1-NETWORK1"))), AdminStates.Maintenance, State.Degraded); otnLinksAlt.replace(link.key(), link); - - ConvertORTopoToTapiTopo tapiFactory = new ConvertORTopoToTapiTopo(topologyUuid, tapiLink); List networkPortListA = new ArrayList<>(); for (TerminationPoint tp : otnMuxA.augmentation(Node1.class).getTerminationPoint().values()) { if (tp.augmentation(TerminationPoint1.class).getTpType().equals(OpenroadmTpType.XPONDERNETWORK)) { networkPortListA.add(tp.getTpId().getValue()); } } + ConvertORToTapiTopology tapiFactory = new ConvertORToTapiTopology(topologyUuid); + ConvertORTopoToTapiTopo tapiAbsFactory = new ConvertORTopoToTapiTopo(topologyUuid, tapiLink); tapiFactory.convertNode(otnMuxA, networkPortListA); + tapiAbsFactory.setTapiNodes(tapiFactory.getTapiNodes()); List networkPortListC = new ArrayList<>(); for (TerminationPoint tp : otnMuxC.augmentation(Node1.class).getTerminationPoint().values()) { if (tp.augmentation(TerminationPoint1.class).getTpType().equals(OpenroadmTpType.XPONDERNETWORK)) { @@ -453,39 +414,42 @@ public class ConvertORTopoToTapiTopoTest extends AbstractTest { } } tapiFactory.convertNode(otnMuxC, networkPortListC); - tapiFactory.convertLinks(otnLinksAlt); - - List tapiLinks = tapiFactory.getTapiLinks().values().stream() + tapiAbsFactory.setTapiNodes(tapiFactory.getTapiNodes()); + tapiAbsFactory.convertLinks(otnLinksAlt); + List tapiLinks = tapiAbsFactory.getTapiLinks().values().stream() .sorted((l1, l2) -> l1.getUuid().getValue().compareTo(l2.getUuid().getValue())) .collect(Collectors.toList()); - assertEquals("Administrative state should be LOCKED", - AdministrativeState.LOCKED, tapiLinks.get(3).getAdministrativeState()); - assertEquals("Administrative state should be UNLOCKED", - AdministrativeState.UNLOCKED, tapiLinks.get(0).getAdministrativeState()); - assertEquals("Operational state should be DISABLED", - OperationalState.DISABLED, tapiLinks.get(3).getOperationalState()); - assertEquals("Operational state should be ENABLED", - OperationalState.ENABLED, tapiLinks.get(0).getOperationalState()); + assertEquals(AdministrativeState.LOCKED, tapiLinks.get(1).getAdministrativeState(), + "Administrative state should be LOCKED"); + assertEquals(AdministrativeState.UNLOCKED, tapiLinks.get(0).getAdministrativeState(), + "Administrative state should be UNLOCKED"); + assertEquals(OperationalState.DISABLED, tapiLinks.get(1).getOperationalState(), + "Operational state should be DISABLED"); + assertEquals(OperationalState.ENABLED, tapiLinks.get(0).getOperationalState(), + "Operational state should be ENABLED"); } @Test - public void convertOtnLinkWhenBadStateOnOppositeLink() { - HashMap otnLinksAlt = new HashMap<>(otnLinks); - org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.network.topology.rev180226.networks.network.Link - link = changeOtnLinkState(otnLinks.get(new LinkKey( + void convertOtnLinkWhenBadStateOnOppositeLink() { + HashMap otnLinksAlt = new HashMap<>(otnLinks); + org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.network.topology.rev180226 + .networks.network.Link link = + changeOtnLinkState(otnLinks.get(new LinkKey( new LinkId("ODTU4-SPDR-SC1-XPDR1-XPDR1-NETWORK1toSPDR-SA1-XPDR1-XPDR1-NETWORK1"))), AdminStates.OutOfService, State.OutOfService); otnLinksAlt.replace(link.key(), link); - - ConvertORTopoToTapiTopo tapiFactory = new ConvertORTopoToTapiTopo(topologyUuid, tapiLink); List networkPortListA = new ArrayList<>(); for (TerminationPoint tp : otnMuxA.augmentation(Node1.class).getTerminationPoint().values()) { if (tp.augmentation(TerminationPoint1.class).getTpType().equals(OpenroadmTpType.XPONDERNETWORK)) { networkPortListA.add(tp.getTpId().getValue()); } } + ConvertORToTapiTopology tapiFactory = new ConvertORToTapiTopology(topologyUuid); + ConvertORTopoToTapiTopo tapiAbsFactory = new ConvertORTopoToTapiTopo(topologyUuid, tapiLink); tapiFactory.convertNode(otnMuxA, networkPortListA); + tapiAbsFactory.setTapiNodes(tapiFactory.getTapiNodes()); List networkPortListC = new ArrayList<>(); for (TerminationPoint tp : otnMuxC.augmentation(Node1.class).getTerminationPoint().values()) { if (tp.augmentation(TerminationPoint1.class).getTpType().equals(OpenroadmTpType.XPONDERNETWORK)) { @@ -493,24 +457,25 @@ public class ConvertORTopoToTapiTopoTest extends AbstractTest { } } tapiFactory.convertNode(otnMuxC, networkPortListC); - tapiFactory.convertLinks(otnLinksAlt); + tapiAbsFactory.setTapiNodes(tapiFactory.getTapiNodes()); + tapiAbsFactory.convertLinks(otnLinksAlt); - List tapiLinks = tapiFactory.getTapiLinks().values().stream() + List tapiLinks = tapiAbsFactory.getTapiLinks().values().stream() .sorted((l1, l2) -> l1.getUuid().getValue().compareTo(l2.getUuid().getValue())) .collect(Collectors.toList()); - assertEquals("Administrative state should be LOCKED", - AdministrativeState.LOCKED, tapiLinks.get(3).getAdministrativeState()); - assertEquals("Administrative state should be UNLOCKED", - AdministrativeState.UNLOCKED, tapiLinks.get(0).getAdministrativeState()); - assertEquals("Operational state should be DISABLED", - OperationalState.DISABLED, tapiLinks.get(3).getOperationalState()); - assertEquals("Operational state should be ENABLED", - OperationalState.ENABLED, tapiLinks.get(0).getOperationalState()); + assertEquals(AdministrativeState.LOCKED, tapiLinks.get(1).getAdministrativeState(), + "Administrative state should be LOCKED"); + assertEquals(AdministrativeState.UNLOCKED, tapiLinks.get(0).getAdministrativeState(), + "Administrative state should be UNLOCKED"); + assertEquals(OperationalState.DISABLED, tapiLinks.get(1).getOperationalState(), + "Operational state should be DISABLED"); + assertEquals(OperationalState.ENABLED, tapiLinks.get(0).getOperationalState(), + "Operational state should be ENABLED"); } @Test - public void convertNodeForTransponder100G() { - ConvertORTopoToTapiTopo tapiFactory = new ConvertORTopoToTapiTopo(topologyUuid, tapiLink); + void convertNodeForTransponder100G() { + ConvertORToTapiTopology tapiFactory = new ConvertORToTapiTopology(topologyUuid); List networkPortList = new ArrayList<>(); for (TerminationPoint tp : tpdr100G.augmentation(Node1.class).getTerminationPoint().values()) { if (tp.augmentation(TerminationPoint1.class).getTpType().equals(OpenroadmTpType.XPONDERNETWORK)) { @@ -518,31 +483,22 @@ public class ConvertORTopoToTapiTopoTest extends AbstractTest { } } tapiFactory.convertNode(tpdr100G, networkPortList); - List tapiNodes - = tapiFactory.getTapiNodes().values().stream() - .sorted((n1, n2) -> n1.getUuid().getValue().compareTo(n2.getUuid().getValue())) - .collect(Collectors.toList()); - - assertEquals("Node list size should be 2", 2, tapiFactory.getTapiNodes().size()); - assertEquals("Link list size should be 2", 2, tapiFactory.getTapiLinks().size()); + List tapiNodes = + tapiFactory.getTapiNodes().values().stream() + .sorted((n1, n2) -> n1.getUuid().getValue().compareTo(n2.getUuid().getValue())) + .collect(Collectors.toList()); - Uuid dsrNodeUuid = new Uuid(UUID.nameUUIDFromBytes("XPDR-A1-XPDR1+DSR".getBytes(Charset.forName("UTF-8"))) - .toString()); - checkDsrNode(tapiNodes.get(1), dsrNodeUuid, "tpdr", "XPDR-A1-XPDR1+DSR"); - Uuid otsiNodeUuid = new Uuid(UUID.nameUUIDFromBytes("XPDR-A1-XPDR1+OTSi".getBytes(Charset.forName("UTF-8"))) - .toString()); - checkOtsiNode(tapiNodes.get(0), otsiNodeUuid, "tpdr", "XPDR-A1-XPDR1+OTSi"); + assertEquals(1, tapiFactory.getTapiNodes().size(), "Node list size should be 1 (DSR-ODU merged)"); + assertEquals(0, tapiFactory.getTapiLinks().size(), "Link list size should be 0 (no more transitional links)"); - List tapiLinks = tapiFactory.getTapiLinks().values().stream() - .sorted((l1, l2) -> l1.getUuid().getValue().compareTo(l2.getUuid().getValue())) - .collect(Collectors.toList()); - checkTransitionalLink(tapiLinks.get(1), dsrNodeUuid, otsiNodeUuid, - "XPDR-A1-XPDR1+iODU+XPDR1-NETWORK1", "XPDR-A1-XPDR1+iOTSi+XPDR1-NETWORK1", "XPDR-A1-XPDR1"); + Uuid dsrNodeUuid = new Uuid( + UUID.nameUUIDFromBytes("XPDR-A1-XPDR1+XPONDER".getBytes(Charset.forName("UTF-8"))).toString()); + checkDsrNode(tapiNodes.get(getNodeRank("SPDR-SA1", tapiNodes)), dsrNodeUuid, "tpdr", "XPDR-A1-XPDR1+XPONDER"); } @Test - public void convertNodeForOtnMuxponder() { - ConvertORTopoToTapiTopo tapiFactory = new ConvertORTopoToTapiTopo(topologyUuid, tapiLink); + void convertNodeForOtnMuxponder() { + ConvertORToTapiTopology tapiFactory = new ConvertORToTapiTopology(topologyUuid); List networkPortList = new ArrayList<>(); for (TerminationPoint tp : otnMuxA.augmentation(Node1.class).getTerminationPoint().values()) { if (tp.augmentation(TerminationPoint1.class).getTpType().equals(OpenroadmTpType.XPONDERNETWORK)) { @@ -550,30 +506,21 @@ public class ConvertORTopoToTapiTopoTest extends AbstractTest { } } tapiFactory.convertNode(otnMuxA, networkPortList); - List tapiNodes - = tapiFactory.getTapiNodes().values().stream() - .sorted((n1, n2) -> n1.getUuid().getValue().compareTo(n2.getUuid().getValue())) - .collect(Collectors.toList()); - - assertEquals("Node list size should be 2", 2, tapiFactory.getTapiNodes().size()); - assertEquals("Link list size should be 1", 1, tapiFactory.getTapiLinks().size()); - Uuid dsrNodeUuid = new Uuid(UUID.nameUUIDFromBytes("SPDR-SA1-XPDR1+DSR".getBytes(Charset.forName("UTF-8"))) - .toString()); - checkDsrNode(tapiNodes.get(0), dsrNodeUuid, "mux", "SPDR-SA1-XPDR1+DSR"); - Uuid otsiNodeUuid = new Uuid(UUID.nameUUIDFromBytes("SPDR-SA1-XPDR1+OTSi".getBytes(Charset.forName("UTF-8"))) - .toString()); - checkOtsiNode(tapiNodes.get(1), otsiNodeUuid, "mux", "SPDR-SA1-XPDR1+OTSi"); - - List tapiLinks = tapiFactory.getTapiLinks().values().stream() - .sorted((l1, l2) -> l1.getUuid().getValue().compareTo(l2.getUuid().getValue())) - .collect(Collectors.toList()); - checkTransitionalLink(tapiLinks.get(0), dsrNodeUuid, otsiNodeUuid, - "SPDR-SA1-XPDR1+iODU+XPDR1-NETWORK1", "SPDR-SA1-XPDR1+iOTSi+XPDR1-NETWORK1", "SPDR-SA1-XPDR1"); + List tapiNodes = + tapiFactory.getTapiNodes().values().stream() + .sorted((n1, n2) -> n1.getUuid().getValue().compareTo(n2.getUuid().getValue())) + .collect(Collectors.toList()); + + assertEquals(1, tapiFactory.getTapiNodes().size(), "Node list size should be 1 (DSR & ODU merged"); + assertEquals(0, tapiFactory.getTapiLinks().size(), "Link list size should be 0, no more transitional links"); + Uuid dsrNodeUuid = new Uuid( + UUID.nameUUIDFromBytes("SPDR-SA1-XPDR1+XPONDER".getBytes(Charset.forName("UTF-8"))).toString()); + checkDsrNode(tapiNodes.get(getNodeRank("SPDR-SA1", tapiNodes)), dsrNodeUuid, "mux", "SPDR-SA1-XPDR1+XPONDER"); } @Test - public void convertNodeForOtnSwitch() { - ConvertORTopoToTapiTopo tapiFactory = new ConvertORTopoToTapiTopo(topologyUuid, tapiLink); + void convertNodeForOtnSwitch() { + ConvertORToTapiTopology tapiFactory = new ConvertORToTapiTopology(topologyUuid); List networkPortList = new ArrayList<>(); for (TerminationPoint tp : otnSwitch.augmentation(Node1.class).getTerminationPoint().values()) { if (tp.augmentation(TerminationPoint1.class).getTpType().equals(OpenroadmTpType.XPONDERNETWORK)) { @@ -581,38 +528,32 @@ public class ConvertORTopoToTapiTopoTest extends AbstractTest { } } tapiFactory.convertNode(otnSwitch, networkPortList); - List tapiNodes - = tapiFactory.getTapiNodes().values().stream() - .sorted((n1, n2) -> n1.getUuid().getValue().compareTo(n2.getUuid().getValue())) - .collect(Collectors.toList()); - - assertEquals("Node list size should be 2", 2, tapiFactory.getTapiNodes().size()); - assertEquals("Link list size should be 4", 4, tapiFactory.getTapiLinks().size()); - - Uuid dsrNodeUuid = new Uuid(UUID.nameUUIDFromBytes("SPDR-SA1-XPDR2+DSR".getBytes(Charset.forName("UTF-8"))) - .toString()); - checkDsrNode(tapiNodes.get(0), dsrNodeUuid, "switch", "SPDR-SA1-XPDR2+DSR"); - Uuid otsiNodeUuid = new Uuid(UUID.nameUUIDFromBytes("SPDR-SA1-XPDR2+OTSi".getBytes(Charset.forName("UTF-8"))) - .toString()); - checkOtsiNode(tapiNodes.get(1), otsiNodeUuid, "switch", "SPDR-SA1-XPDR2+OTSi"); - - List tapiLinks = tapiFactory.getTapiLinks().values().stream() - .sorted((l1, l2) -> l1.getUuid().getValue().compareTo(l2.getUuid().getValue())) - .collect(Collectors.toList()); - checkTransitionalLink(tapiLinks.get(2), dsrNodeUuid, otsiNodeUuid, - "SPDR-SA1-XPDR2+iODU+XPDR2-NETWORK4", "SPDR-SA1-XPDR2+iOTSi+XPDR2-NETWORK4", "SPDR-SA1-XPDR2"); + List tapiNodes = + tapiFactory.getTapiNodes().values().stream() + .sorted((n1, n2) -> n1.getUuid().getValue().compareTo(n2.getUuid().getValue())) + .collect(Collectors.toList()); + + assertEquals(1, tapiFactory.getTapiNodes().size(), "Node list size should be 1 (DSR/ODU merged)"); + assertEquals(0, tapiFactory.getTapiLinks().size(), "Link list size should be 0 : no more transitional link"); + + Uuid dsrNodeUuid = new Uuid( + UUID.nameUUIDFromBytes("SPDR-SA1-XPDR2+XPONDER".getBytes(Charset.forName("UTF-8"))).toString()); + checkDsrNode(tapiNodes.get(getNodeRank("SPDR-SA1", tapiNodes)), dsrNodeUuid, "switch", + "SPDR-SA1-XPDR2+XPONDER"); } @Test - public void convertOtnLink() { - ConvertORTopoToTapiTopo tapiFactory = new ConvertORTopoToTapiTopo(topologyUuid, tapiLink); + void convertOtnLink() { List networkPortListA = new ArrayList<>(); for (TerminationPoint tp : otnMuxA.augmentation(Node1.class).getTerminationPoint().values()) { if (tp.augmentation(TerminationPoint1.class).getTpType().equals(OpenroadmTpType.XPONDERNETWORK)) { networkPortListA.add(tp.getTpId().getValue()); } } + ConvertORToTapiTopology tapiFactory = new ConvertORToTapiTopology(topologyUuid); + ConvertORTopoToTapiTopo tapiAbsFactory = new ConvertORTopoToTapiTopo(topologyUuid, tapiLink); tapiFactory.convertNode(otnMuxA, networkPortListA); + tapiAbsFactory.setTapiNodes(tapiFactory.getTapiNodes()); List networkPortListC = new ArrayList<>(); for (TerminationPoint tp : otnMuxC.augmentation(Node1.class).getTerminationPoint().values()) { if (tp.augmentation(TerminationPoint1.class).getTpType().equals(OpenroadmTpType.XPONDERNETWORK)) { @@ -620,58 +561,66 @@ public class ConvertORTopoToTapiTopoTest extends AbstractTest { } } tapiFactory.convertNode(otnMuxC, networkPortListC); - tapiFactory.convertLinks(otnLinks); - assertEquals("Link list size should be 4", 4, tapiFactory.getTapiLinks().size()); - - Uuid node1Uuid = new Uuid(UUID.nameUUIDFromBytes("SPDR-SA1-XPDR1+DSR".getBytes(Charset.forName("UTF-8"))) - .toString()); - Uuid node2Uuid = new Uuid(UUID.nameUUIDFromBytes("SPDR-SC1-XPDR1+DSR".getBytes(Charset.forName("UTF-8"))) - .toString()); - Uuid node3Uuid = new Uuid(UUID.nameUUIDFromBytes("SPDR-SA1-XPDR1+OTSi".getBytes(Charset.forName("UTF-8"))) - .toString()); - Uuid node4Uuid = new Uuid(UUID.nameUUIDFromBytes("SPDR-SC1-XPDR1+OTSi".getBytes(Charset.forName("UTF-8"))) - .toString()); - Uuid tp1Uuid = new Uuid(UUID.nameUUIDFromBytes("SPDR-SA1-XPDR1+eODU+XPDR1-NETWORK1" - .getBytes(Charset.forName("UTF-8"))).toString()); - Uuid tp2Uuid = new Uuid(UUID.nameUUIDFromBytes("SPDR-SC1-XPDR1+eODU+XPDR1-NETWORK1" - .getBytes(Charset.forName("UTF-8"))).toString()); - Uuid tp3Uuid = new Uuid(UUID.nameUUIDFromBytes("SPDR-SA1-XPDR1+iOTSi+XPDR1-NETWORK1" - .getBytes(Charset.forName("UTF-8"))).toString()); - Uuid tp4Uuid = new Uuid(UUID.nameUUIDFromBytes("SPDR-SC1-XPDR1+iOTSi+XPDR1-NETWORK1" - .getBytes(Charset.forName("UTF-8"))).toString()); - Uuid link1Uuid = - new Uuid(UUID.nameUUIDFromBytes("SPDR-SA1-XPDR1+eODU+XPDR1-NETWORK1toSPDR-SC1-XPDR1+eODU+XPDR1-NETWORK1" - .getBytes(Charset.forName("UTF-8"))).toString()); - Uuid link2Uuid = - new Uuid(UUID.nameUUIDFromBytes("SPDR-SA1-XPDR1+iOTSi+XPDR1-NETWORK1toSPDR-SC1-XPDR1+iOTSi+XPDR1-NETWORK1" - .getBytes(Charset.forName("UTF-8"))).toString()); - - List links = tapiFactory.getTapiLinks().values().stream() + tapiAbsFactory.setTapiNodes(tapiFactory.getTapiNodes()); + + tapiAbsFactory.convertLinks(otnLinks); + assertEquals(2, tapiAbsFactory.getTapiLinks().size(), "Link list size should be 2 : no transitional link"); + + Uuid node1Uuid = new Uuid( + UUID.nameUUIDFromBytes("SPDR-SA1-XPDR1+XPONDER".getBytes(Charset.forName("UTF-8"))).toString()); + Uuid node2Uuid = new Uuid( + UUID.nameUUIDFromBytes("SPDR-SC1-XPDR1+XPONDER".getBytes(Charset.forName("UTF-8"))).toString()); + Uuid node3Uuid = new Uuid( + UUID.nameUUIDFromBytes("SPDR-SA1-XPDR1+XPONDER".getBytes(Charset.forName("UTF-8"))).toString()); + Uuid node4Uuid = new Uuid( + UUID.nameUUIDFromBytes("SPDR-SC1-XPDR1+XPONDER".getBytes(Charset.forName("UTF-8"))).toString()); + Uuid tp1Uuid = new Uuid( + UUID.nameUUIDFromBytes("SPDR-SA1-XPDR1+eODU+XPDR1-NETWORK1".getBytes(Charset.forName("UTF-8"))).toString()); + Uuid tp2Uuid = new Uuid( + UUID.nameUUIDFromBytes("SPDR-SC1-XPDR1+eODU+XPDR1-NETWORK1".getBytes(Charset.forName("UTF-8"))).toString()); + Uuid tp3Uuid = new Uuid( + UUID.nameUUIDFromBytes("SPDR-SA1-XPDR1+iOTSi+XPDR1-NETWORK1".getBytes(Charset.forName("UTF-8"))) + .toString()); + Uuid tp4Uuid = new Uuid( + UUID.nameUUIDFromBytes("SPDR-SC1-XPDR1+iOTSi+XPDR1-NETWORK1".getBytes(Charset.forName("UTF-8"))) + .toString()); + Uuid link1Uuid = new Uuid( + UUID.nameUUIDFromBytes("SPDR-SA1-XPDR1+eODU+XPDR1-NETWORK1toSPDR-SC1-XPDR1+eODU+XPDR1-NETWORK1" + .getBytes(Charset.forName("UTF-8"))) + .toString()); + Uuid link2Uuid = new Uuid( + UUID.nameUUIDFromBytes("SPDR-SA1-XPDR1+iOTSi+XPDR1-NETWORK1toSPDR-SC1-XPDR1+iOTSi+XPDR1-NETWORK1" + .getBytes(Charset.forName("UTF-8"))) + .toString()); + List links = tapiAbsFactory.getTapiLinks().values().stream() .sorted((l1, l2) -> l1.getUuid().getValue().compareTo(l2.getUuid().getValue())) .collect(Collectors.toList()); - checkOtnLink(links.get(3), node1Uuid, node2Uuid, tp1Uuid, tp2Uuid, link1Uuid, + LOG.info("Node3 {}, Node4 = {},", node3Uuid, node4Uuid); + checkOtnLink(links.get(1), node1Uuid, node2Uuid, tp1Uuid, tp2Uuid, link1Uuid, "SPDR-SA1-XPDR1+eODU+XPDR1-NETWORK1toSPDR-SC1-XPDR1+eODU+XPDR1-NETWORK1"); - checkOtnLink(links.get(2), node3Uuid, node4Uuid, tp3Uuid, tp4Uuid, link2Uuid, + checkOtnLink(links.get(0), node3Uuid, node4Uuid, tp3Uuid, tp4Uuid, link2Uuid, "SPDR-SA1-XPDR1+iOTSi+XPDR1-NETWORK1toSPDR-SC1-XPDR1+iOTSi+XPDR1-NETWORK1"); + LOG.info("The link we check has name {}", links.get(0).getName()); } @Test - public void convertRoadmInfrastructureWhenNoXponderAttached() { - ConvertORTopoToTapiTopo tapiFactory = new ConvertORTopoToTapiTopo(topologyUuid, tapiLink); - tapiFactory.convertRoadmInfrastructure(); - - assertEquals("Node list size should be 1", 1, tapiFactory.getTapiNodes().size()); - assertEquals("Link list size should be empty", 0, tapiFactory.getTapiLinks().size()); - List tapiNodes - = tapiFactory.getTapiNodes().values().stream().collect(Collectors.toList()); - Uuid otsiNodeUuid = new Uuid(UUID.nameUUIDFromBytes("ROADM-infra".getBytes(Charset.forName("UTF-8"))) - .toString()); - checkOtsiNode(tapiNodes.get(0), otsiNodeUuid, "infra", "ROADM-infra"); + void convertRoadmInfrastructureWhenNoXponderAttached() { + ConvertORTopoToTapiTopo tapiAbsFactory = new ConvertORTopoToTapiTopo(topologyUuid, tapiLink); + tapiAbsFactory.convertRoadmInfrastructure(); + + assertEquals(1, tapiAbsFactory.getTapiNodes().size(), "Node list size should be 1"); + assertEquals(0, tapiAbsFactory.getTapiLinks().size(), "Link list size should be empty"); + List tapiNodes = + tapiAbsFactory.getTapiNodes().values().stream().collect(Collectors.toList()); + Uuid photNodeUuid = new Uuid( + UUID.nameUUIDFromBytes("ROADM-infra".getBytes(Charset.forName("UTF-8"))).toString()); + checkOtsiNode(tapiNodes.get(0), photNodeUuid, "infra", "ROADM-infra"); } @Test - public void convertRoadmInfrastructureWhenOtnMuxAttached() { - ConvertORTopoToTapiTopo tapiFactory = new ConvertORTopoToTapiTopo(topologyUuid, tapiLink); + void convertRoadmInfrastructureWhenOtnMuxAttached() { + ConvertORTopoToTapiTopo tapiAbsFactory = new ConvertORTopoToTapiTopo(topologyUuid, tapiLink); + ConvertORToTapiTopology tapiFactory = new ConvertORToTapiTopology(topologyUuid); List networkPortListA = new ArrayList<>(); for (TerminationPoint tp : otnMuxA.augmentation(Node1.class).getTerminationPoint().values()) { if (tp.augmentation(TerminationPoint1.class).getTpType().equals(OpenroadmTpType.XPONDERNETWORK)) { @@ -679,51 +628,65 @@ public class ConvertORTopoToTapiTopoTest extends AbstractTest { } } tapiFactory.convertNode(otnMuxA, networkPortListA); - tapiFactory.convertRoadmInfrastructure(); - - assertEquals("Node list size should be 3", 3, tapiFactory.getTapiNodes().size()); - assertEquals("Link list size should be 2", 2, tapiFactory.getTapiLinks().size()); - List tapiNodes - = tapiFactory.getTapiNodes().values().stream() - .sorted((n1, n2) -> n1.getUuid().getValue().compareTo(n2.getUuid().getValue())) - .collect(Collectors.toList()); - Uuid otsiNodeUuid = new Uuid(UUID.nameUUIDFromBytes("ROADM-infra".getBytes(Charset.forName("UTF-8"))) - .toString()); - checkOtsiNode(tapiNodes.get(2), otsiNodeUuid, "infra", "ROADM-infra"); - - List links = tapiFactory.getTapiLinks().values().stream() + tapiAbsFactory.setTapiNodes(tapiFactory.getTapiNodes()); + tapiAbsFactory.convertRoadmInfrastructure(); + LOG.info("ERRORLINK List of link = {}", tapiAbsFactory.getTapiLinks().toString()); + assertEquals(2, tapiAbsFactory.getTapiNodes().size(), + "Node list size should be 2"); + assertEquals(1, tapiAbsFactory.getTapiLinks().size(), "Link list size should be 1"); + + Map nodeMap = + tapiFactory.getTapiNodes(); + nodeMap.putAll(tapiAbsFactory.getTapiNodes()); + List tapiNodes = + nodeMap.values().stream() + .sorted((n1, n2) -> n1.getUuid().getValue().compareTo(n2.getUuid().getValue())) + .collect(Collectors.toList()); + checkOtsiNode( + tapiNodes.get(getNodeRank("ROADM", tapiNodes)), + //otsiNodeUuid, + new Uuid(UUID.nameUUIDFromBytes("ROADM-infra".getBytes(Charset.forName("UTF-8"))).toString()), + "infra", "ROADM-infra"); + List links = tapiAbsFactory.getTapiLinks().values().stream() .sorted((l1, l2) -> l1.getUuid().getValue().compareTo(l2.getUuid().getValue())) .collect(Collectors.toList()); - Uuid node1Uuid = new Uuid(UUID.nameUUIDFromBytes("SPDR-SA1-XPDR1+OTSi".getBytes(Charset.forName("UTF-8"))) - .toString()); - Uuid node2Uuid = new Uuid(UUID.nameUUIDFromBytes("ROADM-infra".getBytes(Charset.forName("UTF-8"))) - .toString()); - Uuid tp1Uuid = new Uuid(UUID.nameUUIDFromBytes("SPDR-SA1-XPDR1+eOTSi+XPDR1-NETWORK1" - .getBytes(Charset.forName("UTF-8"))).toString()); - Uuid tp2Uuid = new Uuid(UUID.nameUUIDFromBytes(("roadm node+nep+1") - .getBytes(Charset.forName("UTF-8"))).toString()); - Uuid linkUuid = - new Uuid(UUID.nameUUIDFromBytes( - "SPDR-SA1-XPDR1+OTSi--SPDR-SA1-XPDR1+eOTSi+XPDR1-NETWORK1 and ROADM-infra--NodeEdgePoint_1" - .getBytes(Charset.forName("UTF-8"))).toString()); - checkOmsLink(links.get(1), node1Uuid, node2Uuid, tp1Uuid, tp2Uuid, linkUuid, - "SPDR-SA1-XPDR1+OTSi--SPDR-SA1-XPDR1+eOTSi+XPDR1-NETWORK1 and ROADM-infra--NodeEdgePoint_1"); + String str1 = + "SPDR-SA1-XPDR1+XPONDER--SPDR-SA1-XPDR1+PHOTONIC_MEDIA_OTS+XPDR1-NETWORK1 and ROADM-infra--NodeEdgePoint_1"; + LOG.info("LinksCheck 0 = {} ", links.get(0).getName()); + checkOmsLink(links.get(0), + //node1Uuid, + new Uuid(UUID.nameUUIDFromBytes("SPDR-SA1-XPDR1+XPONDER".getBytes(Charset.forName("UTF-8"))).toString()), + //node2Uuid, + new Uuid(UUID.nameUUIDFromBytes("ROADM-infra".getBytes(Charset.forName("UTF-8"))).toString()), + //tp1Uuid, + new Uuid( + UUID.nameUUIDFromBytes( + "SPDR-SA1-XPDR1+PHOTONIC_MEDIA_OTS+XPDR1-NETWORK1".getBytes(Charset.forName("UTF-8"))) + .toString()), + //tp2Uuid, + new Uuid(UUID.nameUUIDFromBytes(("roadm node+nep+1").getBytes(Charset.forName("UTF-8"))).toString()), + //linkUuid, + new Uuid(UUID.nameUUIDFromBytes(str1.getBytes(Charset.forName("UTF-8"))).toString()), + str1); } - private void checkDsrNode(org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.topology.rev181210.topology.Node node, - Uuid nodeUuid, String dsrNodeType, String nodeId) { - assertEquals("incorrect node uuid", nodeUuid, node.getUuid()); - assertEquals("incorrect node name", nodeId, node.getName().get(new NameKey("dsr/odu node name")).getValue()); - assertEquals("administrative state should be UNLOCKED", - AdministrativeState.UNLOCKED, node.getAdministrativeState()); - assertEquals("life-cycle state should be INSTALLED", LifecycleState.INSTALLED, node.getLifecycleState()); - assertEquals("operational state should be ENABLED", OperationalState.ENABLED, node.getOperationalState()); + private void checkDsrNode( + org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.topology.rev221121.topology.Node node, + Uuid nodeUuid, String dsrNodeType, String nodeId) { + assertEquals(nodeUuid, node.getUuid(), "incorrect node uuid"); + assertEquals(nodeId, node.getName().get(new NameKey("dsr/odu node name")).getValue(), "incorrect node name"); + assertEquals(AdministrativeState.UNLOCKED, node.getAdministrativeState(), + "administrative state should be UNLOCKED"); + assertEquals(LifecycleState.INSTALLED, node.getLifecycleState(), "life-cycle state should be INSTALLED"); + assertEquals(OperationalState.ENABLED, node.getOperationalState(), "operational state should be ENABLED"); assertThat("one value-name should be 'dsr/odu node name'", new ArrayList<>(node.nonnullName().keySet()), hasItem(new NameKey("dsr/odu node name"))); - assertEquals("dsr node should manage 2 protocol layers : dsr and odu", - 2, node.getLayerProtocolName().size()); - assertThat("dsr node should manage 2 protocol layers : dsr and odu", - node.getLayerProtocolName(), hasItems(LayerProtocolName.DSR, LayerProtocolName.ODU)); + assertEquals(4, node.getLayerProtocolName().size(), + "dsr node should manage 4 protocol layers : dsr, odu, DIGITALOTN and photonic"); + assertThat("dsr node should manage 3 protocol layers : dsr, odu and photonic", + node.getLayerProtocolName(), hasItems(LayerProtocolName.DSR, LayerProtocolName.ODU, + LayerProtocolName.PHOTONICMEDIA)); List nepsN = node.nonnullOwnedNodeEdgePoint().values().stream() .filter(n -> n.getName().containsKey(new NameKey("iNodeEdgePoint_N"))) .sorted((nep1, nep2) -> nep1.getUuid().getValue().compareTo(nep2.getUuid().getValue())) @@ -735,8 +698,8 @@ public class ConvertORTopoToTapiTopoTest extends AbstractTest { .filter(n -> n.getName().containsKey(new NameKey("NodeEdgePoint_C"))) .sorted((nep1, nep2) -> nep1.getUuid().getValue().compareTo(nep2.getUuid().getValue())) .collect(Collectors.toList()); - assertEquals("Switch-DSR node should have 4 NEPs network", 4, nepsN.size()); - assertEquals("Switch-DSR node should have 4 NEPs client", 4, nepsC.size()); + assertEquals(4, nepsN.size(), "Switch-DSR node should have 4 NEPs network"); + assertEquals(4, nepsC.size(), "Switch-DSR node should have 4 NEPs client"); OwnedNodeEdgePoint nep1 = nepsC.get(2); Uuid client4NepUuid = new Uuid( UUID.nameUUIDFromBytes((nodeId.split("\\+")[0] + "+DSR+XPDR2-CLIENT4") @@ -759,8 +722,8 @@ public class ConvertORTopoToTapiTopoTest extends AbstractTest { .filter(n -> n.getName().containsKey(new NameKey("NodeEdgePoint_C"))) .sorted((nep3, nep4) -> nep3.getUuid().getValue().compareTo(nep4.getUuid().getValue())) .collect(Collectors.toList()); - assertEquals("Mux-DSR node should have 1 NEP network", 1, nepsN.size()); - assertEquals("Mux-DSR node should have 4 NEPs client", 4, nepsC.size()); + assertEquals(1, nepsN.size(), "Mux-DSR node should have 1 NEP network"); + assertEquals(4, nepsC.size(), "Mux-DSR node should have 4 NEPs client"); OwnedNodeEdgePoint nep3 = nepsC.get(2); Uuid client3NepUuid = new Uuid( UUID.nameUUIDFromBytes((nodeId.split("\\+")[0] + "+DSR+XPDR1-CLIENT3") @@ -784,8 +747,8 @@ public class ConvertORTopoToTapiTopoTest extends AbstractTest { .filter(n -> n.getName().containsKey(new NameKey("100G-tpdr"))) .sorted((nep5, nep6) -> nep5.getUuid().getValue().compareTo(nep6.getUuid().getValue())) .collect(Collectors.toList()); - assertEquals("Tpdr-DSR node should have 2 NEPs network", 2, nepsN.size()); - assertEquals("Tpdr-DSR node should have 2 NEPs client", 2, nepsC.size()); + assertEquals(2, nepsN.size(), "Tpdr-DSR node should have 2 NEPs network"); + assertEquals(2, nepsC.size(), "Tpdr-DSR node should have 2 NEPs client"); OwnedNodeEdgePoint nep5 = nepsC.get(0); Uuid client1NepUuid = new Uuid( UUID.nameUUIDFromBytes((nodeId.split("\\+")[0] + "+DSR+XPDR1-CLIENT1") @@ -811,20 +774,20 @@ public class ConvertORTopoToTapiTopoTest extends AbstractTest { } private void checkOtsiNode( - org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.topology.rev181210.topology.Node node, - Uuid nodeUuid, String otsiNodeType, String nodeId) { - assertEquals("incorrect node uuid", nodeUuid, node.getUuid()); - assertEquals("incorrect node name", nodeId, node.getName().get(new NameKey("otsi node name")).getValue()); - assertEquals("administrative state should be UNLOCKED", - AdministrativeState.UNLOCKED, node.getAdministrativeState()); - assertEquals("life-cycle state should be INSTALLED", LifecycleState.INSTALLED, node.getLifecycleState()); - assertEquals("operational state should be ENABLED", OperationalState.ENABLED, node.getOperationalState()); + org.opendaylight.yang.gen.v1.urn.onf.otcc.yang.tapi.topology.rev221121.topology.Node node, + Uuid nodeUuid, String otsiNodeType, String nodeId) { + assertEquals(nodeUuid, node.getUuid(), "incorrect node uuid"); + assertEquals(nodeId, node.getName().get(new NameKey("otsi node name")).getValue(), "incorrect node name"); + assertEquals(AdministrativeState.UNLOCKED, node.getAdministrativeState(), + "administrative state should be UNLOCKED"); + assertEquals(LifecycleState.INSTALLED, node.getLifecycleState(), "life-cycle state should be INSTALLED"); + assertEquals(OperationalState.ENABLED, node.getOperationalState(), "operational state should be ENABLED"); assertThat("one value-name should be 'dsr/odu node name'", new ArrayList<>(node.nonnullName().keySet()), hasItem(new NameKey("otsi node name"))); - assertEquals("otsi node should manage a single protocol layer : PHOTONIC_MEDIA", - 1, node.getLayerProtocolName().size()); - assertEquals("otsi node should manage a single protocol layer : PHOTONIC_MEDIA", - LayerProtocolName.PHOTONICMEDIA, node.getLayerProtocolName().get(0)); + assertEquals(1, node.getLayerProtocolName().size(), + "otsi node should manage a single protocol layer : PHOTONIC_MEDIA"); + assertEquals(LayerProtocolName.PHOTONICMEDIA, node.getLayerProtocolName().stream().findFirst().orElseThrow(), + "otsi node should manage a single protocol layer : PHOTONIC_MEDIA"); List nepsI = node.nonnullOwnedNodeEdgePoint().values().stream() .filter(n -> n.getName().containsKey(new NameKey("iNodeEdgePoint"))) .sorted((nep1, nep2) -> nep1.getUuid().getValue().compareTo(nep2.getUuid().getValue())) @@ -835,8 +798,8 @@ public class ConvertORTopoToTapiTopoTest extends AbstractTest { .collect(Collectors.toList()); switch (otsiNodeType) { case "switch": - assertEquals("Switch-OTSi node should have 4 eNEPs", 4, nepsE.size()); - assertEquals("Switch-OTSi node should have 4 iNEPs", 4, nepsI.size()); + assertEquals(4, nepsE.size(), "Switch-OTSi node should have 4 eNEPs"); + assertEquals(4, nepsI.size(), "Switch-OTSi node should have 4 iNEPs"); OwnedNodeEdgePoint nep1 = nepsI.get(1); Uuid inepUuid = new Uuid( UUID.nameUUIDFromBytes((nodeId.split("\\+")[0] + "+iOTSi+XPDR2-NETWORK2") @@ -845,24 +808,24 @@ public class ConvertORTopoToTapiTopoTest extends AbstractTest { otnSwitch.getNodeId().getValue(), TapiStringConstants.I_OTSI); OwnedNodeEdgePoint nep2 = nepsE.get(0); Uuid enepUuid = new Uuid( - UUID.nameUUIDFromBytes((nodeId.split("\\+")[0] + "+eOTSi+XPDR2-NETWORK2") + UUID.nameUUIDFromBytes((nodeId.split("\\+")[0] + "+PHOTONIC_MEDIA_OTS+XPDR2-NETWORK2") .getBytes(Charset.forName("UTF-8"))).toString()); checkNepOtsiNode(nep2, enepUuid, "XPDR2-NETWORK2", "eNodeEdgePoint", - otnSwitch.getNodeId().getValue(), TapiStringConstants.E_OTSI); + otnSwitch.getNodeId().getValue(), TapiStringConstants.PHTNC_MEDIA_OTS); List nrgList = node.nonnullNodeRuleGroup().values().stream() .sorted((nrg1, nrg2) -> nrg1.getUuid().getValue().compareTo(nrg2.getUuid().getValue())) .collect(Collectors.toList()); checkNodeRuleGroupForSwitchOTSi(nrgList, enepUuid, inepUuid, nodeUuid); break; case "mux": - assertEquals("Mux-OTSi node should have 1 eNEP", 1, nepsE.size()); - assertEquals("Mux-OTSi node should have 1 iNEPs", 1, nepsI.size()); + assertEquals(1, nepsE.size(), "Mux-OTSi node should have 1 eNEP"); + assertEquals(1, nepsI.size(), "Mux-OTSi node should have 1 iNEPs"); OwnedNodeEdgePoint nep3 = nepsE.get(0); Uuid enepUuid2 = new Uuid( - UUID.nameUUIDFromBytes((nodeId.split("\\+")[0] + "+eOTSi+XPDR1-NETWORK1") + UUID.nameUUIDFromBytes((nodeId.split("\\+")[0] + "+PHOTONIC_MEDIA_OTS+XPDR1-NETWORK1") .getBytes(Charset.forName("UTF-8"))).toString()); checkNepOtsiNode(nep3, enepUuid2, "XPDR1-NETWORK1", "eNodeEdgePoint", - otnMuxA.getNodeId().getValue(), TapiStringConstants.E_OTSI); + otnMuxA.getNodeId().getValue(), TapiStringConstants.PHTNC_MEDIA_OTS); OwnedNodeEdgePoint nep4 = nepsI.get(0); Uuid inepUuid2 = new Uuid( UUID.nameUUIDFromBytes((nodeId.split("\\+")[0] + "+iOTSi+XPDR1-NETWORK1") @@ -875,14 +838,14 @@ public class ConvertORTopoToTapiTopoTest extends AbstractTest { checkNodeRuleGroupForMuxOTSi(nrgList2, enepUuid2, inepUuid2, nodeUuid); break; case "tpdr": - assertEquals("Tpdr-OTSi node should have 2 eNEPs", 2, nepsE.size()); - assertEquals("Tpdr-OTSi node should have 2 iNEPs", 2, nepsI.size()); + assertEquals(2, nepsE.size(), "Tpdr-OTSi node should have 2 eNEPs"); + assertEquals(2, nepsI.size(), "Tpdr-OTSi node should have 2 iNEPs"); OwnedNodeEdgePoint nep5 = nepsE.get(0); Uuid enepUuid3 = new Uuid( - UUID.nameUUIDFromBytes((nodeId.split("\\+")[0] + "+eOTSi+XPDR1-NETWORK1") + UUID.nameUUIDFromBytes((nodeId.split("\\+")[0] + "+PHOTONIC_MEDIA_OTS+XPDR1-NETWORK1") .getBytes(Charset.forName("UTF-8"))).toString()); checkNepOtsiNode(nep5, enepUuid3, "XPDR1-NETWORK1", "eNodeEdgePoint", - tpdr100G.getNodeId().getValue(), TapiStringConstants.E_OTSI); + tpdr100G.getNodeId().getValue(), TapiStringConstants.PHTNC_MEDIA_OTS); OwnedNodeEdgePoint nep6 = nepsI.get(0); Uuid inepUuid3 = new Uuid( UUID.nameUUIDFromBytes((nodeId.split("\\+")[0] + "+iOTSi+XPDR1-NETWORK1") @@ -914,50 +877,54 @@ public class ConvertORTopoToTapiTopoTest extends AbstractTest { } } - private void checkNepClient10G(OwnedNodeEdgePoint nep, Uuid nepUuid, String portName, String nepName, - String nodeId, String extension) { - assertEquals("bad uuid for " + portName, nepUuid, nep.getUuid()); - List nameList = new ArrayList<>(nep.nonnullName().values()); - Name name = nameList.get(0); - assertEquals("value of client nep should be '" + portName + "'", - String.join("+", nodeId, extension, portName), name.getValue()); - assertEquals("value-name of client nep for '" + portName + "' should be '" + nepName + "'", - nepName, name.getValueName()); - assertEquals("Client nep should support 3 kind of cep", - 3, nep.getSupportedCepLayerProtocolQualifier().size()); - assertThat("client nep should support 3 kind of cep", - nep.getSupportedCepLayerProtocolQualifier(), - hasItems(ODUTYPEODU2.class, ODUTYPEODU2E.class, DIGITALSIGNALTYPE10GigELAN.class)); - assertEquals("client nep should be of ETH protocol type", LayerProtocolName.ETH, nep.getLayerProtocolName()); + private void checkNepClient10G( + OwnedNodeEdgePoint nep, Uuid nepUuid, String portName, String nepName, String nodeId, String extension) { + assertEquals(nepUuid, nep.getUuid(), "bad uuid for " + portName); + Name name = new ArrayList<>(nep.nonnullName().values()).get(0); + assertEquals( + String.join("+", nodeId, extension, portName), + name.getValue(), + "value of client nep should be '" + portName + "'"); + assertEquals(nepName, name.getValueName(), + "value-name of client nep for '" + portName + "' should be '" + nepName + "'"); + List lpql = new ArrayList<>(); + for (SupportedCepLayerProtocolQualifierInstances entry : nep.getSupportedCepLayerProtocolQualifierInstances()) { + lpql.add(entry.getLayerProtocolQualifier()); + } + assertEquals(3, lpql.size(), "Client nep should support 3 kind of cep"); + assertThat("client nep should support 3 kind of cep", lpql, + hasItems(ODUTYPEODU2.VALUE, ODUTYPEODU2E.VALUE, DIGITALSIGNALTYPE10GigELAN.VALUE)); + assertEquals(LayerProtocolName.DSR, nep.getLayerProtocolName(), "client nep should be of DSR(ETH) protocol "); checkCommonPartOfNep(nep, false); checkSIP(nep, portName, nodeId, extension); } - private void checkNepNetworkODU4(OwnedNodeEdgePoint nep, Uuid nepUuid, String portName, String nepName, - String nodeId, String extension) { - assertEquals("bad uuid for " + portName, nepUuid, nep.getUuid()); + private void checkNepNetworkODU4( + OwnedNodeEdgePoint nep, Uuid nepUuid, String portName, String nepName, String nodeId, String extension) { + assertEquals(nepUuid, nep.getUuid(), "bad uuid for " + portName); List nameList = new ArrayList<>(nep.nonnullName().values()); Name name = nameList.get(0); - assertEquals("value of network nep should be '" + portName + "'", - String.join("+", nodeId, extension, portName), name.getValue()); - assertEquals("value-name of network nep for '" + portName + "' should be '" + nepName + "'", - nepName, name.getValueName()); - assertEquals("Network nep should support 1 kind of cep", - 1, nep.getSupportedCepLayerProtocolQualifier().size()); - assertThat("network nep should support 1 kind of cep", - nep.getSupportedCepLayerProtocolQualifier(), - hasItem(ODUTYPEODU4.class)); - assertEquals("network nep should be of ODU protocol type", LayerProtocolName.ODU, nep.getLayerProtocolName()); + assertEquals(String.join("+", nodeId, extension, portName), name.getValue(), + "value of network nep should be '" + portName + "'"); + assertEquals(nepName, name.getValueName(), + "value-name of network nep for '" + portName + "' should be '" + nepName + "'"); + List lpql = new ArrayList<>(); + for (SupportedCepLayerProtocolQualifierInstances entry :nep.getSupportedCepLayerProtocolQualifierInstances()) { + lpql.add(entry.getLayerProtocolQualifier()); + } + assertEquals(1, lpql.size(), "Network nep should support 1 kind of cep"); + assertThat("network nep should support 1 kind of cep", lpql, hasItem(ODUTYPEODU4.VALUE)); + assertEquals(LayerProtocolName.ODU, nep.getLayerProtocolName(), "network nep should be of ODU protocol type"); checkCommonPartOfNep(nep, false); checkSIP(nep, portName, nodeId, extension); } - private void checkNodeRuleGroupForTpdrDSR(List nrgList, Uuid clientNepUuid, Uuid networkNepUuid, - Uuid nodeUuid) { - assertEquals("transponder DSR should contain 2 node rule group", 2, nrgList.size()); + private void checkNodeRuleGroupForTpdrDSR( + List nrgList, Uuid clientNepUuid, Uuid networkNepUuid, Uuid nodeUuid) { + assertEquals(4, nrgList.size(), "transponder DSR should contain 4 node rule group (2*DSR/I_ODU+2*E_ODU/I_ODU)"); for (NodeRuleGroup nodeRuleGroup : nrgList) { - assertEquals("each node-rule-group should contain 2 NEP for transponder DSR", - 2, nodeRuleGroup.getNodeEdgePoint().size()); + assertEquals(2, nodeRuleGroup.getNodeEdgePoint().size(), + "each node-rule-group should contain 2 NEP for transponder DSR"); } List nodeEdgePointList = new ArrayList<>(nrgList.get(0).nonnullNodeEdgePoint().values()); assertThat("node-rule-group nb 1 should be between nep-client1 and nep-network1", @@ -966,26 +933,25 @@ public class ConvertORTopoToTapiTopoTest extends AbstractTest { assertThat("node-rule-group nb 1 should be between nep-client1 and nep-network1", nodeEdgePointList.get(1).getNodeEdgePointUuid().getValue(), either(containsString(networkNepUuid.getValue())).or(containsString(clientNepUuid.getValue()))); - assertEquals("node-rule-group nb 1 should be between nep-client1 and nep-network1 of the same node", - nodeEdgePointList.get(0).getNodeUuid(), nodeUuid); - assertEquals("node-rule-group nb 1 should be between nep-client1 and nep-network1 of the same node", - nodeEdgePointList.get(1).getNodeUuid(), nodeUuid); + assertEquals(nodeEdgePointList.get(0).getNodeUuid(), nodeUuid, + "node-rule-group nb 1 should be between nep-client1 and nep-network1 of the same node"); + assertEquals(nodeEdgePointList.get(1).getNodeUuid(), nodeUuid, + "node-rule-group nb 1 should be between nep-client1 and nep-network1 of the same node"); List rule = new ArrayList<>(nrgList.get(1).nonnullRule().values()); - assertEquals("node-rule-group nb 1 should contain a single rule", 1, rule.size()); - assertEquals("local-id of the rule should be 'forward'", - "forward", rule.get(0).getLocalId()); - assertEquals("the forwarding rule should be 'MAYFORWARDACROSSGROUP'", - ForwardingRule.MAYFORWARDACROSSGROUP, rule.get(0).getForwardingRule()); - assertEquals("the rule type should be 'FORWARDING'", - RuleType.FORWARDING, rule.get(0).getRuleType()); + assertEquals(1, rule.size(), "node-rule-group nb 1 should contain a single rule"); + assertEquals("forward", rule.get(0).getLocalId(), "local-id of the rule should be 'forward'"); + assertEquals(FORWARDINGRULEMAYFORWARDACROSSGROUP.VALUE, rule.get(0).getForwardingRule(), + "the forwarding rule should be 'MAYFORWARDACROSSGROUP'"); + assertEquals(RuleType.FORWARDING, rule.get(0).getRuleType().iterator().next(), + "the rule type should be 'FORWARDING'"); } - private void checkNodeRuleGroupForMuxDSR(List nrgList, Uuid clientNepUuid, Uuid networkNepUuid, - Uuid nodeUuid) { - assertEquals("muxponder DSR should contain 4 node rule group", 4, nrgList.size()); + private void checkNodeRuleGroupForMuxDSR( + List nrgList, Uuid clientNepUuid, Uuid networkNepUuid, Uuid nodeUuid) { + assertEquals(8, nrgList.size(), "muxponder DSR should contain 8 node rule group (4*DSR/I_ODU + 4*E_ODU/I_ODU)"); for (NodeRuleGroup nodeRuleGroup : nrgList) { - assertEquals("each node-rule-group should contain 2 NEP for muxponder DSR", - 2, nodeRuleGroup.getNodeEdgePoint().size()); + assertEquals(2, nodeRuleGroup.getNodeEdgePoint().size(), + "each node-rule-group should contain 2 NEP for muxponder DSR"); } List nodeEdgePointList = new ArrayList<>(nrgList.get(0).nonnullNodeEdgePoint().values()); assertThat("node-rule-group nb 2 should be between nep-client4 and nep-network1", @@ -994,122 +960,117 @@ public class ConvertORTopoToTapiTopoTest extends AbstractTest { assertThat("node-rule-group nb 2 should be between nep-client4 and nep-network1", nodeEdgePointList.get(1).getNodeEdgePointUuid().getValue(), either(containsString(networkNepUuid.getValue())).or(containsString(clientNepUuid.getValue()))); - assertEquals("node-rule-group nb 2 should be between nep-client4 and nep-network1 of the same node", - nodeEdgePointList.get(0).getNodeUuid(), nodeUuid); - assertEquals("node-rule-group nb 2 should be between nep-client4 and nep-network1 of the same node", - nodeEdgePointList.get(1).getNodeUuid(), nodeUuid); + assertEquals(nodeEdgePointList.get(0).getNodeUuid(), nodeUuid, + "node-rule-group nb 2 should be between nep-client4 and nep-network1 of the same node"); + assertEquals(nodeEdgePointList.get(1).getNodeUuid(), nodeUuid, + "node-rule-group nb 2 should be between nep-client4 and nep-network1 of the same node"); List rule = new ArrayList<>(nrgList.get(1).nonnullRule().values()); - assertEquals("node-rule-group nb 2 should contain a single rule", 1, rule.size()); - assertEquals("local-id of the rule should be 'forward'", - "forward", rule.get(0).getLocalId()); - assertEquals("the forwarding rule should be 'MAYFORWARDACROSSGROUP'", - ForwardingRule.MAYFORWARDACROSSGROUP, rule.get(0).getForwardingRule()); - assertEquals("the rule type should be 'FORWARDING'", - RuleType.FORWARDING, rule.get(0).getRuleType()); + assertEquals(1, rule.size(), "node-rule-group nb 2 should contain a single rule"); + assertEquals("forward", rule.get(0).getLocalId(), "local-id of the rule should be 'forward'"); + assertEquals(FORWARDINGRULEMAYFORWARDACROSSGROUP.VALUE, rule.get(0).getForwardingRule(), + "the forwarding rule should be 'MAYFORWARDACROSSGROUP'"); + assertEquals(RuleType.FORWARDING, rule.get(0).getRuleType().iterator().next(), + "the rule type should be 'FORWARDING'"); } - private void checkNodeRuleGroupForSwitchDSR(List nrgList, Uuid clientNepUuid, Uuid networkNepUuid, - Uuid nodeUuid) { - assertEquals("Switch-DSR should contain a single node rule group", 1, nrgList.size()); - assertEquals("Switch-DSR node-rule-group should contain 8 NEP", 8, nrgList.get(0).getNodeEdgePoint().size()); + private void checkNodeRuleGroupForSwitchDSR( + List nrgList, Uuid clientNepUuid, Uuid networkNepUuid, Uuid nodeUuid) { + assertEquals(2, nrgList.size(), "Switch-DSR should contain 2 node rule groups (DSR/I_ODU + E_ODU/I_ODU)"); + assertEquals(8, nrgList.get(0).getNodeEdgePoint().size(), "Switch-DSR node-rule-group should contain 8 NEP"); List nrg = nrgList.get(0).nonnullNodeEdgePoint().values().stream() .sorted((nrg1, nrg2) -> nrg1.getNodeEdgePointUuid().getValue() .compareTo(nrg2.getNodeEdgePointUuid().getValue())) .collect(Collectors.toList()); - assertEquals("in the sorted node-rule-group, nep number 7 should be XPDR2-NETWORK1", - networkNepUuid, nrg.get(6).getNodeEdgePointUuid()); - assertEquals("in the sorted node-rule-group, nep number 6 should be XPDR2-CLIENT4", - clientNepUuid, nrg.get(5).getNodeEdgePointUuid()); - assertEquals("any item of the node-rule-group should have the same nodeUuid", - nodeUuid, nrg.get(4).getNodeUuid()); - assertEquals("any item of the node-rule-group should have the same nodeUuid", - nodeUuid, nrg.get(3).getNodeUuid()); + assertEquals(networkNepUuid, nrg.get(6).getNodeEdgePointUuid(), + "in the sorted node-rule-group, nep number 7 should be XPDR2-NETWORK1"); + assertEquals(clientNepUuid, nrg.get(5).getNodeEdgePointUuid(), + "in the sorted node-rule-group, nep number 6 should be XPDR2-CLIENT4"); + assertEquals(nodeUuid, nrg.get(4).getNodeUuid(), + "any item of the node-rule-group should have the same nodeUuid"); + assertEquals(nodeUuid, nrg.get(3).getNodeUuid(), + "any item of the node-rule-group should have the same nodeUuid"); @Nullable List ruleList = new ArrayList<>(nrgList.get(0).nonnullRule().values()); - assertEquals("node-rule-group should contain a single rule", 1, ruleList.size()); - assertEquals("local-id of the rule should be 'forward'", - "forward", ruleList.get(0).getLocalId()); - assertEquals("the forwarding rule should be 'MAYFORWARDACROSSGROUP'", - ForwardingRule.MAYFORWARDACROSSGROUP, ruleList.get(0).getForwardingRule()); - assertEquals("the rule type should be 'FORWARDING'", - RuleType.FORWARDING, ruleList.get(0).getRuleType()); + assertEquals(1, ruleList.size(), "node-rule-group should contain a single rule"); + assertEquals("forward", ruleList.get(0).getLocalId(), "local-id of the rule should be 'forward'"); + assertEquals(FORWARDINGRULEMAYFORWARDACROSSGROUP.VALUE, ruleList.get(0).getForwardingRule(), + "the forwarding rule should be 'MAYFORWARDACROSSGROUP'"); + assertEquals(RuleType.FORWARDING, ruleList.get(0).getRuleType().iterator().next(), + "the rule type should be 'FORWARDING'"); } private void checkNodeRuleGroupForRdmInfra(List nrgList, int nbNeps) { - assertEquals("RDM infra node - OTSi should contain a single node rule groups", 1, nrgList.size()); + assertEquals(1, nrgList.size(), "RDM infra node - OTSi should contain a single node rule groups"); if (nbNeps > 0) { List nodeEdgePointList = new ArrayList<>(nrgList.get(0).getNodeEdgePoint().values()); - assertEquals("RDM infra node -rule-group should contain " + nbNeps + " NEP", - nbNeps, nodeEdgePointList.size()); + assertEquals(nbNeps, nodeEdgePointList.size(), + "RDM infra node -rule-group should contain " + nbNeps + " NEP"); } else { - assertNull("RDM infra node -rule-group should contain no NEP", nrgList.get(0).getNodeEdgePoint()); + assertNull(nrgList.get(0).getNodeEdgePoint(), "RDM infra node -rule-group should contain no NEP"); } List ruleList = new ArrayList<>(nrgList.get(0).nonnullRule().values()); - assertEquals("node-rule-group should contain a single rule", 1, ruleList.size()); - assertEquals("local-id of the rule should be 'forward'", - "forward", ruleList.get(0).getLocalId()); - assertEquals("the forwarding rule should be 'MAYFORWARDACROSSGROUP'", - ForwardingRule.MAYFORWARDACROSSGROUP, ruleList.get(0).getForwardingRule()); - assertEquals("the rule type should be 'FORWARDING'", - RuleType.FORWARDING, ruleList.get(0).getRuleType()); + assertEquals(1, ruleList.size(), "node-rule-group should contain a single rule"); + assertEquals("forward", ruleList.get(0).getLocalId(), "local-id of the rule should be 'forward'"); + assertEquals(FORWARDINGRULEMAYFORWARDACROSSGROUP.VALUE, ruleList.get(0).getForwardingRule(), + "the forwarding rule should be 'MAYFORWARDACROSSGROUP'"); + assertEquals(RuleType.FORWARDING, ruleList.get(0).getRuleType().iterator().next(), + "the rule type should be 'FORWARDING'"); } - private void checkNodeRuleGroupForTpdrOTSi(List nrgList, Uuid enepUuid, Uuid inepUuid, - Uuid nodeUuid) { - assertEquals("Tpdr-OTSi should contain two node rule groups", 2, nrgList.size()); + private void checkNodeRuleGroupForTpdrOTSi( + List nrgList, Uuid enepUuid, Uuid inepUuid, Uuid nodeUuid) { + assertEquals(2, nrgList.size(), "Tpdr-OTSi should contain two node rule groups"); List nodeEdgePointList = new ArrayList<>(nrgList.get(0).getNodeEdgePoint().values()); - assertEquals("Tpdr-OTSi node-rule-group should contain 2 NEP", 2, nodeEdgePointList.size()); + assertEquals(2, nodeEdgePointList.size(), "Tpdr-OTSi node-rule-group should contain 2 NEP"); assertThat("Tpdr-OTSi node-rule-group should be between eNEP and iNEP of XPDR1-NETWORK1", nodeEdgePointList.get(0).getNodeEdgePointUuid().getValue(), either(containsString(enepUuid.getValue())).or(containsString(inepUuid.getValue()))); assertThat("Tpdr-OTSi node-rule-group should be between eNEP and iNEP of XPDR1-NETWORK1", nodeEdgePointList.get(1).getNodeEdgePointUuid().getValue(), either(containsString(enepUuid.getValue())).or(containsString(inepUuid.getValue()))); - assertEquals("any item of the node-rule-group should have the same nodeUuid", - nodeUuid, nodeEdgePointList.get(0).getNodeUuid()); - assertEquals("any item of the node-rule-group should have the same nodeUuid", - nodeUuid, nodeEdgePointList.get(1).getNodeUuid()); + assertEquals(nodeUuid, nodeEdgePointList.get(0).getNodeUuid(), + "any item of the node-rule-group should have the same nodeUuid"); + assertEquals(nodeUuid, nodeEdgePointList.get(1).getNodeUuid(), + "any item of the node-rule-group should have the same nodeUuid"); List ruleList = new ArrayList<>(nrgList.get(0).nonnullRule().values()); - assertEquals("node-rule-group should contain a single rule", 1, ruleList.size()); - assertEquals("local-id of the rule should be 'forward'", - "forward", ruleList.get(0).getLocalId()); - assertEquals("the forwarding rule should be 'MAYFORWARDACROSSGROUP'", - ForwardingRule.MAYFORWARDACROSSGROUP, ruleList.get(0).getForwardingRule()); - assertEquals("the rule type should be 'FORWARDING'", - RuleType.FORWARDING, ruleList.get(0).getRuleType()); + assertEquals(1, ruleList.size(), "node-rule-group should contain a single rule"); + assertEquals("forward", ruleList.get(0).getLocalId(), "local-id of the rule should be 'forward'"); + assertEquals(FORWARDINGRULEMAYFORWARDACROSSGROUP.VALUE, ruleList.get(0).getForwardingRule(), + "the forwarding rule should be 'MAYFORWARDACROSSGROUP'"); + assertEquals(RuleType.FORWARDING, ruleList.get(0).getRuleType().iterator().next(), + "the rule type should be 'FORWARDING'"); } - private void checkNodeRuleGroupForMuxOTSi(List nrgList, Uuid enepUuid, Uuid inepUuid, - Uuid nodeUuid) { - assertEquals("Mux-OTSi should contain a single node rule group", 1, nrgList.size()); + private void checkNodeRuleGroupForMuxOTSi( + List nrgList, Uuid enepUuid, Uuid inepUuid, Uuid nodeUuid) { + assertEquals(1, nrgList.size(), "Mux-OTSi should contain a single node rule group"); List nodeEdgePointList = new ArrayList<>(nrgList.get(0).getNodeEdgePoint().values()); - assertEquals("Mux-OTSi node-rule-group should contain 2 NEP", 2, nodeEdgePointList.size()); + assertEquals(2, nodeEdgePointList.size(), "Mux-OTSi node-rule-group should contain 2 NEP"); assertThat("Mux-OTSi node-rule-group should be between eNEP and iNEP of XPDR1-NETWORK1", nodeEdgePointList.get(0).getNodeEdgePointUuid().getValue(), either(containsString(enepUuid.getValue())).or(containsString(inepUuid.getValue()))); assertThat("Mux-OTSi node-rule-group should be between eNEP and iNEP of XPDR1-NETWORK1", nodeEdgePointList.get(1).getNodeEdgePointUuid().getValue(), either(containsString(enepUuid.getValue())).or(containsString(inepUuid.getValue()))); - assertEquals("any item of the node-rule-group should have the same nodeUuid", - nodeUuid, nodeEdgePointList.get(0).getNodeUuid()); - assertEquals("any item of the node-rule-group should have the same nodeUuid", - nodeUuid, nodeEdgePointList.get(1).getNodeUuid()); + assertEquals(nodeUuid, nodeEdgePointList.get(0).getNodeUuid(), + "any item of the node-rule-group should have the same nodeUuid"); + assertEquals(nodeUuid, nodeEdgePointList.get(1).getNodeUuid(), + "any item of the node-rule-group should have the same nodeUuid"); List ruleList = new ArrayList<>(nrgList.get(0).nonnullRule().values()); - assertEquals("node-rule-group should contain a single rule", 1, ruleList.size()); - assertEquals("local-id of the rule should be 'forward'", - "forward", ruleList.get(0).getLocalId()); - assertEquals("the forwarding rule should be 'MAYFORWARDACROSSGROUP'", - ForwardingRule.MAYFORWARDACROSSGROUP, ruleList.get(0).getForwardingRule()); - assertEquals("the rule type should be 'FORWARDING'", - RuleType.FORWARDING, ruleList.get(0).getRuleType()); + assertEquals(1, ruleList.size(), "node-rule-group should contain a single rule"); + assertEquals("forward", ruleList.get(0).getLocalId(), "local-id of the rule should be 'forward'"); + assertEquals(FORWARDINGRULEMAYFORWARDACROSSGROUP.VALUE, ruleList.get(0).getForwardingRule(), + "the forwarding rule should be 'MAYFORWARDACROSSGROUP'"); + assertEquals(RuleType.FORWARDING, ruleList.get(0).getRuleType().iterator().next(), + "the rule type should be 'FORWARDING'"); } - private void checkNodeRuleGroupForSwitchOTSi(List nrgList, Uuid enepUuid, Uuid inepUuid, - Uuid nodeUuid) { - assertEquals("Switch-OTSi should contain 4 node rule group", 4, nrgList.size()); + private void checkNodeRuleGroupForSwitchOTSi( + List nrgList, Uuid enepUuid, Uuid inepUuid, Uuid nodeUuid) { + assertEquals(4, nrgList.size(), "Switch-OTSi should contain 4 node rule group"); for (NodeRuleGroup nodeRuleGroup : nrgList) { - assertEquals("each node-rule-group should contain 2 NEP for Switch-OTSi", - 2, nodeRuleGroup.getNodeEdgePoint().size()); + assertEquals(2, nodeRuleGroup.getNodeEdgePoint().size(), + "each node-rule-group should contain 2 NEP for Switch-OTSi"); } List nodeEdgePointList1 = new ArrayList<>(nrgList.get(3).nonnullNodeEdgePoint().values()); assertThat("Switch-OTSi node-rule-group nb 4 should be between eNEP and iNEP of XPDR2-NETWORK2", @@ -1119,192 +1080,168 @@ public class ConvertORTopoToTapiTopoTest extends AbstractTest { nodeEdgePointList1.get(1).getNodeEdgePointUuid().getValue(), either(containsString(enepUuid.getValue())).or(containsString(inepUuid.getValue()))); List nodeEdgePointList0 = new ArrayList<>(nrgList.get(0).getNodeEdgePoint().values()); - assertEquals("any item of the node-rule-group should have the same nodeUuid", - nodeUuid, nodeEdgePointList0.get(0).getNodeUuid()); - assertEquals("any item of the node-rule-group should have the same nodeUuid", - nodeUuid, nodeEdgePointList0.get(1).getNodeUuid()); + assertEquals(nodeUuid, nodeEdgePointList0.get(0).getNodeUuid(), + "any item of the node-rule-group should have the same nodeUuid"); + assertEquals(nodeUuid, nodeEdgePointList0.get(1).getNodeUuid(), + "any item of the node-rule-group should have the same nodeUuid"); List ruleList0 = new ArrayList<>(nrgList.get(0).nonnullRule().values()); - assertEquals("node-rule-group should contain a single rule", 1, ruleList0.size()); - assertEquals("local-id of the rule should be 'forward'", - "forward", ruleList0.get(0).getLocalId()); - assertEquals("the forwarding rule should be 'MAYFORWARDACROSSGROUP'", - ForwardingRule.MAYFORWARDACROSSGROUP, ruleList0.get(0).getForwardingRule()); - assertEquals("the rule type should be 'FORWARDING'", - RuleType.FORWARDING, ruleList0.get(0).getRuleType()); + assertEquals(1, ruleList0.size(), "node-rule-group should contain a single rule"); + assertEquals("forward", ruleList0.get(0).getLocalId(),"local-id of the rule should be 'forward'"); + assertEquals(FORWARDINGRULEMAYFORWARDACROSSGROUP.VALUE, ruleList0.get(0).getForwardingRule(), + "the forwarding rule should be 'MAYFORWARDACROSSGROUP'"); + assertEquals(RuleType.FORWARDING, ruleList0.get(0).getRuleType().iterator().next(), + "the rule type should be 'FORWARDING'"); } - private void checkNepClient100GSwitch(OwnedNodeEdgePoint nep, Uuid nepUuid, String portName, String nepName, - String nodeId, String extension) { - assertEquals("bad uuid for " + portName, nepUuid, nep.getUuid()); + private void checkNepClient100GSwitch( + OwnedNodeEdgePoint nep, Uuid nepUuid, String portName, String nepName, String nodeId, String extension) { + assertEquals(nepUuid, nep.getUuid(), "bad uuid for " + portName); List nameList = new ArrayList<>(nep.nonnullName().values()); - assertEquals("value of client nep should be '" + portName + "'", - String.join("+", nodeId, extension, portName), nameList.get(0).getValue()); - assertEquals("value-name of client nep for '" + portName + "' should be '" + nepName + "'", - nepName, nameList.get(0).getValueName()); - assertEquals("Client nep should support 2 kind of cep", - 2, nep.getSupportedCepLayerProtocolQualifier().size()); - assertThat("client nep should support 2 kind of cep", - nep.getSupportedCepLayerProtocolQualifier(), - hasItems(ODUTYPEODU4.class, DIGITALSIGNALTYPE100GigE.class)); - assertEquals("client nep should be of ETH protocol type", LayerProtocolName.ETH, nep.getLayerProtocolName()); + assertEquals(String.join("+", nodeId, extension, portName), nameList.get(0).getValue(), + "value of client nep should be '" + portName + "'"); + assertEquals(nepName, nameList.get(0).getValueName(), + "value-name of client nep for '" + portName + "' should be '" + nepName + "'"); + List lpql = new ArrayList<>(); + for (SupportedCepLayerProtocolQualifierInstances entry : nep.getSupportedCepLayerProtocolQualifierInstances()) { + lpql.add(entry.getLayerProtocolQualifier()); + } + assertEquals(2, lpql.size(), "Client nep should support 2 kind of cep"); + assertThat("client nep should support 2 kind of cep", lpql, + hasItems(ODUTYPEODU4.VALUE, DIGITALSIGNALTYPE100GigE.VALUE)); + assertEquals(LayerProtocolName.DSR, nep.getLayerProtocolName(), "client nep should be of DSR(ETH) protocol"); checkCommonPartOfNep(nep, false); checkSIP(nep, portName, nodeId, extension); } - private void checkNepClient100GTpdr(OwnedNodeEdgePoint nep, Uuid nepUuid, String portName, String nepName, - String nodeId, String extension) { - assertEquals("bad uuid for " + portName, nepUuid, nep.getUuid()); + private void checkNepClient100GTpdr( + OwnedNodeEdgePoint nep, Uuid nepUuid, String portName, String nepName, String nodeId, String extension) { + assertEquals(nepUuid, nep.getUuid(), "bad uuid for " + portName); List nameList = new ArrayList<>(nep.nonnullName().values()); - assertEquals("value of client nep should be '" + portName + "'", - String.join("+", nodeId, extension, portName), nameList.get(0).getValue()); - assertEquals("value-name of client nep for '" + portName + "' should be 100G-tpdr'", - nepName, nameList.get(0).getValueName()); - assertEquals("Client nep should support 1 kind of cep", - 1, nep.getSupportedCepLayerProtocolQualifier().size()); - assertThat("client nep should support 2 kind of cep", - nep.getSupportedCepLayerProtocolQualifier(), - hasItems(DIGITALSIGNALTYPE100GigE.class)); - assertEquals("client nep should be of ETH protocol type", LayerProtocolName.ETH, nep.getLayerProtocolName()); + assertEquals(String.join("+", nodeId, extension, portName), nameList.get(0).getValue(), + "value of client nep should be '" + portName + "'"); + assertEquals(nepName, nameList.get(0).getValueName(), + "value-name of client nep for '" + portName + "' should be 100G-tpdr'"); + List lpql = new ArrayList<>(); + for (SupportedCepLayerProtocolQualifierInstances entry : nep.getSupportedCepLayerProtocolQualifierInstances()) { + lpql.add(entry.getLayerProtocolQualifier()); + } + assertEquals(1, lpql.size(), "Client nep should support 1 kind of cep"); + assertThat("client nep should support 2 kind of cep", lpql, hasItems(DIGITALSIGNALTYPE100GigE.VALUE)); + assertEquals(LayerProtocolName.DSR, nep.getLayerProtocolName(), "client nep should be of DSR(ETH) protocol"); checkCommonPartOfNep(nep, false); checkSIP(nep, portName, nodeId, extension); } - private void checkNepOtsiNode(OwnedNodeEdgePoint nep, Uuid nepUuid, String portName, String nepName, - String nodeId, String extension) { - assertEquals("bad uuid for " + portName, nepUuid, nep.getUuid()); + private void checkNepOtsiNode( + OwnedNodeEdgePoint nep, Uuid nepUuid, String portName, String nepName, String nodeId, String extension) { + assertEquals(nepUuid, nep.getUuid(), "bad uuid for " + portName); List nameList = new ArrayList<>(nep.nonnullName().values()); - assertEquals("value of OTSi nep should be '" + portName + "'", - String.join("+", nodeId, extension, portName), nameList.get(0).getValue()); - assertEquals("value-name of OTSi nep should be '" + nepName + "'", - nepName, nameList.get(0).getValueName()); - assertEquals("OTSi nep should support 2 kind of cep", - 2, nep.getSupportedCepLayerProtocolQualifier().size()); - assertThat("OTSi nep should support 2 kind of cep", - nep.getSupportedCepLayerProtocolQualifier(), - hasItems(PHOTONICLAYERQUALIFIEROMS.class, PHOTONICLAYERQUALIFIEROTSi.class)); - assertEquals("OTSi nep should be of PHOTONIC_MEDIA protocol type", - LayerProtocolName.PHOTONICMEDIA, nep.getLayerProtocolName()); - assertEquals("OTSi nep should support one SIP", 1, nep.getMappedServiceInterfacePoint().size()); + assertEquals(String.join("+", nodeId, extension, portName), nameList.get(0).getValue(), + "value of OTSi nep should be '" + portName + "'"); + assertEquals(nepName, nameList.get(0).getValueName(), "value-name of OTSi nep should be '" + nepName + "'"); + List lpql = new ArrayList<>(); + for (SupportedCepLayerProtocolQualifierInstances entry : nep.getSupportedCepLayerProtocolQualifierInstances()) { + lpql.add(entry.getLayerProtocolQualifier()); + } + assertEquals(2, lpql.size(), "OTSi nep should support 2 kind of cep"); + assertThat("OTSi nep should support 2 kind of cep", lpql, + hasItems(PHOTONICLAYERQUALIFIEROMS.VALUE, PHOTONICLAYERQUALIFIEROTSi.VALUE)); + assertEquals(LayerProtocolName.PHOTONICMEDIA, nep.getLayerProtocolName(), + "OTSi nep should be of PHOTONIC_MEDIA protocol type"); + assertEquals(1, nep.getMappedServiceInterfacePoint().size(), "OTSi nep should support one SIP"); checkCommonPartOfNep(nep, false); checkSIP(nep, portName, nodeId, extension); } private void checkSIP(OwnedNodeEdgePoint nep, String portName, String nodeId, String extension) { - Uuid sipUuid = new Uuid(UUID.nameUUIDFromBytes((String.join("+", "SIP", nodeId, extension, portName)) - .getBytes(Charset.forName("UTF-8"))).toString()); - assertEquals("service-interface-point-uuid of network nep for '" + portName + "' should be '" - + String.join("+", "SIP", portName) + "'", sipUuid, nep.getMappedServiceInterfacePoint() - .get(new MappedServiceInterfacePointKey(sipUuid)).getServiceInterfacePointUuid()); + Uuid sipUuid = new Uuid( + UUID.nameUUIDFromBytes((String.join("+", "SIP", nodeId, extension, portName)) + .getBytes(Charset.forName("UTF-8"))) + .toString()); + assertEquals( + sipUuid, + nep.getMappedServiceInterfacePoint().get(new MappedServiceInterfacePointKey(sipUuid)) + .getServiceInterfacePointUuid(), + "service-interface-point-uuid of network nep for '" + portName + "' should be '" + + String.join("+", "SIP", portName) + "'"); } private void checkNepOtsiRdmNode(OwnedNodeEdgePoint nep, Uuid nepUuid, String portName, String nepName) { - assertEquals("bad uuid for " + portName, nepUuid, nep.getUuid()); + assertEquals(nepUuid, nep.getUuid(), "bad uuid for " + portName); List nameList = new ArrayList<>(nep.nonnullName().values()); - assertEquals("value of OTSi nep should be '" + portName + "'", - portName, nameList.get(0).getValue()); - assertEquals("value-name of OTSi nep should be '" + nepName + "'", - nepName, nameList.get(0).getValueName()); - assertEquals("OTSi nep of RDM infra node should support only 1 kind of cep", - 1, nep.getSupportedCepLayerProtocolQualifier().size()); - assertThat("OTSi nep should support 2 kind of cep", - nep.getSupportedCepLayerProtocolQualifier(), - hasItems(PHOTONICLAYERQUALIFIEROMS.class)); - assertEquals("OTSi nep should be of PHOTONIC_MEDIA protocol type", - LayerProtocolName.PHOTONICMEDIA, nep.getLayerProtocolName()); - assertEquals("OTSi nep of RDM infra should support no SIP", 0, nep.nonnullMappedServiceInterfacePoint().size()); + assertEquals(portName, nameList.get(0).getValue(), "value of OTSi nep should be '" + portName + "'"); + assertEquals(nepName, nameList.get(0).getValueName(), "value-name of OTSi nep should be '" + nepName + "'"); + List lpql = new ArrayList<>(); + for (SupportedCepLayerProtocolQualifierInstances entry : nep.getSupportedCepLayerProtocolQualifierInstances()) { + lpql.add(entry.getLayerProtocolQualifier()); + } + assertEquals(1, lpql.size(), "OTSi nep of RDM infra node should support only 1 kind of cep"); + assertThat("OTSi nep should support OTS cep", lpql, hasItems(PHOTONICLAYERQUALIFIEROTS.VALUE)); + assertEquals(LayerProtocolName.PHOTONICMEDIA, nep.getLayerProtocolName(), + "OTSi nep should be of PHOTONIC_MEDIA protocol type"); + assertEquals(0, nep.nonnullMappedServiceInterfacePoint().size(), "OTSi nep of RDM infra should support no SIP"); checkCommonPartOfNep(nep, true); } private void checkCommonPartOfNep(OwnedNodeEdgePoint nep, boolean isRdm) { - assertEquals("link port direction should be DIRECTIONAL", - PortDirection.BIDIRECTIONAL, nep.getLinkPortDirection()); - assertEquals("administrative state should be UNLOCKED", - AdministrativeState.UNLOCKED, nep.getAdministrativeState()); - assertEquals("termination state should be TERMINATED BIDIRECTIONAL", - TerminationState.TERMINATEDBIDIRECTIONAL, nep.getTerminationState()); - assertEquals("life-cycle state should be INSTALLED", LifecycleState.INSTALLED, nep.getLifecycleState()); + assertEquals(Direction.BIDIRECTIONAL, nep.getDirection(), + "link port direction should be DIRECTIONAL"); + assertEquals(AdministrativeState.UNLOCKED, nep.getAdministrativeState(), + "administrative state should be UNLOCKED"); +// TODO: convert this test since terminationState is migrated to CEP attribute in TAPI 2.4 +// assertEquals(TerminationState.TERMINATEDBIDIRECTIONAL, nep.getTerminationState(), +// "termination state should be TERMINATED BIDIRECTIONAL"); + assertEquals(LifecycleState.INSTALLED, nep.getLifecycleState(), + "life-cycle state should be INSTALLED"); if (!isRdm) { - assertEquals("client nep should support 1 SIP", 1, nep.getMappedServiceInterfacePoint().size()); + assertEquals(1, nep.getMappedServiceInterfacePoint().size(), "client nep should support 1 SIP"); } - assertEquals("termination direction should be BIDIRECTIONAL", - TerminationDirection.BIDIRECTIONAL, nep.getTerminationDirection()); - assertEquals("operational state of client nep should be ENABLED", - OperationalState.ENABLED, nep.getOperationalState()); - assertEquals("link-port-role of client nep should be SYMMETRIC", - PortRole.SYMMETRIC, nep.getLinkPortRole()); +// TODO: convert this test since terminationState is migrated to CEP attribute in TAPI 2.4 +// assertEquals(TerminationDirection.BIDIRECTIONAL, nep.getTerminationDirection(), +// "termination direction should be BIDIRECTIONAL"); + assertEquals(OperationalState.ENABLED, nep.getOperationalState(), + "operational state of client nep should be ENABLED"); + assertEquals(PortRole.SYMMETRIC, nep.getLinkPortRole(), "link-port-role of client nep should be SYMMETRIC"); } - private void checkTransitionalLink(Link link, Uuid node1Uuid, Uuid node2Uuid, String tp1, String tp2, - String ietfNodeId) { - Uuid linkUuid = new Uuid(UUID.nameUUIDFromBytes((tp1 + "to" + tp2) - .getBytes(Charset.forName("UTF-8"))).toString()); - assertEquals("bad uuid for link between DSR node " + tp1 + " and iOTSI port " + tp2, linkUuid, link.getUuid()); - assertEquals("Available capacity unit should be GBPS", - CapacityUnit.GBPS, link.getAvailableCapacity().getTotalSize().getUnit()); - assertEquals("Available capacity -total size value should be 100", - Uint64.valueOf(100), link.getAvailableCapacity().getTotalSize().getValue()); - assertEquals("transitional link should be between 2 nodes of protocol layers ODU and PHOTONIC_MEDIA", - 2, link.getTransitionedLayerProtocolName().size()); - assertThat("transitional link should be between 2 nodes of protocol layers ODU and PHOTONIC_MEDIA", - link.getTransitionedLayerProtocolName(), - hasItems(LayerProtocolName.ODU.getName(), LayerProtocolName.PHOTONICMEDIA.getName())); - assertEquals("transitional link should be BIDIRECTIONAL", - ForwardingDirection.BIDIRECTIONAL, link.getDirection()); - List nodeEdgePointList = new ArrayList<>(link.nonnullNodeEdgePoint().values()); - assertEquals("topology uuid should be the same for the two termination point of the link", - topologyUuid, nodeEdgePointList.get(0).getTopologyUuid()); - assertEquals("topology uuid should be the same for the two termination point of the link", - topologyUuid, nodeEdgePointList.get(1).getTopologyUuid()); - assertThat("transitional links should terminate on DSR node and Photonic node", - nodeEdgePointList.get(0).getNodeUuid().getValue(), - either(containsString(node1Uuid.getValue())).or(containsString(node2Uuid.getValue()))); - assertThat("transitional links should terminate on DSR node and Photonic node", - nodeEdgePointList.get(1).getNodeUuid().getValue(), - either(containsString(node1Uuid.getValue())).or(containsString(node2Uuid.getValue()))); - Uuid nep1Uuid = new Uuid(UUID.nameUUIDFromBytes(tp1.getBytes(Charset.forName("UTF-8"))).toString()); - Uuid nep2Uuid = new Uuid(UUID.nameUUIDFromBytes(tp2.getBytes(Charset.forName("UTF-8"))).toString()); - assertThat("transitional links should terminate on " + tp1 + " and " + tp2 + " neps", - nodeEdgePointList.get(0).getNodeEdgePointUuid().getValue(), - either(containsString(nep1Uuid.getValue())).or(containsString(nep2Uuid.getValue()))); - assertThat("transitional links should terminate on DSR node and Photonic node", - nodeEdgePointList.get(1).getNodeEdgePointUuid().getValue(), - either(containsString(nep1Uuid.getValue())).or(containsString(nep2Uuid.getValue()))); - } - - private void checkOtnLink(Link link, Uuid node1Uuid, Uuid node2Uuid, Uuid tp1Uuid, Uuid tp2Uuid, Uuid linkUuid, - String linkName) { - assertEquals("bad name for the link", linkName, link.getName().get(new NameKey("otn link name")).getValue()); - assertEquals("bad uuid for link", linkUuid, link.getUuid()); - assertEquals("Available capacity unit should be MBPS", - CapacityUnit.GBPS, link.getAvailableCapacity().getTotalSize().getUnit()); + private void checkOtnLink( + Link link, Uuid node1Uuid, Uuid node2Uuid, Uuid tp1Uuid, Uuid tp2Uuid, Uuid linkUuid, String linkName) { + assertEquals(linkName, link.getName().get(new NameKey("otn link name")).getValue(), "bad name for the link"); + assertEquals(linkUuid, link.getUuid(), "bad uuid for link"); + assertEquals(CAPACITYUNITGBPS.VALUE, link.getAvailableCapacity().getTotalSize().getUnit(), + "Available capacity unit should be MBPS"); String prefix = linkName.split("-")[0]; if ("OTU4".equals(prefix)) { - assertEquals("Available capacity -total size value should be 0", - Uint64.valueOf(0), link.getAvailableCapacity().getTotalSize().getValue()); + assertEquals(Uint64.valueOf(0), link.getAvailableCapacity().getTotalSize().getValue(), + "Available capacity -total size value should be 0"); } else if ("ODTU4".equals(prefix)) { - assertEquals("Available capacity -total size value should be 100 000", - Uint64.valueOf(100000), link.getAvailableCapacity().getTotalSize().getValue()); + assertEquals(Uint64.valueOf(100000), link.getAvailableCapacity().getTotalSize().getValue(), + "Available capacity -total size value should be 100 000"); } - assertEquals("Total capacity unit should be GBPS", - CapacityUnit.GBPS, link.getTotalPotentialCapacity().getTotalSize().getUnit()); - assertEquals("Total capacity -total size value should be 100", - Uint64.valueOf(100), link.getTotalPotentialCapacity().getTotalSize().getValue()); + assertEquals(CAPACITYUNITGBPS.VALUE, link.getTotalPotentialCapacity().getTotalSize().getUnit(), + "Total capacity unit should be GBPS"); + assertEquals(Decimal64.valueOf("100"), link.getTotalPotentialCapacity().getTotalSize().getValue(), + "Total capacity -total size value should be 100"); if ("OTU4".equals(prefix)) { - assertEquals("otn link should be between 2 nodes of protocol layers PHOTONIC_MEDIA", - LayerProtocolName.PHOTONICMEDIA.getName(), link.getLayerProtocolName().get(0).getName()); + assertEquals( + LayerProtocolName.PHOTONICMEDIA.getName(), + link.getLayerProtocolName().stream().findFirst().orElseThrow().getName(), + "otn link should be between 2 nodes of protocol layers PHOTONIC_MEDIA"); } else if ("ODTU4".equals(prefix)) { - assertEquals("otn link should be between 2 nodes of protocol layers ODU", - LayerProtocolName.ODU.getName(), link.getLayerProtocolName().get(0).getName()); + assertEquals( + LayerProtocolName.ODU.getName(), + link.getLayerProtocolName().stream().findFirst().orElseThrow().getName(), + "otn link should be between 2 nodes of protocol layers ODU"); } - assertEquals("otn tapi link should be BIDIRECTIONAL", - ForwardingDirection.BIDIRECTIONAL, link.getDirection()); - List nodeEdgePointList = new ArrayList<>(link.nonnullNodeEdgePoint().values()); - assertEquals("topology uuid should be the same for the two termination point of the link", - topologyUuid, nodeEdgePointList.get(0).getTopologyUuid()); - assertEquals("topology uuid should be the same for the two termination point of the link", - topologyUuid, nodeEdgePointList.get(1).getTopologyUuid()); + assertEquals(ForwardingDirection.BIDIRECTIONAL, link.getDirection(), "otn tapi link should be BIDIRECTIONAL"); + List nodeEdgePointList = new ArrayList<>(link.nonnullNodeEdgePoint().values()); + LOG.info("OUTPUT: Node1UUID = {}, Node2UU2D = {},", node1Uuid, node2Uuid); + LOG.info("NEPLIST = {}", nodeEdgePointList); + assertEquals(topologyUuid, nodeEdgePointList.get(0).getTopologyUuid(), + "topology uuid should be the same for the two termination point of the link"); + assertEquals(topologyUuid, nodeEdgePointList.get(1).getTopologyUuid(), + "topology uuid should be the same for the two termination point of the link"); assertThat("otn links should terminate on two distinct nodes", nodeEdgePointList.get(0).getNodeUuid().getValue(), either(containsString(node1Uuid.getValue())).or(containsString(node2Uuid.getValue()))); @@ -1317,27 +1254,27 @@ public class ConvertORTopoToTapiTopoTest extends AbstractTest { assertThat("otn links should terminate on two distinct tps", nodeEdgePointList.get(1).getNodeEdgePointUuid().getValue(), either(containsString(tp1Uuid.getValue())).or(containsString(tp2Uuid.getValue()))); - assertEquals("operational state should be ENABLED", - OperationalState.ENABLED, link.getOperationalState()); - assertEquals("administrative state should be UNLOCKED", - AdministrativeState.UNLOCKED, link.getAdministrativeState()); + assertEquals(OperationalState.ENABLED, link.getOperationalState(), "operational state should be ENABLED"); + assertEquals(AdministrativeState.UNLOCKED, link.getAdministrativeState(), + "administrative state should be UNLOCKED"); } - private void checkOmsLink(Link link, Uuid node1Uuid, Uuid node2Uuid, Uuid tp1Uuid, Uuid tp2Uuid, Uuid linkUuid, - String linkName) { - assertEquals("bad name for the link", linkName, link.getName().get(new NameKey("OMS link name")).getValue()); - assertEquals("bad uuid for link", linkUuid, link.getUuid()); - assertEquals("oms link should be between 2 nodes of protocol layers PHOTONIC_MEDIA", - LayerProtocolName.PHOTONICMEDIA.getName(), link.getLayerProtocolName().get(0).getName()); - assertEquals("otn tapi link should be BIDIRECTIONAL", - ForwardingDirection.BIDIRECTIONAL, link.getDirection()); - List nodeEdgePointList = new ArrayList<>(link.nonnullNodeEdgePoint().values()); - assertEquals("oms link should be between 2 neps",2 , nodeEdgePointList.size()); - assertEquals("topology uuid should be the same for the two termination point of the link", - topologyUuid, nodeEdgePointList.get(0).getTopologyUuid()); - assertEquals("topology uuid should be the same for the two termination point of the link", - topologyUuid, nodeEdgePointList.get(1).getTopologyUuid()); + private void checkOmsLink( + Link link, Uuid node1Uuid, Uuid node2Uuid, Uuid tp1Uuid, Uuid tp2Uuid, Uuid linkUuid, String linkName) { + assertEquals(linkName, link.getName().get(new NameKey("OTS link name")).getValue(), "bad name for the link"); + assertEquals(linkUuid, link.getUuid(), "bad uuid for link"); + assertEquals( + LayerProtocolName.PHOTONICMEDIA.getName(), + link.getLayerProtocolName().stream().findFirst().orElseThrow().getName(), + "oms link should be between 2 nodes of protocol layers PHOTONIC_MEDIA"); + assertEquals(ForwardingDirection.BIDIRECTIONAL, link.getDirection(), "otn tapi link should be BIDIRECTIONAL"); + List nodeEdgePointList = new ArrayList<>(link.nonnullNodeEdgePoint().values()); + assertEquals(2, nodeEdgePointList.size(), "oms link should be between 2 neps"); + assertEquals(topologyUuid, nodeEdgePointList.get(0).getTopologyUuid(), + "topology uuid should be the same for the two termination point of the link"); + assertEquals(topologyUuid, nodeEdgePointList.get(1).getTopologyUuid(), + "topology uuid should be the same for the two termination point of the link"); assertThat("oms links should terminate on two distinct nodes", nodeEdgePointList.get(0).getNodeUuid().getValue(), either(containsString(node1Uuid.getValue())).or(containsString(node2Uuid.getValue()))); @@ -1353,34 +1290,50 @@ public class ConvertORTopoToTapiTopoTest extends AbstractTest { } private Node changeTerminationPointState(Node initialNode, String tpid, AdminStates admin, State oper) { - org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.network.topology.rev180226.Node1Builder tpdr1Bldr - = new org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.network.topology.rev180226.Node1Builder( - initialNode.augmentation(Node1.class)); + var tpdr1Bldr = new org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.network.topology.rev180226 + .Node1Builder(initialNode.augmentation(Node1.class)); Map tps = new HashMap<>(tpdr1Bldr.getTerminationPoint()); - TerminationPointBuilder tpBldr = new TerminationPointBuilder( - tps.get(new TerminationPointKey(new TpId(tpid)))); - TerminationPoint1Builder tp1Bldr = new TerminationPoint1Builder(tpBldr.augmentation(TerminationPoint1.class)); - tp1Bldr.setAdministrativeState(admin) - .setOperationalState(oper); + TerminationPointBuilder tpBldr = new TerminationPointBuilder(tps.get(new TerminationPointKey(new TpId(tpid)))); + TerminationPoint1Builder tp1Bldr = + new TerminationPoint1Builder(tpBldr.augmentation(TerminationPoint1.class)) + .setAdministrativeState(admin) + .setOperationalState(oper); tpBldr.addAugmentation(tp1Bldr.build()); tps.replace(tpBldr.key(), tpBldr.build()); - tpdr1Bldr.setTerminationPoint(tps); - return new NodeBuilder(initialNode).addAugmentation(tpdr1Bldr.build()).build(); + return new NodeBuilder(initialNode).addAugmentation(tpdr1Bldr.setTerminationPoint(tps).build()).build(); } - private org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.network.topology.rev180226.networks.network - .Link changeOtnLinkState( - org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.network.topology.rev180226.networks.network - .Link initiallink, AdminStates admin, State oper) { + private org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.network.topology.rev180226 + .networks.network.Link changeOtnLinkState( + org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.network.topology.rev180226 + .networks.network.Link initiallink, + AdminStates admin, + State oper) { + var linkBldr = new org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.network.topology.rev180226 + .networks.network.LinkBuilder(initiallink); + return linkBldr + .addAugmentation( + new Link1Builder(linkBldr.augmentation(Link1.class)) + .setAdministrativeState(admin) + .setOperationalState(oper) + .build()) + .build(); + } - org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.network.topology.rev180226.networks.network - .LinkBuilder linkBldr = new - org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.network.topology.rev180226.networks.network - .LinkBuilder(initiallink); - Link1Builder link1Bldr = new Link1Builder(linkBldr.augmentation(Link1.class)); - link1Bldr.setAdministrativeState(admin) - .setOperationalState(oper); - linkBldr.addAugmentation(link1Bldr.build()); - return linkBldr.build(); + private int getNodeRank( + String searchedChar, + List nodeList) { + int foundAtRank = 0; + int rank = 0; + for (var node: nodeList) { + for (Map.Entry entry: node.getName().entrySet()) { + if (entry.getValue().getValue().contains(searchedChar)) { + foundAtRank = rank; + } + } + rank++; + } + LOG.info("searched Char {} found at rank {}", searchedChar, foundAtRank); + return foundAtRank; } -} \ No newline at end of file +}