X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=tests%2Ftransportpce_tests%2F1.2.1%2Ftest_portmapping.py;h=51694b5683ef88a8eddf2a4c221e381626fd37bd;hb=6fe500a1bf557eb44d22584ac6bf7c924f12c47f;hp=a1daf17f270c66950da29426721010e4df476a76;hpb=c668b61cda0335795bb554acd2c85b744044780b;p=transportpce.git

diff --git a/tests/transportpce_tests/1.2.1/test_portmapping.py b/tests/transportpce_tests/1.2.1/test_portmapping.py
index a1daf17f2..51694b568 100644
--- a/tests/transportpce_tests/1.2.1/test_portmapping.py
+++ b/tests/transportpce_tests/1.2.1/test_portmapping.py
@@ -9,6 +9,9 @@
 # http://www.apache.org/licenses/LICENSE-2.0
 ##############################################################################
 
+# pylint: disable=no-member
+# pylint: disable=too-many-public-methods
+
 import unittest
 import time
 import requests
@@ -26,6 +29,7 @@ class TransportPCEPortMappingTesting(unittest.TestCase):
 
     @classmethod
     def tearDownClass(cls):
+        # pylint: disable=not-an-iterable
         for process in cls.processes:
             test_utils.shutdown_process(process)
         print("all processes killed")
@@ -42,9 +46,7 @@ class TransportPCEPortMappingTesting(unittest.TestCase):
 #                         'connected')
 
 #     def test_02_restconfAPI(self):
-#         url = ("{}/config/transportpce-portmapping:network/nodes/controller-config")
-#         response = requests.request(
-#             "GET", url, headers=test_utils.TYPE_APPLICATION_JSON, auth=(test_utils.ODL_LOGIN, test_utils.ODL_PWD))
+#         response = test_utils.portmapping_request("controller-config")
 #         self.assertEqual(response.status_code, requests.codes.not_found)
 #         res = response.json()
 #         self.assertIn(
@@ -66,10 +68,7 @@ class TransportPCEPortMappingTesting(unittest.TestCase):
         time.sleep(10)
 
     def test_03_rdm_portmapping_info(self):
-        url = ("{}/config/transportpce-portmapping:network/"
-               "nodes/ROADMA01/node-info"
-               )
-        response = test_utils.get_request(url)
+        response = test_utils.portmapping_request("ROADMA01/node-info")
         self.assertEqual(response.status_code, requests.codes.ok)
         res = response.json()
         self.assertEqual(
@@ -82,10 +81,7 @@ class TransportPCEPortMappingTesting(unittest.TestCase):
         time.sleep(3)
 
     def test_04_rdm_portmapping_DEG1_TTP_TXRX(self):
-        url = ("{}/config/transportpce-portmapping:network/"
-               "nodes/ROADMA01/mapping/DEG1-TTP-TXRX"
-               )
-        response = test_utils.get_request(url)
+        response = test_utils.portmapping_request("ROADMA01/mapping/DEG1-TTP-TXRX")
         self.assertEqual(response.status_code, requests.codes.ok)
         res = response.json()
         self.assertIn(
@@ -94,10 +90,7 @@ class TransportPCEPortMappingTesting(unittest.TestCase):
             res['mapping'])
 
     def test_05_rdm_portmapping_SRG1_PP7_TXRX(self):
-        url = ("{}/config/transportpce-portmapping:network/"
-               "nodes/ROADMA01/mapping/SRG1-PP7-TXRX"
-               )
-        response = test_utils.get_request(url)
+        response = test_utils.portmapping_request("ROADMA01/mapping/SRG1-PP7-TXRX")
         self.assertEqual(response.status_code, requests.codes.ok)
         res = response.json()
         self.assertIn(
@@ -106,10 +99,7 @@ class TransportPCEPortMappingTesting(unittest.TestCase):
             res['mapping'])
 
     def test_06_rdm_portmapping_SRG3_PP1_TXRX(self):
-        url = ("{}/config/transportpce-portmapping:network/"
-               "nodes/ROADMA01/mapping/SRG3-PP1-TXRX"
-               )
-        response = test_utils.get_request(url)
+        response = test_utils.portmapping_request("ROADMA01/mapping/SRG3-PP1-TXRX")
         self.assertEqual(response.status_code, requests.codes.ok)
         res = response.json()
         self.assertIn(
@@ -131,10 +121,7 @@ class TransportPCEPortMappingTesting(unittest.TestCase):
         time.sleep(10)
 
     def test_09_xpdr_portmapping_info(self):
-        url = ("{}/config/transportpce-portmapping:network/"
-               "nodes/XPDRA01/node-info"
-               )
-        response = test_utils.get_request(url)
+        response = test_utils.portmapping_request("XPDRA01/node-info")
         self.assertEqual(response.status_code, requests.codes.ok)
         res = response.json()
         self.assertEqual(
@@ -147,10 +134,7 @@ class TransportPCEPortMappingTesting(unittest.TestCase):
         time.sleep(3)
 
     def test_10_xpdr_portmapping_NETWORK1(self):
-        url = ("{}/config/transportpce-portmapping:network/"
-               "nodes/XPDRA01/mapping/XPDR1-NETWORK1"
-               )
-        response = test_utils.get_request(url)
+        response = test_utils.portmapping_request("XPDRA01/mapping/XPDR1-NETWORK1")
         self.assertEqual(response.status_code, requests.codes.ok)
         res = response.json()
         self.assertIn(
@@ -161,10 +145,7 @@ class TransportPCEPortMappingTesting(unittest.TestCase):
             res['mapping'])
 
     def test_11_xpdr_portmapping_NETWORK2(self):
-        url = ("{}/config/transportpce-portmapping:network/"
-               "nodes/XPDRA01/mapping/XPDR1-NETWORK2"
-               )
-        response = test_utils.get_request(url)
+        response = test_utils.portmapping_request("XPDRA01/mapping/XPDR1-NETWORK2")
         self.assertEqual(response.status_code, requests.codes.ok)
         res = response.json()
         self.assertIn(
@@ -175,10 +156,7 @@ class TransportPCEPortMappingTesting(unittest.TestCase):
             res['mapping'])
 
     def test_12_xpdr_portmapping_CLIENT1(self):
-        url = ("{}/config/transportpce-portmapping:network/"
-               "nodes/XPDRA01/mapping/XPDR1-CLIENT1"
-               )
-        response = test_utils.get_request(url)
+        response = test_utils.portmapping_request("XPDRA01/mapping/XPDR1-CLIENT1")
         self.assertEqual(response.status_code, requests.codes.ok)
         res = response.json()
         self.assertIn(
@@ -190,10 +168,7 @@ class TransportPCEPortMappingTesting(unittest.TestCase):
             res['mapping'])
 
     def test_13_xpdr_portmapping_CLIENT2(self):
-        url = ("{}/config/transportpce-portmapping:network/"
-               "nodes/XPDRA01/mapping/XPDR1-CLIENT2"
-               )
-        response = test_utils.get_request(url)
+        response = test_utils.portmapping_request("XPDRA01/mapping/XPDR1-CLIENT2")
         self.assertEqual(response.status_code, requests.codes.ok)
         res = response.json()
         self.assertIn(
@@ -205,10 +180,7 @@ class TransportPCEPortMappingTesting(unittest.TestCase):
             res['mapping'])
 
     def test_14_xpdr_portmapping_CLIENT3(self):
-        url = ("{}/config/transportpce-portmapping:network/"
-               "nodes/XPDRA01/mapping/XPDR1-CLIENT3"
-               )
-        response = test_utils.get_request(url)
+        response = test_utils.portmapping_request("XPDRA01/mapping/XPDR1-CLIENT3")
         self.assertEqual(response.status_code, requests.codes.ok)
         res = response.json()
         self.assertIn(
@@ -220,10 +192,7 @@ class TransportPCEPortMappingTesting(unittest.TestCase):
             res['mapping'])
 
     def test_15_xpdr_portmapping_CLIENT4(self):
-        url = ("{}/config/transportpce-portmapping:network/"
-               "nodes/XPDRA01/mapping/XPDR1-CLIENT4"
-               )
-        response = test_utils.get_request(url)
+        response = test_utils.portmapping_request("XPDRA01/mapping/XPDR1-CLIENT4")
         self.assertEqual(response.status_code, requests.codes.ok)
         res = response.json()
         self.assertIn(
@@ -239,7 +208,7 @@ class TransportPCEPortMappingTesting(unittest.TestCase):
 
     def test_17_xpdr_device_disconnected(self):
         response = test_utils.get_netconf_oper_request("XPDRA01")
-        self.assertEqual(response.status_code, requests.codes.not_found)
+        self.assertEqual(response.status_code, requests.codes.conflict)
         res = response.json()
         self.assertIn(
             {"error-type": "application", "error-tag": "data-missing",
@@ -247,9 +216,8 @@ class TransportPCEPortMappingTesting(unittest.TestCase):
             res['errors']['error'])
 
     def test_18_xpdr_device_not_connected(self):
-        url = ("{}/config/transportpce-portmapping:network/nodes/XPDRA01")
-        response = test_utils.get_request(url)
-        self.assertEqual(response.status_code, requests.codes.not_found)
+        response = test_utils.portmapping_request("XPDRA01")
+        self.assertEqual(response.status_code, requests.codes.conflict)
         res = response.json()
         self.assertIn(
             {"error-type": "application", "error-tag": "data-missing",
@@ -262,7 +230,7 @@ class TransportPCEPortMappingTesting(unittest.TestCase):
 
     def test_20_rdm_device_disconnected(self):
         response = test_utils.get_netconf_oper_request("ROADMA01")
-        self.assertEqual(response.status_code, requests.codes.not_found)
+        self.assertEqual(response.status_code, requests.codes.conflict)
         res = response.json()
         self.assertIn(
             {"error-type": "application", "error-tag": "data-missing",
@@ -270,9 +238,8 @@ class TransportPCEPortMappingTesting(unittest.TestCase):
             res['errors']['error'])
 
     def test_21_rdm_device_not_connected(self):
-        url = ("{}/config/transportpce-portmapping:network/nodes/ROADMA01")
-        response = test_utils.get_request(url)
-        self.assertEqual(response.status_code, requests.codes.not_found)
+        response = test_utils.portmapping_request("ROADMA01")
+        self.assertEqual(response.status_code, requests.codes.conflict)
         res = response.json()
         self.assertIn(
             {"error-type": "application", "error-tag": "data-missing",