X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=tests%2Ftransportpce_tests%2F2.2.1%2Ftest_topology.py;h=936ccfc5d4761b5bed7fc2004211f32ff7facd5d;hb=6fe500a1bf557eb44d22584ac6bf7c924f12c47f;hp=c30f9151548ba5c26a9c6fb4e33b0f2f7f3f4583;hpb=82ae34c05bd194c26ef4e30b2bdf1cf19093e19b;p=transportpce.git diff --git a/tests/transportpce_tests/2.2.1/test_topology.py b/tests/transportpce_tests/2.2.1/test_topology.py index c30f91515..936ccfc5d 100644 --- a/tests/transportpce_tests/2.2.1/test_topology.py +++ b/tests/transportpce_tests/2.2.1/test_topology.py @@ -11,6 +11,7 @@ # pylint: disable=no-member # pylint: disable=too-many-public-methods +# pylint: disable=too-many-lines import unittest import time @@ -30,6 +31,7 @@ class TransportPCEtesting(unittest.TestCase): @classmethod def tearDownClass(cls): + # pylint: disable=not-an-iterable for process in cls.processes: test_utils.shutdown_process(process) print("all processes killed") @@ -60,6 +62,7 @@ class TransportPCEtesting(unittest.TestCase): self.assertEqual(res['network'][0]['node'][0]['org-openroadm-network:model'], 'model2') def test_04_getLinks_OpenroadmTopology(self): + # pylint: disable=redundant-unittest-assert response = test_utils.get_ordm_topo_request("") self.assertEqual(response.status_code, requests.codes.ok) res = response.json() @@ -100,6 +103,7 @@ class TransportPCEtesting(unittest.TestCase): self.assertEqual(len(dropLink), 0) def test_05_getNodes_OpenRoadmTopology(self): + # pylint: disable=redundant-unittest-assert response = test_utils.get_ordm_topo_request("") res = response.json() # Tests related to nodes @@ -112,7 +116,7 @@ class TransportPCEtesting(unittest.TestCase): res['network'][0]['node'][i]['supporting-node']) nodeType = res['network'][0]['node'][i]['org-openroadm-common-network:node-type'] nodeId = res['network'][0]['node'][i]['node-id'] - if(nodeId == 'ROADM-A1-SRG1'): + if nodeId == 'ROADM-A1-SRG1': # Test related to SRG1 self.assertEqual(nodeType, 'SRG') self.assertEqual(len(res['network'][0]['node'][i]['ietf-network-topology:termination-point']), 5) @@ -125,7 +129,7 @@ class TransportPCEtesting(unittest.TestCase): self.assertIn({'network-ref': 'openroadm-network', 'node-ref': 'ROADM-A1'}, res['network'][0]['node'][i]['supporting-node']) listNode.remove(nodeId) - elif(nodeId == 'ROADM-A1-SRG3'): + elif nodeId == 'ROADM-A1-SRG3': # Test related to SRG1 self.assertEqual(nodeType, 'SRG') self.assertEqual(len(res['network'][0]['node'][i]['ietf-network-topology:termination-point']), 5) @@ -138,7 +142,7 @@ class TransportPCEtesting(unittest.TestCase): self.assertIn({'network-ref': 'openroadm-network', 'node-ref': 'ROADM-A1'}, res['network'][0]['node'][i]['supporting-node']) listNode.remove(nodeId) - elif(nodeId == 'ROADM-A1-DEG1'): + elif nodeId == 'ROADM-A1-DEG1': # Test related to DEG1 self.assertEqual(nodeType, 'DEGREE') self.assertIn({'tp-id': 'DEG1-TTP-TXRX', 'org-openroadm-common-network:tp-type': 'DEGREE-TXRX-TTP'}, @@ -150,7 +154,7 @@ class TransportPCEtesting(unittest.TestCase): self.assertIn({'network-ref': 'openroadm-network', 'node-ref': 'ROADM-A1'}, res['network'][0]['node'][i]['supporting-node']) listNode.remove(nodeId) - elif(nodeId == 'ROADM-A1-DEG2'): + elif nodeId == 'ROADM-A1-DEG2': # Test related to DEG2 self.assertEqual(nodeType, 'DEGREE') self.assertIn({'tp-id': 'DEG2-TTP-TXRX', 'org-openroadm-common-network:tp-type': 'DEGREE-TXRX-TTP'}, @@ -178,6 +182,7 @@ class TransportPCEtesting(unittest.TestCase): self.assertEqual(res['network'][0]['node'][0]['org-openroadm-clli-network:clli'], 'NodeA') def test_08_getOpenRoadmNetwork(self): + # pylint: disable=redundant-unittest-assert response = test_utils.get_ordm_net_request() self.assertEqual(response.status_code, requests.codes.ok) res = response.json() @@ -187,16 +192,17 @@ class TransportPCEtesting(unittest.TestCase): self.assertEqual(res['network'][0]['node'][i]['supporting-node'][0]['network-ref'], 'clli-network') self.assertEqual(res['network'][0]['node'][i]['supporting-node'][0]['node-ref'], 'NodeA') nodeId = res['network'][0]['node'][i]['node-id'] - if(nodeId == 'XPDR-A1'): + if nodeId == 'XPDR-A1': self.assertEqual(res['network'][0]['node'][i]['org-openroadm-common-network:node-type'], 'XPONDER') self.assertEqual(res['network'][0]['node'][i]['org-openroadm-network:model'], 'model2') - elif(nodeId == 'ROADM-A1'): + elif nodeId == 'ROADM-A1': self.assertEqual(res['network'][0]['node'][i]['org-openroadm-common-network:node-type'], 'ROADM') self.assertEqual(res['network'][0]['node'][i]['org-openroadm-network:model'], 'model2') else: self.assertFalse(True) def test_09_getNodes_OpenRoadmTopology(self): + # pylint: disable=redundant-unittest-assert response = test_utils.get_ordm_topo_request("") res = response.json() # Tests related to nodes @@ -208,7 +214,7 @@ class TransportPCEtesting(unittest.TestCase): nodeType = res['network'][0]['node'][i]['org-openroadm-common-network:node-type'] nodeId = res['network'][0]['node'][i]['node-id'] # Tests related to XPDRA nodes - if(nodeId == 'XPDR-A1-XPDR1'): + if nodeId == 'XPDR-A1-XPDR1': self.assertIn({'network-ref': 'openroadm-network', 'node-ref': 'XPDR-A1'}, res['network'][0]['node'][i]['supporting-node']) self.assertIn({'network-ref': 'clli-network', 'node-ref': 'NodeA'}, @@ -221,21 +227,21 @@ class TransportPCEtesting(unittest.TestCase): tpType = (res['network'][0]['node'][i]['ietf-network-topology:termination-point'][j] ['org-openroadm-common-network:tp-type']) tpId = res['network'][0]['node'][i]['ietf-network-topology:termination-point'][j]['tp-id'] - if (tpType == 'XPONDER-CLIENT'): + if tpType == 'XPONDER-CLIENT': client += 1 - elif (tpType == 'XPONDER-NETWORK'): + elif tpType == 'XPONDER-NETWORK': network += 1 - if (tpId == 'XPDR1-NETWORK2'): + if tpId == 'XPDR1-NETWORK2': self.assertEqual(res['network'][0]['node'][i]['ietf-network-topology:termination-point'][j] ['transportpce-topology:associated-connection-map-port'], 'XPDR1-CLIENT2') - if (tpId == 'XPDR1-CLIENT2'): + if tpId == 'XPDR1-CLIENT2': self.assertEqual(res['network'][0]['node'][i]['ietf-network-topology:termination-point'][j] ['transportpce-topology:associated-connection-map-port'], 'XPDR1-NETWORK2') self.assertTrue(client == 2) self.assertTrue(network == 2) listNode.remove(nodeId) - elif(nodeId == 'ROADM-A1-SRG1'): + elif nodeId == 'ROADM-A1-SRG1': # Test related to SRG1 self.assertEqual(nodeType, 'SRG') self.assertEqual(len(res['network'][0]['node'][i]['ietf-network-topology:termination-point']), 5) @@ -246,7 +252,7 @@ class TransportPCEtesting(unittest.TestCase): self.assertIn({'network-ref': 'openroadm-network', 'node-ref': 'ROADM-A1'}, res['network'][0]['node'][i]['supporting-node']) listNode.remove(nodeId) - elif(nodeId == 'ROADM-A1-SRG3'): + elif nodeId == 'ROADM-A1-SRG3': # Test related to SRG1 self.assertEqual(nodeType, 'SRG') self.assertEqual(len(res['network'][0]['node'][i]['ietf-network-topology:termination-point']), 5) @@ -257,7 +263,7 @@ class TransportPCEtesting(unittest.TestCase): self.assertIn({'network-ref': 'openroadm-network', 'node-ref': 'ROADM-A1'}, res['network'][0]['node'][i]['supporting-node']) listNode.remove(nodeId) - elif(nodeId == 'ROADM-A1-DEG1'): + elif nodeId == 'ROADM-A1-DEG1': # Test related to DEG1 self.assertEqual(nodeType, 'DEGREE') self.assertIn({'tp-id': 'DEG1-TTP-TXRX', 'org-openroadm-common-network:tp-type': 'DEGREE-TXRX-TTP'}, @@ -267,7 +273,7 @@ class TransportPCEtesting(unittest.TestCase): self.assertIn({'network-ref': 'openroadm-network', 'node-ref': 'ROADM-A1'}, res['network'][0]['node'][i]['supporting-node']) listNode.remove(nodeId) - elif(nodeId == 'ROADM-A1-DEG2'): + elif nodeId == 'ROADM-A1-DEG2': # Test related to DEG2 self.assertEqual(nodeType, 'DEGREE') self.assertIn({'tp-id': 'DEG2-TTP-TXRX', 'org-openroadm-common-network:tp-type': 'DEGREE-TXRX-TTP'}, @@ -294,6 +300,7 @@ class TransportPCEtesting(unittest.TestCase): self.assertEqual(response.status_code, requests.codes.ok) def test_12_getLinks_OpenRoadmTopology(self): + # pylint: disable=redundant-unittest-assert response = test_utils.get_ordm_topo_request("") self.assertEqual(response.status_code, requests.codes.ok) res = response.json() @@ -315,23 +322,23 @@ class TransportPCEtesting(unittest.TestCase): for i in range(0, nbLink): nodeType = res['network'][0]['ietf-network-topology:link'][i]['org-openroadm-common-network:link-type'] linkId = res['network'][0]['ietf-network-topology:link'][i]['link-id'] - if(nodeType == 'EXPRESS-LINK'): + if nodeType == 'EXPRESS-LINK': find = linkId in expressLink self.assertEqual(find, True) expressLink.remove(linkId) - elif(nodeType == 'ADD-LINK'): + elif nodeType == 'ADD-LINK': find = linkId in addLink self.assertEqual(find, True) addLink.remove(linkId) - elif(nodeType == 'DROP-LINK'): + elif nodeType == 'DROP-LINK': find = linkId in dropLink self.assertEqual(find, True) dropLink.remove(linkId) - elif(nodeType == 'XPONDER-INPUT'): + elif nodeType == 'XPONDER-INPUT': find = linkId in XPDR_IN self.assertEqual(find, True) XPDR_IN.remove(linkId) - elif(nodeType == 'XPONDER-OUTPUT'): + elif nodeType == 'XPONDER-OUTPUT': find = linkId in XPDR_OUT self.assertEqual(find, True) XPDR_OUT.remove(linkId) @@ -384,7 +391,7 @@ class TransportPCEtesting(unittest.TestCase): nodeId = res['network'][0]['node'][i]['node-id'] find = nodeId in listNode self.assertEqual(find, True) - if(nodeId == 'NodeA'): + if nodeId == 'NodeA': self.assertEqual(res['network'][0]['node'][i]['org-openroadm-clli-network:clli'], 'NodeA') else: self.assertEqual(res['network'][0]['node'][i]['org-openroadm-clli-network:clli'], 'NodeC') @@ -392,6 +399,7 @@ class TransportPCEtesting(unittest.TestCase): self.assertEqual(len(listNode), 0) def test_17_getOpenRoadmNetwork(self): + # pylint: disable=redundant-unittest-assert response = test_utils.get_ordm_net_request() self.assertEqual(response.status_code, requests.codes.ok) res = response.json() @@ -401,17 +409,17 @@ class TransportPCEtesting(unittest.TestCase): for i in range(0, nbNode): self.assertEqual(res['network'][0]['node'][i]['supporting-node'][0]['network-ref'], 'clli-network') nodeId = res['network'][0]['node'][i]['node-id'] - if(nodeId == 'XPDR-A1'): + if nodeId == 'XPDR-A1': self.assertEqual(res['network'][0]['node'][i]['supporting-node'][0]['node-ref'], 'NodeA') self.assertEqual(res['network'][0]['node'][i]['org-openroadm-common-network:node-type'], 'XPONDER') self.assertEqual(res['network'][0]['node'][i]['org-openroadm-network:model'], 'model2') listNode.remove(nodeId) - elif(nodeId == 'ROADM-A1'): + elif nodeId == 'ROADM-A1': self.assertEqual(res['network'][0]['node'][i]['supporting-node'][0]['node-ref'], 'NodeA') self.assertEqual(res['network'][0]['node'][i]['org-openroadm-common-network:node-type'], 'ROADM') self.assertEqual(res['network'][0]['node'][i]['org-openroadm-network:model'], 'model2') listNode.remove(nodeId) - elif(nodeId == 'ROADM-C1'): + elif nodeId == 'ROADM-C1': self.assertEqual(res['network'][0]['node'][i]['supporting-node'][0]['node-ref'], 'NodeC') self.assertEqual(res['network'][0]['node'][i]['org-openroadm-common-network:node-type'], 'ROADM') self.assertEqual(res['network'][0]['node'][i]['org-openroadm-network:model'], 'model2') @@ -421,6 +429,7 @@ class TransportPCEtesting(unittest.TestCase): self.assertEqual(len(listNode), 0) def test_18_getROADMLinkOpenRoadmTopology(self): + # pylint: disable=redundant-unittest-assert response = test_utils.get_ordm_topo_request("") self.assertEqual(response.status_code, requests.codes.ok) res = response.json() @@ -450,27 +459,27 @@ class TransportPCEtesting(unittest.TestCase): for i in range(0, nbLink): nodeType = res['network'][0]['ietf-network-topology:link'][i]['org-openroadm-common-network:link-type'] linkId = res['network'][0]['ietf-network-topology:link'][i]['link-id'] - if(nodeType == 'EXPRESS-LINK'): + if nodeType == 'EXPRESS-LINK': find = linkId in expressLink self.assertEqual(find, True) expressLink.remove(linkId) - elif(nodeType == 'ADD-LINK'): + elif nodeType == 'ADD-LINK': find = linkId in addLink self.assertEqual(find, True) addLink.remove(linkId) - elif(nodeType == 'DROP-LINK'): + elif nodeType == 'DROP-LINK': find = linkId in dropLink self.assertEqual(find, True) dropLink.remove(linkId) - elif(nodeType == 'ROADM-TO-ROADM'): + elif nodeType == 'ROADM-TO-ROADM': find = linkId in R2RLink self.assertEqual(find, True) R2RLink.remove(linkId) - elif(nodeType == 'XPONDER-INPUT'): + elif nodeType == 'XPONDER-INPUT': find = linkId in XPDR_IN self.assertEqual(find, True) XPDR_IN.remove(linkId) - elif(nodeType == 'XPONDER-OUTPUT'): + elif nodeType == 'XPONDER-OUTPUT': find = linkId in XPDR_OUT self.assertEqual(find, True) XPDR_OUT.remove(linkId) @@ -494,19 +503,20 @@ class TransportPCEtesting(unittest.TestCase): 'ROADM-C1-DEG1-DEG1-TTP-TXRXtoROADM-A1-DEG2-DEG2-TTP-TXRX'] for i in range(0, nbLink): link_id = res['network'][0]['ietf-network-topology:link'][i]['link-id'] - if(link_id in R2RLink): + if link_id in R2RLink: find = False spanLoss = res['network'][0]['ietf-network-topology:link'][i][ 'org-openroadm-network-topology:OMS-attributes']['span']["engineered-spanloss"] length = res['network'][0]['ietf-network-topology:link'][i][ 'org-openroadm-network-topology:OMS-attributes']['span']['link-concatenation'][0]['SRLG-length'] - if((spanLoss != None) & (length != None)): + if (spanLoss is not None) & (length is not None): find = True self.assertTrue(find) R2RLink.remove(link_id) self.assertEqual(len(R2RLink), 0) def test_20_getNodes_OpenRoadmTopology(self): + # pylint: disable=redundant-unittest-assert response = test_utils.get_ordm_topo_request("") res = response.json() # Tests related to nodes @@ -520,7 +530,7 @@ class TransportPCEtesting(unittest.TestCase): for i in range(0, nbNode): nodeType = res['network'][0]['node'][i]['org-openroadm-common-network:node-type'] nodeId = res['network'][0]['node'][i]['node-id'] - if(nodeId == 'XPDR-A1-XPDR1'): + if nodeId == 'XPDR-A1-XPDR1': self.assertIn({'network-ref': 'openroadm-network', 'node-ref': 'XPDR-A1'}, res['network'][0]['node'][i]['supporting-node']) self.assertEqual(nodeType, 'XPONDER') @@ -531,14 +541,14 @@ class TransportPCEtesting(unittest.TestCase): for j in range(0, nbTps): tpType = (res['network'][0]['node'][i]['ietf-network-topology:termination-point'][j] ['org-openroadm-common-network:tp-type']) - if (tpType == 'XPONDER-CLIENT'): + if tpType == 'XPONDER-CLIENT': client += 1 - elif (tpType == 'XPONDER-NETWORK'): + elif tpType == 'XPONDER-NETWORK': network += 1 self.assertTrue(client == 2) self.assertTrue(network == 2) listNode.remove(nodeId) - elif(nodeId == 'ROADM-A1-SRG1'): + elif nodeId == 'ROADM-A1-SRG1': # Test related to SRG1 self.assertEqual(len(res['network'][0]['node'][i]['ietf-network-topology:termination-point']), 5) self.assertIn({'tp-id': 'SRG1-CP-TXRX', 'org-openroadm-common-network:tp-type': 'SRG-TXRX-CP'}, @@ -549,7 +559,7 @@ class TransportPCEtesting(unittest.TestCase): res['network'][0]['node'][i]['supporting-node']) self.assertEqual(res['network'][0]['node'][i]['org-openroadm-common-network:node-type'], 'SRG') listNode.remove(nodeId) - elif(nodeId == 'ROADM-A1-SRG3'): + elif nodeId == 'ROADM-A1-SRG3': # Test related to SRG1 self.assertEqual(len(res['network'][0]['node'][i]['ietf-network-topology:termination-point']), 5) self.assertIn({'tp-id': 'SRG3-CP-TXRX', 'org-openroadm-common-network:tp-type': 'SRG-TXRX-CP'}, @@ -560,7 +570,7 @@ class TransportPCEtesting(unittest.TestCase): res['network'][0]['node'][i]['supporting-node']) self.assertEqual(res['network'][0]['node'][i]['org-openroadm-common-network:node-type'], 'SRG') listNode.remove(nodeId) - elif(nodeId == 'ROADM-A1-DEG1'): + elif nodeId == 'ROADM-A1-DEG1': # Test related to DEG1 self.assertIn({'tp-id': 'DEG1-TTP-TXRX', 'org-openroadm-common-network:tp-type': 'DEGREE-TXRX-TTP'}, res['network'][0]['node'][i]['ietf-network-topology:termination-point']) @@ -570,7 +580,7 @@ class TransportPCEtesting(unittest.TestCase): res['network'][0]['node'][i]['supporting-node']) self.assertEqual(res['network'][0]['node'][i]['org-openroadm-common-network:node-type'], 'DEGREE') listNode.remove(nodeId) - elif(nodeId == 'ROADM-A1-DEG2'): + elif nodeId == 'ROADM-A1-DEG2': # Test related to DEG2 self.assertIn({'tp-id': 'DEG2-TTP-TXRX', 'org-openroadm-common-network:tp-type': 'DEGREE-TXRX-TTP'}, res['network'][0]['node'][i]['ietf-network-topology:termination-point']) @@ -580,7 +590,7 @@ class TransportPCEtesting(unittest.TestCase): res['network'][0]['node'][i]['supporting-node']) self.assertEqual(res['network'][0]['node'][i]['org-openroadm-common-network:node-type'], 'DEGREE') listNode.remove(nodeId) - elif(nodeId == 'ROADM-C1-SRG1'): + elif nodeId == 'ROADM-C1-SRG1': # Test related to SRG1 self.assertEqual(len(res['network'][0]['node'][i]['ietf-network-topology:termination-point']), 5) self.assertIn({'tp-id': 'SRG1-CP-TXRX', 'org-openroadm-common-network:tp-type': 'SRG-TXRX-CP'}, @@ -591,7 +601,7 @@ class TransportPCEtesting(unittest.TestCase): res['network'][0]['node'][i]['supporting-node']) self.assertEqual(res['network'][0]['node'][i]['org-openroadm-common-network:node-type'], 'SRG') listNode.remove(nodeId) - elif(nodeId == 'ROADM-C1-DEG1'): + elif nodeId == 'ROADM-C1-DEG1': # Test related to DEG1 self.assertIn({'tp-id': 'DEG1-TTP-TXRX', 'org-openroadm-common-network:tp-type': 'DEGREE-TXRX-TTP'}, res['network'][0]['node'][i]['ietf-network-topology:termination-point']) @@ -601,7 +611,7 @@ class TransportPCEtesting(unittest.TestCase): res['network'][0]['node'][i]['supporting-node']) self.assertEqual(res['network'][0]['node'][i]['org-openroadm-common-network:node-type'], 'DEGREE') listNode.remove(nodeId) - elif(nodeId == 'ROADM-C1-DEG2'): + elif nodeId == 'ROADM-C1-DEG2': # Test related to DEG1 self.assertIn({'tp-id': 'DEG2-TTP-TXRX', 'org-openroadm-common-network:tp-type': 'DEGREE-TXRX-TTP'}, res['network'][0]['node'][i]['ietf-network-topology:termination-point']) @@ -687,9 +697,9 @@ class TransportPCEtesting(unittest.TestCase): nodeId = res['network'][0]['node'][i]['node-id'] find = nodeId in listNode self.assertEqual(find, True) - if(nodeId == 'NodeA'): + if nodeId == 'NodeA': self.assertEqual(res['network'][0]['node'][i]['org-openroadm-clli-network:clli'], 'NodeA') - elif(nodeId == 'NodeB'): + elif nodeId == 'NodeB': self.assertEqual(res['network'][0]['node'][i]['org-openroadm-clli-network:clli'], 'NodeB') else: self.assertEqual(res['network'][0]['node'][i]['org-openroadm-clli-network:clli'], 'NodeC') @@ -766,13 +776,13 @@ class TransportPCEtesting(unittest.TestCase): 'ROADM-B1-DEG2-DEG2-TTP-TXRXtoROADM-C1-DEG2-DEG2-TTP-TXRX'] for i in range(0, nbLink): link_id = res['network'][0]['ietf-network-topology:link'][i]['link-id'] - if(link_id in R2RLink): + if link_id in R2RLink: find = False spanLoss = res['network'][0]['ietf-network-topology:link'][i][ 'org-openroadm-network-topology:OMS-attributes']['span']["engineered-spanloss"] length = res['network'][0]['ietf-network-topology:link'][i][ 'org-openroadm-network-topology:OMS-attributes']['span']['link-concatenation'][0]['SRLG-length'] - if((spanLoss != None) & (length != None)): + if (spanLoss is not None) & (length is not None): find = True self.assertTrue(find) R2RLink.remove(link_id) @@ -859,6 +869,7 @@ class TransportPCEtesting(unittest.TestCase): # 'ROADMC-DEG2-DEG2-CTP-TXRXtoROADMC-DEG1-DEG1-CTP-TXRX') def test_32_getNodes_OpenRoadmTopology(self): + # pylint: disable=redundant-unittest-assert response = test_utils.get_ordm_topo_request("") res = response.json() # Tests related to nodes @@ -870,14 +881,14 @@ class TransportPCEtesting(unittest.TestCase): nodeType = res['network'][0]['node'][i]['org-openroadm-common-network:node-type'] nodeId = res['network'][0]['node'][i]['node-id'] # Tests related to XPDRA nodes - if(nodeId == 'XPDR-A1-XPDR1'): + if nodeId == 'XPDR-A1-XPDR1': nbTp = len(res['network'][0]['node'][i]['ietf-network-topology:termination-point']) for j in range(0, nbTp): tpid = res['network'][0]['node'][i]['ietf-network-topology:termination-point'][j]['tp-id'] - if (tpid == 'XPDR1-CLIENT1'): + if tpid == 'XPDR1-CLIENT1': self.assertEqual((res['network'][0]['node'][i]['ietf-network-topology:termination-point'][j] ['org-openroadm-common-network:tp-type']), 'XPONDER-CLIENT') - if (tpid == 'XPDR1-NETWORK1'): + if tpid == 'XPDR1-NETWORK1': self.assertEqual((res['network'][0]['node'][i]['ietf-network-topology:termination-point'][j] ['org-openroadm-common-network:tp-type']), 'XPONDER-NETWORK') self.assertEqual((res['network'][0]['node'][i]['ietf-network-topology:termination-point'][j] @@ -887,7 +898,7 @@ class TransportPCEtesting(unittest.TestCase): self.assertIn({'network-ref': 'openroadm-network', 'node-ref': 'XPDR-A1'}, res['network'][0]['node'][i]['supporting-node']) listNode.remove(nodeId) - elif(nodeId == 'ROADM-A1-SRG1'): + elif nodeId == 'ROADM-A1-SRG1': # Test related to SRG1 self.assertEqual(nodeType, 'SRG') self.assertEqual(len(res['network'][0]['node'][i]['ietf-network-topology:termination-point']), 5) @@ -898,7 +909,7 @@ class TransportPCEtesting(unittest.TestCase): self.assertIn({'network-ref': 'openroadm-network', 'node-ref': 'ROADM-A1'}, res['network'][0]['node'][i]['supporting-node']) listNode.remove(nodeId) - elif(nodeId == 'ROADM-A1-SRG3'): + elif nodeId == 'ROADM-A1-SRG3': # Test related to SRG1 self.assertEqual(nodeType, 'SRG') self.assertEqual(len(res['network'][0]['node'][i]['ietf-network-topology:termination-point']), 5) @@ -909,7 +920,7 @@ class TransportPCEtesting(unittest.TestCase): self.assertIn({'network-ref': 'openroadm-network', 'node-ref': 'ROADM-A1'}, res['network'][0]['node'][i]['supporting-node']) listNode.remove(nodeId) - elif(nodeId == 'ROADM-A1-DEG1'): + elif nodeId == 'ROADM-A1-DEG1': # Test related to DEG1 self.assertEqual(nodeType, 'DEGREE') self.assertIn({'tp-id': 'DEG1-TTP-TXRX', 'org-openroadm-common-network:tp-type': 'DEGREE-TXRX-TTP'}, @@ -919,7 +930,7 @@ class TransportPCEtesting(unittest.TestCase): self.assertIn({'network-ref': 'openroadm-network', 'node-ref': 'ROADM-A1'}, res['network'][0]['node'][i]['supporting-node']) listNode.remove(nodeId) - elif(nodeId == 'ROADM-A1-DEG2'): + elif nodeId == 'ROADM-A1-DEG2': # Test related to DEG2 self.assertEqual(nodeType, 'DEGREE') self.assertIn({'tp-id': 'DEG2-TTP-TXRX', 'org-openroadm-common-network:tp-type': 'DEGREE-TXRX-TTP'}, @@ -979,6 +990,7 @@ class TransportPCEtesting(unittest.TestCase): self.assertNotEqual(res['network'][0]['node'][i]['node-id'], 'XPDR-A1') def test_38_getNodes_OpenRoadmTopology(self): + # pylint: disable=redundant-unittest-assert response = test_utils.get_ordm_topo_request("") res = response.json() # Tests related to nodes @@ -991,7 +1003,7 @@ class TransportPCEtesting(unittest.TestCase): res['network'][0]['node'][i]['supporting-node']) nodeType = res['network'][0]['node'][i]['org-openroadm-common-network:node-type'] nodeId = res['network'][0]['node'][i]['node-id'] - if(nodeId == 'ROADM-A1-SRG1'): + if nodeId == 'ROADM-A1-SRG1': # Test related to SRG1 self.assertEqual(nodeType, 'SRG') self.assertEqual(len(res['network'][0]['node'][i]['ietf-network-topology:termination-point']), 5) @@ -1000,7 +1012,7 @@ class TransportPCEtesting(unittest.TestCase): self.assertIn({'tp-id': 'SRG1-PP1-TXRX', 'org-openroadm-common-network:tp-type': 'SRG-TXRX-PP'}, res['network'][0]['node'][i]['ietf-network-topology:termination-point']) listNode.remove(nodeId) - elif(nodeId == 'ROADM-A1-SRG3'): + elif nodeId == 'ROADM-A1-SRG3': # Test related to SRG1 self.assertEqual(nodeType, 'SRG') self.assertEqual(len(res['network'][0]['node'][i]['ietf-network-topology:termination-point']), 5) @@ -1009,7 +1021,7 @@ class TransportPCEtesting(unittest.TestCase): self.assertIn({'tp-id': 'SRG3-PP1-TXRX', 'org-openroadm-common-network:tp-type': 'SRG-TXRX-PP'}, res['network'][0]['node'][i]['ietf-network-topology:termination-point']) listNode.remove(nodeId) - elif(nodeId == 'ROADM-A1-DEG1'): + elif nodeId == 'ROADM-A1-DEG1': # Test related to DEG1 self.assertEqual(nodeType, 'DEGREE') self.assertIn({'tp-id': 'DEG1-TTP-TXRX', 'org-openroadm-common-network:tp-type': 'DEGREE-TXRX-TTP'}, @@ -1017,7 +1029,7 @@ class TransportPCEtesting(unittest.TestCase): self.assertIn({'tp-id': 'DEG1-CTP-TXRX', 'org-openroadm-common-network:tp-type': 'DEGREE-TXRX-CTP'}, res['network'][0]['node'][i]['ietf-network-topology:termination-point']) listNode.remove(nodeId) - elif(nodeId == 'ROADM-A1-DEG2'): + elif nodeId == 'ROADM-A1-DEG2': # Test related to DEG2 self.assertEqual(nodeType, 'DEGREE') self.assertIn({'tp-id': 'DEG2-TTP-TXRX', 'org-openroadm-common-network:tp-type': 'DEGREE-TXRX-TTP'},