X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=yang%2Fyang-data-codec-gson%2Fsrc%2Ftest%2Fjava%2Forg%2Fopendaylight%2Fyangtools%2Fyang%2Fdata%2Fcodec%2Fgson%2FBug4501Test.java;h=f3704b54b3229d8f5710efb9dc61b8852479561a;hb=f24f264f6fa03f6e7a4a23fdef4576bcc0341aa9;hp=9cde9b39bda503556a45ba7352ec8eb85535b168;hpb=c8668229ad6e73d5ae03a52f4b87e8e4d2a67c6e;p=yangtools.git diff --git a/yang/yang-data-codec-gson/src/test/java/org/opendaylight/yangtools/yang/data/codec/gson/Bug4501Test.java b/yang/yang-data-codec-gson/src/test/java/org/opendaylight/yangtools/yang/data/codec/gson/Bug4501Test.java index 9cde9b39bd..f3704b54b3 100644 --- a/yang/yang-data-codec-gson/src/test/java/org/opendaylight/yangtools/yang/data/codec/gson/Bug4501Test.java +++ b/yang/yang-data-codec-gson/src/test/java/org/opendaylight/yangtools/yang/data/codec/gson/Bug4501Test.java @@ -8,8 +8,8 @@ package org.opendaylight.yangtools.yang.data.codec.gson; import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertThrows; import static org.junit.Assert.assertTrue; -import static org.junit.Assert.fail; import static org.opendaylight.yangtools.yang.data.codec.gson.TestUtils.loadTextFile; import com.google.common.collect.ImmutableSet; @@ -17,25 +17,23 @@ import com.google.gson.stream.JsonReader; import java.io.IOException; import java.io.StringReader; import java.net.URISyntaxException; -import java.util.Optional; import org.junit.AfterClass; import org.junit.BeforeClass; import org.junit.Test; import org.opendaylight.yangtools.yang.common.QName; import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier.NodeIdentifier; -import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier.PathArgument; import org.opendaylight.yangtools.yang.data.api.schema.DataContainerChild; import org.opendaylight.yangtools.yang.data.api.schema.NormalizedNode; import org.opendaylight.yangtools.yang.data.api.schema.UnkeyedListNode; import org.opendaylight.yangtools.yang.data.api.schema.stream.NormalizedNodeStreamWriter; import org.opendaylight.yangtools.yang.data.impl.schema.ImmutableNormalizedNodeStreamWriter; import org.opendaylight.yangtools.yang.data.impl.schema.NormalizedNodeResult; -import org.opendaylight.yangtools.yang.model.api.SchemaContext; +import org.opendaylight.yangtools.yang.model.api.EffectiveModelContext; import org.opendaylight.yangtools.yang.test.util.YangParserTestUtils; public class Bug4501Test { - private static SchemaContext schemaContext; + private static EffectiveModelContext schemaContext; @BeforeClass public static void initialization() { @@ -55,15 +53,14 @@ public class Bug4501Test { final JsonParserStream jsonParser = JsonParserStream.create(streamWriter, JSONCodecFactorySupplier.DRAFT_LHOTKA_NETMOD_YANG_JSON_02.getShared(schemaContext)); jsonParser.parse(new JsonReader(new StringReader(inputJson))); - final NormalizedNode transformedInput = result.getResult(); + final NormalizedNode transformedInput = result.getResult(); assertTrue(transformedInput instanceof UnkeyedListNode); final UnkeyedListNode hop = (UnkeyedListNode) transformedInput; - final Optional> lrsBits = hop.getChild(0).getChild( + final DataContainerChild lrsBits = hop.childAt(0).childByArg( NodeIdentifier.create(QName.create("foo", "lrs-bits"))); - final ImmutableSet expectedValue = ImmutableSet.of("lookup", "rloc-probe", "strict"); - assertEquals(expectedValue, lrsBits.get().getValue()); + assertEquals(ImmutableSet.of("lookup", "rloc-probe", "strict"), lrsBits.body()); } @Test @@ -74,11 +71,9 @@ public class Bug4501Test { final JsonParserStream jsonParser = JsonParserStream.create(streamWriter, JSONCodecFactorySupplier.DRAFT_LHOTKA_NETMOD_YANG_JSON_02.getShared(schemaContext)); - try { - jsonParser.parse(new JsonReader(new StringReader(inputJson))); - fail("IllegalArgumentException should be thrown."); - } catch (IllegalArgumentException e) { - assertEquals(e.getMessage(), "Node '(foo)lrs-bits' has already set its value to '[lookup]'"); - } + final JsonReader reader = new JsonReader(new StringReader(inputJson)); + final IllegalArgumentException ex = assertThrows(IllegalArgumentException.class, + () -> jsonParser.parse(reader)); + assertEquals("Node '(foo)lrs-bits' has already set its value to '[lookup]'", ex.getMessage()); } } \ No newline at end of file