X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=yang%2Fyang-data-impl%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fyangtools%2Fyang%2Fdata%2Fimpl%2Fschema%2Fnodes%2FAbstractImmutableNormalizedValueNode.java;h=31f8bab90dcd668012ee1a980e0c114397491ac8;hb=541932e3a97f3f461dc806e46f8c2bd21caf2853;hp=a37a44450e5df1b6ff83bfa284d9d7e7361c0387;hpb=8fdc09336d2df5712dbaafed4e43ac8ec657a824;p=yangtools.git diff --git a/yang/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/schema/nodes/AbstractImmutableNormalizedValueNode.java b/yang/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/schema/nodes/AbstractImmutableNormalizedValueNode.java index a37a44450e..31f8bab90d 100644 --- a/yang/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/schema/nodes/AbstractImmutableNormalizedValueNode.java +++ b/yang/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/schema/nodes/AbstractImmutableNormalizedValueNode.java @@ -7,39 +7,28 @@ */ package org.opendaylight.yangtools.yang.data.impl.schema.nodes; -import javax.annotation.Nullable; +import static java.util.Objects.requireNonNull; + +import javax.annotation.Nonnull; import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier.PathArgument; -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; public abstract class AbstractImmutableNormalizedValueNode extends AbstractImmutableNormalizedNode { - private static final Logger LOG = LoggerFactory.getLogger(AbstractImmutableNormalizedValueNode.class); - @Nullable + @Nonnull private final V value; - protected AbstractImmutableNormalizedValueNode(final K nodeIdentifier, @Nullable final V value) { + protected AbstractImmutableNormalizedValueNode(final K nodeIdentifier, @Nonnull final V value) { super(nodeIdentifier); - - /* - * Null value is allowed for empty type definition so it should be debug, - * but still we are logging it in case we need to debug missing values. - */ - // FIXME: one we do not map YANG 'void' to java.lang.Void we should be enforcing non-null here - if (value == null) { - LOG.debug("The value of node {} is null", nodeIdentifier.getNodeType()); - } - this.value = value; + this.value = requireNonNull(value); } - @Nullable @Override public final V getValue() { return wrapValue(value); } - @Nullable + @Nonnull protected final V value() { return value; }