X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=yang%2Fyang-parser-impl%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fyangtools%2Fyang%2Fparser%2Fstmt%2Frfc6020%2FUtils.java;h=3123445b478574bee0f9ac12a10eed0f48218abf;hb=04fa25a4fe8957f6492618aa9a1e9a4f9af39df4;hp=2f4c55be38dea92e966be13352b23f3dc618f8f5;hpb=26267c3c9b4bd4e4ead26d7373ae1c1752876bde;p=yangtools.git diff --git a/yang/yang-parser-impl/src/main/java/org/opendaylight/yangtools/yang/parser/stmt/rfc6020/Utils.java b/yang/yang-parser-impl/src/main/java/org/opendaylight/yangtools/yang/parser/stmt/rfc6020/Utils.java index 2f4c55be38..3123445b47 100644 --- a/yang/yang-parser-impl/src/main/java/org/opendaylight/yangtools/yang/parser/stmt/rfc6020/Utils.java +++ b/yang/yang-parser-impl/src/main/java/org/opendaylight/yangtools/yang/parser/stmt/rfc6020/Utils.java @@ -8,47 +8,45 @@ package org.opendaylight.yangtools.yang.parser.stmt.rfc6020; import static org.opendaylight.yangtools.yang.parser.spi.meta.StmtContextUtils.firstAttributeOf; - import com.google.common.base.CharMatcher; +import com.google.common.base.Preconditions; import com.google.common.base.Splitter; +import com.google.common.base.Strings; +import com.google.common.collect.ImmutableMap; +import com.google.common.collect.ImmutableMap.Builder; import com.google.common.collect.Iterables; - import java.util.ArrayList; import java.util.Arrays; import java.util.Collection; +import java.util.Date; import java.util.HashSet; -import java.util.Iterator; -import java.util.LinkedList; import java.util.List; -import java.util.Objects; +import java.util.Map; import java.util.Set; - +import java.util.regex.Pattern; import javax.annotation.Nullable; import javax.xml.xpath.XPath; import javax.xml.xpath.XPathExpressionException; import javax.xml.xpath.XPathFactory; - import org.antlr.v4.runtime.tree.TerminalNode; import org.opendaylight.yangtools.antlrv4.code.gen.YangStatementParser; import org.opendaylight.yangtools.yang.common.QName; import org.opendaylight.yangtools.yang.common.QNameModule; import org.opendaylight.yangtools.yang.common.SimpleDateFormatUtil; -import org.opendaylight.yangtools.yang.common.YangConstants; -import org.opendaylight.yangtools.yang.model.api.DataSchemaNode; import org.opendaylight.yangtools.yang.model.api.Deviation; +import org.opendaylight.yangtools.yang.model.api.Deviation.Deviate; import org.opendaylight.yangtools.yang.model.api.ModuleIdentifier; -import org.opendaylight.yangtools.yang.model.api.SchemaPath; +import org.opendaylight.yangtools.yang.model.api.RevisionAwareXPath; import org.opendaylight.yangtools.yang.model.api.Status; -import org.opendaylight.yangtools.yang.model.api.stmt.AugmentStatement; import org.opendaylight.yangtools.yang.model.api.stmt.BelongsToStatement; -import org.opendaylight.yangtools.yang.model.api.stmt.ChoiceStatement; import org.opendaylight.yangtools.yang.model.api.stmt.ModuleStatement; +import org.opendaylight.yangtools.yang.model.api.stmt.RevisionStatement; import org.opendaylight.yangtools.yang.model.api.stmt.SchemaNodeIdentifier; import org.opendaylight.yangtools.yang.model.api.stmt.SchemaNodeIdentifier.Relative; import org.opendaylight.yangtools.yang.model.api.stmt.SubmoduleStatement; -import org.opendaylight.yangtools.yang.model.api.stmt.UsesStatement; +import org.opendaylight.yangtools.yang.model.util.RevisionAwareXPathImpl; +import org.opendaylight.yangtools.yang.parser.spi.meta.QNameCacheNamespace; import org.opendaylight.yangtools.yang.parser.spi.meta.StmtContext; -import org.opendaylight.yangtools.yang.parser.spi.meta.StmtContext.Mutable; import org.opendaylight.yangtools.yang.parser.spi.meta.StmtContextUtils; import org.opendaylight.yangtools.yang.parser.spi.source.BelongsToPrefixToModuleName; import org.opendaylight.yangtools.yang.parser.spi.source.ImpPrefixToModuleIdentifier; @@ -57,37 +55,59 @@ import org.opendaylight.yangtools.yang.parser.spi.source.ModuleIdentifierToModul import org.opendaylight.yangtools.yang.parser.spi.source.ModuleNameToModuleQName; import org.opendaylight.yangtools.yang.parser.spi.source.PrefixToModule; import org.opendaylight.yangtools.yang.parser.spi.source.QNameToStatementDefinition; -import org.opendaylight.yangtools.yang.parser.spi.validation.ValidationBundlesNamespace; -import org.opendaylight.yangtools.yang.parser.spi.validation.ValidationBundlesNamespace.ValidationBundleType; +import org.opendaylight.yangtools.yang.parser.spi.source.SourceException; import org.opendaylight.yangtools.yang.parser.stmt.reactor.StatementContextBase; import org.slf4j.Logger; import org.slf4j.LoggerFactory; public final class Utils { - private static final Logger LOG = LoggerFactory.getLogger(Utils.class); private static final CharMatcher DOUBLE_QUOTE_MATCHER = CharMatcher.is('"'); private static final CharMatcher SINGLE_QUOTE_MATCHER = CharMatcher.is('\''); + private static final CharMatcher LEFT_PARENTHESIS_MATCHER = CharMatcher.is('('); + private static final CharMatcher RIGHT_PARENTHESIS_MATCHER = CharMatcher.is(')'); + private static final CharMatcher AMPERSAND_MATCHER = CharMatcher.is('&'); + private static final CharMatcher QUESTION_MARK_MATCHER = CharMatcher.is('?'); + private static final Splitter SLASH_SPLITTER = Splitter.on('/').omitEmptyStrings().trimResults(); + private static final Splitter SPACE_SPLITTER = Splitter.on(' ').omitEmptyStrings().trimResults(); + private static final Pattern PATH_ABS = Pattern.compile("/[^/].*"); + + private static final Map KEYWORD_TO_DEVIATE_MAP; + static { + Builder keywordToDeviateMapBuilder = ImmutableMap.builder(); + for (Deviate deviate : Deviation.Deviate.values()) { + keywordToDeviateMapBuilder.put(deviate.getKeyword(), deviate); + } + KEYWORD_TO_DEVIATE_MAP = keywordToDeviateMapBuilder.build(); + } - public static final QName EMPTY_QNAME = QName.create("empty", "empty"); - - private static final char SEPARATOR_NODENAME = '/'; - - private static final String REGEX_PATH_ABS = "/[^/].*"; - - public static final char SEPARATOR = ' '; + private static final ThreadLocal XPATH_FACTORY = new ThreadLocal() { + @Override + protected XPathFactory initialValue() { + return XPathFactory.newInstance(); + } + }; private Utils() { + throw new UnsupportedOperationException(); + } + + /** + * Cleanup any resources attached to the current thread. Threads interacting with this class can cause thread-local + * caches to them. Invoke this method if you want to detach those resources. + */ + public static void detachFromCurrentThread() { + XPATH_FACTORY.remove(); } - public static Collection transformKeysStringToKeyNodes(StmtContext ctx, - String value) { - Splitter keySplitter = Splitter.on(SEPARATOR).omitEmptyStrings().trimResults(); - List keyTokens = keySplitter.splitToList(value); + public static Collection transformKeysStringToKeyNodes(final StmtContext ctx, + final String value) { + List keyTokens = SPACE_SPLITTER.splitToList(value); // to detect if key contains duplicates if ((new HashSet<>(keyTokens)).size() < keyTokens.size()) { - throw new IllegalArgumentException(); + // FIXME: report all duplicate keys + throw new SourceException(ctx.getStatementSourceReference(), "Duplicate value in list key: %s", value); } Set keyNodes = new HashSet<>(); @@ -102,36 +122,26 @@ public final class Utils { return keyNodes; } - public static List splitPathToNodeNames(String path) { - - Splitter keySplitter = Splitter.on(SEPARATOR_NODENAME).omitEmptyStrings().trimResults(); - return keySplitter.splitToList(path); + private static String trimSingleLastSlashFromXPath(final String path) { + return path.endsWith("/") ? path.substring(0, path.length() - 1) : path; } - public static void validateXPath(final StmtContext ctx, String path) { - - final XPath xPath = XPathFactory.newInstance().newXPath(); + static RevisionAwareXPath parseXPath(final StmtContext ctx, final String path) { + final XPath xPath = XPATH_FACTORY.get().newXPath(); + xPath.setNamespaceContext(StmtNamespaceContext.create(ctx)); + final String trimmed = trimSingleLastSlashFromXPath(path); try { - xPath.compile(path); + // TODO: we could capture the result and expose its 'evaluate' method + xPath.compile(trimmed); } catch (XPathExpressionException e) { - throw new IllegalArgumentException(String.format("Argument %s is not valid XPath string at %s", path, ctx - .getStatementSourceReference().toString()), e); + LOG.warn("Argument \"{}\" is not valid XPath string at \"{}\"", path, ctx.getStatementSourceReference(), e); } - } - private static String trimSingleLastSlashFromXPath(final String path) { - return path.replaceAll("/$", ""); + return new RevisionAwareXPathImpl(path, PATH_ABS.matcher(path).matches()); } - public static boolean isXPathAbsolute(final StmtContext ctx, String path) { - - validateXPath(ctx, trimSingleLastSlashFromXPath(path)); - - return path.matches(REGEX_PATH_ABS); - } - - public static QName trimPrefix(QName identifier) { + public static QName trimPrefix(final QName identifier) { String prefixedLocalName = identifier.getLocalName(); String[] namesParts = prefixedLocalName.split(":"); @@ -143,18 +153,22 @@ public final class Utils { return identifier; } - public static String getPrefixFromArgument(String prefixedLocalName) { - String[] namesParts = prefixedLocalName.split(":"); - if (namesParts.length == 2) { - return namesParts[0]; - } - return null; - } - - public static boolean isValidStatementDefinition(PrefixToModule prefixes, QNameToStatementDefinition stmtDef, - QName identifier) { + /** + * + * Based on identifier read from source and collections of relevant prefixes and statement definitions mappings + * provided for actual phase, method resolves and returns valid QName for declared statement to be written. + * This applies to any declared statement, including unknown statements. + * + * @param prefixes - collection of all relevant prefix mappings supplied for actual parsing phase + * @param stmtDef - collection of all relevant statement definition mappings provided for actual parsing phase + * @param identifier - statement to parse from source + * @return valid QName for declared statement to be written + * + */ + public static QName getValidStatementDefinition(final PrefixToModule prefixes, final QNameToStatementDefinition + stmtDef, final QName identifier) { if (stmtDef.get(identifier) != null) { - return true; + return stmtDef.get(identifier).getStatementName(); } else { String prefixedLocalName = identifier.getLocalName(); String[] namesParts = prefixedLocalName.split(":"); @@ -163,37 +177,28 @@ public final class Utils { String prefix = namesParts[0]; String localName = namesParts[1]; if (prefixes != null && prefixes.get(prefix) != null - && stmtDef.get(new QName(YangConstants.RFC6020_YIN_NAMESPACE, localName)) != null) { - return true; - } else { - if (stmtDef.get(new QName(YangConstants.RFC6020_YIN_NAMESPACE, localName)) != null) { - return true; - } + && stmtDef.get(QName.create(prefixes.get(prefix), localName)) != null) { + return QName.create(prefixes.get(prefix), localName); } } } - return false; + return null; } - public static Iterable parseXPath(StmtContext ctx, String path) { - - String trimmedPath = trimSingleLastSlashFromXPath(path); - - validateXPath(ctx, trimmedPath); - - List nodeNames = splitPathToNodeNames(trimmedPath); - List qNames = new ArrayList<>(); - - for (String nodeName : nodeNames) { + static SchemaNodeIdentifier nodeIdentifierFromPath(final StmtContext ctx, final String path) { + // FIXME: is the path trimming really necessary?? + final List qNames = new ArrayList<>(); + for (String nodeName : SLASH_SPLITTER.split(trimSingleLastSlashFromXPath(path))) { try { final QName qName = Utils.qNameFromArgument(ctx, nodeName); qNames.add(qName); } catch (Exception e) { - throw new IllegalArgumentException(e); + throw new IllegalArgumentException( + String.format("Failed to parse node '%s' in path '%s'", nodeName, path), e); } } - return qNames; + return SchemaNodeIdentifier.create(qNames, PATH_ABS.matcher(path).matches()); } public static String stringFromStringContext(final YangStatementParser.ArgumentContext context) { @@ -219,10 +224,9 @@ public final class Utils { return sb.toString(); } - public static QName qNameFromArgument(StmtContext ctx, String value) { - - if (value == null || value.equals("")) { - return EMPTY_QNAME; + public static QName qNameFromArgument(StmtContext ctx, final String value) { + if (Strings.isNullOrEmpty(value)) { + return ctx.getPublicDefinition().getStatementName(); } String prefix; @@ -235,7 +239,7 @@ public final class Utils { localName = namesParts[0]; qNameModule = getRootModuleQName(ctx); break; - case 2: + default: prefix = namesParts[0]; localName = namesParts[1]; qNameModule = getModuleQNameByPrefix(ctx, prefix); @@ -252,208 +256,125 @@ public final class Utils { qNameModule = getModuleQNameByPrefix(ctx, prefix); } break; - default: - break; } - if (qNameModule == null) { - if (StmtContextUtils.producesDeclared(ctx, UnknownStatementImpl.class) - && StmtContextUtils.producesDeclared(ctx.getParentContext(), UnknownStatementImpl.class)) { - - qNameModule = getRootModuleQName(ctx); - localName = value; - } else { - throw new IllegalArgumentException("Error in module '" + ctx.getRoot().rawStatementArgument() - + "': can not resolve QNameModule for '" + value + "'."); - } + Preconditions.checkArgument(qNameModule != null, + "Error in module '%s': can not resolve QNameModule for '%s'. Statement source at %s", + ctx.getRoot().rawStatementArgument(), value, ctx.getStatementSourceReference()); + final QNameModule resultQNameModule; + if (qNameModule.getRevision() == null) { + resultQNameModule = QNameModule.create(qNameModule.getNamespace(), SimpleDateFormatUtil.DEFAULT_DATE_REV) + .intern(); + } else { + resultQNameModule = qNameModule; } - QNameModule resultQNameModule = qNameModule.getRevision() == null ? QNameModule.create( - qNameModule.getNamespace(), SimpleDateFormatUtil.DEFAULT_DATE_REV) : qNameModule; - - return QName.create(resultQNameModule, localName); + return ctx.getFromNamespace(QNameCacheNamespace.class, QName.create(resultQNameModule, localName)); } - public static QNameModule getModuleQNameByPrefix(StmtContext ctx, String prefix) { - QNameModule qNameModule; - ModuleIdentifier impModIdentifier = ctx.getRoot().getFromNamespace(ImpPrefixToModuleIdentifier.class, prefix); - qNameModule = ctx.getFromNamespace(ModuleIdentifierToModuleQName.class, impModIdentifier); + public static QNameModule getModuleQNameByPrefix(final StmtContext ctx, final String prefix) { + final ModuleIdentifier modId = ctx.getRoot().getFromNamespace(ImpPrefixToModuleIdentifier.class, prefix); + final QNameModule qNameModule = ctx.getFromNamespace(ModuleIdentifierToModuleQName.class, modId); if (qNameModule == null && StmtContextUtils.producesDeclared(ctx.getRoot(), SubmoduleStatement.class)) { String moduleName = ctx.getRoot().getFromNamespace(BelongsToPrefixToModuleName.class, prefix); - qNameModule = ctx.getFromNamespace(ModuleNameToModuleQName.class, moduleName); + return ctx.getFromNamespace(ModuleNameToModuleQName.class, moduleName); } return qNameModule; } - public static QNameModule getRootModuleQName(StmtContext ctx) { - + public static QNameModule getRootModuleQName(final StmtContext ctx) { if (ctx == null) { return null; } - StmtContext rootCtx = ctx.getRoot(); - QNameModule qNameModule = null; + final StmtContext rootCtx = ctx.getRoot(); + final QNameModule qNameModule; if (StmtContextUtils.producesDeclared(rootCtx, ModuleStatement.class)) { qNameModule = rootCtx.getFromNamespace(ModuleCtxToModuleQName.class, rootCtx); } else if (StmtContextUtils.producesDeclared(rootCtx, SubmoduleStatement.class)) { - String belongsToModuleName = firstAttributeOf(ctx.getRoot().declaredSubstatements(), - BelongsToStatement.class); + final String belongsToModuleName = firstAttributeOf(rootCtx.substatements(), BelongsToStatement.class); qNameModule = rootCtx.getFromNamespace(ModuleNameToModuleQName.class, belongsToModuleName); + } else { + qNameModule = null; } - return qNameModule.getRevision() == null ? QNameModule.create(qNameModule.getNamespace(), - SimpleDateFormatUtil.DEFAULT_DATE_REV) : qNameModule; - } - - @Nullable - public static StatementContextBase findNode(StatementContextBase rootStmtCtx, - final Iterable path) { - - StatementContextBase parent = rootStmtCtx; - - Iterator pathIter = path.iterator(); - while (pathIter.hasNext()) { - QName nextPathQName = pathIter.next(); - StatementContextBase foundSubstatement = getSubstatementByQName(parent, nextPathQName); - - if (foundSubstatement == null) { - return null; - } - if (!pathIter.hasNext()) { - return foundSubstatement; - } - - parent = foundSubstatement; - } - - return null; - } - - public static StatementContextBase getSubstatementByQName(StatementContextBase parent, - QName nextPathQName) { - - Collection> declaredSubstatement = parent.declaredSubstatements(); - Collection> effectiveSubstatement = parent.effectiveSubstatements(); - - Collection> allSubstatements = new LinkedList<>(); - allSubstatements.addAll(declaredSubstatement); - allSubstatements.addAll(effectiveSubstatement); - - for (StatementContextBase substatement : allSubstatements) { - if (nextPathQName.equals(substatement.getStatementArgument())) { - return substatement; - } + Preconditions.checkArgument(qNameModule != null, "Failed to look up root QNameModule for %s", ctx); + if (qNameModule.getRevision() != null) { + return qNameModule; } - return null; + return QNameModule.create(qNameModule.getNamespace(), SimpleDateFormatUtil.DEFAULT_DATE_REV).intern(); } @Nullable - public static StatementContextBase findNode(StatementContextBase rootStmtCtx, + public static StatementContextBase findNode(final StmtContext rootStmtCtx, final SchemaNodeIdentifier node) { - return findNode(rootStmtCtx, node.getPathFromRoot()); - } - - public static SchemaPath getSchemaPath(StmtContext ctx) { - - if (ctx == null) { - return null; - } - - Iterator> iteratorFromRoot = ctx.getStmtContextsFromRoot().iterator(); - - if (iteratorFromRoot.hasNext()) { - iteratorFromRoot.next(); // skip root argument - } - - List qNamesFromRoot = new LinkedList<>(); - while (iteratorFromRoot.hasNext()) { - StmtContext nextStmtCtx = iteratorFromRoot.next(); - Object nextStmtArgument = nextStmtCtx.getStatementArgument(); - if (nextStmtArgument instanceof QName) { - QName qname = (QName) nextStmtArgument; - if (StmtContextUtils.producesDeclared(nextStmtCtx, UsesStatement.class)) { - continue; - } - if (StmtContextUtils.producesDeclared(nextStmtCtx.getParentContext(), ChoiceStatement.class) - && isSupportedAsShorthandCase(nextStmtCtx)) { - qNamesFromRoot.add(qname); - } - qNamesFromRoot.add(qname); - } else if (nextStmtArgument instanceof String) { - QName qName = qNameFromArgument(ctx, ((String) nextStmtArgument)); - qNamesFromRoot.add(qName); - } else if (StmtContextUtils.producesDeclared(nextStmtCtx, AugmentStatement.class) - && nextStmtArgument instanceof SchemaNodeIdentifier) { - addQNamesFromSchemaNodeIdentifierToList(qNamesFromRoot, (SchemaNodeIdentifier) nextStmtArgument); - } else if (nextStmtCtx.getPublicDefinition().getDeclaredRepresentationClass() - .isAssignableFrom(UnknownStatementImpl.class)) { - qNamesFromRoot.add(nextStmtCtx.getPublicDefinition().getStatementName()); - } else { - return SchemaPath.SAME; - } - } - - final SchemaPath schemaPath = SchemaPath.create(qNamesFromRoot, true); - return schemaPath; + return (StatementContextBase) rootStmtCtx.getFromNamespace(SchemaNodeIdentifierBuildNamespace.class, node); } - private static boolean isSupportedAsShorthandCase(StmtContext statementCtx) { - - Collection supportedCaseShorthands = statementCtx.getFromNamespace(ValidationBundlesNamespace.class, - ValidationBundleType.SUPPORTED_CASE_SHORTHANDS); - - return supportedCaseShorthands == null || supportedCaseShorthands.contains(statementCtx.getPublicDefinition()); + public static boolean isUnknownNode(final StmtContext stmtCtx) { + return stmtCtx.getPublicDefinition().getDeclaredRepresentationClass() + .isAssignableFrom(UnknownStatementImpl.class); } - private static void addQNamesFromSchemaNodeIdentifierToList(List qNamesFromRoot, - SchemaNodeIdentifier augmentTargetPath) { - Iterator augmentTargetPathIterator = augmentTargetPath.getPathFromRoot().iterator(); - while (augmentTargetPathIterator.hasNext()) { - qNamesFromRoot.add(augmentTargetPathIterator.next()); - } - } - - public static Deviation.Deviate parseDeviateFromString(final String deviate) { - - // Yang constants should be lowercase so we have throw if value does not - // suit this - String deviateUpper = deviate.toUpperCase(); - if (Objects.equals(deviate, deviateUpper)) { - throw new IllegalArgumentException(String.format("String %s is not valid deviate argument", deviate)); - } - - // but Java enum is uppercase so we cannot use lowercase here - try { - return Deviation.Deviate.valueOf(deviateUpper); - } catch (IllegalArgumentException e) { - throw new IllegalArgumentException(String.format("String %s is not valid deviate argument", deviate), e); - } + public static Deviation.Deviate parseDeviateFromString(final StmtContext ctx, final String deviateKeyword) { + return Preconditions.checkNotNull(KEYWORD_TO_DEVIATE_MAP.get(deviateKeyword), + "String '%s' is not valid deviate argument. Statement source at %s", deviateKeyword, + ctx.getStatementSourceReference()); } - public static Status parseStatus(String value) { - - Status status = null; + public static Status parseStatus(final String value) { switch (value) { case "current": - status = Status.CURRENT; - break; + return Status.CURRENT; case "deprecated": - status = Status.DEPRECATED; - break; + return Status.DEPRECATED; case "obsolete": - status = Status.OBSOLETE; - break; + return Status.OBSOLETE; default: - LOG.warn("Invalid 'status' statement: " + value); + LOG.warn("Invalid 'status' statement: {}", value); + return null; } + } + + public static Date getLatestRevision(final Iterable> subStmts) { + Date revision = null; + for (StmtContext subStmt : subStmts) { + if (subStmt.getPublicDefinition().getDeclaredRepresentationClass().isAssignableFrom(RevisionStatement + .class)) { + if (revision == null && subStmt.getStatementArgument() != null) { + revision = (Date) subStmt.getStatementArgument(); + } else if (subStmt.getStatementArgument() != null && ((Date) subStmt.getStatementArgument()).compareTo + (revision) > 0) { + revision = (Date) subStmt.getStatementArgument(); + } + } + } + return revision; + } - return status; + public static boolean isModuleIdentifierWithoutSpecifiedRevision(final Object o) { + return (o instanceof ModuleIdentifier) + && (((ModuleIdentifier) o).getRevision() == SimpleDateFormatUtil.DEFAULT_DATE_IMP || ((ModuleIdentifier) o) + .getRevision() == SimpleDateFormatUtil.DEFAULT_BELONGS_TO_DATE); } - public static SchemaPath SchemaNodeIdentifierToSchemaPath(SchemaNodeIdentifier identifier) { - return SchemaPath.create(identifier.getPathFromRoot(), identifier.isAbsolute()); + /** + * Replaces illegal characters of QName by the name of the character (e.g. + * '?' is replaced by "QuestionMark" etc.). + * + * @param string + * input String + * @return result String + */ + public static String replaceIllegalCharsForQName(String string) { + string = LEFT_PARENTHESIS_MATCHER.replaceFrom(string, "LeftParenthesis"); + string = RIGHT_PARENTHESIS_MATCHER.replaceFrom(string, "RightParenthesis"); + string = AMPERSAND_MATCHER.replaceFrom(string, "Ampersand"); + string = QUESTION_MARK_MATCHER.replaceFrom(string, "QuestionMark"); + + return string; } }