git.opendaylight Code Review - mdsal.git/commit - binding/mdsal-binding-generator-impl/src/main/java/org/opendaylight/mdsal/binding/generator/impl/AbstractTypeGenerator.java

author	Robert Varga <robert.varga@pantheon.tech>
	Mon, 23 Apr 2018 18:21:40 +0000 (20:21 +0200)
committer	Robert Varga <nite@hq.sk>
	Sun, 3 Jun 2018 21:12:04 +0000 (21:12 +0000)
commit	9d3b03f85ddfabbd3e20b78dbc11b56271353974
tree	49e6dc62570530744c208999f0efae2af708f838	tree \| snapshot
parent	d0f30cd7654e3083e23eb49669cc9fb78d5dfd6a	commit \| diff

Rename Identifiable.getKey() to key()

Identifiable's getKey() method has a tendency to conflict with models
which define a leaf named 'key'. Rename the method so it does not
conflict with generated getters and unify its definition in
BindingMapping. Also tag it as returning @NonNull, as that is the API
contract.

Since 'key' is a valid property, Builders cannot use a 'setKey' method,
hence it is renamed to 'withKey'.

JIRA: MDSAL-2
Change-Id: Idda720c31fd5519ab21a1722ab5072da5b18fcc9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

29 files changed:

binding/mdsal-binding-dom-adapter/src/test/java/org/opendaylight/mdsal/binding/dom/adapter/AbstractForwardedDataBrokerTest.java		diff \| blob \| history
binding/mdsal-binding-dom-adapter/src/test/java/org/opendaylight/mdsal/binding/dom/adapter/test/Bug5845booleanKeyTest.java		diff \| blob \| history
binding/mdsal-binding-dom-adapter/src/test/java/org/opendaylight/mdsal/binding/dom/adapter/test/ForwardedNotificationAdapterTest.java		diff \| blob \| history
binding/mdsal-binding-dom-adapter/src/test/java/org/opendaylight/mdsal/binding/dom/adapter/test/Mdsal298Test.java		diff \| blob \| history
binding/mdsal-binding-dom-adapter/src/test/java/org/opendaylight/mdsal/binding/dom/adapter/test/WriteTransactionTest.java		diff \| blob \| history
binding/mdsal-binding-dom-codec/src/main/java/org/opendaylight/mdsal/binding/dom/codec/gen/impl/StreamWriterGenerator.java		diff \| blob \| history
binding/mdsal-binding-dom-codec/src/main/java/org/opendaylight/mdsal/binding/dom/codec/impl/KeyedListNodeCodecContext.java		diff \| blob \| history
binding/mdsal-binding-dom-codec/src/test/java/org/opendaylight/mdsal/binding/dom/codec/test/AugmentationClassDiscoveredAfterCodecTest.java		diff \| blob \| history
binding/mdsal-binding-dom-codec/src/test/java/org/opendaylight/mdsal/binding/dom/codec/test/AugmentationSubstitutionTest.java		diff \| blob \| history
binding/mdsal-binding-dom-codec/src/test/java/org/opendaylight/mdsal/binding/dom/codec/test/CachingCodecTest.java		diff \| blob \| history
binding/mdsal-binding-dom-codec/src/test/java/org/opendaylight/mdsal/binding/dom/codec/test/CaseSubstitutionTest.java		diff \| blob \| history
binding/mdsal-binding-dom-codec/src/test/java/org/opendaylight/mdsal/binding/dom/codec/test/EmptyLeafTest.java		diff \| blob \| history
binding/mdsal-binding-dom-codec/src/test/java/org/opendaylight/mdsal/binding/dom/codec/test/NormalizedNodeSerializeDeserializeTest.java		diff \| blob \| history
binding/mdsal-binding-dom-codec/src/test/java/org/opendaylight/mdsal/binding/dom/codec/test/NotificationProcessingTest.java		diff \| blob \| history
binding/mdsal-binding-dom-codec/src/test/java/org/opendaylight/mdsal/binding/dom/codec/test/RpcDataSerializationTest.java		diff \| blob \| history
binding/mdsal-binding-generator-impl/src/main/java/org/opendaylight/mdsal/binding/generator/impl/AbstractTypeGenerator.java		diff \| blob \| history
binding/mdsal-binding-generator-impl/src/test/java/org/opendaylight/mdsal/binding/generator/impl/AugmentRelativeXPathTest.java		diff \| blob \| history
binding/mdsal-binding-generator-impl/src/test/java/org/opendaylight/mdsal/binding/generator/impl/AugmentedTypeTest.java		diff \| blob \| history
binding/mdsal-binding-generator-impl/src/test/java/org/opendaylight/mdsal/binding/generator/impl/GeneratedTypesLeafrefTest.java		diff \| blob \| history
binding/mdsal-binding-generator-impl/src/test/java/org/opendaylight/mdsal/binding/generator/impl/GeneratedTypesTest.java		diff \| blob \| history
binding/mdsal-binding-java-api-generator/src/main/java/org/opendaylight/mdsal/binding/java/api/generator/BuilderTemplate.xtend		diff \| blob \| history
binding/mdsal-binding-java-api-generator/src/test/java/org/opendaylight/mdsal/binding/java/api/generator/test/Bug532Test.java		diff \| blob \| history
binding/mdsal-binding-test-model/src/main/java/org/opendaylight/mdsal/binding/test/model/util/ListsBindingUtils.java		diff \| blob \| history
binding/mdsal-binding-test-model/src/main/yang/opendaylight-mdsal337.yang	[new file with mode: 0644]	blob
binding/mdsal-binding-test-utils/src/test/java/org/opendaylight/mdsal/binding/testutils/ExpectedObjects.java		diff \| blob \| history
binding/yang-binding/src/main/java/org/opendaylight/yangtools/yang/binding/BindingMapping.java		diff \| blob \| history
binding/yang-binding/src/main/java/org/opendaylight/yangtools/yang/binding/Identifiable.java		diff \| blob \| history
binding/yang-binding/src/main/java/org/opendaylight/yangtools/yang/binding/util/DataObjectReadingUtil.java		diff \| blob \| history
model/ietf/ietf-restconf/src/test/java/org/opendaylight/yang/gen/v1/urn/ietf/params/xml/ns/yang/ietf/restconf/rev131019/restconf/restconf/modules/ModuleBuilderTest.java		diff \| blob \| history

MD-SAL: Model-Driven Service Adaptation Layer

RSS Atom