Fix most PortMapping Sonar issues 05/97505/9
authorguillaume.lambert <guillaume.lambert@orange.com>
Thu, 16 Sep 2021 09:56:41 +0000 (11:56 +0200)
committerguillaume.lambert <guillaume.lambert@orange.com>
Wed, 22 Sep 2021 09:25:10 +0000 (11:25 +0200)
commitbb3d2a2445a0ebf985b3bbf2260c25c26f2fbf1b
tree3c6342eaa97ef57c246632a9a9ab60fd2dc6b0ca
parenta4ba83ae9ea0e7c3b42ad8cafad61ab3e8b80565
Fix most PortMapping Sonar issues

- use static HashMap instead of switch/case in MappingUtils
- return directly boolean expressions instead of using if-else blocks
- log every catched exceptions
- perform minor refactoring and realignments

JIRA: TRNSPRTPCE-355 TRNSPRTPCE-356
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I2f262d94c04d256fb473b94a3815486d5636a14e
common/src/main/java/org/opendaylight/transportpce/common/mapping/MappingUtilsImpl.java
common/src/main/java/org/opendaylight/transportpce/common/mapping/PortMappingImpl.java
common/src/main/java/org/opendaylight/transportpce/common/mapping/PortMappingUtils.java
common/src/main/java/org/opendaylight/transportpce/common/mapping/PortMappingVersion121.java
common/src/main/java/org/opendaylight/transportpce/common/mapping/PortMappingVersion221.java
common/src/main/java/org/opendaylight/transportpce/common/mapping/PortMappingVersion710.java