Code Review / yangtools.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: e85954b) | patch
Seal NormalizedNode hierarchy 06/109406/13
authorRobert Varga <robert.varga@pantheon.tech>
Fri, 22 Dec 2023 15:51:48 +0000 (16:51 +0100)
committerRobert Varga <robert.varga@pantheon.tech>
Thu, 28 Dec 2023 23:48:12 +0000 (00:48 +0100)
commit1867432c68157e9f12a4b795fc9ad78520433bd7
tree4fafc168ca5ca270503ff1af401bfd404b6857c4tree | snapshot
parente85954b803561166596bf6f604c0aafb094a38aecommit | diff
Seal NormalizedNode hierarchy

This patch ensures that all of NormalizedNode interface hierarchy is
sealed, so users can rely on instanceof exhaustiveness.

As a side-effect of this change, we promote
node.spi.AbstractNormalizedNode into the API package and create a mirror
class hierarchy around it.

This hierarchy is then extende by the immutable implementations. This
adds a bit of code duplication, but it also makes it very clear what the
expectations are.

We have flushed out a couple of bugs in the process -- like
LeafSetEntryNode not protecting byte[] children.

JIRA: YANGTOOLS-1259
Change-Id: I0764278cff74a482c74381e6b5e4787ffc3f87e1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
47 files changed:
data/yang-data-api/src/main/java/org/opendaylight/yangtools/yang/data/api/schema/AbstractAnydataNode.java [new file with mode: 0644] blob
data/yang-data-api/src/main/java/org/opendaylight/yangtools/yang/data/api/schema/AbstractAnyxmlNode.java [new file with mode: 0644] blob
data/yang-data-api/src/main/java/org/opendaylight/yangtools/yang/data/api/schema/AbstractChoiceNode.java [new file with mode: 0644] blob
data/yang-data-api/src/main/java/org/opendaylight/yangtools/yang/data/api/schema/AbstractContainerNode.java [new file with mode: 0644] blob
data/yang-data-api/src/main/java/org/opendaylight/yangtools/yang/data/api/schema/AbstractLeafNode.java [new file with mode: 0644] blob
data/yang-data-api/src/main/java/org/opendaylight/yangtools/yang/data/api/schema/AbstractLeafSetEntryNode.java [new file with mode: 0644] blob
data/yang-data-api/src/main/java/org/opendaylight/yangtools/yang/data/api/schema/AbstractMapEntryNode.java [new file with mode: 0644] blob
data/yang-data-api/src/main/java/org/opendaylight/yangtools/yang/data/api/schema/AbstractNormalizedNode.java [moved from data/yang-data-spi/src/main/java/org/opendaylight/yangtools/yang/data/spi/node/AbstractNormalizedNode.java with 69% similarity] diff | blob | history
data/yang-data-api/src/main/java/org/opendaylight/yangtools/yang/data/api/schema/AbstractNormalizedSimpleValueNode.java [moved from data/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/schema/nodes/AbstractImmutableNormalizedSimpleValueNode.java with 56% similarity] diff | blob | history
data/yang-data-api/src/main/java/org/opendaylight/yangtools/yang/data/api/schema/AbstractNormalizedValueNode.java [new file with mode: 0644] blob
data/yang-data-api/src/main/java/org/opendaylight/yangtools/yang/data/api/schema/AbstractSystemLeafSetNode.java [new file with mode: 0644] blob
data/yang-data-api/src/main/java/org/opendaylight/yangtools/yang/data/api/schema/AbstractSystemMapNode.java [new file with mode: 0644] blob
data/yang-data-api/src/main/java/org/opendaylight/yangtools/yang/data/api/schema/AbstractUnkeyedListEntryNode.java [new file with mode: 0644] blob
data/yang-data-api/src/main/java/org/opendaylight/yangtools/yang/data/api/schema/AbstractUnkeyedListNode.java [new file with mode: 0644] blob
data/yang-data-api/src/main/java/org/opendaylight/yangtools/yang/data/api/schema/AbstractUserLeafSetNode.java [new file with mode: 0644] blob
data/yang-data-api/src/main/java/org/opendaylight/yangtools/yang/data/api/schema/AbstractUserMapNode.java [new file with mode: 0644] blob
data/yang-data-api/src/main/java/org/opendaylight/yangtools/yang/data/api/schema/DataContainerNode.java diff | blob | history
data/yang-data-api/src/main/java/org/opendaylight/yangtools/yang/data/api/schema/DistinctNodeContainer.java diff | blob | history
data/yang-data-api/src/main/java/org/opendaylight/yangtools/yang/data/api/schema/MapEntryNode.java diff | blob | history
data/yang-data-api/src/main/java/org/opendaylight/yangtools/yang/data/api/schema/NormalizedNode.java diff | blob | history
data/yang-data-api/src/main/java/org/opendaylight/yangtools/yang/data/api/schema/NormalizedNodePrettyTree.java [moved from data/yang-data-spi/src/main/java/org/opendaylight/yangtools/yang/data/spi/node/NormalizedNodePrettyTree.java with 92% similarity] diff | blob | history
data/yang-data-api/src/main/java/org/opendaylight/yangtools/yang/data/api/schema/UnkeyedListEntryNode.java diff | blob | history
data/yang-data-api/src/test/java/org/opendaylight/yangtools/yang/data/api/schema/NormalizedNodesTest.java diff | blob | history
data/yang-data-api/src/test/java/org/opendaylight/yangtools/yang/data/api/schema/stream/NormalizedNodeWriterTest.java diff | blob | history
data/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/schema/builder/impl/AbstractImmutableDataContainerNodeBuilder.java diff | blob | history
data/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/schema/builder/impl/ImmutableAnyXmlNodeBuilder.java diff | blob | history
data/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/schema/builder/impl/ImmutableAnydataNodeBuilder.java diff | blob | history
data/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/schema/builder/impl/ImmutableChoiceNodeBuilder.java diff | blob | history
data/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/schema/builder/impl/ImmutableContainerNodeBuilder.java diff | blob | history
data/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/schema/builder/impl/ImmutableLeafNodeBuilder.java diff | blob | history
data/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/schema/builder/impl/ImmutableLeafSetEntryNodeBuilder.java diff | blob | history
data/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/schema/builder/impl/ImmutableLeafSetNodeBuilder.java diff | blob | history
data/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/schema/builder/impl/ImmutableMapEntryNodeBuilder.java diff | blob | history
data/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/schema/builder/impl/ImmutableMapNodeBuilder.java diff | blob | history
data/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/schema/builder/impl/ImmutableNormalizedNodeMethods.java [new file with mode: 0644] blob
data/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/schema/builder/impl/ImmutableUnkeyedListEntryNodeBuilder.java diff | blob | history
data/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/schema/builder/impl/ImmutableUnkeyedListNodeBuilder.java diff | blob | history
data/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/schema/builder/impl/ImmutableUserLeafSetNodeBuilder.java diff | blob | history
data/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/schema/builder/impl/ImmutableUserMapNodeBuilder.java diff | blob | history
data/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/schema/nodes/AbstractImmutableDataContainerNode.java [deleted file] blob | history
data/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/schema/nodes/AbstractImmutableNormalizedValueNode.java [deleted file] blob | history
data/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/schema/nodes/LazyValues.java diff | blob | history
data/yang-data-tree-spi/src/main/java/org/opendaylight/yangtools/yang/data/tree/spi/DataTreeCandidateNodes.java diff | blob | history
data/yang-data-tree-spi/src/test/java/org/opendaylight/yangtools/yang/data/tree/spi/DataTreeCandidateNodesTest.java diff | blob | history
data/yang-data-tree-spi/src/test/java/org/opendaylight/yangtools/yang/data/tree/spi/DataTreeCandidatesTest.java diff | blob | history
data/yang-data-tree-spi/src/test/java/org/opendaylight/yangtools/yang/data/tree/spi/NormalizedNodeDataTreeCandidateNodeTest.java diff | blob | history
data/yang-data-tree-spi/src/test/java/org/opendaylight/yangtools/yang/data/tree/spi/YT1455Test.java diff | blob | history
OpenDaylight YANG Tools