Code Review / netconf.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: 3578c00) | patch
Improve NETCONF session ID handling 46/105746/5
authorRobert Varga <robert.varga@pantheon.tech>
Fri, 28 Apr 2023 18:56:42 +0000 (20:56 +0200)
committerRobert Varga <robert.varga@pantheon.tech>
Sun, 30 Apr 2023 16:23:32 +0000 (18:23 +0200)
commita78eedbed12341f665d4988fa7c61c5c702cf2dd
tree222b71db30b8baeeea6795d6f6fc0e83f26daaf4tree | snapshot
parent3578c00ce2daa5850f77d76c0041996ee172d2c4commit | diff
Improve NETCONF session ID handling

The session ID has a well-defined semantics, which are not a String, nor
a long, but rather an Uint32 with minimum value of 1 -- as captured by
SessionIdType.

Use SessionIdType as the proper type-safe capture of this construct
across the project.

This also forces netconf-testtool to use proper lifecycle hooks, so that
the session ID is propagated.

JIRA: NETCONF-945
Change-Id: If197be95e8ac4943409eb4e00476a57269828e18
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
85 files changed:
apps/netconf-events-mdsal/src/main/java/org/opendaylight/netconf/server/events/mdsal/CreateSubscription.java diff | blob | history
apps/netconf-events-mdsal/src/main/java/org/opendaylight/netconf/server/events/mdsal/NetconfNotificationOperationService.java diff | blob | history
apps/netconf-events-mdsal/src/main/java/org/opendaylight/netconf/server/events/mdsal/NetconfNotificationOperationServiceFactory.java diff | blob | history
apps/netconf-events-mdsal/src/test/java/org/opendaylight/netconf/server/events/mdsal/CreateSubscriptionTest.java diff | blob | history
netconf/mdsal-netconf-monitoring/src/main/java/org/opendaylight/controller/config/yang/netconf/mdsal/monitoring/GetSchema.java diff | blob | history
netconf/mdsal-netconf-monitoring/src/main/java/org/opendaylight/controller/config/yang/netconf/mdsal/monitoring/MdsalMonitoringMapperFactory.java diff | blob | history
netconf/netconf-netty-util/src/main/java/org/opendaylight/netconf/nettyutil/AbstractNetconfSession.java diff | blob | history
netconf/netconf-netty-util/src/test/java/org/opendaylight/netconf/nettyutil/AbstractNetconfSessionTest.java diff | blob | history
netconf/netconf-netty-util/src/test/java/org/opendaylight/netconf/nettyutil/TestSessionNegotiator.java diff | blob | history
netconf/netconf-netty-util/src/test/java/org/opendaylight/netconf/nettyutil/TestingNetconfSession.java diff | blob | history
netconf/tools/netconf-testtool/src/main/java/org/opendaylight/netconf/test/tool/MdsalOperationProvider.java diff | blob | history
netconf/tools/netconf-testtool/src/main/java/org/opendaylight/netconf/test/tool/NetconfDeviceSimulator.java diff | blob | history
netconf/tools/netconf-testtool/src/main/java/org/opendaylight/netconf/test/tool/SimulatedOperationProvider.java diff | blob | history
netconf/tools/netconf-testtool/src/main/java/org/opendaylight/netconf/test/tool/TesttoolNegotiationFactory.java diff | blob | history
netconf/tools/netconf-testtool/src/main/java/org/opendaylight/netconf/test/tool/customrpc/SettableOperationProvider.java diff | blob | history
netconf/tools/netconf-testtool/src/main/java/org/opendaylight/netconf/test/tool/monitoring/Get.java diff | blob | history
netconf/tools/netconf-testtool/src/main/java/org/opendaylight/netconf/test/tool/monitoring/NetconfMonitoringOperationService.java diff | blob | history
netconf/tools/netconf-testtool/src/main/java/org/opendaylight/netconf/test/tool/monitoring/NetconfMonitoringOperationServiceFactory.java diff | blob | history
netconf/tools/netconf-testtool/src/main/java/org/opendaylight/netconf/test/tool/operations/DefaultOperationsCreator.java diff | blob | history
netconf/tools/netconf-testtool/src/main/java/org/opendaylight/netconf/test/tool/operations/OperationsCreator.java diff | blob | history
netconf/tools/netconf-testtool/src/main/java/org/opendaylight/netconf/test/tool/operations/OperationsProvider.java diff | blob | history
netconf/tools/netconf-testtool/src/main/java/org/opendaylight/netconf/test/tool/rpc/SimulatedCommit.java diff | blob | history
netconf/tools/netconf-testtool/src/main/java/org/opendaylight/netconf/test/tool/rpc/SimulatedCreateSubscription.java diff | blob | history
netconf/tools/netconf-testtool/src/main/java/org/opendaylight/netconf/test/tool/rpc/SimulatedDiscardChanges.java diff | blob | history
netconf/tools/netconf-testtool/src/main/java/org/opendaylight/netconf/test/tool/rpc/SimulatedEditConfig.java diff | blob | history
netconf/tools/netconf-testtool/src/main/java/org/opendaylight/netconf/test/tool/rpc/SimulatedGet.java diff | blob | history
netconf/tools/netconf-testtool/src/main/java/org/opendaylight/netconf/test/tool/rpc/SimulatedGetConfig.java diff | blob | history
netconf/tools/netconf-testtool/src/main/java/org/opendaylight/netconf/test/tool/rpc/SimulatedLock.java diff | blob | history
netconf/tools/netconf-testtool/src/main/java/org/opendaylight/netconf/test/tool/rpc/SimulatedUnLock.java diff | blob | history
netconf/tools/netconf-testtool/src/main/java/org/opendaylight/netconf/test/tool/rpchandler/SettableOperationRpcProvider.java diff | blob | history
plugins/netconf-server-mdsal/src/main/java/org/opendaylight/netconf/mdsal/connector/MdsalNetconfOperationService.java diff | blob | history
plugins/netconf-server-mdsal/src/main/java/org/opendaylight/netconf/mdsal/connector/MdsalNetconfOperationServiceFactory.java diff | blob | history
plugins/netconf-server-mdsal/src/main/java/org/opendaylight/netconf/mdsal/connector/TransactionProvider.java diff | blob | history
plugins/netconf-server-mdsal/src/main/java/org/opendaylight/netconf/mdsal/connector/ops/AbstractConfigOperation.java diff | blob | history
plugins/netconf-server-mdsal/src/main/java/org/opendaylight/netconf/mdsal/connector/ops/AbstractEdit.java diff | blob | history
plugins/netconf-server-mdsal/src/main/java/org/opendaylight/netconf/mdsal/connector/ops/Commit.java diff | blob | history
plugins/netconf-server-mdsal/src/main/java/org/opendaylight/netconf/mdsal/connector/ops/CopyConfig.java diff | blob | history
plugins/netconf-server-mdsal/src/main/java/org/opendaylight/netconf/mdsal/connector/ops/DiscardChanges.java diff | blob | history
plugins/netconf-server-mdsal/src/main/java/org/opendaylight/netconf/mdsal/connector/ops/EditConfig.java diff | blob | history
plugins/netconf-server-mdsal/src/main/java/org/opendaylight/netconf/mdsal/connector/ops/Lock.java diff | blob | history
plugins/netconf-server-mdsal/src/main/java/org/opendaylight/netconf/mdsal/connector/ops/RuntimeRpc.java diff | blob | history
plugins/netconf-server-mdsal/src/main/java/org/opendaylight/netconf/mdsal/connector/ops/Unlock.java diff | blob | history
plugins/netconf-server-mdsal/src/main/java/org/opendaylight/netconf/mdsal/connector/ops/Validate.java diff | blob | history
plugins/netconf-server-mdsal/src/main/java/org/opendaylight/netconf/mdsal/connector/ops/get/AbstractGet.java diff | blob | history
plugins/netconf-server-mdsal/src/main/java/org/opendaylight/netconf/mdsal/connector/ops/get/Get.java diff | blob | history
plugins/netconf-server-mdsal/src/main/java/org/opendaylight/netconf/mdsal/connector/ops/get/GetConfig.java diff | blob | history
plugins/netconf-server-mdsal/src/test/java/org/opendaylight/netconf/mdsal/connector/ops/AbstractNetconfOperationTest.java diff | blob | history
plugins/netconf-server-mdsal/src/test/java/org/opendaylight/netconf/mdsal/connector/ops/NetconfMDSalMappingTest.java diff | blob | history
plugins/netconf-server-mdsal/src/test/java/org/opendaylight/netconf/mdsal/connector/ops/RuntimeRpcTest.java diff | blob | history
plugins/netconf-server-mdsal/src/test/java/org/opendaylight/netconf/mdsal/connector/ops/get/Netconf538Test.java diff | blob | history
plugins/sal-netconf-connector/src/main/java/org/opendaylight/netconf/sal/connect/netconf/listener/NetconfSessionPreferences.java diff | blob | history
plugins/sal-netconf-connector/src/test/java/org/opendaylight/netconf/sal/connect/netconf/listener/NetconfDeviceCommunicatorTest.java diff | blob | history
protocol/netconf-api/pom.xml diff | blob | history
protocol/netconf-api/src/main/java/org/opendaylight/netconf/api/messages/HelloMessage.java diff | blob | history
protocol/netconf-api/src/test/java/org/opendaylight/netconf/api/messages/HelloMessageTest.java diff | blob | history
protocol/netconf-client/src/main/java/org/opendaylight/netconf/client/NetconfClientSession.java diff | blob | history
protocol/netconf-client/src/main/java/org/opendaylight/netconf/client/NetconfClientSessionNegotiator.java diff | blob | history
protocol/netconf-client/src/test/java/org/opendaylight/netconf/client/NetconfClientSessionNegotiatorTest.java diff | blob | history
protocol/netconf-client/src/test/java/org/opendaylight/netconf/client/NetconfClientSessionTest.java diff | blob | history
protocol/netconf-client/src/test/java/org/opendaylight/netconf/client/SimpleNetconfClientSessionListenerTest.java diff | blob | history
protocol/netconf-client/src/test/java/org/opendaylight/netconf/client/TestingNetconfClient.java diff | blob | history
protocol/netconf-server/pom.xml diff | blob | history
protocol/netconf-server/src/main/java/org/opendaylight/netconf/server/NetconfServerSession.java diff | blob | history
protocol/netconf-server/src/main/java/org/opendaylight/netconf/server/NetconfServerSessionNegotiator.java diff | blob | history
protocol/netconf-server/src/main/java/org/opendaylight/netconf/server/NetconfServerSessionNegotiatorFactory.java diff | blob | history
protocol/netconf-server/src/main/java/org/opendaylight/netconf/server/api/SessionIdProvider.java diff | blob | history
protocol/netconf-server/src/main/java/org/opendaylight/netconf/server/api/operations/AbstractLastNetconfOperation.java diff | blob | history
protocol/netconf-server/src/main/java/org/opendaylight/netconf/server/api/operations/AbstractNetconfOperation.java diff | blob | history
protocol/netconf-server/src/main/java/org/opendaylight/netconf/server/api/operations/AbstractSingletonNetconfOperation.java diff | blob | history
protocol/netconf-server/src/main/java/org/opendaylight/netconf/server/api/operations/NetconfOperationServiceFactory.java diff | blob | history
protocol/netconf-server/src/main/java/org/opendaylight/netconf/server/impl/DefaultSessionIdProvider.java diff | blob | history
protocol/netconf-server/src/main/java/org/opendaylight/netconf/server/mapping/operations/DefaultCloseSession.java diff | blob | history
protocol/netconf-server/src/main/java/org/opendaylight/netconf/server/mapping/operations/DefaultStartExi.java diff | blob | history
protocol/netconf-server/src/main/java/org/opendaylight/netconf/server/mapping/operations/DefaultStopExi.java diff | blob | history
protocol/netconf-server/src/main/java/org/opendaylight/netconf/server/osgi/AggregatedNetconfOperationServiceFactory.java diff | blob | history
protocol/netconf-server/src/main/java/org/opendaylight/netconf/server/osgi/NetconfOperationRouterImpl.java diff | blob | history
protocol/netconf-server/src/test/java/org/opendaylight/netconf/server/ConcurrentClientsTest.java diff | blob | history
protocol/netconf-server/src/test/java/org/opendaylight/netconf/server/NetconfServerSessionListenerTest.java diff | blob | history
protocol/netconf-server/src/test/java/org/opendaylight/netconf/server/NetconfServerSessionTest.java diff | blob | history
protocol/netconf-server/src/test/java/org/opendaylight/netconf/server/api/operations/AbstractLastNetconfOperationTest.java diff | blob | history
protocol/netconf-server/src/test/java/org/opendaylight/netconf/server/api/operations/AbstractNetconfOperationTest.java diff | blob | history
protocol/netconf-server/src/test/java/org/opendaylight/netconf/server/api/operations/AbstractSingletonNetconfOperationTest.java diff | blob | history
protocol/netconf-server/src/test/java/org/opendaylight/netconf/server/mapping/operations/DefaultCloseSessionTest.java diff | blob | history
protocol/netconf-server/src/test/java/org/opendaylight/netconf/server/mapping/operations/DefaultStopExiTest.java diff | blob | history
protocol/netconf-server/src/test/java/org/opendaylight/netconf/server/osgi/NetconfOperationRouterImplTest.java diff | blob | history
Netconf