Java 5 migration 88/68488/6
authorStephen Kitt <skitt@redhat.com>
Thu, 22 Feb 2018 10:42:18 +0000 (11:42 +0100)
committerSam Hague <shague@redhat.com>
Wed, 4 Apr 2018 15:53:24 +0000 (15:53 +0000)
commit3cd66a15326870898f5b11c32aaba1d92e845f54
treed2d69d08a109ba6e9f11590088ad93e1d818d5ec
parent94a376cdb49576d4eb33f8c85ac86dcc77e6e723
Java 5 migration

* Use foreach loops instead of indexed for loops or iterating while
  loops.
* Use String::contains instead of String::indexOf.
* Use StringBuilder instead of StringBuffer, or a collector when the
  StringBuffer is only used to join a string collection.

This patch also simplifies the return value handling in
FibHelper::doesPrefixBelongToSubnet.

Change-Id: I13c63380e056cdeaa96090c16fee06316db782d9
Signed-off-by: Stephen Kitt <skitt@redhat.com>
bgpmanager/impl/src/main/java/org/opendaylight/netvirt/bgpmanager/BgpUtil.java
bgpmanager/impl/src/main/java/org/opendaylight/netvirt/bgpmanager/VtyshCli.java
elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/ha/HwvtepHAUtil.java
fibmanager/api/src/main/java/org/opendaylight/netvirt/fibmanager/api/FibHelper.java
fibmanager/shell/src/main/java/org/opendaylight/netvirt/fibmanager/shell/ShowFibCommand.java
ipv6service/impl/src/main/java/org/opendaylight/netvirt/ipv6service/utils/Ipv6ServiceUtils.java
ipv6service/shell/src/main/java/org/opendaylight/netvirt/ipv6service/shell/ShowIpv6Command.java
neutronvpn/impl/src/main/java/org/opendaylight/netvirt/neutronvpn/NeutronBgpvpnChangeListener.java
neutronvpn/impl/src/main/java/org/opendaylight/netvirt/neutronvpn/NeutronvpnUtils.java
statistics/impl/src/main/java/org/opendaylight/netvirt/statistics/CounterRetriever.java
vpnmanager/impl/src/main/java/org/opendaylight/netvirt/vpnmanager/VpnSubnetRouteHandler.java