NETVIRT-1076: refactor arrow anti-patterns 03/68203/17
authorValentina <valentina.krasnobaeva@6wind.com>
Tue, 13 Feb 2018 16:53:06 +0000 (17:53 +0100)
committerSam Hague <shague@redhat.com>
Tue, 20 Mar 2018 11:21:05 +0000 (11:21 +0000)
commitde0d153abf233b5279eeb92130afb078bbff6fbd
tree9a9f54f0efe88e1bdd38fea1b453ccbb961ce805
parentb2217b6d2a6c0e710bb04099e749f33e0454a1d4
NETVIRT-1076: refactor arrow anti-patterns

* NeutronvpnUtils:

    ** getSubnetMapsforNetworkRoute() method is replaced by
       getPrivateSubnetsToExport(), which obtains the list of private
       subnets from router in more simple way;
    ** addExternalNetworkToVpn() and removeExternalNetworkFromVpn() were
       moved to NeutronvpnManager to avoid import collisions.

* NeutronvpnNatManager:

    ** use getPrivateSubnetsToExport() instead of
       getSubnetMapsforNetworkRoute();
    ** fix log messages.

* NeutronvpnManager:

    ** refactor arrow anti-patterns in associateNetworksToVpn() and
       dissociateNetworksFromVpn() methods;
    ** add a support of use-case, when BGPVPN can be associated with more
       than one Provider Network;
    ** fix log messages;

JIRA: NETVIRT-1076
Change-Id: Ifea2e0d2c2631ac87a3883f5a59d5fd3f189f812
Signed-off-by: Valentina <valentina.krasnobaeva@6wind.com>
neutronvpn/impl/src/main/java/org/opendaylight/netvirt/neutronvpn/NeutronvpnManager.java
neutronvpn/impl/src/main/java/org/opendaylight/netvirt/neutronvpn/NeutronvpnNatManager.java
neutronvpn/impl/src/main/java/org/opendaylight/netvirt/neutronvpn/NeutronvpnUtils.java