Code Review / packetcable.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: 4f0f343) | patch
Completed COPS Message refactoring. Was planning on one additional patch starting... 70/18670/1
authorSteven Pisarski <s.pisarski@cablelabs.com>
Mon, 20 Apr 2015 21:24:51 +0000 (15:24 -0600)
committerSteven Pisarski <s.pisarski@cablelabs.com>
Mon, 20 Apr 2015 21:24:51 +0000 (15:24 -0600)
commitdd830d0bca451a8a11ec30d9a6d2f6d3480624e1
tree164dd78d8d3f0329018cf571d757023d8d1eac63tree | snapshot
parent4f0f343be373c2a8c261a8b951b254ccea7fc022commit | diff
Completed COPS Message refactoring. Was planning on one additional patch starting with the COPSHeader; however, the dependencies of COPSHeader were everywhere the COPSMsg objects were being instantiated and determined it would be easier merging this as the final patch versus splitting these changes up. Please see Bugzilla report #2943 for more details. In addition to the restructuring of the COPSMsg classes for immutability, semantics by adding in enumerations, and testability, this patch is also fixing some of the code warnings and removing MS-DOS CR characters.

Change-Id: Ica1e55209728fab5c71d0bffb52eb4ca0401e4dc
Signed-off-by: Steven Pisarski <s.pisarski@cablelabs.com>
63 files changed:
packetcable-driver/src/main/java/org/pcmm/PCMMPdpAgent.java diff | blob | history
packetcable-driver/src/main/java/org/pcmm/PCMMPdpConnection.java diff | blob | history
packetcable-driver/src/main/java/org/pcmm/PCMMPdpMsgSender.java diff | blob | history
packetcable-driver/src/main/java/org/pcmm/PCMMPdpReqStateMan.java diff | blob | history
packetcable-driver/src/main/java/org/pcmm/PCMMPepAgent.java diff | blob | history
packetcable-driver/src/main/java/org/pcmm/messages/IMessageFactory.java diff | blob | history
packetcable-driver/src/main/java/org/pcmm/messages/impl/COPSDecisionMsgEX.java diff | blob | history
packetcable-driver/src/main/java/org/pcmm/messages/impl/MessageFactory.java diff | blob | history
packetcable-driver/src/main/java/org/pcmm/nio/PCMMChannel.java diff | blob | history
packetcable-driver/src/main/java/org/pcmm/rcd/IPCMMClient.java diff | blob | history
packetcable-driver/src/main/java/org/pcmm/rcd/impl/AbstractPCMMServer.java diff | blob | history
packetcable-driver/src/main/java/org/pcmm/rcd/impl/CMTS.java diff | blob | history
packetcable-driver/src/main/java/org/pcmm/rcd/impl/PCMMPolicyServer.java diff | blob | history
packetcable-driver/src/main/java/org/umu/cops/ospdp/COPSPdpOSAgent.java diff | blob | history
packetcable-driver/src/main/java/org/umu/cops/ospdp/COPSPdpOSConnection.java diff | blob | history
packetcable-driver/src/main/java/org/umu/cops/ospdp/COPSPdpOSDataProcess.java diff | blob | history
packetcable-driver/src/main/java/org/umu/cops/ospdp/COPSPdpOSMsgSender.java diff | blob | history
packetcable-driver/src/main/java/org/umu/cops/ospdp/COPSPdpOSReqStateMan.java diff | blob | history
packetcable-driver/src/main/java/org/umu/cops/ospep/COPSPepOSAgent.java diff | blob | history
packetcable-driver/src/main/java/org/umu/cops/ospep/COPSPepOSConnection.java diff | blob | history
packetcable-driver/src/main/java/org/umu/cops/ospep/COPSPepOSMsgSender.java diff | blob | history
packetcable-driver/src/main/java/org/umu/cops/ospep/COPSPepOSReqStateMan.java diff | blob | history
packetcable-driver/src/main/java/org/umu/cops/prpdp/COPSPdpAgent.java diff | blob | history
packetcable-driver/src/main/java/org/umu/cops/prpdp/COPSPdpConnection.java diff | blob | history
packetcable-driver/src/main/java/org/umu/cops/prpdp/COPSPdpDataProcess.java diff | blob | history
packetcable-driver/src/main/java/org/umu/cops/prpdp/COPSPdpMsgSender.java diff | blob | history
packetcable-driver/src/main/java/org/umu/cops/prpdp/COPSPdpReqStateMan.java diff | blob | history
packetcable-driver/src/main/java/org/umu/cops/prpep/COPSPepAgent.java diff | blob | history
packetcable-driver/src/main/java/org/umu/cops/prpep/COPSPepConnection.java diff | blob | history
packetcable-driver/src/main/java/org/umu/cops/prpep/COPSPepDataProcess.java diff | blob | history
packetcable-driver/src/main/java/org/umu/cops/prpep/COPSPepMsgSender.java diff | blob | history
packetcable-driver/src/main/java/org/umu/cops/prpep/COPSPepReqStateMan.java diff | blob | history
packetcable-driver/src/main/java/org/umu/cops/stack/COPSClientAcceptMsg.java diff | blob | history
packetcable-driver/src/main/java/org/umu/cops/stack/COPSClientCloseMsg.java diff | blob | history
packetcable-driver/src/main/java/org/umu/cops/stack/COPSClientOpenMsg.java diff | blob | history
packetcable-driver/src/main/java/org/umu/cops/stack/COPSData.java diff | blob | history
packetcable-driver/src/main/java/org/umu/cops/stack/COPSDecision.java diff | blob | history
packetcable-driver/src/main/java/org/umu/cops/stack/COPSDecisionMsg.java diff | blob | history
packetcable-driver/src/main/java/org/umu/cops/stack/COPSDeleteMsg.java diff | blob | history
packetcable-driver/src/main/java/org/umu/cops/stack/COPSHandle.java diff | blob | history
packetcable-driver/src/main/java/org/umu/cops/stack/COPSHeader.java diff | blob | history
packetcable-driver/src/main/java/org/umu/cops/stack/COPSHeaderData.java [new file with mode: 0644] blob
packetcable-driver/src/main/java/org/umu/cops/stack/COPSKAMsg.java diff | blob | history
packetcable-driver/src/main/java/org/umu/cops/stack/COPSMsg.java diff | blob | history
packetcable-driver/src/main/java/org/umu/cops/stack/COPSMsgParser.java diff | blob | history
packetcable-driver/src/main/java/org/umu/cops/stack/COPSObjBase.java diff | blob | history
packetcable-driver/src/main/java/org/umu/cops/stack/COPSReportMsg.java diff | blob | history
packetcable-driver/src/main/java/org/umu/cops/stack/COPSReqMsg.java diff | blob | history
packetcable-driver/src/main/java/org/umu/cops/stack/COPSSyncStateMsg.java diff | blob | history
packetcable-driver/src/main/java/org/umu/cops/stack/COPSTransceiver.java diff | blob | history
packetcable-driver/src/test/java/org/umu/cops/stack/COPSClientAcceptMsgTest.java [new file with mode: 0644] blob
packetcable-driver/src/test/java/org/umu/cops/stack/COPSClientCloseMsgTest.java [new file with mode: 0644] blob
packetcable-driver/src/test/java/org/umu/cops/stack/COPSClientOpenMsgTest.java [new file with mode: 0644] blob
packetcable-driver/src/test/java/org/umu/cops/stack/COPSDataFirstConstructorTest.java diff | blob | history
packetcable-driver/src/test/java/org/umu/cops/stack/COPSDecisionMsgTest.java [new file with mode: 0644] blob
packetcable-driver/src/test/java/org/umu/cops/stack/COPSDeleteMsgTest.java [new file with mode: 0644] blob
packetcable-driver/src/test/java/org/umu/cops/stack/COPSHeaderTest.java [new file with mode: 0644] blob
packetcable-driver/src/test/java/org/umu/cops/stack/COPSKAMsgTest.java [new file with mode: 0644] blob
packetcable-driver/src/test/java/org/umu/cops/stack/COPSMsgParserTest.java [new file with mode: 0644] blob
packetcable-driver/src/test/java/org/umu/cops/stack/COPSReportMsgTest.java [new file with mode: 0644] blob
packetcable-driver/src/test/java/org/umu/cops/stack/COPSReqMsgTest.java [new file with mode: 0644] blob
packetcable-driver/src/test/java/org/umu/cops/stack/COPSSyncStateMsgTest.java [new file with mode: 0644] blob
packetcable-driver/src/test/java/org/umu/cops/stack/TestCOPSServer.java [new file with mode: 0644] blob
PacketCable