Fix FindBugs violations and enable enforcement 39/67639/3
authorTom Pantelis <tompantelis@gmail.com>
Sat, 27 Jan 2018 16:30:09 +0000 (11:30 -0500)
committerTom Pantelis <tompantelis@gmail.com>
Fri, 9 Feb 2018 15:17:35 +0000 (10:17 -0500)
commitaa24978000a477367321aadd836d1a1abe261ff5
tree470e990adecce3e46f68c46d354064b3a99a61b1
parentaeb68a5d96bbf19361f423722c4852ad8f3542cf
Fix FindBugs violations and enable enforcement

- Method call passes null for non-null parameter
- Method ignores exceptional return value
- Boxing/unboxing to parse a primitive
- Redundant nullcheck of value known to be non-null
- Constructor invokes Thread.start()
- Load of known null value

Change-Id: I3cf3c48306c1ade906fe51b5c0492f5a669a2d43
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
13 files changed:
.gitignore
addresstracker/implementation/src/main/java/org/opendaylight/l2switch/addresstracker/addressobserver/AddressTrackerProvider.java
arphandler/src/main/java/org/opendaylight/l2switch/arphandler/core/PacketDispatcher.java
arphandler/src/main/java/org/opendaylight/l2switch/arphandler/flow/InitialFlowWriter.java
arphandler/src/test/java/org/opendaylight/l2switch/arphandler/core/PacketDispatcherTest.java
hosttracker/implementation/src/main/java/org/opendaylight/l2switch/hosttracker/plugin/internal/HostTrackerImpl.java
hosttracker/implementation/src/main/java/org/opendaylight/l2switch/hosttracker/plugin/internal/OperationProcessor.java
l2switch-main/src/main/java/org/opendaylight/l2switch/flow/InitialFlowWriter.java
loopremover/implementation/src/main/java/org/opendaylight/l2switch/loopremover/flow/InitialFlowWriter.java
packethandler/implementation/src/main/java/org/opendaylight/l2switch/packethandler/decoders/AbstractPacketDecoder.java
packethandler/implementation/src/main/java/org/opendaylight/l2switch/packethandler/decoders/utils/BitBufferHelper.java
packethandler/implementation/src/main/java/org/opendaylight/l2switch/packethandler/decoders/utils/NetUtils.java
parent/pom.xml