Clean up mdsal-singleton-dom-impl 45/109245/1
authorRobert Varga <robert.varga@pantheon.tech>
Sat, 9 Dec 2023 06:38:46 +0000 (07:38 +0100)
committerRobert Varga <robert.varga@pantheon.tech>
Sat, 9 Dec 2023 07:46:50 +0000 (08:46 +0100)
commit73703bbaabbb0044bac5c859c25e51bb6b723b7f
tree2c1eb3a967a765333b84e081eefa7bf5d0b8634e
parent401a736f12fb8c0cd85ec8b8a1e1093f262110d9
Clean up mdsal-singleton-dom-impl

Fold the multitude of implementation classes into a single
EOSClusterSingletonServiceProvider.

Furthermore do not expose close() from the implemented interface, so
that users do not end up shutting the implementation down.

Eliminate ServiceLoader integration, as we are a stateful component
and therefore want to explicit lifecycle.

The shutdown process is made synchronous, so that close() waits for
everything to settle down.

JIRA: MDSAL-843
Change-Id: I0d137d03d184de07e21e5a9a4329855a021dd433
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
14 files changed:
replicate/mdsal-replicate-netty/src/test/java/org/opendaylight/mdsal/replicate/netty/IntegrationTest.java
singleton-service/mdsal-singleton-common-api/src/main/java/org/opendaylight/mdsal/singleton/common/api/ClusterSingletonServiceProvider.java
singleton-service/mdsal-singleton-dom-impl/pom.xml
singleton-service/mdsal-singleton-dom-impl/src/main/java/module-info.java
singleton-service/mdsal-singleton-dom-impl/src/main/java/org/opendaylight/mdsal/singleton/dom/impl/ClusterSingletonServiceGroupImpl.java
singleton-service/mdsal-singleton-dom-impl/src/main/java/org/opendaylight/mdsal/singleton/dom/impl/DOMClusterSingletonServiceProviderImpl.java [deleted file]
singleton-service/mdsal-singleton-dom-impl/src/main/java/org/opendaylight/mdsal/singleton/dom/impl/EOSClusterSingletonServiceProvider.java [moved from singleton-service/mdsal-singleton-dom-impl/src/main/java/org/opendaylight/mdsal/singleton/dom/impl/AbstractClusterSingletonServiceProviderImpl.java with 67% similarity]
singleton-service/mdsal-singleton-dom-impl/src/main/java/org/opendaylight/mdsal/singleton/dom/impl/OSGiClusterSingletonServiceProvider.java [deleted file]
singleton-service/mdsal-singleton-dom-impl/src/main/java/org/opendaylight/mdsal/singleton/dom/impl/ServiceInfo.java
singleton-service/mdsal-singleton-dom-impl/src/main/java/org/opendaylight/mdsal/singleton/dom/impl/di/DefaultClusterSingletonServiceProvider.java [deleted file]
singleton-service/mdsal-singleton-dom-impl/src/test/java/org/opendaylight/mdsal/singleton/dom/impl/AbstractEOSClusterSingletonServiceProviderTest.java [moved from singleton-service/mdsal-singleton-dom-impl/src/test/java/org/opendaylight/mdsal/singleton/dom/impl/AbstractDOMClusterServiceProviderTest.java with 94% similarity]
singleton-service/mdsal-singleton-dom-impl/src/test/java/org/opendaylight/mdsal/singleton/dom/impl/AsyncEOSClusterSingletonServiceProviderTest.java [moved from singleton-service/mdsal-singleton-dom-impl/src/test/java/org/opendaylight/mdsal/singleton/dom/impl/DOMClusterSingletonServiceProviderAsyncImplTest.java with 99% similarity]
singleton-service/mdsal-singleton-dom-impl/src/test/java/org/opendaylight/mdsal/singleton/dom/impl/ClusterSingletonServiceGroupImplTest.java
singleton-service/mdsal-singleton-dom-impl/src/test/java/org/opendaylight/mdsal/singleton/dom/impl/SyncEOSClusterSingletonServiceProviderTest.java [moved from singleton-service/mdsal-singleton-dom-impl/src/test/java/org/opendaylight/mdsal/singleton/dom/impl/DOMClusterSingletonServiceProviderImplTest.java with 97% similarity]