BUG-4688: eliminate SimpleDateFormatUtil.DEFAULT_DATE_REV 73/64673/3
authorRobert Varga <robert.varga@pantheon.tech>
Tue, 24 Oct 2017 15:49:22 +0000 (17:49 +0200)
committerRobert Varga <robert.varga@pantheon.tech>
Tue, 24 Oct 2017 19:28:42 +0000 (21:28 +0200)
commit6071a13cdd982f42b4ffb9a9ad67380a7abe146e
treec967814cb210a508d731e3bb90e7620ad72de401
parentae76efb1486909a2a57102a23b4d0fc7efee95a0
BUG-4688: eliminate SimpleDateFormatUtil.DEFAULT_DATE_REV

This is the final push for eliminating DEFAULT_DATE_REV, with all
other issues resolved, this removes the constant, adjusts the code
to correctly interpret non-present revisions and fixes up test
cases, eliminating the leaking 1970-01-01 string.

This actually fixes a few test cases, which relied on import with
revision 1970-01-01 matching modules which do not declare revision.

Change-Id: I59dbe8b06ad2d94e6a677959f29f5c2b52357d0b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
103 files changed:
yang/yang-common/src/main/java/org/opendaylight/yangtools/yang/common/SimpleDateFormatUtil.java
yang/yang-data-codec-gson/src/test/java/org/opendaylight/yangtools/yang/data/codec/gson/Bug4501Test.java
yang/yang-data-codec-gson/src/test/java/org/opendaylight/yangtools/yang/data/codec/gson/Bug7246Test.java
yang/yang-data-codec-xml/src/test/java/org/opendaylight/yangtools/yang/data/codec/xml/Bug8745Test.java
yang/yang-data-codec-xml/src/test/java/org/opendaylight/yangtools/yang/data/codec/xml/Bug8803Test.java
yang/yang-data-codec-xml/src/test/java/org/opendaylight/yangtools/yang/data/codec/xml/DOMSourceXMLStreamReaderTest.java
yang/yang-data-codec-xml/src/test/java/org/opendaylight/yangtools/yang/data/codec/xml/NormalizedNodesToXmlTest.java
yang/yang-data-codec-xml/src/test/java/org/opendaylight/yangtools/yang/data/codec/xml/XmlToNormalizedNodesTest.java
yang/yang-data-codec-xml/src/test/java/org/opendaylight/yangtools/yang/data/codec/xml/YangModeledAnyXMLDeserializationTest.java
yang/yang-data-codec-xml/src/test/java/org/opendaylight/yangtools/yang/data/codec/xml/YangModeledAnyXMLSerializationTest.java
yang/yang-data-impl/src/test/java/org/opendaylight/yangtools/yang/data/impl/codecs/StringPatternCheckingCodecTest.java
yang/yang-data-impl/src/test/java/org/opendaylight/yangtools/yang/data/impl/leafref/Bug7844Test.java
yang/yang-data-impl/src/test/java/org/opendaylight/yangtools/yang/data/impl/schema/SchemaUtilsTest.java
yang/yang-data-impl/src/test/java/org/opendaylight/yangtools/yang/data/impl/schema/tree/Bug4295Test.java
yang/yang-data-impl/src/test/java/org/opendaylight/yangtools/yang/data/impl/schema/tree/Bug8291Test.java
yang/yang-data-impl/src/test/java/org/opendaylight/yangtools/yang/data/impl/schema/tree/OrderedListTest.java
yang/yang-data-impl/src/test/resources/bug7844/bar.yang
yang/yang-data-impl/src/test/resources/bug7844/foo.yang
yang/yang-maven-plugin/src/main/java/org/opendaylight/yangtools/yang2sources/plugin/Util.java
yang/yang-model-export/src/main/java/org/opendaylight/yangtools/yang/model/export/SchemaContextEmitter.java
yang/yang-model-export/src/main/java/org/opendaylight/yangtools/yang/model/export/YinExportUtils.java
yang/yang-model-export/src/test/java/org/opendaylight/yangtools/yang/model/export/EffectiveSchemaContextEmitterTest.java
yang/yang-model-export/src/test/java/org/opendaylight/yangtools/yang/model/export/test/Bug2444Test.java
yang/yang-model-export/src/test/java/org/opendaylight/yangtools/yang/model/export/test/YinExportTestUtils.java
yang/yang-model-export/src/test/resources/bugs/bug2444/yang/import-yang1.yang
yang/yang-model-export/src/test/resources/bugs/bug2444/yang/import.yang
yang/yang-model-export/src/test/resources/bugs/bug2444/yang/include.yang
yang/yang-model-export/src/test/resources/bugs/bug2444/yin-effective-emitter/notification.yin [moved from yang/yang-model-export/src/test/resources/bugs/bug2444/yin-effective-emitter/notification@1970-01-01.yin with 96% similarity]
yang/yang-model-export/src/test/resources/bugs/bug2444/yin/action.yin [moved from yang/yang-model-export/src/test/resources/bugs/bug2444/yin/action@1970-01-01.yin with 100% similarity]
yang/yang-model-export/src/test/resources/bugs/bug2444/yin/anydata.yin [moved from yang/yang-model-export/src/test/resources/bugs/bug2444/yin/anydata@1970-01-01.yin with 100% similarity]
yang/yang-model-export/src/test/resources/bugs/bug2444/yin/binary-spec.yin [moved from yang/yang-model-export/src/test/resources/bugs/bug2444/yin/binary-spec@1970-01-01.yin with 100% similarity]
yang/yang-model-export/src/test/resources/bugs/bug2444/yin/default.yin [moved from yang/yang-model-export/src/test/resources/bugs/bug2444/yin/default@1970-01-01.yin with 100% similarity]
yang/yang-model-export/src/test/resources/bugs/bug2444/yin/identities.yin [moved from yang/yang-model-export/src/test/resources/bugs/bug2444/yin/identities@1970-01-01.yin with 100% similarity]
yang/yang-model-export/src/test/resources/bugs/bug2444/yin/import-yang1@1970-01-01.yin
yang/yang-model-export/src/test/resources/bugs/bug2444/yin/import.yin [moved from yang/yang-model-export/src/test/resources/bugs/bug2444/yin/import@1970-01-01.yin with 90% similarity]
yang/yang-model-export/src/test/resources/bugs/bug2444/yin/include@2017-06-26.yin
yang/yang-model-export/src/test/resources/bugs/bug2444/yin/leafref-yang1.yin [moved from yang/yang-model-export/src/test/resources/bugs/bug2444/yin/leafref-yang1@1970-01-01.yin with 100% similarity]
yang/yang-model-export/src/test/resources/bugs/bug2444/yin/leafref.yin [moved from yang/yang-model-export/src/test/resources/bugs/bug2444/yin/leafref@1970-01-01.yin with 100% similarity]
yang/yang-model-export/src/test/resources/bugs/bug2444/yin/modifier-yang1.yin [moved from yang/yang-model-export/src/test/resources/bugs/bug2444/yin/modifier-yang1@1970-01-01.yin with 100% similarity]
yang/yang-model-export/src/test/resources/bugs/bug2444/yin/modifier.yin [moved from yang/yang-model-export/src/test/resources/bugs/bug2444/yin/modifier@1970-01-01.yin with 100% similarity]
yang/yang-model-export/src/test/resources/bugs/bug2444/yin/must-yang1.yin [moved from yang/yang-model-export/src/test/resources/bugs/bug2444/yin/must-yang1@1970-01-01.yin with 100% similarity]
yang/yang-model-export/src/test/resources/bugs/bug2444/yin/must.yin [moved from yang/yang-model-export/src/test/resources/bugs/bug2444/yin/must@1970-01-01.yin with 100% similarity]
yang/yang-model-export/src/test/resources/bugs/bug2444/yin/notification.yin [moved from yang/yang-model-export/src/test/resources/bugs/bug2444/yin/notification@1970-01-01.yin with 100% similarity]
yang/yang-model-export/src/test/resources/bugs/bug2444/yin/submodule.yin [moved from yang/yang-model-export/src/test/resources/bugs/bug2444/yin/submodule@1970-01-01.yin with 100% similarity]
yang/yang-model-export/src/test/resources/bugs/bug2444/yin/unique.yin [moved from yang/yang-model-export/src/test/resources/bugs/bug2444/yin/unique@1970-01-01.yin with 100% similarity]
yang/yang-model-util/src/main/java/org/opendaylight/yangtools/yang/model/util/AbstractSchemaContext.java
yang/yang-model-util/src/main/java/org/opendaylight/yangtools/yang/model/util/ModuleDependencySort.java
yang/yang-parser-impl/src/main/java/org/opendaylight/yangtools/yang/parser/stmt/rfc6020/ModuleStatementSupport.java
yang/yang-parser-impl/src/main/java/org/opendaylight/yangtools/yang/parser/stmt/rfc6020/SubmoduleStatementImpl.java
yang/yang-parser-impl/src/main/java/org/opendaylight/yangtools/yang/parser/stmt/rfc6020/effective/ModuleEffectiveStatementImpl.java
yang/yang-parser-impl/src/main/java/org/opendaylight/yangtools/yang/parser/stmt/rfc6020/effective/SubmoduleEffectiveStatementImpl.java
yang/yang-parser-impl/src/test/java/org/opendaylight/yangtools/yang/parser/repo/MultipleRevImportBug6875Test.java
yang/yang-parser-impl/src/test/java/org/opendaylight/yangtools/yang/parser/repo/SharedSchemaRepositoryWithFeaturesTest.java
yang/yang-parser-impl/src/test/java/org/opendaylight/yangtools/yang/parser/stmt/rfc6020/Bug5410Test.java
yang/yang-parser-impl/src/test/java/org/opendaylight/yangtools/yang/parser/stmt/rfc7950/Bug6868Test.java
yang/yang-parser-impl/src/test/java/org/opendaylight/yangtools/yang/parser/stmt/rfc7950/Bug6869Test.java
yang/yang-parser-impl/src/test/java/org/opendaylight/yangtools/yang/parser/stmt/rfc7950/Bug6870Test.java
yang/yang-parser-impl/src/test/java/org/opendaylight/yangtools/yang/parser/stmt/rfc7950/Bug6876Test.java
yang/yang-parser-impl/src/test/java/org/opendaylight/yangtools/yang/parser/stmt/rfc7950/Bug6880Test.java
yang/yang-parser-impl/src/test/java/org/opendaylight/yangtools/yang/parser/stmt/rfc7950/Bug6883Test.java
yang/yang-parser-impl/src/test/java/org/opendaylight/yangtools/yang/parser/stmt/rfc7950/Bug6884Test.java
yang/yang-parser-impl/src/test/java/org/opendaylight/yangtools/yang/parser/stmt/rfc7950/Bug6897Test.java
yang/yang-parser-impl/src/test/java/org/opendaylight/yangtools/yang/parser/stmt/rfc7950/Bug6901Test.java
yang/yang-parser-impl/src/test/java/org/opendaylight/yangtools/yang/stmt/AugmentProcessTest.java
yang/yang-parser-impl/src/test/java/org/opendaylight/yangtools/yang/stmt/Bug3874ExtensionTest.java
yang/yang-parser-impl/src/test/java/org/opendaylight/yangtools/yang/stmt/Bug4410Test.java
yang/yang-parser-impl/src/test/java/org/opendaylight/yangtools/yang/stmt/Bug4623Test.java
yang/yang-parser-impl/src/test/java/org/opendaylight/yangtools/yang/stmt/Bug5396Test.java
yang/yang-parser-impl/src/test/java/org/opendaylight/yangtools/yang/stmt/Bug5518Test.java
yang/yang-parser-impl/src/test/java/org/opendaylight/yangtools/yang/stmt/Bug6183Test.java
yang/yang-parser-impl/src/test/java/org/opendaylight/yangtools/yang/stmt/Bug6316Test.java
yang/yang-parser-impl/src/test/java/org/opendaylight/yangtools/yang/stmt/Bug6491Test.java
yang/yang-parser-impl/src/test/java/org/opendaylight/yangtools/yang/stmt/Bug6771Test.java
yang/yang-parser-impl/src/test/java/org/opendaylight/yangtools/yang/stmt/Bug7037Test.java
yang/yang-parser-impl/src/test/java/org/opendaylight/yangtools/yang/stmt/Bug7424Test.java
yang/yang-parser-impl/src/test/java/org/opendaylight/yangtools/yang/stmt/Bug7865Test.java
yang/yang-parser-impl/src/test/java/org/opendaylight/yangtools/yang/stmt/Bug7879Test.java
yang/yang-parser-impl/src/test/java/org/opendaylight/yangtools/yang/stmt/Bug8126Test.java
yang/yang-parser-impl/src/test/java/org/opendaylight/yangtools/yang/stmt/Bug8597Test.java
yang/yang-parser-impl/src/test/java/org/opendaylight/yangtools/yang/stmt/Bug8922Test.java
yang/yang-parser-impl/src/test/java/org/opendaylight/yangtools/yang/stmt/EffectiveBuildTest.java
yang/yang-parser-impl/src/test/java/org/opendaylight/yangtools/yang/stmt/EffectiveIdentityTest.java
yang/yang-parser-impl/src/test/java/org/opendaylight/yangtools/yang/stmt/EffectiveModuleTest.java
yang/yang-parser-impl/src/test/java/org/opendaylight/yangtools/yang/stmt/EffectiveModulesAndSubmodulesTest.java
yang/yang-parser-impl/src/test/java/org/opendaylight/yangtools/yang/stmt/IfFeatureResolutionTest.java
yang/yang-parser-impl/src/test/java/org/opendaylight/yangtools/yang/stmt/ImportRevisionsTest.java
yang/yang-parser-impl/src/test/java/org/opendaylight/yangtools/yang/stmt/IncludeRevisionsTest.java
yang/yang-parser-impl/src/test/java/org/opendaylight/yangtools/yang/stmt/MoreRevisionsTest.java
yang/yang-parser-impl/src/test/java/org/opendaylight/yangtools/yang/stmt/YangParserNegativeTest.java
yang/yang-parser-impl/src/test/java/org/opendaylight/yangtools/yang/stmt/YangTypes2StmtTest.java
yang/yang-parser-impl/src/test/resources/bugs/bug7037/foo.yang
yang/yang-parser-impl/src/test/resources/bugs/bug7038/bar.yang
yang/yang-parser-impl/src/test/resources/bugs/bug8126/bar.yang
yang/yang-parser-impl/src/test/resources/import-revision-date-test/root-with-1970-revision-date.yang [deleted file]
yang/yang-parser-impl/src/test/resources/revisions/mod-1970-rev.yang [deleted file]
yang/yang-parser-impl/src/test/resources/revisions/mod-1970-root.yang [deleted file]
yang/yang-parser-impl/src/test/resources/rfc7950/bug6884/circular-includes/foo.yang
yang/yang-parser-impl/src/test/resources/rfc7950/bug6884/circular-includes/sub-foo.yang
yang/yang-parser-impl/src/test/resources/rfc7950/bug6884/yang1-1/foo.yang
yang/yang-parser-impl/src/test/resources/stmt-test/augments/multiple-augment-root.yang
yang/yang-parser-impl/src/test/resources/stmt-test/submodules/root-module.yang
yang/yang-parser-impl/src/test/resources/stmt-test/submodules/submodule-1.yang
yang/yang-parser-spi/src/main/java/org/opendaylight/yangtools/yang/parser/spi/meta/StmtContextUtils.java