Code Review / yangtools.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: 53ed624) | patch
BUG 1131: Removed duplicate code in builders. 95/7895/13
authorTomas Olvecky <tolvecky@cisco.com>
Wed, 25 Jun 2014 12:22:30 +0000 (14:22 +0200)
committerMartin Vitez <mvitez@cisco.com>
Mon, 30 Jun 2014 09:37:24 +0000 (09:37 +0000)
commit79682669e4e54af1fa2f98aafbdebba55ff184f9
tree1a833d83af06679b840fa529a163ab9d62c9f4fctree | snapshot
parent53ed6248e765cc1116a42fe443766a6a2bc3fe78commit | diff
BUG 1131: Removed duplicate code in builders.

Sonar Analysis showed that concrete implementations of builders have
number of similar code blocks, which deals with creating instance
of schema node.

This functionality should have only one implementiation (this
increases readibility and reduces potential places for bugs)
moved common shared functionality  to Abstract*Builder and
Abstract implementaitons of SchemaNodes.

Change-Id: Ie9d87eaa728612090f9ad3740381df1bf970d1fe
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
17 files changed:
yang/yang-model-api/src/main/java/org/opendaylight/yangtools/yang/model/api/DocumentedNode.java [new file with mode: 0644] blob
yang/yang-model-api/src/main/java/org/opendaylight/yangtools/yang/model/api/SchemaNode.java diff | blob | history
yang/yang-parser-impl/src/main/java/org/opendaylight/yangtools/yang/parser/builder/api/DataNodeContainerBuilder.java diff | blob | history
yang/yang-parser-impl/src/main/java/org/opendaylight/yangtools/yang/parser/builder/impl/AugmentationSchemaBuilderImpl.java diff | blob | history
yang/yang-parser-impl/src/main/java/org/opendaylight/yangtools/yang/parser/builder/impl/ChoiceCaseBuilder.java diff | blob | history
yang/yang-parser-impl/src/main/java/org/opendaylight/yangtools/yang/parser/builder/impl/ContainerSchemaNodeBuilder.java diff | blob | history
yang/yang-parser-impl/src/main/java/org/opendaylight/yangtools/yang/parser/builder/impl/GroupingBuilderImpl.java diff | blob | history
yang/yang-parser-impl/src/main/java/org/opendaylight/yangtools/yang/parser/builder/impl/ListSchemaNodeBuilder.java diff | blob | history
yang/yang-parser-impl/src/main/java/org/opendaylight/yangtools/yang/parser/builder/impl/ModuleBuilder.java diff | blob | history
yang/yang-parser-impl/src/main/java/org/opendaylight/yangtools/yang/parser/builder/impl/NotificationBuilder.java diff | blob | history
yang/yang-parser-impl/src/main/java/org/opendaylight/yangtools/yang/parser/builder/impl/RefineUtils.java diff | blob | history
yang/yang-parser-impl/src/main/java/org/opendaylight/yangtools/yang/parser/builder/util/AbstractDataNodeContainerBuilder.java [deleted file] blob | history
yang/yang-parser-impl/src/main/java/org/opendaylight/yangtools/yang/parser/builder/util/AbstractDocumentedDataNodeContainer.java [new file with mode: 0644] blob
yang/yang-parser-impl/src/main/java/org/opendaylight/yangtools/yang/parser/builder/util/AbstractDocumentedDataNodeContainerBuilder.java [new file with mode: 0644] blob
yang/yang-parser-impl/src/main/java/org/opendaylight/yangtools/yang/parser/builder/util/AbstractDocumentedNode.java [new file with mode: 0644] blob
yang/yang-parser-impl/src/main/java/org/opendaylight/yangtools/yang/parser/builder/util/AbstractDocumentedNodeBuilder.java [new file with mode: 0644] blob
yang/yang-parser-impl/src/test/java/org/opendaylight/yangtools/yang/parser/impl/YangParserNegativeTest.java diff | blob | history
OpenDaylight YANG Tools