Code Review / openflowplugin.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: 7ac1b04) | patch
Cleanup ReconciliationServiceImpl 37/92337/1
authorRobert Varga <robert.varga@pantheon.tech>
Mon, 31 Aug 2020 11:27:55 +0000 (13:27 +0200)
committerRobert Varga <robert.varga@pantheon.tech>
Mon, 31 Aug 2020 11:27:55 +0000 (13:27 +0200)
commit0073747d4d94fc5bb387e34463a1bcc78fec8191
tree691be27dc118381e835afa4e89a637198185dc2etree | snapshot
parent7ac1b0453536de6a98a406953e119c6711357553commit | diff
Cleanup ReconciliationServiceImpl

The first hint here is the raw ConcurrentHashMap, which turns out
to be immediately overwritten in constructor. After this is fixed
it becomes obvious the field is actually final, not volatile.

Further investigation shows we can improve use of RpcErrorBuilder,
making the code a lot simpler.

Change-Id: I89bc14a6f30f7903d8e54d496e3899b290a03705
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
applications/southbound-cli/src/main/java/org/opendaylight/openflowplugin/applications/southboundcli/ReconciliationServiceImpl.java diff | blob | history
OpenFlow Plugin