Code Review / aaa.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: 28df5aa) | patch
Fix findbugs violations in aaa-authn-api 81/69581/2
authorTom Pantelis <tompantelis@gmail.com>
Sat, 17 Mar 2018 13:38:50 +0000 (09:38 -0400)
committerTom Pantelis <tompantelis@gmail.com>
Mon, 19 Mar 2018 15:10:49 +0000 (11:10 -0400)
commit1013aa9930971da2c4ba0ea6d772da6cce98a49e
treef29657268805cca3fbfa667d4dcb309ed3534938tree | snapshot
parent28df5aa29725becf5d51ebe52a06248f6d22f4d6commit | diff
Fix findbugs violations in aaa-authn-api

- Equals method should not assume anything about the type of its argument
- Reliance on default encoding
- Dead store to local variable
- Possible null pointer dereference on branch that might be infeasible
- Field not initialized in constructor but dereferenced without null check

Change-Id: Ia7a47d3b3b6a9729263c7c42656f14791edefccc
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
aaa-authn-api/src/main/java/org/opendaylight/aaa/api/SHA256Calculator.java diff | blob | history
aaa-authn-api/src/main/java/org/opendaylight/aaa/api/StoreBuilder.java diff | blob | history
aaa-authn-api/src/main/java/org/opendaylight/aaa/api/model/Domain.java diff | blob | history
aaa-authn-api/src/main/java/org/opendaylight/aaa/api/model/Grant.java diff | blob | history
aaa-authn-api/src/main/java/org/opendaylight/aaa/api/model/Role.java diff | blob | history
aaa-authn-api/src/main/java/org/opendaylight/aaa/api/model/User.java diff | blob | history
Authentication, Authorization, Accounting