Introduced a new Connection Service in the library which abstracts all the Netty... 19/8319/3
authorMadhu Venugopal <mavenugo@gmail.com>
Wed, 25 Jun 2014 03:39:14 +0000 (20:39 -0700)
committerMadhu Venugopal <mavenugo@gmail.com>
Wed, 25 Jun 2014 03:59:27 +0000 (20:59 -0700)
commit1595843a38f3204904845f502af87b097e16a227
tree0c6a2fd9e1e6d1dd0331d6c4fccca76d6adb632c
parent6364f6933a77c11db1db23087ab87695cd3bd91f
Introduced a new Connection Service in the library which abstracts all the Netty related code into the Library layer.

The changes here just provides the functionality aspects of the Connection Service and is suitable for a non-osgi environment.
But the code is reorganized (by providing service interface vs implementation and moving them into different package) in lieu
of the upcoming OSGi-friendly library changes.

This commit includes the following changes.

- Removed all the existing code that creates the Netty Channel and replaced it with the new ConnectionService APIs.
- ConnectionService implementation now supports both Active and Passive connection management.
- Added a new ConnectionListener for the Passive connect / disconnect events.
- Split the Library API and impl specific to the Connection management into separate packages.
- Removed all the direct access to OvsDBClientImpl and replaced with its interface OvsDBClient
- Modified all the Integration tests that was using the older method of channel creation to the new ConnectionService mechanism.
- Added a Test for Passive Connection in the Library bundle’s OvsDBClientTestIT class.
- Removed an unused SchemaObjs class
- Renamed file names from OvsDB* to Ovsdb* for the affected classes.

Change-Id: If8a31e4b62cc217f8fe980a5417f35fe53825e26
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
19 files changed:
library/src/main/java/org/opendaylight/ovsdb/lib/LockAquisitionCallback.java
library/src/main/java/org/opendaylight/ovsdb/lib/LockStolenCallback.java
library/src/main/java/org/opendaylight/ovsdb/lib/OvsdbClient.java [moved from library/src/main/java/org/opendaylight/ovsdb/lib/OvsDBClient.java with 98% similarity]
library/src/main/java/org/opendaylight/ovsdb/lib/OvsdbConnection.java [new file with mode: 0644]
library/src/main/java/org/opendaylight/ovsdb/lib/OvsdbConnectionInfo.java [new file with mode: 0644]
library/src/main/java/org/opendaylight/ovsdb/lib/OvsdbConnectionListener.java [new file with mode: 0644]
library/src/main/java/org/opendaylight/ovsdb/lib/impl/ChannelConnectionHandler.java [new file with mode: 0644]
library/src/main/java/org/opendaylight/ovsdb/lib/impl/OvsdbClientImpl.java [moved from library/src/main/java/org/opendaylight/ovsdb/lib/OvsDBClientImpl.java with 93% similarity]
library/src/main/java/org/opendaylight/ovsdb/lib/impl/OvsdbConnectionService.java [new file with mode: 0644]
library/src/main/java/org/opendaylight/ovsdb/lib/operations/TransactionBuilder.java
library/src/test/java/org/opendaylight/ovsdb/lib/OvsdbClientTestIT.java [moved from library/src/test/java/org/opendaylight/ovsdb/lib/OvsDBClientTestIT.java with 96% similarity]
library/src/test/java/org/opendaylight/ovsdb/lib/OvsdbClientTestITTyped.java [moved from library/src/test/java/org/opendaylight/ovsdb/lib/OvsDBClientTestITTyped.java with 90% similarity]
library/src/test/java/org/opendaylight/ovsdb/lib/OvsdbTestBase.java
library/src/test/java/org/opendaylight/ovsdb/lib/schema/OvsdbSchemaTest.java [moved from library/src/test/java/org/opendaylight/ovsdb/lib/schema/OvsDBSchemaTest.java with 92% similarity]
library/src/test/java/org/opendaylight/ovsdb/lib/schema/temp/SchemaObjs.java [deleted file]
schemas/Open_vSwitch/src/test/java/org/opendaylight/ovsdb/schema/openvswitch/OvsdbTestBase.java
schemas/Open_vSwitch/src/test/java/org/opendaylight/ovsdb/schema/openvswitch/TypedVSwitchdSchemaIT.java
schemas/hardware_vtep/src/test/java/org/opendaylight/ovsdb/schema/hardwarevtep/OvsdbTestBase.java
schemas/hardware_vtep/src/test/java/org/opendaylight/ovsdb/schema/hardwarevtep/TypedHardwareVTepSchemaIT.java