Clean up L2ForwardingService
authorStephen Kitt <skitt@redhat.com>
Fri, 20 Nov 2015 16:44:05 +0000 (17:44 +0100)
committerStephen Kitt <skitt@redhat.com>
Mon, 23 Nov 2015 15:53:15 +0000 (16:53 +0100)
commit167d2bf5a154baf68f9c507341e44ad346433f04
tree8e99ebf83b26db94dcd7d2b6971170f04900a7bf
parent9dbd3589a84ca6c153774f61c635bdd679438335
Clean up L2ForwardingService

Avoid multiple instanciations of MatchBuilders.

Factor common code involved in FlowBuilder setup and instruction
construction, adding appropriate methods in FlowUtils and
InstructionUtils.

Use fluent-style builders.

Drop appendResubmitLocalFlood() which isn't used.

Avoid multiple creations of the same Uri in loops.

Two of the FlowBuilders don't have a setStrict() call; is that
intentional?

Change-Id: I984a735229613bd013443ff16815a1566a74b2d5
Signed-off-by: Stephen Kitt <skitt@redhat.com>
openstack/net-virt-providers/src/main/java/org/opendaylight/ovsdb/openstack/netvirt/providers/openflow13/services/L2ForwardingService.java
utils/mdsal-openflow/src/main/java/org/opendaylight/ovsdb/utils/mdsal/openflow/FlowUtils.java
utils/mdsal-openflow/src/main/java/org/opendaylight/ovsdb/utils/mdsal/openflow/InstructionUtils.java